All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Jarzmik <robert.jarzmik-GANU6spQydw@public.gmane.org>
To: Mike Turquette <mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Haojian Zhuang
	<haojian.zhuang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Eric Miao <eric.y.miao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
Subject: Re: [PATCH 2/4] dts: add devicetree bindings for pxa27x clocks
Date: Fri, 04 Jul 2014 21:38:30 +0200	[thread overview]
Message-ID: <87d2dkoqx5.fsf@free.fr> (raw)
In-Reply-To: <20140703220328.11380.22037@quantum> (Mike Turquette's message of "Thu, 03 Jul 2014 15:03:28 -0700")

Mike Turquette <mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> writes:

> Quoting Haojian Zhuang (2014-07-02 23:14:33)
>> Maybe defining these clocks in pxa27x clock driver is better.
>
> Agreed. After a long time trying to figure out the best DT binding for
> clocks it seems that defining the per-clock data in DTS is not the best
> way. The qcom msm and samsung exynos clock bindings and DTS data are
> good examples.

Ah, I see. Would have been a great comment in the former RFC patch serie, sic
... Maybe a comment in the clock device-tree documentation would prevent others
to do the same error ?

Well, it will take me some time to transform the dts data into code, especially
if I want to have some genericity to handle all PXA variants.

I'll work on it in the next days/week.

Cheers.

-- 
Robert
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: robert.jarzmik@free.fr (Robert Jarzmik)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] dts: add devicetree bindings for pxa27x clocks
Date: Fri, 04 Jul 2014 21:38:30 +0200	[thread overview]
Message-ID: <87d2dkoqx5.fsf@free.fr> (raw)
In-Reply-To: <20140703220328.11380.22037@quantum> (Mike Turquette's message of "Thu, 03 Jul 2014 15:03:28 -0700")

Mike Turquette <mturquette@linaro.org> writes:

> Quoting Haojian Zhuang (2014-07-02 23:14:33)
>> Maybe defining these clocks in pxa27x clock driver is better.
>
> Agreed. After a long time trying to figure out the best DT binding for
> clocks it seems that defining the per-clock data in DTS is not the best
> way. The qcom msm and samsung exynos clock bindings and DTS data are
> good examples.

Ah, I see. Would have been a great comment in the former RFC patch serie, sic
... Maybe a comment in the clock device-tree documentation would prevent others
to do the same error ?

Well, it will take me some time to transform the dts data into code, especially
if I want to have some genericity to handle all PXA variants.

I'll work on it in the next days/week.

Cheers.

-- 
Robert

  reply	other threads:[~2014-07-04 19:38 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-29 18:32 [PATCH 0/4] Migrate PXA27x platforms to clock framework Robert Jarzmik
2014-06-29 18:32 ` Robert Jarzmik
     [not found] ` <1404066744-13416-1-git-send-email-robert.jarzmik-GANU6spQydw@public.gmane.org>
2014-06-29 18:32   ` [PATCH 1/4] clk: add pxa27x clock drivers Robert Jarzmik
2014-06-29 18:32     ` Robert Jarzmik
     [not found]     ` <1404066744-13416-2-git-send-email-robert.jarzmik-GANU6spQydw@public.gmane.org>
2014-07-03  6:12       ` Haojian Zhuang
2014-07-03  6:12         ` Haojian Zhuang
     [not found]         ` <CAN1soZzoiGAz3OicdKbg5Dv2tW3yeinsu2i=M7KX+j1HuMs3Kg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-07-03 22:28           ` Robert Jarzmik
2014-07-03 22:28             ` Robert Jarzmik
2014-06-29 18:32   ` [PATCH 2/4] dts: add devicetree bindings for pxa27x clocks Robert Jarzmik
2014-06-29 18:32     ` Robert Jarzmik
     [not found]     ` <1404066744-13416-3-git-send-email-robert.jarzmik-GANU6spQydw@public.gmane.org>
2014-07-03  6:14       ` Haojian Zhuang
2014-07-03  6:14         ` Haojian Zhuang
     [not found]         ` <CAN1soZys4k6g5RgPLbreopOxTwDJ+bfPOq8XPwsNpyt5+YURjg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-07-03 22:03           ` Mike Turquette
2014-07-03 22:03             ` Mike Turquette
2014-07-04 19:38             ` Robert Jarzmik [this message]
2014-07-04 19:38               ` Robert Jarzmik
2014-06-29 18:32   ` [PATCH 3/4] arm: pxa: Transition pxa27x to clk framework Robert Jarzmik
2014-06-29 18:32     ` Robert Jarzmik
2014-06-29 18:32   ` [PATCH 4/4] clk: dts: document pxa27x clock binding Robert Jarzmik
2014-06-29 18:32     ` Robert Jarzmik
2014-06-30  6:55   ` [PATCH 0/4] Migrate PXA27x platforms to clock framework Arnd Bergmann
2014-06-30  6:55     ` Arnd Bergmann
2014-06-30 18:38     ` Robert Jarzmik
2014-06-30 18:38       ` Robert Jarzmik
     [not found]       ` <877g3yp7ie.fsf-GANU6spQydw@public.gmane.org>
2014-06-30 20:14         ` Arnd Bergmann
2014-06-30 20:14           ` Arnd Bergmann
2014-07-03  6:21         ` Haojian Zhuang
2014-07-03  6:21           ` Haojian Zhuang
     [not found]           ` <CAN1soZyu192Y7z-HJHo+3_bddFcf=H0udgJSWez1=Lmrb5wVfg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-07-03 22:14             ` Robert Jarzmik
2014-07-03 22:14               ` Robert Jarzmik
     [not found]               ` <87lhsanl7q.fsf-GANU6spQydw@public.gmane.org>
2014-07-04  2:39                 ` Haojian Zhuang
2014-07-04  2:39                   ` Haojian Zhuang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d2dkoqx5.fsf@free.fr \
    --to=robert.jarzmik-ganu6spqydw@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=eric.y.miao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=haojian.zhuang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.