From: Stephen Smalley <sds@tycho.nsa.gov> To: David Howells <dhowells@redhat.com> Cc: viro@zeniv.linux.org.uk, Casey Schaufler <casey@schaufler-ca.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, nicolas.dichtel@6wind.com, raven@themaw.net, Christian Brauner <christian@brauner.io>, keyrings@vger.kernel.org, linux-usb@vger.kernel.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 10/11] selinux: Implement the watch_key security hook [ver #7] Date: Fri, 30 Aug 2019 11:41:16 -0400 [thread overview] Message-ID: <87de7cc1-435e-1b56-afec-bc041c193317@tycho.nsa.gov> (raw) In-Reply-To: <13308.1567176090@warthog.procyon.org.uk> On 8/30/19 10:41 AM, David Howells wrote: > How about the attached instead, then? Works for me. > > David > --- > commit 00444a695b35c602230ac2cabb4f1d7e94e3966d > Author: David Howells <dhowells@redhat.com> > Date: Thu Aug 29 17:01:34 2019 +0100 > > selinux: Implement the watch_key security hook > > Implement the watch_key security hook to make sure that a key grants the > caller View permission in order to set a watch on a key. > > For the moment, the watch_devices security hook is left unimplemented as > it's not obvious what the object should be since the queue is global and > didn't previously exist. > > Signed-off-by: David Howells <dhowells@redhat.com> Acked-by: Stephen Smalley <sds@tycho.nsa.gov> > > diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c > index 74dd46de01b6..88df06969bed 100644 > --- a/security/selinux/hooks.c > +++ b/security/selinux/hooks.c > @@ -6533,6 +6533,17 @@ static int selinux_key_getsecurity(struct key *key, char **_buffer) > *_buffer = context; > return rc; > } > + > +#ifdef CONFIG_KEY_NOTIFICATIONS > +static int selinux_watch_key(struct key *key) > +{ > + struct key_security_struct *ksec = key->security; > + u32 sid = current_sid(); > + > + return avc_has_perm(&selinux_state, > + sid, ksec->sid, SECCLASS_KEY, KEY_NEED_VIEW, NULL); > +} > +#endif > #endif > > #ifdef CONFIG_SECURITY_INFINIBAND > @@ -6965,6 +6976,9 @@ static struct security_hook_list selinux_hooks[] __lsm_ro_after_init = { > LSM_HOOK_INIT(key_free, selinux_key_free), > LSM_HOOK_INIT(key_permission, selinux_key_permission), > LSM_HOOK_INIT(key_getsecurity, selinux_key_getsecurity), > +#ifdef CONFIG_KEY_NOTIFICATIONS > + LSM_HOOK_INIT(watch_key, selinux_watch_key), > +#endif > #endif > > #ifdef CONFIG_AUDIT >
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Smalley <sds@tycho.nsa.gov> To: David Howells <dhowells@redhat.com> Cc: viro@zeniv.linux.org.uk, Casey Schaufler <casey@schaufler-ca.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, nicolas.dichtel@6wind.com, raven@themaw.net, Christian Brauner <christian@brauner.io>, keyrings@vger.kernel.org, linux-usb@vger.kernel.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 10/11] selinux: Implement the watch_key security hook [ver #7] Date: Fri, 30 Aug 2019 15:41:16 +0000 [thread overview] Message-ID: <87de7cc1-435e-1b56-afec-bc041c193317@tycho.nsa.gov> (raw) In-Reply-To: <13308.1567176090@warthog.procyon.org.uk> On 8/30/19 10:41 AM, David Howells wrote: > How about the attached instead, then? Works for me. > > David > --- > commit 00444a695b35c602230ac2cabb4f1d7e94e3966d > Author: David Howells <dhowells@redhat.com> > Date: Thu Aug 29 17:01:34 2019 +0100 > > selinux: Implement the watch_key security hook > > Implement the watch_key security hook to make sure that a key grants the > caller View permission in order to set a watch on a key. > > For the moment, the watch_devices security hook is left unimplemented as > it's not obvious what the object should be since the queue is global and > didn't previously exist. > > Signed-off-by: David Howells <dhowells@redhat.com> Acked-by: Stephen Smalley <sds@tycho.nsa.gov> > > diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c > index 74dd46de01b6..88df06969bed 100644 > --- a/security/selinux/hooks.c > +++ b/security/selinux/hooks.c > @@ -6533,6 +6533,17 @@ static int selinux_key_getsecurity(struct key *key, char **_buffer) > *_buffer = context; > return rc; > } > + > +#ifdef CONFIG_KEY_NOTIFICATIONS > +static int selinux_watch_key(struct key *key) > +{ > + struct key_security_struct *ksec = key->security; > + u32 sid = current_sid(); > + > + return avc_has_perm(&selinux_state, > + sid, ksec->sid, SECCLASS_KEY, KEY_NEED_VIEW, NULL); > +} > +#endif > #endif > > #ifdef CONFIG_SECURITY_INFINIBAND > @@ -6965,6 +6976,9 @@ static struct security_hook_list selinux_hooks[] __lsm_ro_after_init = { > LSM_HOOK_INIT(key_free, selinux_key_free), > LSM_HOOK_INIT(key_permission, selinux_key_permission), > LSM_HOOK_INIT(key_getsecurity, selinux_key_getsecurity), > +#ifdef CONFIG_KEY_NOTIFICATIONS > + LSM_HOOK_INIT(watch_key, selinux_watch_key), > +#endif > #endif > > #ifdef CONFIG_AUDIT >
next prev parent reply other threads:[~2019-08-30 15:48 UTC|newest] Thread overview: 234+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <20190903085706.7700-1-hdanton@sina.com> 2019-08-30 13:57 ` [PATCH 00/11] Keyrings, Block and USB notifications [ver #7] David Howells 2019-08-30 13:57 ` David Howells 2019-08-30 13:57 ` David Howells 2019-08-30 13:57 ` [PATCH 01/11] uapi: General notification ring definitions " David Howells 2019-08-30 13:57 ` David Howells 2019-08-30 13:57 ` David Howells 2019-08-30 13:57 ` [PATCH 02/11] security: Add hooks to rule on setting a watch " David Howells 2019-08-30 13:57 ` David Howells 2019-08-30 13:57 ` David Howells 2019-08-30 13:57 ` [PATCH 03/11] security: Add a hook for the point of notification insertion " David Howells 2019-08-30 13:57 ` David Howells 2019-08-30 13:57 ` David Howells 2019-08-30 13:57 ` [PATCH 04/11] General notification queue with user mmap()'able ring buffer " David Howells 2019-08-30 13:57 ` David Howells 2019-08-30 13:57 ` David Howells 2019-08-30 13:57 ` [PATCH 05/11] keys: Add a notification facility " David Howells 2019-08-30 13:57 ` David Howells 2019-08-30 13:57 ` David Howells 2019-08-30 13:58 ` [PATCH 06/11] Add a general, global device notification watch list " David Howells 2019-08-30 13:58 ` David Howells 2019-08-30 13:58 ` David Howells 2019-09-03 8:34 ` Yoshihiro Shimoda 2019-09-03 8:34 ` Yoshihiro Shimoda 2019-09-03 8:34 ` Yoshihiro Shimoda 2019-09-03 16:41 ` David Howells 2019-09-03 16:41 ` David Howells 2019-09-03 16:41 ` David Howells 2019-08-30 13:58 ` [PATCH 07/11] block: Add block layer notifications " David Howells 2019-08-30 13:58 ` David Howells 2019-08-30 13:58 ` David Howells 2019-08-30 13:58 ` [PATCH 08/11] usb: Add USB subsystem " David Howells 2019-08-30 13:58 ` David Howells 2019-08-30 13:58 ` David Howells 2019-09-03 8:53 ` Yoshihiro Shimoda 2019-09-03 8:53 ` Yoshihiro Shimoda 2019-09-03 8:53 ` Yoshihiro Shimoda 2019-09-03 9:37 ` Greg Kroah-Hartman 2019-09-03 9:37 ` Greg Kroah-Hartman 2019-09-03 9:37 ` Greg Kroah-Hartman 2019-09-04 1:53 ` Yoshihiro Shimoda 2019-09-04 1:53 ` Yoshihiro Shimoda 2019-09-04 1:53 ` Yoshihiro Shimoda 2019-09-03 12:51 ` Guenter Roeck 2019-09-03 12:51 ` Guenter Roeck 2019-09-03 16:07 ` David Howells 2019-09-03 16:07 ` David Howells 2019-09-03 16:12 ` Guenter Roeck 2019-09-03 16:12 ` Guenter Roeck 2019-09-03 16:29 ` David Howells 2019-09-03 16:29 ` David Howells 2019-09-03 17:06 ` Alan Stern 2019-09-03 17:06 ` Alan Stern 2019-09-03 17:06 ` Alan Stern 2019-09-03 17:17 ` Alan Stern 2019-09-03 17:17 ` Alan Stern 2019-09-03 17:17 ` Alan Stern 2019-09-04 15:17 ` David Howells 2019-09-04 15:17 ` David Howells 2019-08-30 13:58 ` [PATCH 09/11] Add sample notification program " David Howells 2019-08-30 13:58 ` David Howells 2019-08-30 13:58 ` David Howells 2019-08-30 13:58 ` [PATCH 10/11] selinux: Implement the watch_key security hook " David Howells 2019-08-30 13:58 ` David Howells 2019-08-30 13:58 ` David Howells 2019-08-30 14:15 ` Stephen Smalley 2019-08-30 14:15 ` Stephen Smalley 2019-08-30 14:23 ` David Howells 2019-08-30 14:23 ` David Howells 2019-08-30 14:41 ` David Howells 2019-08-30 14:41 ` David Howells 2019-08-30 15:41 ` Stephen Smalley [this message] 2019-08-30 15:41 ` Stephen Smalley 2019-08-30 13:58 ` [PATCH 11/11] smack: Implement the watch_key and post_notification hooks [untested] " David Howells 2019-08-30 13:58 ` David Howells 2019-08-30 13:58 ` David Howells 2019-09-03 15:20 ` Casey Schaufler 2019-09-03 15:20 ` Casey Schaufler 2019-09-03 15:41 ` David Howells 2019-09-03 15:41 ` David Howells 2019-09-03 17:40 ` Casey Schaufler 2019-09-03 17:40 ` Casey Schaufler 2019-09-03 18:06 ` David Howells 2019-09-03 18:06 ` David Howells 2019-09-03 22:16 ` Casey Schaufler 2019-09-03 22:16 ` Casey Schaufler 2019-09-03 22:39 ` David Howells 2019-09-03 22:39 ` David Howells 2019-09-04 12:08 ` David Howells 2019-09-04 12:08 ` David Howells 2019-09-04 14:56 ` Casey Schaufler 2019-09-04 14:56 ` Casey Schaufler 2019-08-30 14:15 ` watch_queue(7) manpage David Howells 2019-08-30 14:15 ` David Howells 2019-08-30 14:15 ` David Howells 2019-08-30 14:15 ` watch_devices(2) manpage David Howells 2019-08-30 14:15 ` David Howells 2019-08-30 14:16 ` keyctl_watch_key.3 manpage David Howells 2019-08-30 14:16 ` David Howells 2019-08-30 22:09 ` [PATCH 00/11] Keyrings, Block and USB notifications [ver #7] Casey Schaufler 2019-08-30 22:09 ` Casey Schaufler 2019-09-02 12:39 ` David Howells 2019-09-02 12:39 ` David Howells 2019-09-02 13:26 ` David Howells 2019-09-02 13:26 ` David Howells 2019-09-03 16:06 ` [PATCH 04/11] General notification queue with user mmap()'able ring buffer " David Howells 2019-09-03 16:06 ` David Howells 2019-09-03 16:37 ` David Howells 2019-09-03 16:37 ` David Howells 2019-09-04 22:15 [PATCH 00/11] Keyrings, Block and USB notifications [ver #8] David Howells 2019-09-04 22:15 ` David Howells 2019-09-04 22:15 ` David Howells 2019-09-04 22:15 ` [PATCH 01/11] uapi: General notification ring definitions " David Howells 2019-09-04 22:15 ` David Howells 2019-09-04 22:15 ` David Howells 2019-09-04 22:16 ` [PATCH 02/11] security: Add hooks to rule on setting a watch " David Howells 2019-09-04 22:16 ` David Howells 2019-09-04 22:16 ` David Howells 2019-09-04 22:16 ` [PATCH 03/11] security: Add a hook for the point of notification insertion " David Howells 2019-09-04 22:16 ` David Howells 2019-09-04 22:16 ` David Howells 2019-09-04 22:16 ` [PATCH 04/11] General notification queue with user mmap()'able ring buffer " David Howells 2019-09-04 22:16 ` David Howells 2019-09-04 22:16 ` David Howells 2019-09-04 22:16 ` [PATCH 05/11] keys: Add a notification facility " David Howells 2019-09-04 22:16 ` David Howells 2019-09-04 22:16 ` David Howells 2019-09-04 22:16 ` [PATCH 06/11] Add a general, global device notification watch list " David Howells 2019-09-04 22:16 ` David Howells 2019-09-04 22:16 ` David Howells 2019-09-04 22:16 ` [PATCH 07/11] block: Add block layer notifications " David Howells 2019-09-04 22:16 ` David Howells 2019-09-04 22:16 ` David Howells 2019-09-04 22:16 ` [PATCH 08/11] usb: Add USB subsystem " David Howells 2019-09-04 22:16 ` David Howells 2019-09-04 22:16 ` David Howells 2019-09-04 22:17 ` [PATCH 09/11] Add sample notification program " David Howells 2019-09-04 22:17 ` David Howells 2019-09-04 22:17 ` David Howells 2019-09-04 22:17 ` [PATCH 10/11] selinux: Implement the watch_key security hook " David Howells 2019-09-04 22:17 ` David Howells 2019-09-04 22:17 ` David Howells 2019-09-04 22:17 ` [PATCH 11/11] smack: Implement the watch_key and post_notification hooks " David Howells 2019-09-04 22:17 ` David Howells 2019-09-04 22:17 ` David Howells 2019-09-04 22:28 ` [PATCH 00/11] Keyrings, Block and USB notifications " Linus Torvalds 2019-09-04 22:28 ` Linus Torvalds 2019-09-05 17:01 ` Why add the general notification queue and its sources David Howells 2019-09-05 17:01 ` David Howells 2019-09-05 17:19 ` Linus Torvalds 2019-09-05 17:19 ` Linus Torvalds 2019-09-05 18:32 ` Ray Strode 2019-09-05 18:32 ` Ray Strode 2019-09-05 18:32 ` Ray Strode 2019-09-05 20:39 ` Linus Torvalds 2019-09-05 20:39 ` Linus Torvalds 2019-09-06 19:32 ` Ray Strode 2019-09-06 19:32 ` Ray Strode 2019-09-06 19:41 ` Ray Strode 2019-09-06 19:41 ` Ray Strode 2019-09-06 19:53 ` Robbie Harwood 2019-09-06 19:53 ` Robbie Harwood 2019-09-06 19:53 ` Robbie Harwood 2019-09-05 21:32 ` David Howells 2019-09-05 21:32 ` David Howells 2019-09-05 22:08 ` Linus Torvalds 2019-09-05 22:08 ` Linus Torvalds 2019-09-05 23:18 ` David Howells 2019-09-05 23:18 ` David Howells 2019-09-06 0:07 ` Linus Torvalds 2019-09-06 0:07 ` Linus Torvalds 2019-09-06 10:09 ` David Howells 2019-09-06 10:09 ` David Howells 2019-09-06 15:35 ` Linus Torvalds 2019-09-06 15:35 ` Linus Torvalds 2019-09-06 15:53 ` Linus Torvalds 2019-09-06 15:53 ` Linus Torvalds 2019-09-06 16:12 ` Steven Whitehouse 2019-09-06 16:12 ` Steven Whitehouse 2019-09-06 17:07 ` Linus Torvalds 2019-09-06 17:07 ` Linus Torvalds 2019-09-06 17:14 ` Linus Torvalds 2019-09-06 17:14 ` Linus Torvalds 2019-09-06 21:19 ` David Howells 2019-09-06 21:19 ` David Howells 2019-09-06 17:14 ` Andy Lutomirski 2019-09-06 17:14 ` Andy Lutomirski 2019-09-05 18:37 ` Steven Whitehouse 2019-09-05 18:37 ` Steven Whitehouse 2019-09-05 18:51 ` Ray Strode 2019-09-05 18:51 ` Ray Strode 2019-09-05 20:09 ` David Lehman 2019-09-05 20:09 ` David Lehman 2019-09-05 18:33 ` Greg Kroah-Hartman 2019-09-05 18:33 ` Greg Kroah-Hartman -- strict thread matches above, loose matches on Subject: below -- 2019-08-29 18:29 [PATCH 00/11] Keyrings, Block and USB notifications [ver #6] David Howells 2019-08-29 18:29 ` David Howells 2019-08-29 18:29 ` David Howells 2019-08-29 18:29 ` [PATCH 01/11] uapi: General notification ring definitions " David Howells 2019-08-29 18:29 ` David Howells 2019-08-29 18:29 ` David Howells 2019-08-29 18:30 ` [PATCH 02/11] security: Add hooks to rule on setting a watch " David Howells 2019-08-29 18:30 ` David Howells 2019-08-29 18:30 ` David Howells 2019-08-29 18:30 ` [PATCH 03/11] security: Add a hook for the point of notification insertion " David Howells 2019-08-29 18:30 ` David Howells 2019-08-29 18:30 ` David Howells 2019-08-29 18:30 ` [PATCH 04/11] General notification queue with user mmap()'able ring buffer " David Howells 2019-08-29 18:30 ` David Howells 2019-08-29 18:30 ` David Howells 2019-08-29 18:30 ` [PATCH 05/11] keys: Add a notification facility " David Howells 2019-08-29 18:30 ` David Howells 2019-08-29 18:30 ` David Howells 2019-08-29 18:30 ` [PATCH 06/11] Add a general, global device notification watch list " David Howells 2019-08-29 18:30 ` David Howells 2019-08-29 18:30 ` David Howells 2019-08-29 18:30 ` [PATCH 07/11] block: Add block layer notifications " David Howells 2019-08-29 18:30 ` David Howells 2019-08-29 18:30 ` David Howells 2019-08-29 18:31 ` [PATCH 08/11] usb: Add USB subsystem " David Howells 2019-08-29 18:31 ` David Howells 2019-08-29 18:31 ` David Howells 2019-08-29 18:31 ` [PATCH 09/11] Add sample notification program " David Howells 2019-08-29 18:31 ` David Howells 2019-08-29 18:31 ` David Howells 2019-08-29 18:31 ` [PATCH 10/11] selinux: Implement the watch_key security hook " David Howells 2019-08-29 18:31 ` David Howells 2019-08-29 18:31 ` David Howells 2019-08-29 18:44 ` Stephen Smalley 2019-08-29 18:44 ` Stephen Smalley 2019-08-29 19:11 ` David Howells 2019-08-29 19:11 ` David Howells 2019-08-29 18:31 ` [PATCH 11/11] smack: Implement the watch_key and post_notification hooks [untested] " David Howells 2019-08-29 18:31 ` David Howells 2019-08-29 18:31 ` David Howells
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87de7cc1-435e-1b56-afec-bc041c193317@tycho.nsa.gov \ --to=sds@tycho.nsa.gov \ --cc=casey@schaufler-ca.com \ --cc=christian@brauner.io \ --cc=dhowells@redhat.com \ --cc=gregkh@linuxfoundation.org \ --cc=keyrings@vger.kernel.org \ --cc=linux-api@vger.kernel.org \ --cc=linux-block@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-security-module@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=nicolas.dichtel@6wind.com \ --cc=raven@themaw.net \ --cc=viro@zeniv.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.