From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: David Howells <dhowells@redhat.com>, "viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>, Casey Schaufler <casey@schaufler-ca.com>, Stephen Smalley <sds@tycho.nsa.gov>, "nicolas.dichtel@6wind.com" <nicolas.dichtel@6wind.com>, "raven@themaw.net" <raven@themaw.net>, Christian Brauner <christian@brauner.io>, "keyrings@vger.kernel.org" <keyrings@vger.kernel.org>, "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>, "linux-security-module@vger.kernel.org" <linux-security-module@vger.kernel.org>, "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>, "linux-api@vger.kernel.org" <linux-api@vger.kernel.org>, "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: RE: [PATCH 08/11] usb: Add USB subsystem notifications [ver #7] Date: Wed, 4 Sep 2019 01:53:01 +0000 [thread overview] Message-ID: <TYAPR01MB45441054C3956CCA7BBD80CBD8B80@TYAPR01MB4544.jpnprd01.prod.outlook.com> (raw) In-Reply-To: <20190903093720.GD12325@kroah.com> Hi Greg, > From: Greg Kroah-Hartman, Sent: Tuesday, September 3, 2019 6:37 PM <snip> > > > +void post_usb_bus_notification(const struct usb_bus *ubus, > > > > This function's argument is struct usb_bus *, but ... > > > > > + enum usb_notification_type subtype, u32 error) > > > +{ > > > + post_usb_notification(ubus->bus_name, subtype, error); > > > +} > > > +#endif > > > + > > > static int usbdev_notify(struct notifier_block *self, > > > unsigned long action, void *dev) > > > { > > > switch (action) { > > > case USB_DEVICE_ADD: > > > + post_usb_device_notification(dev, NOTIFY_USB_DEVICE_ADD, 0); > > > break; > > > case USB_DEVICE_REMOVE: > > > + post_usb_device_notification(dev, NOTIFY_USB_DEVICE_REMOVE, 0); > > > + usbdev_remove(dev); > > > + break; > > > + case USB_BUS_ADD: > > > + post_usb_bus_notification(dev, NOTIFY_USB_BUS_ADD, 0); > > > + break; > > > + case USB_BUS_REMOVE: > > > + post_usb_bus_notification(dev, NOTIFY_USB_BUS_REMOVE, 0); > > > usbdev_remove(dev); > > > > this function calls usbdev_remove() with incorrect argument if the action > > is USB_BUS_REMOVE. So, this seems to cause the following issue [1] on > > my environment (R-Car H3 / r8a7795 on next-20190902) [2]. However, I have > > no idea how to fix the issue, so I report this issue at the first step. > > As a few of us just discussed this on IRC, these bus notifiers should > probably be dropped as these are the incorrect structure type as you > found out. Thanks for the report. Thank you for the discussion. I got it. Best regards, Yoshihiro Shimoda > greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: David Howells <dhowells@redhat.com>, "viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>, Casey Schaufler <casey@schaufler-ca.com>, Stephen Smalley <sds@tycho.nsa.gov>, "nicolas.dichtel@6wind.com" <nicolas.dichtel@6wind.com>, "raven@themaw.net" <raven@themaw.net>, Christian Brauner <christian@brauner.io>, "keyrings@vger.kernel.org" <keyrings@vger.kernel.org>, "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>, "linux-security-module@vger.kernel.org" <linux-security-module@vger.kernel.org>, "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>, "linux-api@vger.kernel.org" <linux-api@vger.kernel.org>, "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: RE: [PATCH 08/11] usb: Add USB subsystem notifications [ver #7] Date: Wed, 04 Sep 2019 01:53:01 +0000 [thread overview] Message-ID: <TYAPR01MB45441054C3956CCA7BBD80CBD8B80@TYAPR01MB4544.jpnprd01.prod.outlook.com> (raw) In-Reply-To: <20190903093720.GD12325@kroah.com> Hi Greg, > From: Greg Kroah-Hartman, Sent: Tuesday, September 3, 2019 6:37 PM <snip> > > > +void post_usb_bus_notification(const struct usb_bus *ubus, > > > > This function's argument is struct usb_bus *, but ... > > > > > + enum usb_notification_type subtype, u32 error) > > > +{ > > > + post_usb_notification(ubus->bus_name, subtype, error); > > > +} > > > +#endif > > > + > > > static int usbdev_notify(struct notifier_block *self, > > > unsigned long action, void *dev) > > > { > > > switch (action) { > > > case USB_DEVICE_ADD: > > > + post_usb_device_notification(dev, NOTIFY_USB_DEVICE_ADD, 0); > > > break; > > > case USB_DEVICE_REMOVE: > > > + post_usb_device_notification(dev, NOTIFY_USB_DEVICE_REMOVE, 0); > > > + usbdev_remove(dev); > > > + break; > > > + case USB_BUS_ADD: > > > + post_usb_bus_notification(dev, NOTIFY_USB_BUS_ADD, 0); > > > + break; > > > + case USB_BUS_REMOVE: > > > + post_usb_bus_notification(dev, NOTIFY_USB_BUS_REMOVE, 0); > > > usbdev_remove(dev); > > > > this function calls usbdev_remove() with incorrect argument if the action > > is USB_BUS_REMOVE. So, this seems to cause the following issue [1] on > > my environment (R-Car H3 / r8a7795 on next-20190902) [2]. However, I have > > no idea how to fix the issue, so I report this issue at the first step. > > As a few of us just discussed this on IRC, these bus notifiers should > probably be dropped as these are the incorrect structure type as you > found out. Thanks for the report. Thank you for the discussion. I got it. Best regards, Yoshihiro Shimoda > greg k-h
next prev parent reply other threads:[~2019-09-04 1:53 UTC|newest] Thread overview: 234+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <20190903085706.7700-1-hdanton@sina.com> 2019-08-30 13:57 ` [PATCH 00/11] Keyrings, Block and USB notifications [ver #7] David Howells 2019-08-30 13:57 ` David Howells 2019-08-30 13:57 ` David Howells 2019-08-30 13:57 ` [PATCH 01/11] uapi: General notification ring definitions " David Howells 2019-08-30 13:57 ` David Howells 2019-08-30 13:57 ` David Howells 2019-08-30 13:57 ` [PATCH 02/11] security: Add hooks to rule on setting a watch " David Howells 2019-08-30 13:57 ` David Howells 2019-08-30 13:57 ` David Howells 2019-08-30 13:57 ` [PATCH 03/11] security: Add a hook for the point of notification insertion " David Howells 2019-08-30 13:57 ` David Howells 2019-08-30 13:57 ` David Howells 2019-08-30 13:57 ` [PATCH 04/11] General notification queue with user mmap()'able ring buffer " David Howells 2019-08-30 13:57 ` David Howells 2019-08-30 13:57 ` David Howells 2019-08-30 13:57 ` [PATCH 05/11] keys: Add a notification facility " David Howells 2019-08-30 13:57 ` David Howells 2019-08-30 13:57 ` David Howells 2019-08-30 13:58 ` [PATCH 06/11] Add a general, global device notification watch list " David Howells 2019-08-30 13:58 ` David Howells 2019-08-30 13:58 ` David Howells 2019-09-03 8:34 ` Yoshihiro Shimoda 2019-09-03 8:34 ` Yoshihiro Shimoda 2019-09-03 8:34 ` Yoshihiro Shimoda 2019-09-03 16:41 ` David Howells 2019-09-03 16:41 ` David Howells 2019-09-03 16:41 ` David Howells 2019-08-30 13:58 ` [PATCH 07/11] block: Add block layer notifications " David Howells 2019-08-30 13:58 ` David Howells 2019-08-30 13:58 ` David Howells 2019-08-30 13:58 ` [PATCH 08/11] usb: Add USB subsystem " David Howells 2019-08-30 13:58 ` David Howells 2019-08-30 13:58 ` David Howells 2019-09-03 8:53 ` Yoshihiro Shimoda 2019-09-03 8:53 ` Yoshihiro Shimoda 2019-09-03 8:53 ` Yoshihiro Shimoda 2019-09-03 9:37 ` Greg Kroah-Hartman 2019-09-03 9:37 ` Greg Kroah-Hartman 2019-09-03 9:37 ` Greg Kroah-Hartman 2019-09-04 1:53 ` Yoshihiro Shimoda [this message] 2019-09-04 1:53 ` Yoshihiro Shimoda 2019-09-04 1:53 ` Yoshihiro Shimoda 2019-09-03 12:51 ` Guenter Roeck 2019-09-03 12:51 ` Guenter Roeck 2019-09-03 16:07 ` David Howells 2019-09-03 16:07 ` David Howells 2019-09-03 16:12 ` Guenter Roeck 2019-09-03 16:12 ` Guenter Roeck 2019-09-03 16:29 ` David Howells 2019-09-03 16:29 ` David Howells 2019-09-03 17:06 ` Alan Stern 2019-09-03 17:06 ` Alan Stern 2019-09-03 17:06 ` Alan Stern 2019-09-03 17:17 ` Alan Stern 2019-09-03 17:17 ` Alan Stern 2019-09-03 17:17 ` Alan Stern 2019-09-04 15:17 ` David Howells 2019-09-04 15:17 ` David Howells 2019-08-30 13:58 ` [PATCH 09/11] Add sample notification program " David Howells 2019-08-30 13:58 ` David Howells 2019-08-30 13:58 ` David Howells 2019-08-30 13:58 ` [PATCH 10/11] selinux: Implement the watch_key security hook " David Howells 2019-08-30 13:58 ` David Howells 2019-08-30 13:58 ` David Howells 2019-08-30 14:15 ` Stephen Smalley 2019-08-30 14:15 ` Stephen Smalley 2019-08-30 14:23 ` David Howells 2019-08-30 14:23 ` David Howells 2019-08-30 14:41 ` David Howells 2019-08-30 14:41 ` David Howells 2019-08-30 15:41 ` Stephen Smalley 2019-08-30 15:41 ` Stephen Smalley 2019-08-30 13:58 ` [PATCH 11/11] smack: Implement the watch_key and post_notification hooks [untested] " David Howells 2019-08-30 13:58 ` David Howells 2019-08-30 13:58 ` David Howells 2019-09-03 15:20 ` Casey Schaufler 2019-09-03 15:20 ` Casey Schaufler 2019-09-03 15:41 ` David Howells 2019-09-03 15:41 ` David Howells 2019-09-03 17:40 ` Casey Schaufler 2019-09-03 17:40 ` Casey Schaufler 2019-09-03 18:06 ` David Howells 2019-09-03 18:06 ` David Howells 2019-09-03 22:16 ` Casey Schaufler 2019-09-03 22:16 ` Casey Schaufler 2019-09-03 22:39 ` David Howells 2019-09-03 22:39 ` David Howells 2019-09-04 12:08 ` David Howells 2019-09-04 12:08 ` David Howells 2019-09-04 14:56 ` Casey Schaufler 2019-09-04 14:56 ` Casey Schaufler 2019-08-30 14:15 ` watch_queue(7) manpage David Howells 2019-08-30 14:15 ` David Howells 2019-08-30 14:15 ` David Howells 2019-08-30 14:15 ` watch_devices(2) manpage David Howells 2019-08-30 14:15 ` David Howells 2019-08-30 14:16 ` keyctl_watch_key.3 manpage David Howells 2019-08-30 14:16 ` David Howells 2019-08-30 22:09 ` [PATCH 00/11] Keyrings, Block and USB notifications [ver #7] Casey Schaufler 2019-08-30 22:09 ` Casey Schaufler 2019-09-02 12:39 ` David Howells 2019-09-02 12:39 ` David Howells 2019-09-02 13:26 ` David Howells 2019-09-02 13:26 ` David Howells 2019-09-03 16:06 ` [PATCH 04/11] General notification queue with user mmap()'able ring buffer " David Howells 2019-09-03 16:06 ` David Howells 2019-09-03 16:37 ` David Howells 2019-09-03 16:37 ` David Howells 2019-09-04 22:15 [PATCH 00/11] Keyrings, Block and USB notifications [ver #8] David Howells 2019-09-04 22:15 ` David Howells 2019-09-04 22:15 ` David Howells 2019-09-04 22:15 ` [PATCH 01/11] uapi: General notification ring definitions " David Howells 2019-09-04 22:15 ` David Howells 2019-09-04 22:15 ` David Howells 2019-09-04 22:16 ` [PATCH 02/11] security: Add hooks to rule on setting a watch " David Howells 2019-09-04 22:16 ` David Howells 2019-09-04 22:16 ` David Howells 2019-09-04 22:16 ` [PATCH 03/11] security: Add a hook for the point of notification insertion " David Howells 2019-09-04 22:16 ` David Howells 2019-09-04 22:16 ` David Howells 2019-09-04 22:16 ` [PATCH 04/11] General notification queue with user mmap()'able ring buffer " David Howells 2019-09-04 22:16 ` David Howells 2019-09-04 22:16 ` David Howells 2019-09-04 22:16 ` [PATCH 05/11] keys: Add a notification facility " David Howells 2019-09-04 22:16 ` David Howells 2019-09-04 22:16 ` David Howells 2019-09-04 22:16 ` [PATCH 06/11] Add a general, global device notification watch list " David Howells 2019-09-04 22:16 ` David Howells 2019-09-04 22:16 ` David Howells 2019-09-04 22:16 ` [PATCH 07/11] block: Add block layer notifications " David Howells 2019-09-04 22:16 ` David Howells 2019-09-04 22:16 ` David Howells 2019-09-04 22:16 ` [PATCH 08/11] usb: Add USB subsystem " David Howells 2019-09-04 22:16 ` David Howells 2019-09-04 22:16 ` David Howells 2019-09-04 22:17 ` [PATCH 09/11] Add sample notification program " David Howells 2019-09-04 22:17 ` David Howells 2019-09-04 22:17 ` David Howells 2019-09-04 22:17 ` [PATCH 10/11] selinux: Implement the watch_key security hook " David Howells 2019-09-04 22:17 ` David Howells 2019-09-04 22:17 ` David Howells 2019-09-04 22:17 ` [PATCH 11/11] smack: Implement the watch_key and post_notification hooks " David Howells 2019-09-04 22:17 ` David Howells 2019-09-04 22:17 ` David Howells 2019-09-04 22:28 ` [PATCH 00/11] Keyrings, Block and USB notifications " Linus Torvalds 2019-09-04 22:28 ` Linus Torvalds 2019-09-05 17:01 ` Why add the general notification queue and its sources David Howells 2019-09-05 17:01 ` David Howells 2019-09-05 17:19 ` Linus Torvalds 2019-09-05 17:19 ` Linus Torvalds 2019-09-05 18:32 ` Ray Strode 2019-09-05 18:32 ` Ray Strode 2019-09-05 18:32 ` Ray Strode 2019-09-05 20:39 ` Linus Torvalds 2019-09-05 20:39 ` Linus Torvalds 2019-09-06 19:32 ` Ray Strode 2019-09-06 19:32 ` Ray Strode 2019-09-06 19:41 ` Ray Strode 2019-09-06 19:41 ` Ray Strode 2019-09-06 19:53 ` Robbie Harwood 2019-09-06 19:53 ` Robbie Harwood 2019-09-06 19:53 ` Robbie Harwood 2019-09-05 21:32 ` David Howells 2019-09-05 21:32 ` David Howells 2019-09-05 22:08 ` Linus Torvalds 2019-09-05 22:08 ` Linus Torvalds 2019-09-05 23:18 ` David Howells 2019-09-05 23:18 ` David Howells 2019-09-06 0:07 ` Linus Torvalds 2019-09-06 0:07 ` Linus Torvalds 2019-09-06 10:09 ` David Howells 2019-09-06 10:09 ` David Howells 2019-09-06 15:35 ` Linus Torvalds 2019-09-06 15:35 ` Linus Torvalds 2019-09-06 15:53 ` Linus Torvalds 2019-09-06 15:53 ` Linus Torvalds 2019-09-06 16:12 ` Steven Whitehouse 2019-09-06 16:12 ` Steven Whitehouse 2019-09-06 17:07 ` Linus Torvalds 2019-09-06 17:07 ` Linus Torvalds 2019-09-06 17:14 ` Linus Torvalds 2019-09-06 17:14 ` Linus Torvalds 2019-09-06 21:19 ` David Howells 2019-09-06 21:19 ` David Howells 2019-09-06 17:14 ` Andy Lutomirski 2019-09-06 17:14 ` Andy Lutomirski 2019-09-05 18:37 ` Steven Whitehouse 2019-09-05 18:37 ` Steven Whitehouse 2019-09-05 18:51 ` Ray Strode 2019-09-05 18:51 ` Ray Strode 2019-09-05 20:09 ` David Lehman 2019-09-05 20:09 ` David Lehman 2019-09-05 18:33 ` Greg Kroah-Hartman 2019-09-05 18:33 ` Greg Kroah-Hartman -- strict thread matches above, loose matches on Subject: below -- 2019-08-29 18:29 [PATCH 00/11] Keyrings, Block and USB notifications [ver #6] David Howells 2019-08-29 18:29 ` David Howells 2019-08-29 18:29 ` David Howells 2019-08-29 18:29 ` [PATCH 01/11] uapi: General notification ring definitions " David Howells 2019-08-29 18:29 ` David Howells 2019-08-29 18:29 ` David Howells 2019-08-29 18:30 ` [PATCH 02/11] security: Add hooks to rule on setting a watch " David Howells 2019-08-29 18:30 ` David Howells 2019-08-29 18:30 ` David Howells 2019-08-29 18:30 ` [PATCH 03/11] security: Add a hook for the point of notification insertion " David Howells 2019-08-29 18:30 ` David Howells 2019-08-29 18:30 ` David Howells 2019-08-29 18:30 ` [PATCH 04/11] General notification queue with user mmap()'able ring buffer " David Howells 2019-08-29 18:30 ` David Howells 2019-08-29 18:30 ` David Howells 2019-08-29 18:30 ` [PATCH 05/11] keys: Add a notification facility " David Howells 2019-08-29 18:30 ` David Howells 2019-08-29 18:30 ` David Howells 2019-08-29 18:30 ` [PATCH 06/11] Add a general, global device notification watch list " David Howells 2019-08-29 18:30 ` David Howells 2019-08-29 18:30 ` David Howells 2019-08-29 18:30 ` [PATCH 07/11] block: Add block layer notifications " David Howells 2019-08-29 18:30 ` David Howells 2019-08-29 18:30 ` David Howells 2019-08-29 18:31 ` [PATCH 08/11] usb: Add USB subsystem " David Howells 2019-08-29 18:31 ` David Howells 2019-08-29 18:31 ` David Howells 2019-08-29 18:31 ` [PATCH 09/11] Add sample notification program " David Howells 2019-08-29 18:31 ` David Howells 2019-08-29 18:31 ` David Howells 2019-08-29 18:31 ` [PATCH 10/11] selinux: Implement the watch_key security hook " David Howells 2019-08-29 18:31 ` David Howells 2019-08-29 18:31 ` David Howells 2019-08-29 18:44 ` Stephen Smalley 2019-08-29 18:44 ` Stephen Smalley 2019-08-29 19:11 ` David Howells 2019-08-29 19:11 ` David Howells 2019-08-29 18:31 ` [PATCH 11/11] smack: Implement the watch_key and post_notification hooks [untested] " David Howells 2019-08-29 18:31 ` David Howells 2019-08-29 18:31 ` David Howells
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=TYAPR01MB45441054C3956CCA7BBD80CBD8B80@TYAPR01MB4544.jpnprd01.prod.outlook.com \ --to=yoshihiro.shimoda.uh@renesas.com \ --cc=casey@schaufler-ca.com \ --cc=christian@brauner.io \ --cc=dhowells@redhat.com \ --cc=gregkh@linuxfoundation.org \ --cc=keyrings@vger.kernel.org \ --cc=linux-api@vger.kernel.org \ --cc=linux-block@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-security-module@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=nicolas.dichtel@6wind.com \ --cc=raven@themaw.net \ --cc=sds@tycho.nsa.gov \ --cc=viro@zeniv.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.