* [PATCH] soc: dove: constify reset_control_ops structures
@ 2017-01-09 16:34 Bhumika Goyal
2017-01-13 16:36 ` Gregory CLEMENT
0 siblings, 1 reply; 6+ messages in thread
From: Bhumika Goyal @ 2017-01-09 16:34 UTC (permalink / raw)
To: julia.lawall, rmk+kernel, gregory.clement, tglx, linux-kernel
Cc: Bhumika Goyal
Declare reset_control_ops as const as they are only stored in the ops
field of a reset_controller_dev structure. This field is of type const
struct reset_control_ops *, so reset_control_ops structures having this
property can be declared as const.
Done using Coccinelle:
@r1 disable optional_qualifier@
identifier i;
position p;
@@
static struct reset_control_ops i@p={...};
@ok1@
identifier r1.i;
position p;
struct reset_controller_dev x;
@@
x.ops=&i@p;
@bad@
position p!={r1.p,ok1.p};
identifier r1.i;
@@
i@p
@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
+const
struct reset_control_ops i;
File size before: drivers/soc/dove/pmu.o
text data bss dec hex filename
2447 112 16 2575 a0f drivers/soc/dove/pmu.o
File size after: drivers/soc/dove/pmu.o
text data bss dec hex filename
2479 80 16 2575 a0f drivers/soc/dove/pmu.o
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
drivers/soc/dove/pmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/dove/pmu.c b/drivers/soc/dove/pmu.c
index 039374e..95d77ec 100644
--- a/drivers/soc/dove/pmu.c
+++ b/drivers/soc/dove/pmu.c
@@ -87,7 +87,7 @@ static int pmu_reset_deassert(struct reset_controller_dev *rc, unsigned long id)
return 0;
}
-static struct reset_control_ops pmu_reset_ops = {
+static const struct reset_control_ops pmu_reset_ops = {
.reset = pmu_reset_reset,
.assert = pmu_reset_assert,
.deassert = pmu_reset_deassert,
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] soc: dove: constify reset_control_ops structures
2017-01-09 16:34 [PATCH] soc: dove: constify reset_control_ops structures Bhumika Goyal
@ 2017-01-13 16:36 ` Gregory CLEMENT
2017-01-13 16:50 ` Russell King - ARM Linux
0 siblings, 1 reply; 6+ messages in thread
From: Gregory CLEMENT @ 2017-01-13 16:36 UTC (permalink / raw)
To: Sebastian Hesselbarth
Cc: Bhumika Goyal, julia.lawall, rmk+kernel, tglx, linux-kernel
Hi Sebastian,
On lun., janv. 09 2017, Bhumika Goyal <bhumirks@gmail.com> wrote:
> Declare reset_control_ops as const as they are only stored in the ops
> field of a reset_controller_dev structure. This field is of type const
> struct reset_control_ops *, so reset_control_ops structures having this
> property can be declared as const.
> Done using Coccinelle:
>
> @r1 disable optional_qualifier@
> identifier i;
> position p;
> @@
> static struct reset_control_ops i@p={...};
>
> @ok1@
> identifier r1.i;
> position p;
> struct reset_controller_dev x;
> @@
> x.ops=&i@p;
>
> @bad@
> position p!={r1.p,ok1.p};
> identifier r1.i;
> @@
> i@p
>
> @depends on !bad disable optional_qualifier@
> identifier r1.i;
> @@
> +const
> struct reset_control_ops i;
>
> File size before: drivers/soc/dove/pmu.o
> text data bss dec hex filename
> 2447 112 16 2575 a0f drivers/soc/dove/pmu.o
>
> File size after: drivers/soc/dove/pmu.o
> text data bss dec hex filename
> 2479 80 16 2575 a0f drivers/soc/dove/pmu.o
>
If you agree with this patch I will apply it on mvebu/soc.
Thanks,
Gregory
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
> drivers/soc/dove/pmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/dove/pmu.c b/drivers/soc/dove/pmu.c
> index 039374e..95d77ec 100644
> --- a/drivers/soc/dove/pmu.c
> +++ b/drivers/soc/dove/pmu.c
> @@ -87,7 +87,7 @@ static int pmu_reset_deassert(struct reset_controller_dev *rc, unsigned long id)
> return 0;
> }
>
> -static struct reset_control_ops pmu_reset_ops = {
> +static const struct reset_control_ops pmu_reset_ops = {
> .reset = pmu_reset_reset,
> .assert = pmu_reset_assert,
> .deassert = pmu_reset_deassert,
> --
> 1.9.1
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] soc: dove: constify reset_control_ops structures
2017-01-13 16:36 ` Gregory CLEMENT
@ 2017-01-13 16:50 ` Russell King - ARM Linux
2017-01-13 16:55 ` Gregory CLEMENT
0 siblings, 1 reply; 6+ messages in thread
From: Russell King - ARM Linux @ 2017-01-13 16:50 UTC (permalink / raw)
To: Gregory CLEMENT
Cc: Sebastian Hesselbarth, Bhumika Goyal, julia.lawall, tglx, linux-kernel
On Fri, Jan 13, 2017 at 05:36:42PM +0100, Gregory CLEMENT wrote:
> Hi Sebastian,
>
> On lun., janv. 09 2017, Bhumika Goyal <bhumirks@gmail.com> wrote:
>
> > Declare reset_control_ops as const as they are only stored in the ops
> > field of a reset_controller_dev structure. This field is of type const
> > struct reset_control_ops *, so reset_control_ops structures having this
> > property can be declared as const.
> > Done using Coccinelle:
> >
> > @r1 disable optional_qualifier@
> > identifier i;
> > position p;
> > @@
> > static struct reset_control_ops i@p={...};
> >
> > @ok1@
> > identifier r1.i;
> > position p;
> > struct reset_controller_dev x;
> > @@
> > x.ops=&i@p;
> >
> > @bad@
> > position p!={r1.p,ok1.p};
> > identifier r1.i;
> > @@
> > i@p
> >
> > @depends on !bad disable optional_qualifier@
> > identifier r1.i;
> > @@
> > +const
> > struct reset_control_ops i;
> >
> > File size before: drivers/soc/dove/pmu.o
> > text data bss dec hex filename
> > 2447 112 16 2575 a0f drivers/soc/dove/pmu.o
> >
> > File size after: drivers/soc/dove/pmu.o
> > text data bss dec hex filename
> > 2479 80 16 2575 a0f drivers/soc/dove/pmu.o
> >
>
> If you agree with this patch I will apply it on mvebu/soc.
You really ought to be asking me...
Acked-by: Russell King <rmk+kernel@armlinux.org.uk>
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] soc: dove: constify reset_control_ops structures
2017-01-13 16:50 ` Russell King - ARM Linux
@ 2017-01-13 16:55 ` Gregory CLEMENT
2017-03-24 13:00 ` Russell King - ARM Linux
0 siblings, 1 reply; 6+ messages in thread
From: Gregory CLEMENT @ 2017-01-13 16:55 UTC (permalink / raw)
To: Russell King - ARM Linux
Cc: Sebastian Hesselbarth, Bhumika Goyal, julia.lawall, tglx, linux-kernel
Hi Russell King,
On ven., janv. 13 2017, Russell King - ARM Linux <linux@armlinux.org.uk> wrote:
> On Fri, Jan 13, 2017 at 05:36:42PM +0100, Gregory CLEMENT wrote:
>> Hi Sebastian,
>>
>> On lun., janv. 09 2017, Bhumika Goyal <bhumirks@gmail.com> wrote:
>>
>> > Declare reset_control_ops as const as they are only stored in the ops
>> > field of a reset_controller_dev structure. This field is of type const
>> > struct reset_control_ops *, so reset_control_ops structures having this
>> > property can be declared as const.
>> > Done using Coccinelle:
>> >
>> > @r1 disable optional_qualifier@
>> > identifier i;
>> > position p;
>> > @@
>> > static struct reset_control_ops i@p={...};
>> >
>> > @ok1@
>> > identifier r1.i;
>> > position p;
>> > struct reset_controller_dev x;
>> > @@
>> > x.ops=&i@p;
>> >
>> > @bad@
>> > position p!={r1.p,ok1.p};
>> > identifier r1.i;
>> > @@
>> > i@p
>> >
>> > @depends on !bad disable optional_qualifier@
>> > identifier r1.i;
>> > @@
>> > +const
>> > struct reset_control_ops i;
>> >
>> > File size before: drivers/soc/dove/pmu.o
>> > text data bss dec hex filename
>> > 2447 112 16 2575 a0f drivers/soc/dove/pmu.o
>> >
>> > File size after: drivers/soc/dove/pmu.o
>> > text data bss dec hex filename
>> > 2479 80 16 2575 a0f drivers/soc/dove/pmu.o
>> >
>>
>> If you agree with this patch I will apply it on mvebu/soc.
>
> You really ought to be asking me...
Sorry when I saw SoC and Dove I though to Sebastian. And I ma sure he
would have redirect me to you :)
>
> Acked-by: Russell King <rmk+kernel@armlinux.org.uk>
Applied on mvebu/soc
Thanks,
Gregory
>
> --
> RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
> FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
> according to speedtest.net.
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] soc: dove: constify reset_control_ops structures
2017-01-13 16:55 ` Gregory CLEMENT
@ 2017-03-24 13:00 ` Russell King - ARM Linux
2017-03-24 14:40 ` Sebastian Hesselbarth
0 siblings, 1 reply; 6+ messages in thread
From: Russell King - ARM Linux @ 2017-03-24 13:00 UTC (permalink / raw)
To: Gregory CLEMENT
Cc: Sebastian Hesselbarth, Bhumika Goyal, julia.lawall, tglx, linux-kernel
On Fri, Jan 13, 2017 at 05:55:26PM +0100, Gregory CLEMENT wrote:
> Sorry when I saw SoC and Dove I though to Sebastian. And I ma sure he
> would have redirect me to you :)
Should I change the MAINTAINERS entry, as it seems that I'm more involved
with Dove than Sebastian is now? Sebastian?
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] soc: dove: constify reset_control_ops structures
2017-03-24 13:00 ` Russell King - ARM Linux
@ 2017-03-24 14:40 ` Sebastian Hesselbarth
0 siblings, 0 replies; 6+ messages in thread
From: Sebastian Hesselbarth @ 2017-03-24 14:40 UTC (permalink / raw)
To: Russell King - ARM Linux, Gregory CLEMENT
Cc: Bhumika Goyal, julia.lawall, tglx, linux-kernel
On 24.03.2017 14:00, Russell King - ARM Linux wrote:
> On Fri, Jan 13, 2017 at 05:55:26PM +0100, Gregory CLEMENT wrote:
>> Sorry when I saw SoC and Dove I though to Sebastian. And I ma sure he
>> would have redirect me to you :)
>
> Should I change the MAINTAINERS entry, as it seems that I'm more involved
> with Dove than Sebastian is now? Sebastian?
>
Uhm, yeah, please change the MAINTAINERS entry.
I haven't been able to follow neither Dove nor mvebu discussion
lately.
If you want to take over, feel free to add my
Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Sebastian
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-03-24 14:41 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-09 16:34 [PATCH] soc: dove: constify reset_control_ops structures Bhumika Goyal
2017-01-13 16:36 ` Gregory CLEMENT
2017-01-13 16:50 ` Russell King - ARM Linux
2017-01-13 16:55 ` Gregory CLEMENT
2017-03-24 13:00 ` Russell King - ARM Linux
2017-03-24 14:40 ` Sebastian Hesselbarth
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.