From: Viresh Kumar <viresh.kumar@linaro.org> To: Rafael Wysocki <rjw@rjwysocki.net>, Vincent Donnefort <vincent.donnefort@arm.com>, lukasz.luba@arm.com, Viresh Kumar <viresh.kumar@linaro.org>, Sudeep Holla <sudeep.holla@arm.com> Cc: linux-pm@vger.kernel.org, Vincent Guittot <vincent.guittot@linaro.org>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 8/8] cpufreq: vexpress: Use auto-registration for energy model Date: Tue, 10 Aug 2021 13:06:55 +0530 [thread overview] Message-ID: <87fecd84e3f6ff6f153be14b0d53de93c0b04ae6.1628579170.git.viresh.kumar@linaro.org> (raw) In-Reply-To: <cover.1628579170.git.viresh.kumar@linaro.org> Use the CPUFREQ_REGISTER_WITH_EM flag to allow cpufreq core to automatically register with the energy model. This allows removal of boiler plate code from the driver and fixes the unregistration part as well. Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- drivers/cpufreq/vexpress-spc-cpufreq.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/cpufreq/vexpress-spc-cpufreq.c b/drivers/cpufreq/vexpress-spc-cpufreq.c index 51dfa9ae6cf5..28c4c3254337 100644 --- a/drivers/cpufreq/vexpress-spc-cpufreq.c +++ b/drivers/cpufreq/vexpress-spc-cpufreq.c @@ -442,8 +442,6 @@ static int ve_spc_cpufreq_init(struct cpufreq_policy *policy) policy->freq_table = freq_table[cur_cluster]; policy->cpuinfo.transition_latency = 1000000; /* 1 ms */ - dev_pm_opp_of_register_em(cpu_dev, policy->cpus); - if (is_bL_switching_enabled()) per_cpu(cpu_last_req_freq, policy->cpu) = clk_get_cpu_rate(policy->cpu); @@ -487,7 +485,8 @@ static void ve_spc_cpufreq_ready(struct cpufreq_policy *policy) static struct cpufreq_driver ve_spc_cpufreq_driver = { .name = "vexpress-spc", .flags = CPUFREQ_HAVE_GOVERNOR_PER_POLICY | - CPUFREQ_NEED_INITIAL_FREQ_CHECK, + CPUFREQ_NEED_INITIAL_FREQ_CHECK | + CPUFREQ_REGISTER_WITH_EM, .verify = cpufreq_generic_frequency_table_verify, .target_index = ve_spc_cpufreq_set_target, .get = ve_spc_cpufreq_get_rate, -- 2.31.1.272.g89b43f80a514
WARNING: multiple messages have this Message-ID (diff)
From: Viresh Kumar <viresh.kumar@linaro.org> To: Rafael Wysocki <rjw@rjwysocki.net>, Vincent Donnefort <vincent.donnefort@arm.com>, lukasz.luba@arm.com, Viresh Kumar <viresh.kumar@linaro.org>, Sudeep Holla <sudeep.holla@arm.com> Cc: linux-pm@vger.kernel.org, Vincent Guittot <vincent.guittot@linaro.org>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 8/8] cpufreq: vexpress: Use auto-registration for energy model Date: Tue, 10 Aug 2021 13:06:55 +0530 [thread overview] Message-ID: <87fecd84e3f6ff6f153be14b0d53de93c0b04ae6.1628579170.git.viresh.kumar@linaro.org> (raw) In-Reply-To: <cover.1628579170.git.viresh.kumar@linaro.org> Use the CPUFREQ_REGISTER_WITH_EM flag to allow cpufreq core to automatically register with the energy model. This allows removal of boiler plate code from the driver and fixes the unregistration part as well. Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- drivers/cpufreq/vexpress-spc-cpufreq.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/cpufreq/vexpress-spc-cpufreq.c b/drivers/cpufreq/vexpress-spc-cpufreq.c index 51dfa9ae6cf5..28c4c3254337 100644 --- a/drivers/cpufreq/vexpress-spc-cpufreq.c +++ b/drivers/cpufreq/vexpress-spc-cpufreq.c @@ -442,8 +442,6 @@ static int ve_spc_cpufreq_init(struct cpufreq_policy *policy) policy->freq_table = freq_table[cur_cluster]; policy->cpuinfo.transition_latency = 1000000; /* 1 ms */ - dev_pm_opp_of_register_em(cpu_dev, policy->cpus); - if (is_bL_switching_enabled()) per_cpu(cpu_last_req_freq, policy->cpu) = clk_get_cpu_rate(policy->cpu); @@ -487,7 +485,8 @@ static void ve_spc_cpufreq_ready(struct cpufreq_policy *policy) static struct cpufreq_driver ve_spc_cpufreq_driver = { .name = "vexpress-spc", .flags = CPUFREQ_HAVE_GOVERNOR_PER_POLICY | - CPUFREQ_NEED_INITIAL_FREQ_CHECK, + CPUFREQ_NEED_INITIAL_FREQ_CHECK | + CPUFREQ_REGISTER_WITH_EM, .verify = cpufreq_generic_frequency_table_verify, .target_index = ve_spc_cpufreq_set_target, .get = ve_spc_cpufreq_get_rate, -- 2.31.1.272.g89b43f80a514 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-10 7:37 UTC|newest] Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-10 7:36 [PATCH 0/8] cpufreq: Auto-register with energy model Viresh Kumar 2021-08-10 7:36 ` Viresh Kumar 2021-08-10 7:36 ` Viresh Kumar 2021-08-10 7:36 ` [PATCH 1/8] cpufreq: Auto-register with energy model if asked Viresh Kumar 2021-08-10 9:36 ` Lukasz Luba 2021-08-10 9:38 ` Viresh Kumar 2021-08-10 15:33 ` Lukasz Luba 2021-08-10 7:36 ` [PATCH 2/8] cpufreq: dt: Use auto-registration for energy model Viresh Kumar 2021-08-10 10:19 ` Lukasz Luba 2021-08-10 7:36 ` [PATCH 3/8] cpufreq: imx6q: " Viresh Kumar 2021-08-10 7:36 ` Viresh Kumar 2021-08-10 10:20 ` Lukasz Luba 2021-08-10 10:20 ` Lukasz Luba 2021-08-10 7:36 ` [PATCH 4/8] cpufreq: mediatek: " Viresh Kumar 2021-08-10 7:36 ` Viresh Kumar 2021-08-10 7:36 ` Viresh Kumar 2021-08-10 10:20 ` Lukasz Luba 2021-08-10 10:20 ` Lukasz Luba 2021-08-10 10:20 ` Lukasz Luba 2021-08-10 7:36 ` [PATCH 5/8] cpufreq: omap: " Viresh Kumar 2021-08-10 10:24 ` Lukasz Luba 2021-08-10 7:36 ` [PATCH 6/8] cpufreq: qcom-cpufreq-hw: " Viresh Kumar 2021-08-10 10:26 ` Lukasz Luba 2021-08-10 7:36 ` [PATCH 7/8] cpufreq: scpi: " Viresh Kumar 2021-08-10 7:36 ` Viresh Kumar 2021-08-10 10:27 ` Lukasz Luba 2021-08-10 10:27 ` Lukasz Luba 2021-08-11 2:40 ` Sudeep Holla 2021-08-11 2:40 ` Sudeep Holla 2021-08-10 7:36 ` Viresh Kumar [this message] 2021-08-10 7:36 ` [PATCH 8/8] cpufreq: vexpress: " Viresh Kumar 2021-08-10 10:05 ` Lukasz Luba 2021-08-10 10:05 ` Lukasz Luba 2021-08-10 10:06 ` Viresh Kumar 2021-08-10 10:06 ` Viresh Kumar 2021-08-10 10:11 ` Lukasz Luba 2021-08-10 10:11 ` Lukasz Luba 2021-08-10 10:12 ` Viresh Kumar 2021-08-10 10:12 ` Viresh Kumar 2021-08-10 10:30 ` Lukasz Luba 2021-08-10 10:30 ` Lukasz Luba 2021-08-11 2:40 ` Sudeep Holla 2021-08-11 2:40 ` Sudeep Holla 2021-08-10 9:17 ` [PATCH 0/8] cpufreq: Auto-register with " Lukasz Luba 2021-08-10 9:17 ` Lukasz Luba 2021-08-10 9:17 ` Lukasz Luba 2021-08-10 9:27 ` Viresh Kumar 2021-08-10 9:27 ` Viresh Kumar 2021-08-10 9:27 ` Viresh Kumar 2021-08-10 9:35 ` Lukasz Luba 2021-08-10 9:35 ` Lukasz Luba 2021-08-10 9:35 ` Lukasz Luba 2021-08-10 12:35 ` Quentin Perret 2021-08-10 12:35 ` Quentin Perret 2021-08-10 12:35 ` Quentin Perret 2021-08-10 13:25 ` Lukasz Luba 2021-08-10 13:25 ` Lukasz Luba 2021-08-10 13:25 ` Lukasz Luba 2021-08-10 13:53 ` Quentin Perret 2021-08-10 13:53 ` Quentin Perret 2021-08-10 13:53 ` Quentin Perret 2021-08-11 5:18 ` Viresh Kumar 2021-08-11 5:18 ` Viresh Kumar 2021-08-11 5:18 ` Viresh Kumar 2021-08-11 5:34 ` Viresh Kumar 2021-08-11 5:34 ` Viresh Kumar 2021-08-11 5:34 ` Viresh Kumar 2021-08-11 9:48 ` Quentin Perret 2021-08-11 9:48 ` Quentin Perret 2021-08-11 9:48 ` Quentin Perret 2021-08-11 9:53 ` Viresh Kumar 2021-08-11 9:53 ` Viresh Kumar 2021-08-11 9:53 ` Viresh Kumar 2021-08-11 10:12 ` Quentin Perret 2021-08-11 10:12 ` Quentin Perret 2021-08-11 10:12 ` Quentin Perret 2021-08-11 10:14 ` Viresh Kumar 2021-08-11 10:14 ` Viresh Kumar 2021-08-11 10:14 ` Viresh Kumar 2021-08-11 8:37 ` Quentin Perret 2021-08-11 8:37 ` Quentin Perret 2021-08-11 8:37 ` Quentin Perret 2021-08-11 9:13 ` Viresh Kumar 2021-08-11 9:13 ` Viresh Kumar 2021-08-11 9:13 ` Viresh Kumar 2021-08-11 9:34 ` Quentin Perret 2021-08-11 9:34 ` Quentin Perret 2021-08-11 9:34 ` Quentin Perret 2021-08-11 9:36 ` Viresh Kumar 2021-08-11 9:36 ` Viresh Kumar 2021-08-11 9:36 ` Viresh Kumar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87fecd84e3f6ff6f153be14b0d53de93c0b04ae6.1628579170.git.viresh.kumar@linaro.org \ --to=viresh.kumar@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=lukasz.luba@arm.com \ --cc=rjw@rjwysocki.net \ --cc=sudeep.holla@arm.com \ --cc=vincent.donnefort@arm.com \ --cc=vincent.guittot@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.