[Buildroot] [PATCH v3 1/2] package/mtd: add host-acl dependency for host

[Buildroot] [PATCH v3 1/2] package/mtd: add host-acl dependency for host

[Antoine Tenart]

When compiling the host version of mtd, --with-jffs and --with-ubifs are
always set, meaning --with-xattr is set by default. The xattr support
only work if 'sys/acl.h' is available, otherwise the feature is silently
dropped (a warning is shown during the configuration step).

This patch adds a dependency on host-acl for host-mtd, so that the xattr
feature is correctly supported. Logic to have xattr support is already
there and working for the non-host flavour.

Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
Reviewed-by: Matthew Weber <matthew.weber@rockwellcollins.com>
---
 package/mtd/mtd.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/mtd/mtd.mk b/package/mtd/mtd.mk
index 1186fa52d552..9f259b35d906 100644
--- a/package/mtd/mtd.mk
+++ b/package/mtd/mtd.mk
@@ -53,7 +53,7 @@ else
 MTD_CONF_OPTS += --without-xattr
 endif
 
-HOST_MTD_DEPENDENCIES = host-zlib host-lzo host-util-linux host-zstd
+HOST_MTD_DEPENDENCIES = host-acl host-zlib host-lzo host-util-linux host-zstd
 HOST_MTD_CONF_OPTS = \
 	--with-jffs \
 	--with-ubifs \
-- 
2.26.2

[Buildroot] [PATCH v3 2/2] fs/jffs2: copy xattrs

[Antoine Tenart]

This patch sets the --with-xattr option when generating an image with
mkfs.jffs2, so that SELinux security contexts and other extended
attributes will be kept and available in jffs2 images.

Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
---

Since v2:
  - Removed condition on BR2_PACKAGE_LIBSELINUX.

Since v1:
  - s/BR2_PACKAGE_REFPOLICY/BR2_PACKAGE_LIBSELINUX/

 fs/jffs2/jffs2.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/jffs2/jffs2.mk b/fs/jffs2/jffs2.mk
index 2adbc2320e38..0096af2ea966 100644
--- a/fs/jffs2/jffs2.mk
+++ b/fs/jffs2/jffs2.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-JFFS2_OPTS = -e $(BR2_TARGET_ROOTFS_JFFS2_EBSIZE)
+JFFS2_OPTS = -e $(BR2_TARGET_ROOTFS_JFFS2_EBSIZE) --with-xattr
 SUMTOOL_OPTS = -e $(BR2_TARGET_ROOTFS_JFFS2_EBSIZE)
 
 ifeq ($(BR2_TARGET_ROOTFS_JFFS2_PAD),y)
-- 
2.26.2

[Buildroot] [PATCH v3 1/2] package/mtd: add host-acl dependency for host

[Thomas Petazzoni]

On Thu,  8 Oct 2020 11:08:35 +0200
Antoine Tenart <antoine.tenart@bootlin.com> wrote:

> When compiling the host version of mtd, --with-jffs and --with-ubifs are
> always set, meaning --with-xattr is set by default. The xattr support
> only work if 'sys/acl.h' is available, otherwise the feature is silently
> dropped (a warning is shown during the configuration step).
> 
> This patch adds a dependency on host-acl for host-mtd, so that the xattr
> feature is correctly supported. Logic to have xattr support is already
> there and working for the non-host flavour.
> 
> Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
> Reviewed-by: Matthew Weber <matthew.weber@rockwellcollins.com>
> ---
>  package/mtd/mtd.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Series applied. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH v3 1/2] package/mtd: add host-acl dependency for host

[Peter Korsgaard]

>>>>> "Antoine" == Antoine Tenart <antoine.tenart@bootlin.com> writes:

 > When compiling the host version of mtd, --with-jffs and --with-ubifs are
 > always set, meaning --with-xattr is set by default. The xattr support
 > only work if 'sys/acl.h' is available, otherwise the feature is silently
 > dropped (a warning is shown during the configuration step).

 > This patch adds a dependency on host-acl for host-mtd, so that the xattr
 > feature is correctly supported. Logic to have xattr support is already
 > there and working for the non-host flavour.

 > Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
 > Reviewed-by: Matthew Weber <matthew.weber@rockwellcollins.com>

Committed to 2020.08.x, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH v3 2/2] fs/jffs2: copy xattrs

[Peter Korsgaard]

>>>>> "Antoine" == Antoine Tenart <antoine.tenart@bootlin.com> writes:

 > This patch sets the --with-xattr option when generating an image with
 > mkfs.jffs2, so that SELinux security contexts and other extended
 > attributes will be kept and available in jffs2 images.

 > Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
 > ---

 > Since v2:
 >   - Removed condition on BR2_PACKAGE_LIBSELINUX.

 > Since v1:
 >   - s/BR2_PACKAGE_REFPOLICY/BR2_PACKAGE_LIBSELINUX/


Committed to 2020.08.x, thanks.

-- 
Bye, Peter Korsgaard