* [Buildroot] [PATCH v3 1/2] package/mtd: add host-acl dependency for host
@ 2020-10-08 9:08 Antoine Tenart
2020-10-08 9:08 ` [Buildroot] [PATCH v3 2/2] fs/jffs2: copy xattrs Antoine Tenart
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Antoine Tenart @ 2020-10-08 9:08 UTC (permalink / raw)
To: buildroot
When compiling the host version of mtd, --with-jffs and --with-ubifs are
always set, meaning --with-xattr is set by default. The xattr support
only work if 'sys/acl.h' is available, otherwise the feature is silently
dropped (a warning is shown during the configuration step).
This patch adds a dependency on host-acl for host-mtd, so that the xattr
feature is correctly supported. Logic to have xattr support is already
there and working for the non-host flavour.
Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
Reviewed-by: Matthew Weber <matthew.weber@rockwellcollins.com>
---
package/mtd/mtd.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/mtd/mtd.mk b/package/mtd/mtd.mk
index 1186fa52d552..9f259b35d906 100644
--- a/package/mtd/mtd.mk
+++ b/package/mtd/mtd.mk
@@ -53,7 +53,7 @@ else
MTD_CONF_OPTS += --without-xattr
endif
-HOST_MTD_DEPENDENCIES = host-zlib host-lzo host-util-linux host-zstd
+HOST_MTD_DEPENDENCIES = host-acl host-zlib host-lzo host-util-linux host-zstd
HOST_MTD_CONF_OPTS = \
--with-jffs \
--with-ubifs \
--
2.26.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* [Buildroot] [PATCH v3 2/2] fs/jffs2: copy xattrs
2020-10-08 9:08 [Buildroot] [PATCH v3 1/2] package/mtd: add host-acl dependency for host Antoine Tenart
@ 2020-10-08 9:08 ` Antoine Tenart
2020-10-10 20:53 ` Peter Korsgaard
2020-10-08 19:48 ` [Buildroot] [PATCH v3 1/2] package/mtd: add host-acl dependency for host Thomas Petazzoni
2020-10-10 20:53 ` Peter Korsgaard
2 siblings, 1 reply; 5+ messages in thread
From: Antoine Tenart @ 2020-10-08 9:08 UTC (permalink / raw)
To: buildroot
This patch sets the --with-xattr option when generating an image with
mkfs.jffs2, so that SELinux security contexts and other extended
attributes will be kept and available in jffs2 images.
Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
---
Since v2:
- Removed condition on BR2_PACKAGE_LIBSELINUX.
Since v1:
- s/BR2_PACKAGE_REFPOLICY/BR2_PACKAGE_LIBSELINUX/
fs/jffs2/jffs2.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/jffs2/jffs2.mk b/fs/jffs2/jffs2.mk
index 2adbc2320e38..0096af2ea966 100644
--- a/fs/jffs2/jffs2.mk
+++ b/fs/jffs2/jffs2.mk
@@ -4,7 +4,7 @@
#
################################################################################
-JFFS2_OPTS = -e $(BR2_TARGET_ROOTFS_JFFS2_EBSIZE)
+JFFS2_OPTS = -e $(BR2_TARGET_ROOTFS_JFFS2_EBSIZE) --with-xattr
SUMTOOL_OPTS = -e $(BR2_TARGET_ROOTFS_JFFS2_EBSIZE)
ifeq ($(BR2_TARGET_ROOTFS_JFFS2_PAD),y)
--
2.26.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v3 2/2] fs/jffs2: copy xattrs
2020-10-08 9:08 ` [Buildroot] [PATCH v3 2/2] fs/jffs2: copy xattrs Antoine Tenart
@ 2020-10-10 20:53 ` Peter Korsgaard
0 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2020-10-10 20:53 UTC (permalink / raw)
To: buildroot
>>>>> "Antoine" == Antoine Tenart <antoine.tenart@bootlin.com> writes:
> This patch sets the --with-xattr option when generating an image with
> mkfs.jffs2, so that SELinux security contexts and other extended
> attributes will be kept and available in jffs2 images.
> Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
> ---
> Since v2:
> - Removed condition on BR2_PACKAGE_LIBSELINUX.
> Since v1:
> - s/BR2_PACKAGE_REFPOLICY/BR2_PACKAGE_LIBSELINUX/
Committed to 2020.08.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v3 1/2] package/mtd: add host-acl dependency for host
2020-10-08 9:08 [Buildroot] [PATCH v3 1/2] package/mtd: add host-acl dependency for host Antoine Tenart
2020-10-08 9:08 ` [Buildroot] [PATCH v3 2/2] fs/jffs2: copy xattrs Antoine Tenart
@ 2020-10-08 19:48 ` Thomas Petazzoni
2020-10-10 20:53 ` Peter Korsgaard
2 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2020-10-08 19:48 UTC (permalink / raw)
To: buildroot
On Thu, 8 Oct 2020 11:08:35 +0200
Antoine Tenart <antoine.tenart@bootlin.com> wrote:
> When compiling the host version of mtd, --with-jffs and --with-ubifs are
> always set, meaning --with-xattr is set by default. The xattr support
> only work if 'sys/acl.h' is available, otherwise the feature is silently
> dropped (a warning is shown during the configuration step).
>
> This patch adds a dependency on host-acl for host-mtd, so that the xattr
> feature is correctly supported. Logic to have xattr support is already
> there and working for the non-host flavour.
>
> Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
> Reviewed-by: Matthew Weber <matthew.weber@rockwellcollins.com>
> ---
> package/mtd/mtd.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Series applied. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v3 1/2] package/mtd: add host-acl dependency for host
2020-10-08 9:08 [Buildroot] [PATCH v3 1/2] package/mtd: add host-acl dependency for host Antoine Tenart
2020-10-08 9:08 ` [Buildroot] [PATCH v3 2/2] fs/jffs2: copy xattrs Antoine Tenart
2020-10-08 19:48 ` [Buildroot] [PATCH v3 1/2] package/mtd: add host-acl dependency for host Thomas Petazzoni
@ 2020-10-10 20:53 ` Peter Korsgaard
2 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2020-10-10 20:53 UTC (permalink / raw)
To: buildroot
>>>>> "Antoine" == Antoine Tenart <antoine.tenart@bootlin.com> writes:
> When compiling the host version of mtd, --with-jffs and --with-ubifs are
> always set, meaning --with-xattr is set by default. The xattr support
> only work if 'sys/acl.h' is available, otherwise the feature is silently
> dropped (a warning is shown during the configuration step).
> This patch adds a dependency on host-acl for host-mtd, so that the xattr
> feature is correctly supported. Logic to have xattr support is already
> there and working for the non-host flavour.
> Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
> Reviewed-by: Matthew Weber <matthew.weber@rockwellcollins.com>
Committed to 2020.08.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-10-10 20:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-08 9:08 [Buildroot] [PATCH v3 1/2] package/mtd: add host-acl dependency for host Antoine Tenart
2020-10-08 9:08 ` [Buildroot] [PATCH v3 2/2] fs/jffs2: copy xattrs Antoine Tenart
2020-10-10 20:53 ` Peter Korsgaard
2020-10-08 19:48 ` [Buildroot] [PATCH v3 1/2] package/mtd: add host-acl dependency for host Thomas Petazzoni
2020-10-10 20:53 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.