* [PATCH] drm/i915/audio: Fix audio detection issue on GLK
@ 2018-04-08 13:36 Gaurav K Singh
2018-04-08 13:45 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 17+ messages in thread
From: Gaurav K Singh @ 2018-04-08 13:36 UTC (permalink / raw)
To: intel-gfx
On Geminilake, sometimes audio card is not getting
detected after reboot. This is a spurious issue happening on
Geminilake. HW codec and HD audio controller link was going
out of sync for which there was a fix in i915 driver but
was not getting invoked for GLK. Extending this fix to GLK as well.
Tested by Du,Wenkai on GLK board.
Signed-off-by: Gaurav K Singh <gaurav.k.singh@intel.com>
---
drivers/gpu/drm/i915/intel_audio.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
index 656f6c931341..73b1e0b96f88 100644
--- a/drivers/gpu/drm/i915/intel_audio.c
+++ b/drivers/gpu/drm/i915/intel_audio.c
@@ -729,7 +729,8 @@ static void i915_audio_component_codec_wake_override(struct device *kdev,
struct drm_i915_private *dev_priv = kdev_to_i915(kdev);
u32 tmp;
- if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv))
+ if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv) &&
+ !IS_GEMINILAKE(dev_priv))
return;
i915_audio_component_get_power(kdev);
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 17+ messages in thread* ✗ Fi.CI.CHECKPATCH: warning for drm/i915/audio: Fix audio detection issue on GLK
2018-04-08 13:36 [PATCH] drm/i915/audio: Fix audio detection issue on GLK Gaurav K Singh
@ 2018-04-08 13:45 ` Patchwork
2018-04-08 14:00 ` ✗ Fi.CI.BAT: failure " Patchwork
2018-04-09 14:07 ` [PATCH] " Jani Nikula
2 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2018-04-08 13:45 UTC (permalink / raw)
To: Gaurav K Singh; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/audio: Fix audio detection issue on GLK
URL : https://patchwork.freedesktop.org/series/41334/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
ccec6d316968 drm/i915/audio: Fix audio detection issue on GLK
-:26: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#26: FILE: drivers/gpu/drm/i915/intel_audio.c:733:
+ if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv) &&
+ !IS_GEMINILAKE(dev_priv))
total: 0 errors, 0 warnings, 1 checks, 9 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915/audio: Fix audio detection issue on GLK
2018-04-08 13:36 [PATCH] drm/i915/audio: Fix audio detection issue on GLK Gaurav K Singh
2018-04-08 13:45 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2018-04-08 14:00 ` Patchwork
2018-04-09 14:07 ` [PATCH] " Jani Nikula
2 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2018-04-08 14:00 UTC (permalink / raw)
To: Gaurav K Singh; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/audio: Fix audio detection issue on GLK
URL : https://patchwork.freedesktop.org/series/41334/
State : failure
== Summary ==
Series 41334v1 drm/i915/audio: Fix audio detection issue on GLK
https://patchwork.freedesktop.org/api/1.0/series/41334/revisions/1/mbox/
---- Possible new issues:
Test gem_ctx_param:
Subgroup basic-default:
incomplete -> PASS (fi-cnl-y3)
Test gem_exec_fence:
Subgroup basic-wait-default:
notrun -> INCOMPLETE (fi-cnl-y3)
Test kms_chamelium:
Subgroup common-hpd-after-suspend:
pass -> INCOMPLETE (fi-skl-6700k2)
---- Known issues:
Test debugfs_test:
Subgroup read_all_entries:
incomplete -> PASS (fi-snb-2520m) fdo#103713
Test gem_mmap_gtt:
Subgroup basic-small-bo-tiledx:
fail -> PASS (fi-gdg-551) fdo#102575
Test kms_chamelium:
Subgroup dp-edid-read:
fail -> PASS (fi-kbl-7500u) fdo#102505
Test kms_flip:
Subgroup basic-flip-vs-wf_vblank:
fail -> PASS (fi-cfl-s3) fdo#100368
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-c:
pass -> INCOMPLETE (fi-bxt-dsi) fdo#103927
Test prime_vgem:
Subgroup basic-fence-flip:
pass -> FAIL (fi-ilk-650) fdo#104008
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#102505 https://bugs.freedesktop.org/show_bug.cgi?id=102505
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
fi-bdw-5557u total:285 pass:264 dwarn:0 dfail:0 fail:0 skip:21 time:429s
fi-bdw-gvtdvm total:285 pass:261 dwarn:0 dfail:0 fail:0 skip:24 time:442s
fi-blb-e6850 total:285 pass:220 dwarn:1 dfail:0 fail:0 skip:64 time:382s
fi-bsw-n3050 total:285 pass:239 dwarn:0 dfail:0 fail:0 skip:46 time:539s
fi-bwr-2160 total:285 pass:180 dwarn:0 dfail:0 fail:0 skip:105 time:299s
fi-bxt-dsi total:243 pass:216 dwarn:0 dfail:0 fail:0 skip:26
fi-bxt-j4205 total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:515s
fi-byt-j1900 total:285 pass:250 dwarn:0 dfail:0 fail:0 skip:35 time:519s
fi-byt-n2820 total:285 pass:246 dwarn:0 dfail:0 fail:0 skip:39 time:517s
fi-cfl-8700k total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:410s
fi-cfl-s3 total:285 pass:259 dwarn:0 dfail:0 fail:0 skip:26 time:563s
fi-cfl-u total:285 pass:259 dwarn:0 dfail:0 fail:0 skip:26 time:517s
fi-cnl-y3 total:46 pass:39 dwarn:0 dfail:0 fail:0 skip:6
fi-elk-e7500 total:285 pass:226 dwarn:0 dfail:0 fail:0 skip:59 time:420s
fi-gdg-551 total:285 pass:177 dwarn:0 dfail:0 fail:0 skip:108 time:315s
fi-glk-1 total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:537s
fi-glk-j4005 total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:481s
fi-hsw-4770 total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:406s
fi-ilk-650 total:285 pass:224 dwarn:0 dfail:0 fail:1 skip:60 time:426s
fi-ivb-3520m total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:468s
fi-ivb-3770 total:285 pass:252 dwarn:0 dfail:0 fail:0 skip:33 time:434s
fi-kbl-7500u total:285 pass:260 dwarn:1 dfail:0 fail:0 skip:24 time:476s
fi-kbl-7567u total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:463s
fi-kbl-r total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:509s
fi-pnv-d510 total:285 pass:220 dwarn:1 dfail:0 fail:0 skip:64 time:665s
fi-skl-6260u total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:438s
fi-skl-6600u total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:544s
fi-skl-6700k2 total:207 pass:190 dwarn:0 dfail:0 fail:0 skip:16
fi-skl-6770hq total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:496s
fi-skl-guc total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:432s
fi-skl-gvtdvm total:285 pass:262 dwarn:0 dfail:0 fail:0 skip:23 time:447s
fi-snb-2520m total:285 pass:245 dwarn:0 dfail:0 fail:0 skip:40 time:582s
fi-snb-2600 total:285 pass:245 dwarn:0 dfail:0 fail:0 skip:40 time:400s
1be073153147c5c39cdcbdfdeb4e2595ba595bf7 drm-tip: 2018y-04m-07d-22h-26m-31s UTC integration manifest
ccec6d316968 drm/i915/audio: Fix audio detection issue on GLK
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8634/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH] drm/i915/audio: Fix audio detection issue on GLK
2018-04-08 13:36 [PATCH] drm/i915/audio: Fix audio detection issue on GLK Gaurav K Singh
2018-04-08 13:45 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2018-04-08 14:00 ` ✗ Fi.CI.BAT: failure " Patchwork
@ 2018-04-09 14:07 ` Jani Nikula
2018-04-09 19:10 ` Rodrigo Vivi
2 siblings, 1 reply; 17+ messages in thread
From: Jani Nikula @ 2018-04-09 14:07 UTC (permalink / raw)
To: Gaurav K Singh, intel-gfx
On Sun, 08 Apr 2018, Gaurav K Singh <gaurav.k.singh@intel.com> wrote:
> On Geminilake, sometimes audio card is not getting
> detected after reboot. This is a spurious issue happening on
> Geminilake. HW codec and HD audio controller link was going
> out of sync for which there was a fix in i915 driver but
> was not getting invoked for GLK. Extending this fix to GLK as well.
>
> Tested by Du,Wenkai on GLK board.
>
> Signed-off-by: Gaurav K Singh <gaurav.k.singh@intel.com>
> ---
> drivers/gpu/drm/i915/intel_audio.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
> index 656f6c931341..73b1e0b96f88 100644
> --- a/drivers/gpu/drm/i915/intel_audio.c
> +++ b/drivers/gpu/drm/i915/intel_audio.c
> @@ -729,7 +729,8 @@ static void i915_audio_component_codec_wake_override(struct device *kdev,
> struct drm_i915_private *dev_priv = kdev_to_i915(kdev);
> u32 tmp;
>
> - if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv))
> + if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv) &&
> + !IS_GEMINILAKE(dev_priv))
That could be written as
if (!IS_GEN9_BC(dev_priv) && !IS_GEN9_LP(dev_priv))
which in turn could just be written as
if (!IS_GEN9(dev_priv))
...but since GLK has gen 10 display, so I'm wondering if the same issue
will be present in gen 10 too, and whether this should just become
if (INTEL_GEN(dev_priv) < 9)
BR,
Jani.
> return;
>
> i915_audio_component_get_power(kdev);
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/i915/audio: Fix audio detection issue on GLK
2018-04-09 14:07 ` [PATCH] " Jani Nikula
@ 2018-04-09 19:10 ` Rodrigo Vivi
2018-04-09 19:18 ` Kumar, Abhay
0 siblings, 1 reply; 17+ messages in thread
From: Rodrigo Vivi @ 2018-04-09 19:10 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Mon, Apr 09, 2018 at 05:07:31PM +0300, Jani Nikula wrote:
> On Sun, 08 Apr 2018, Gaurav K Singh <gaurav.k.singh@intel.com> wrote:
> > On Geminilake, sometimes audio card is not getting
> > detected after reboot. This is a spurious issue happening on
> > Geminilake. HW codec and HD audio controller link was going
> > out of sync for which there was a fix in i915 driver but
> > was not getting invoked for GLK. Extending this fix to GLK as well.
> >
> > Tested by Du,Wenkai on GLK board.
> >
> > Signed-off-by: Gaurav K Singh <gaurav.k.singh@intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_audio.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
> > index 656f6c931341..73b1e0b96f88 100644
> > --- a/drivers/gpu/drm/i915/intel_audio.c
> > +++ b/drivers/gpu/drm/i915/intel_audio.c
> > @@ -729,7 +729,8 @@ static void i915_audio_component_codec_wake_override(struct device *kdev,
> > struct drm_i915_private *dev_priv = kdev_to_i915(kdev);
> > u32 tmp;
> >
> > - if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv))
> > + if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv) &&
> > + !IS_GEMINILAKE(dev_priv))
>
> That could be written as
>
> if (!IS_GEN9_BC(dev_priv) && !IS_GEN9_LP(dev_priv))
>
> which in turn could just be written as
>
> if (!IS_GEN9(dev_priv))
>
> ...but since GLK has gen 10 display, so I'm wondering if the same issue
> will be present in gen 10 too, and whether this should just become
>
> if (INTEL_GEN(dev_priv) < 9)
+1. I opened here to exactly add same comment.
>
> BR,
> Jani.
>
>
>
> > return;
> >
> > i915_audio_component_get_power(kdev);
>
> --
> Jani Nikula, Intel Open Source Technology Center
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/i915/audio: Fix audio detection issue on GLK
2018-04-09 19:10 ` Rodrigo Vivi
@ 2018-04-09 19:18 ` Kumar, Abhay
2018-04-09 23:20 ` Dhinakaran Pandiyan
0 siblings, 1 reply; 17+ messages in thread
From: Kumar, Abhay @ 2018-04-09 19:18 UTC (permalink / raw)
To: Rodrigo Vivi, Jani Nikula; +Cc: intel-gfx
On 4/9/2018 12:10 PM, Rodrigo Vivi wrote:
> On Mon, Apr 09, 2018 at 05:07:31PM +0300, Jani Nikula wrote:
>> On Sun, 08 Apr 2018, Gaurav K Singh <gaurav.k.singh@intel.com> wrote:
>>> On Geminilake, sometimes audio card is not getting
>>> detected after reboot. This is a spurious issue happening on
>>> Geminilake. HW codec and HD audio controller link was going
>>> out of sync for which there was a fix in i915 driver but
>>> was not getting invoked for GLK. Extending this fix to GLK as well.
>>>
>>> Tested by Du,Wenkai on GLK board.
>>>
>>> Signed-off-by: Gaurav K Singh <gaurav.k.singh@intel.com>
>>> ---
>>> drivers/gpu/drm/i915/intel_audio.c | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
>>> index 656f6c931341..73b1e0b96f88 100644
>>> --- a/drivers/gpu/drm/i915/intel_audio.c
>>> +++ b/drivers/gpu/drm/i915/intel_audio.c
>>> @@ -729,7 +729,8 @@ static void i915_audio_component_codec_wake_override(struct device *kdev,
>>> struct drm_i915_private *dev_priv = kdev_to_i915(kdev);
>>> u32 tmp;
>>>
>>> - if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv))
>>> + if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv) &&
>>> + !IS_GEMINILAKE(dev_priv))
>> That could be written as
>>
>> if (!IS_GEN9_BC(dev_priv) && !IS_GEN9_LP(dev_priv))
>>
>> which in turn could just be written as
>>
>> if (!IS_GEN9(dev_priv))
>>
>> ...but since GLK has gen 10 display, so I'm wondering if the same issue
>> will be present in gen 10 too, and whether this should just become
>>
>> if (INTEL_GEN(dev_priv) < 9)
> +1. I opened here to exactly add same comment.
I am checking with DINQ and without this patch for GLK it can enumerate
HDA codec. Ofcourse after cdclk fix.
>
>> BR,
>> Jani.
>>
>>
>>
>>> return;
>>>
>>> i915_audio_component_get_power(kdev);
>> --
>> Jani Nikula, Intel Open Source Technology Center
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/i915/audio: Fix audio detection issue on GLK
2018-04-09 19:18 ` Kumar, Abhay
@ 2018-04-09 23:20 ` Dhinakaran Pandiyan
2018-04-09 23:13 ` Kumar, Abhay
0 siblings, 1 reply; 17+ messages in thread
From: Dhinakaran Pandiyan @ 2018-04-09 23:20 UTC (permalink / raw)
To: Kumar, Abhay; +Cc: intel-gfx, Rodrigo Vivi
On Mon, 2018-04-09 at 12:18 -0700, Kumar, Abhay wrote:
>
> On 4/9/2018 12:10 PM, Rodrigo Vivi wrote:
> > On Mon, Apr 09, 2018 at 05:07:31PM +0300, Jani Nikula wrote:
> >> On Sun, 08 Apr 2018, Gaurav K Singh <gaurav.k.singh@intel.com> wrote:
> >>> On Geminilake, sometimes audio card is not getting
> >>> detected after reboot. This is a spurious issue happening on
> >>> Geminilake. HW codec and HD audio controller link was going
> >>> out of sync for which there was a fix in i915 driver but
> >>> was not getting invoked for GLK. Extending this fix to GLK as well.
> >>>
> >>> Tested by Du,Wenkai on GLK board.
> >>>
> >>> Signed-off-by: Gaurav K Singh <gaurav.k.singh@intel.com>
> >>> ---
> >>> drivers/gpu/drm/i915/intel_audio.c | 3 ++-
> >>> 1 file changed, 2 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
> >>> index 656f6c931341..73b1e0b96f88 100644
> >>> --- a/drivers/gpu/drm/i915/intel_audio.c
> >>> +++ b/drivers/gpu/drm/i915/intel_audio.c
> >>> @@ -729,7 +729,8 @@ static void i915_audio_component_codec_wake_override(struct device *kdev,
> >>> struct drm_i915_private *dev_priv = kdev_to_i915(kdev);
> >>> u32 tmp;
> >>>
> >>> - if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv))
> >>> + if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv) &&
> >>> + !IS_GEMINILAKE(dev_priv))
> >> That could be written as
> >>
> >> if (!IS_GEN9_BC(dev_priv) && !IS_GEN9_LP(dev_priv))
> >>
> >> which in turn could just be written as
> >>
> >> if (!IS_GEN9(dev_priv))
> >>
> >> ...but since GLK has gen 10 display, so I'm wondering if the same issue
> >> will be present in gen 10 too, and whether this should just become
> >>
> >> if (INTEL_GEN(dev_priv) < 9)
> > +1. I opened here to exactly add same comment.
> I am checking with DINQ and without this patch for GLK it can enumerate
> HDA codec. Ofcourse after cdclk fix.
How about the other way around? i.e., does codec enumeration work this
patch but without the cdclk change?
> >
> >> BR,
> >> Jani.
> >>
> >>
> >>
> >>> return;
> >>>
> >>> i915_audio_component_get_power(kdev);
> >> --
> >> Jani Nikula, Intel Open Source Technology Center
> >> _______________________________________________
> >> Intel-gfx mailing list
> >> Intel-gfx@lists.freedesktop.org
> >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/i915/audio: Fix audio detection issue on GLK
2018-04-09 23:20 ` Dhinakaran Pandiyan
@ 2018-04-09 23:13 ` Kumar, Abhay
2018-04-10 11:02 ` Jani Nikula
0 siblings, 1 reply; 17+ messages in thread
From: Kumar, Abhay @ 2018-04-09 23:13 UTC (permalink / raw)
To: Pandiyan, Dhinakaran; +Cc: intel-gfx, Vivi, Rodrigo
On 4/9/2018 4:20 PM, Pandiyan, Dhinakaran wrote:
>
>
> On Mon, 2018-04-09 at 12:18 -0700, Kumar, Abhay wrote:
>> On 4/9/2018 12:10 PM, Rodrigo Vivi wrote:
>>> On Mon, Apr 09, 2018 at 05:07:31PM +0300, Jani Nikula wrote:
>>>> On Sun, 08 Apr 2018, Gaurav K Singh <gaurav.k.singh@intel.com> wrote:
>>>>> On Geminilake, sometimes audio card is not getting
>>>>> detected after reboot. This is a spurious issue happening on
>>>>> Geminilake. HW codec and HD audio controller link was going
>>>>> out of sync for which there was a fix in i915 driver but
>>>>> was not getting invoked for GLK. Extending this fix to GLK as well.
>>>>>
>>>>> Tested by Du,Wenkai on GLK board.
>>>>>
>>>>> Signed-off-by: Gaurav K Singh <gaurav.k.singh@intel.com>
>>>>> ---
>>>>> drivers/gpu/drm/i915/intel_audio.c | 3 ++-
>>>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
>>>>> index 656f6c931341..73b1e0b96f88 100644
>>>>> --- a/drivers/gpu/drm/i915/intel_audio.c
>>>>> +++ b/drivers/gpu/drm/i915/intel_audio.c
>>>>> @@ -729,7 +729,8 @@ static void i915_audio_component_codec_wake_override(struct device *kdev,
>>>>> struct drm_i915_private *dev_priv = kdev_to_i915(kdev);
>>>>> u32 tmp;
>>>>>
>>>>> - if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv))
>>>>> + if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv) &&
>>>>> + !IS_GEMINILAKE(dev_priv))
>>>> That could be written as
>>>>
>>>> if (!IS_GEN9_BC(dev_priv) && !IS_GEN9_LP(dev_priv))
>>>>
>>>> which in turn could just be written as
>>>>
>>>> if (!IS_GEN9(dev_priv))
>>>>
>>>> ...but since GLK has gen 10 display, so I'm wondering if the same issue
>>>> will be present in gen 10 too, and whether this should just become
>>>>
>>>> if (INTEL_GEN(dev_priv) < 9)
>>> +1. I opened here to exactly add same comment.
>> I am checking with DINQ and without this patch for GLK it can enumerate
>> HDA codec. Ofcourse after cdclk fix.
> How about the other way around? i.e., does codec enumeration work this
> patch but without the cdclk change?
Nop. with DINQ we need to have cdclk change to make Codec detection
work. With or without this patch.
>
>
>
>>>> BR,
>>>> Jani.
>>>>
>>>>
>>>>
>>>>> return;
>>>>>
>>>>> i915_audio_component_get_power(kdev);
>>>> --
>>>> Jani Nikula, Intel Open Source Technology Center
>>>> _______________________________________________
>>>> Intel-gfx mailing list
>>>> Intel-gfx@lists.freedesktop.org
>>>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>>> _______________________________________________
>>> Intel-gfx mailing list
>>> Intel-gfx@lists.freedesktop.org
>>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/i915/audio: Fix audio detection issue on GLK
2018-04-09 23:13 ` Kumar, Abhay
@ 2018-04-10 11:02 ` Jani Nikula
2018-04-11 19:27 ` Singh, Gaurav K
0 siblings, 1 reply; 17+ messages in thread
From: Jani Nikula @ 2018-04-10 11:02 UTC (permalink / raw)
To: Kumar, Abhay, Pandiyan, Dhinakaran; +Cc: intel-gfx, Vivi, Rodrigo
On Mon, 09 Apr 2018, "Kumar, Abhay" <abhay.kumar@intel.com> wrote:
> On 4/9/2018 4:20 PM, Pandiyan, Dhinakaran wrote:
>>
>>
>> On Mon, 2018-04-09 at 12:18 -0700, Kumar, Abhay wrote:
>>> On 4/9/2018 12:10 PM, Rodrigo Vivi wrote:
>>>> On Mon, Apr 09, 2018 at 05:07:31PM +0300, Jani Nikula wrote:
>>>>> On Sun, 08 Apr 2018, Gaurav K Singh <gaurav.k.singh@intel.com> wrote:
>>>>>> On Geminilake, sometimes audio card is not getting
>>>>>> detected after reboot. This is a spurious issue happening on
>>>>>> Geminilake. HW codec and HD audio controller link was going
>>>>>> out of sync for which there was a fix in i915 driver but
>>>>>> was not getting invoked for GLK. Extending this fix to GLK as well.
>>>>>>
>>>>>> Tested by Du,Wenkai on GLK board.
>>>>>>
>>>>>> Signed-off-by: Gaurav K Singh <gaurav.k.singh@intel.com>
>>>>>> ---
>>>>>> drivers/gpu/drm/i915/intel_audio.c | 3 ++-
>>>>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>>>>
>>>>>> diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
>>>>>> index 656f6c931341..73b1e0b96f88 100644
>>>>>> --- a/drivers/gpu/drm/i915/intel_audio.c
>>>>>> +++ b/drivers/gpu/drm/i915/intel_audio.c
>>>>>> @@ -729,7 +729,8 @@ static void i915_audio_component_codec_wake_override(struct device *kdev,
>>>>>> struct drm_i915_private *dev_priv = kdev_to_i915(kdev);
>>>>>> u32 tmp;
>>>>>>
>>>>>> - if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv))
>>>>>> + if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv) &&
>>>>>> + !IS_GEMINILAKE(dev_priv))
>>>>> That could be written as
>>>>>
>>>>> if (!IS_GEN9_BC(dev_priv) && !IS_GEN9_LP(dev_priv))
>>>>>
>>>>> which in turn could just be written as
>>>>>
>>>>> if (!IS_GEN9(dev_priv))
>>>>>
>>>>> ...but since GLK has gen 10 display, so I'm wondering if the same issue
>>>>> will be present in gen 10 too, and whether this should just become
>>>>>
>>>>> if (INTEL_GEN(dev_priv) < 9)
>>>> +1. I opened here to exactly add same comment.
>>> I am checking with DINQ and without this patch for GLK it can enumerate
>>> HDA codec. Ofcourse after cdclk fix.
>> How about the other way around? i.e., does codec enumeration work this
>> patch but without the cdclk change?
> Nop. with DINQ we need to have cdclk change to make Codec detection
> work. With or without this patch.
Basically what you're saying is that this patch is not needed? Gaurav,
can you check with the CDCLK patch [1] if that fixes the issue for you?
BR,
Jani.
PS. The CDCLK patch is not enough to fix the issue completely (probe
without display outputs will still choose a low CDCLK) but that's work
in progress.
[1] http://patchwork.freedesktop.org/patch/msgid/1508968932-32208-1-git-send-email-abhay.kumar@intel.com
>
>>
>>
>>
>>>>> BR,
>>>>> Jani.
>>>>>
>>>>>
>>>>>
>>>>>> return;
>>>>>>
>>>>>> i915_audio_component_get_power(kdev);
>>>>> --
>>>>> Jani Nikula, Intel Open Source Technology Center
>>>>> _______________________________________________
>>>>> Intel-gfx mailing list
>>>>> Intel-gfx@lists.freedesktop.org
>>>>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>>>> _______________________________________________
>>>> Intel-gfx mailing list
>>>> Intel-gfx@lists.freedesktop.org
>>>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>>> _______________________________________________
>>> Intel-gfx mailing list
>>> Intel-gfx@lists.freedesktop.org
>>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/i915/audio: Fix audio detection issue on GLK
2018-04-10 11:02 ` Jani Nikula
@ 2018-04-11 19:27 ` Singh, Gaurav K
0 siblings, 0 replies; 17+ messages in thread
From: Singh, Gaurav K @ 2018-04-11 19:27 UTC (permalink / raw)
To: Jani Nikula, Kumar, Abhay, Pandiyan, Dhinakaran; +Cc: intel-gfx, Vivi, Rodrigo
On 4/10/2018 4:32 PM, Jani Nikula wrote:
> On Mon, 09 Apr 2018, "Kumar, Abhay" <abhay.kumar@intel.com> wrote:
>> On 4/9/2018 4:20 PM, Pandiyan, Dhinakaran wrote:
>>>
>>> On Mon, 2018-04-09 at 12:18 -0700, Kumar, Abhay wrote:
>>>> On 4/9/2018 12:10 PM, Rodrigo Vivi wrote:
>>>>> On Mon, Apr 09, 2018 at 05:07:31PM +0300, Jani Nikula wrote:
>>>>>> On Sun, 08 Apr 2018, Gaurav K Singh <gaurav.k.singh@intel.com> wrote:
>>>>>>> On Geminilake, sometimes audio card is not getting
>>>>>>> detected after reboot. This is a spurious issue happening on
>>>>>>> Geminilake. HW codec and HD audio controller link was going
>>>>>>> out of sync for which there was a fix in i915 driver but
>>>>>>> was not getting invoked for GLK. Extending this fix to GLK as well.
>>>>>>>
>>>>>>> Tested by Du,Wenkai on GLK board.
>>>>>>>
>>>>>>> Signed-off-by: Gaurav K Singh <gaurav.k.singh@intel.com>
>>>>>>> ---
>>>>>>> drivers/gpu/drm/i915/intel_audio.c | 3 ++-
>>>>>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>>>>>
>>>>>>> diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
>>>>>>> index 656f6c931341..73b1e0b96f88 100644
>>>>>>> --- a/drivers/gpu/drm/i915/intel_audio.c
>>>>>>> +++ b/drivers/gpu/drm/i915/intel_audio.c
>>>>>>> @@ -729,7 +729,8 @@ static void i915_audio_component_codec_wake_override(struct device *kdev,
>>>>>>> struct drm_i915_private *dev_priv = kdev_to_i915(kdev);
>>>>>>> u32 tmp;
>>>>>>>
>>>>>>> - if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv))
>>>>>>> + if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv) &&
>>>>>>> + !IS_GEMINILAKE(dev_priv))
>>>>>> That could be written as
>>>>>>
>>>>>> if (!IS_GEN9_BC(dev_priv) && !IS_GEN9_LP(dev_priv))
>>>>>>
>>>>>> which in turn could just be written as
>>>>>>
>>>>>> if (!IS_GEN9(dev_priv))
>>>>>>
>>>>>> ...but since GLK has gen 10 display, so I'm wondering if the same issue
>>>>>> will be present in gen 10 too, and whether this should just become
>>>>>>
>>>>>> if (INTEL_GEN(dev_priv) < 9)
>>>>> +1. I opened here to exactly add same comment.
>>>> I am checking with DINQ and without this patch for GLK it can enumerate
>>>> HDA codec. Ofcourse after cdclk fix.
>>> How about the other way around? i.e., does codec enumeration work this
>>> patch but without the cdclk change?
>> Nop. with DINQ we need to have cdclk change to make Codec detection
>> work. With or without this patch.
> Basically what you're saying is that this patch is not needed? Gaurav,
> can you check with the CDCLK patch [1] if that fixes the issue for you?
>
> BR,
> Jani.
Jani,
Our team tried my patch (not including Abhay's patch) which fixed the
issue. But will also try Abhay's patch(this time without my patch), Will
update accordingly.
With regards,
Gaurav
>
>
> PS. The CDCLK patch is not enough to fix the issue completely (probe
> without display outputs will still choose a low CDCLK) but that's work
> in progress.
>
>
> [1] http://patchwork.freedesktop.org/patch/msgid/1508968932-32208-1-git-send-email-abhay.kumar@intel.com
>
>
>>>
>>>
>>>>>> BR,
>>>>>> Jani.
>>>>>>
>>>>>>
>>>>>>
>>>>>>> return;
>>>>>>>
>>>>>>> i915_audio_component_get_power(kdev);
>>>>>> --
>>>>>> Jani Nikula, Intel Open Source Technology Center
>>>>>> _______________________________________________
>>>>>> Intel-gfx mailing list
>>>>>> Intel-gfx@lists.freedesktop.org
>>>>>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>>>>> _______________________________________________
>>>>> Intel-gfx mailing list
>>>>> Intel-gfx@lists.freedesktop.org
>>>>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>>>> _______________________________________________
>>>> Intel-gfx mailing list
>>>> Intel-gfx@lists.freedesktop.org
>>>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH] drm/i915/audio: Fix audio detection issue on GLK
@ 2018-04-17 7:18 Gaurav K Singh
2018-04-17 8:02 ` Jani Nikula
2018-04-17 18:00 ` Kumar, Abhay
0 siblings, 2 replies; 17+ messages in thread
From: Gaurav K Singh @ 2018-04-17 7:18 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula, dhinakaran.pandiyan
On Geminilake, sometimes audio card is not getting
detected after reboot. This is a spurious issue happening on
Geminilake. HW codec and HD audio controller link was going
out of sync for which there was a fix in i915 driver but
was not getting invoked for GLK. Extending this fix to GLK as well.
Tested by Du,Wenkai on GLK board.
Bspec: 21829
v2: Instead of checking GEN9_BC, BXT and GLK macros, use IS_GEN9 macro
Signed-off-by: Gaurav K Singh <gaurav.k.singh@intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/intel_audio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
index 656f6c931341..3ea566f99450 100644
--- a/drivers/gpu/drm/i915/intel_audio.c
+++ b/drivers/gpu/drm/i915/intel_audio.c
@@ -729,7 +729,7 @@ static void i915_audio_component_codec_wake_override(struct device *kdev,
struct drm_i915_private *dev_priv = kdev_to_i915(kdev);
u32 tmp;
- if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv))
+ if (!IS_GEN9(dev_priv))
return;
i915_audio_component_get_power(kdev);
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/i915/audio: Fix audio detection issue on GLK
2018-04-17 7:18 Gaurav K Singh
@ 2018-04-17 8:02 ` Jani Nikula
2018-04-17 18:00 ` Kumar, Abhay
1 sibling, 0 replies; 17+ messages in thread
From: Jani Nikula @ 2018-04-17 8:02 UTC (permalink / raw)
To: Gaurav K Singh, intel-gfx; +Cc: dhinakaran.pandiyan
On Tue, 17 Apr 2018, Gaurav K Singh <gaurav.k.singh@intel.com> wrote:
> On Geminilake, sometimes audio card is not getting
> detected after reboot. This is a spurious issue happening on
> Geminilake. HW codec and HD audio controller link was going
> out of sync for which there was a fix in i915 driver but
> was not getting invoked for GLK. Extending this fix to GLK as well.
>
> Tested by Du,Wenkai on GLK board.
>
> Bspec: 21829
>
> v2: Instead of checking GEN9_BC, BXT and GLK macros, use IS_GEN9 macro
>
> Signed-off-by: Gaurav K Singh <gaurav.k.singh@intel.com>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
That Reviewed-by is jumping to conclusions I'm afraid. Giving review
comments does not mean Reviewed-by. Only explicit Reviewed-by reply
does.
I can only say that this is the right approach *if* glk is to be covered
here, but I have no data to actually say if that's the right thing to
do.
BR,
Jani.
> ---
> drivers/gpu/drm/i915/intel_audio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
> index 656f6c931341..3ea566f99450 100644
> --- a/drivers/gpu/drm/i915/intel_audio.c
> +++ b/drivers/gpu/drm/i915/intel_audio.c
> @@ -729,7 +729,7 @@ static void i915_audio_component_codec_wake_override(struct device *kdev,
> struct drm_i915_private *dev_priv = kdev_to_i915(kdev);
> u32 tmp;
>
> - if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv))
> + if (!IS_GEN9(dev_priv))
> return;
>
> i915_audio_component_get_power(kdev);
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/i915/audio: Fix audio detection issue on GLK
2018-04-17 7:18 Gaurav K Singh
2018-04-17 8:02 ` Jani Nikula
@ 2018-04-17 18:00 ` Kumar, Abhay
1 sibling, 0 replies; 17+ messages in thread
From: Kumar, Abhay @ 2018-04-17 18:00 UTC (permalink / raw)
To: Gaurav K Singh, intel-gfx; +Cc: Nikula, Jani, Pandiyan, Dhinakaran
On 4/17/2018 12:18 AM, Gaurav K Singh wrote:
> On Geminilake, sometimes audio card is not getting
> detected after reboot. This is a spurious issue happening on
> Geminilake. HW codec and HD audio controller link was going
> out of sync for which there was a fix in i915 driver but
> was not getting invoked for GLK. Extending this fix to GLK as well.
>
> Tested by Du,Wenkai on GLK board.
>
> Bspec: 21829
>
> v2: Instead of checking GEN9_BC, BXT and GLK macros, use IS_GEN9 macro
>
> Signed-off-by: Gaurav K Singh <gaurav.k.singh@intel.com>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Abhay Kumar <abhay.Kumar@intel.com>
> ---
> drivers/gpu/drm/i915/intel_audio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
> index 656f6c931341..3ea566f99450 100644
> --- a/drivers/gpu/drm/i915/intel_audio.c
> +++ b/drivers/gpu/drm/i915/intel_audio.c
> @@ -729,7 +729,7 @@ static void i915_audio_component_codec_wake_override(struct device *kdev,
> struct drm_i915_private *dev_priv = kdev_to_i915(kdev);
> u32 tmp;
>
> - if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv))
> + if (!IS_GEN9(dev_priv))
> return;
>
> i915_audio_component_get_power(kdev);
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH] drm/i915/audio: Fix audio detection issue on GLK
@ 2018-04-17 18:22 Gaurav K Singh
2018-04-17 18:28 ` Du,Wenkai
0 siblings, 1 reply; 17+ messages in thread
From: Gaurav K Singh @ 2018-04-17 18:22 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula, dhinakaran.pandiyan
On Geminilake, sometimes audio card is not getting
detected after reboot. This is a spurious issue happening on
Geminilake. HW codec and HD audio controller link was going
out of sync for which there was a fix in i915 driver but
was not getting invoked for GLK. Extending this fix to GLK as well.
Tested by Du,Wenkai on GLK board.
Bspec: 21829
v2: Instead of checking GEN9_BC, BXT and GLK macros, use IS_GEN9 macro (Jani N)
Signed-off-by: Gaurav K Singh <gaurav.k.singh@intel.com>
Reviewed-by: Abhay Kumar <abhay.Kumar@intel.com>
---
drivers/gpu/drm/i915/intel_audio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
index 656f6c931341..3ea566f99450 100644
--- a/drivers/gpu/drm/i915/intel_audio.c
+++ b/drivers/gpu/drm/i915/intel_audio.c
@@ -729,7 +729,7 @@ static void i915_audio_component_codec_wake_override(struct device *kdev,
struct drm_i915_private *dev_priv = kdev_to_i915(kdev);
u32 tmp;
- if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv))
+ if (!IS_GEN9(dev_priv))
return;
i915_audio_component_get_power(kdev);
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/i915/audio: Fix audio detection issue on GLK
2018-04-17 18:22 Gaurav K Singh
@ 2018-04-17 18:28 ` Du,Wenkai
2018-04-18 6:04 ` Singh, Gaurav K
0 siblings, 1 reply; 17+ messages in thread
From: Du,Wenkai @ 2018-04-17 18:28 UTC (permalink / raw)
To: Gaurav K Singh, intel-gfx; +Cc: jani.nikula, dhinakaran.pandiyan
On 4/17/2018 11:22 AM, Gaurav K Singh wrote:
> On Geminilake, sometimes audio card is not getting
> detected after reboot. This is a spurious issue happening on
> Geminilake. HW codec and HD audio controller link was going
> out of sync for which there was a fix in i915 driver but
> was not getting invoked for GLK. Extending this fix to GLK as well.
>
> Tested by Du,Wenkai on GLK board.
>
> Bspec: 21829
>
> v2: Instead of checking GEN9_BC, BXT and GLK macros, use IS_GEN9 macro (Jani N)
>
> Signed-off-by: Gaurav K Singh <gaurav.k.singh@intel.com>
> Reviewed-by: Abhay Kumar <abhay.Kumar@intel.com>
Reviewed-by: Wenkai Du <wenkai.du@intel.com>
Tested-by: Wenkai Du <wenkai.du@intel.com>
Regards,
Wenkai
> ---
> drivers/gpu/drm/i915/intel_audio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
> index 656f6c931341..3ea566f99450 100644
> --- a/drivers/gpu/drm/i915/intel_audio.c
> +++ b/drivers/gpu/drm/i915/intel_audio.c
> @@ -729,7 +729,7 @@ static void i915_audio_component_codec_wake_override(struct device *kdev,
> struct drm_i915_private *dev_priv = kdev_to_i915(kdev);
> u32 tmp;
>
> - if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv))
> + if (!IS_GEN9(dev_priv))
> return;
>
> i915_audio_component_get_power(kdev);
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/i915/audio: Fix audio detection issue on GLK
2018-04-17 18:28 ` Du,Wenkai
@ 2018-04-18 6:04 ` Singh, Gaurav K
2018-04-18 8:07 ` Jani Nikula
0 siblings, 1 reply; 17+ messages in thread
From: Singh, Gaurav K @ 2018-04-18 6:04 UTC (permalink / raw)
To: Du,Wenkai, intel-gfx; +Cc: jani.nikula, dhinakaran.pandiyan
On 4/17/2018 11:58 PM, Du,Wenkai wrote:
>
> On 4/17/2018 11:22 AM, Gaurav K Singh wrote:
>> On Geminilake, sometimes audio card is not getting
>> detected after reboot. This is a spurious issue happening on
>> Geminilake. HW codec and HD audio controller link was going
>> out of sync for which there was a fix in i915 driver but
>> was not getting invoked for GLK. Extending this fix to GLK as well.
>>
>> Tested by Du,Wenkai on GLK board.
>>
>> Bspec: 21829
>>
>> v2: Instead of checking GEN9_BC, BXT and GLK macros, use IS_GEN9
>> macro (Jani N)
>>
>> Signed-off-by: Gaurav K Singh <gaurav.k.singh@intel.com>
>> Reviewed-by: Abhay Kumar <abhay.Kumar@intel.com>
> Reviewed-by: Wenkai Du <wenkai.du@intel.com>
> Tested-by: Wenkai Du <wenkai.du@intel.com>
>
>
> Regards,
> Wenkai
Hi Jani,
Could you please help in merging this patch to unblock audio.
With regards,
Gaurav
>> ---
>> drivers/gpu/drm/i915/intel_audio.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_audio.c
>> b/drivers/gpu/drm/i915/intel_audio.c
>> index 656f6c931341..3ea566f99450 100644
>> --- a/drivers/gpu/drm/i915/intel_audio.c
>> +++ b/drivers/gpu/drm/i915/intel_audio.c
>> @@ -729,7 +729,7 @@ static void
>> i915_audio_component_codec_wake_override(struct device *kdev,
>> struct drm_i915_private *dev_priv = kdev_to_i915(kdev);
>> u32 tmp;
>> - if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv))
>> + if (!IS_GEN9(dev_priv))
>> return;
>> i915_audio_component_get_power(kdev);
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/i915/audio: Fix audio detection issue on GLK
2018-04-18 6:04 ` Singh, Gaurav K
@ 2018-04-18 8:07 ` Jani Nikula
0 siblings, 0 replies; 17+ messages in thread
From: Jani Nikula @ 2018-04-18 8:07 UTC (permalink / raw)
To: Singh, Gaurav K, Du, Wenkai, intel-gfx; +Cc: dhinakaran.pandiyan
On Wed, 18 Apr 2018, "Singh, Gaurav K" <gaurav.k.singh@intel.com> wrote:
> On 4/17/2018 11:58 PM, Du,Wenkai wrote:
>>
>> On 4/17/2018 11:22 AM, Gaurav K Singh wrote:
>>> On Geminilake, sometimes audio card is not getting
>>> detected after reboot. This is a spurious issue happening on
>>> Geminilake. HW codec and HD audio controller link was going
>>> out of sync for which there was a fix in i915 driver but
>>> was not getting invoked for GLK. Extending this fix to GLK as well.
>>>
>>> Tested by Du,Wenkai on GLK board.
>>>
>>> Bspec: 21829
>>>
>>> v2: Instead of checking GEN9_BC, BXT and GLK macros, use IS_GEN9
>>> macro (Jani N)
>>>
>>> Signed-off-by: Gaurav K Singh <gaurav.k.singh@intel.com>
>>> Reviewed-by: Abhay Kumar <abhay.Kumar@intel.com>
>> Reviewed-by: Wenkai Du <wenkai.du@intel.com>
>> Tested-by: Wenkai Du <wenkai.du@intel.com>
>>
>>
>> Regards,
>> Wenkai
> Hi Jani,
>
> Could you please help in merging this patch to unblock audio.
Pushed, thanks for the patch and review.
Added Cc: stable, with a dependency on b651bd2a3ae3 ("drm/i915/audio:
Fix audio enumeration issue on BXT") to be backported as well.
BR,
Jani.
>
> With regards,
> Gaurav
>>> ---
>>> drivers/gpu/drm/i915/intel_audio.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/intel_audio.c
>>> b/drivers/gpu/drm/i915/intel_audio.c
>>> index 656f6c931341..3ea566f99450 100644
>>> --- a/drivers/gpu/drm/i915/intel_audio.c
>>> +++ b/drivers/gpu/drm/i915/intel_audio.c
>>> @@ -729,7 +729,7 @@ static void
>>> i915_audio_component_codec_wake_override(struct device *kdev,
>>> struct drm_i915_private *dev_priv = kdev_to_i915(kdev);
>>> u32 tmp;
>>> - if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv))
>>> + if (!IS_GEN9(dev_priv))
>>> return;
>>> i915_audio_component_get_power(kdev);
>
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2018-04-18 8:07 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-08 13:36 [PATCH] drm/i915/audio: Fix audio detection issue on GLK Gaurav K Singh
2018-04-08 13:45 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2018-04-08 14:00 ` ✗ Fi.CI.BAT: failure " Patchwork
2018-04-09 14:07 ` [PATCH] " Jani Nikula
2018-04-09 19:10 ` Rodrigo Vivi
2018-04-09 19:18 ` Kumar, Abhay
2018-04-09 23:20 ` Dhinakaran Pandiyan
2018-04-09 23:13 ` Kumar, Abhay
2018-04-10 11:02 ` Jani Nikula
2018-04-11 19:27 ` Singh, Gaurav K
2018-04-17 7:18 Gaurav K Singh
2018-04-17 8:02 ` Jani Nikula
2018-04-17 18:00 ` Kumar, Abhay
2018-04-17 18:22 Gaurav K Singh
2018-04-17 18:28 ` Du,Wenkai
2018-04-18 6:04 ` Singh, Gaurav K
2018-04-18 8:07 ` Jani Nikula
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.