* [Buildroot] [PATCH 1/2] package/linux-tools: perf: ditch redundant -f 'rm' flag
@ 2023-03-27 14:11 Luca Ceresoli via buildroot
2023-03-27 14:11 ` [Buildroot] [PATCH 2/2] docs/manual: " Luca Ceresoli via buildroot
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Luca Ceresoli via buildroot @ 2023-03-27 14:11 UTC (permalink / raw)
To: buildroot; +Cc: Luca Ceresoli, Yann E . MORIN, Thomas De Schampheleire
The value of the RM variable in make is 'rm -f', thus the additional -f is
redundant.
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
package/linux-tools/linux-tool-perf.mk.in | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/linux-tools/linux-tool-perf.mk.in b/package/linux-tools/linux-tool-perf.mk.in
index dda63cccecb4..5431c78152c5 100644
--- a/package/linux-tools/linux-tool-perf.mk.in
+++ b/package/linux-tools/linux-tool-perf.mk.in
@@ -166,8 +166,8 @@ endef
# target unless BR2_PACKAGE_LINUX_TOOLS_PERF_SCRIPTS is enabled
ifeq ($(BR2_PACKAGE_LINUX_TOOLS_PERF_SCRIPTS),)
define PERF_INSTALL_REMOVE_SCRIPTS
- $(RM) -rf $(TARGET_DIR)/usr/libexec/perf-core/scripts/
- $(RM) -rf $(TARGET_DIR)/usr/libexec/perf-core/tests/
+ $(RM) -r $(TARGET_DIR)/usr/libexec/perf-core/scripts/
+ $(RM) -r $(TARGET_DIR)/usr/libexec/perf-core/tests/
endef
endif
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 7+ messages in thread* [Buildroot] [PATCH 2/2] docs/manual: ditch redundant -f 'rm' flag
2023-03-27 14:11 [Buildroot] [PATCH 1/2] package/linux-tools: perf: ditch redundant -f 'rm' flag Luca Ceresoli via buildroot
@ 2023-03-27 14:11 ` Luca Ceresoli via buildroot
2023-03-28 19:38 ` Yann E. MORIN
2023-04-10 19:24 ` Peter Korsgaard
2023-03-28 19:37 ` [Buildroot] [PATCH 1/2] package/linux-tools: perf: " Yann E. MORIN
2023-04-10 19:24 ` Peter Korsgaard
2 siblings, 2 replies; 7+ messages in thread
From: Luca Ceresoli via buildroot @ 2023-03-27 14:11 UTC (permalink / raw)
To: buildroot; +Cc: Luca Ceresoli, Yann E . MORIN, Thomas De Schampheleire
The value of the RM variable in make is 'rm -f', thus the additional -f is
redundant. Avoid it on the docs to avoid developers taking it as a good
example to follow.
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
docs/manual/writing-rules.txt | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/docs/manual/writing-rules.txt b/docs/manual/writing-rules.txt
index 758965d80a0a..13b7fd5bea6a 100644
--- a/docs/manual/writing-rules.txt
+++ b/docs/manual/writing-rules.txt
@@ -78,7 +78,7 @@ Do not align the +=+ signs.
+
---------------------
define LIBFOO_REMOVE_DOC
- $(RM) -fr $(TARGET_DIR)/usr/share/libfoo/doc \
+ $(RM) -r $(TARGET_DIR)/usr/share/libfoo/doc \
$(TARGET_DIR)/usr/share/man/man3/libfoo*
endef
---------------------
@@ -118,7 +118,7 @@ YES:
---------------------
ifneq ($(BR2_LIBFOO_INSTALL_DATA),y)
define LIBFOO_REMOVE_DATA
- $(RM) -fr $(TARGET_DIR)/usr/share/libfoo/data
+ $(RM) -r $(TARGET_DIR)/usr/share/libfoo/data
endef
LIBFOO_POST_INSTALL_TARGET_HOOKS += LIBFOO_REMOVE_DATA
endif
@@ -128,7 +128,7 @@ NO:
+
---------------------
define LIBFOO_REMOVE_DATA
- $(RM) -fr $(TARGET_DIR)/usr/share/libfoo/data
+ $(RM) -r $(TARGET_DIR)/usr/share/libfoo/data
endef
ifneq ($(BR2_LIBFOO_INSTALL_DATA),y)
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH 2/2] docs/manual: ditch redundant -f 'rm' flag
2023-03-27 14:11 ` [Buildroot] [PATCH 2/2] docs/manual: " Luca Ceresoli via buildroot
@ 2023-03-28 19:38 ` Yann E. MORIN
2023-03-29 6:43 ` Luca Ceresoli via buildroot
2023-04-10 19:24 ` Peter Korsgaard
1 sibling, 1 reply; 7+ messages in thread
From: Yann E. MORIN @ 2023-03-28 19:38 UTC (permalink / raw)
To: Luca Ceresoli; +Cc: Thomas De Schampheleire, buildroot
Luca, All,
On 2023-03-27 16:11 +0200, Luca Ceresoli spake thusly:
> The value of the RM variable in make is 'rm -f', thus the additional -f is
> redundant. Avoid it on the docs to avoid developers taking it as a good
> example to follow.
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Applied to master, thanks.
Will you send a tree-wide cleanup, now? ;-)
$ git grep -E '\$\(RM\) -r?f' |wc -l
47
Regards,
Yann E. MORIN.
> ---
> docs/manual/writing-rules.txt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/docs/manual/writing-rules.txt b/docs/manual/writing-rules.txt
> index 758965d80a0a..13b7fd5bea6a 100644
> --- a/docs/manual/writing-rules.txt
> +++ b/docs/manual/writing-rules.txt
> @@ -78,7 +78,7 @@ Do not align the +=+ signs.
> +
> ---------------------
> define LIBFOO_REMOVE_DOC
> - $(RM) -fr $(TARGET_DIR)/usr/share/libfoo/doc \
> + $(RM) -r $(TARGET_DIR)/usr/share/libfoo/doc \
> $(TARGET_DIR)/usr/share/man/man3/libfoo*
> endef
> ---------------------
> @@ -118,7 +118,7 @@ YES:
> ---------------------
> ifneq ($(BR2_LIBFOO_INSTALL_DATA),y)
> define LIBFOO_REMOVE_DATA
> - $(RM) -fr $(TARGET_DIR)/usr/share/libfoo/data
> + $(RM) -r $(TARGET_DIR)/usr/share/libfoo/data
> endef
> LIBFOO_POST_INSTALL_TARGET_HOOKS += LIBFOO_REMOVE_DATA
> endif
> @@ -128,7 +128,7 @@ NO:
> +
> ---------------------
> define LIBFOO_REMOVE_DATA
> - $(RM) -fr $(TARGET_DIR)/usr/share/libfoo/data
> + $(RM) -r $(TARGET_DIR)/usr/share/libfoo/data
> endef
>
> ifneq ($(BR2_LIBFOO_INSTALL_DATA),y)
> --
> 2.34.1
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [Buildroot] [PATCH 2/2] docs/manual: ditch redundant -f 'rm' flag
2023-03-28 19:38 ` Yann E. MORIN
@ 2023-03-29 6:43 ` Luca Ceresoli via buildroot
0 siblings, 0 replies; 7+ messages in thread
From: Luca Ceresoli via buildroot @ 2023-03-29 6:43 UTC (permalink / raw)
To: Yann E. MORIN; +Cc: Thomas De Schampheleire, buildroot
Hi Yann,
On Tue, 28 Mar 2023 21:38:49 +0200
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> Luca, All,
>
> On 2023-03-27 16:11 +0200, Luca Ceresoli spake thusly:
> > The value of the RM variable in make is 'rm -f', thus the additional -f is
> > redundant. Avoid it on the docs to avoid developers taking it as a good
> > example to follow.
> >
> > Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
>
> Applied to master, thanks.
>
> Will you send a tree-wide cleanup, now? ;-)
>
> $ git grep -E '\$\(RM\) -r?f' |wc -l
> 47
I think I will leave it as an exercise for the motivated party. ;)
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH 2/2] docs/manual: ditch redundant -f 'rm' flag
2023-03-27 14:11 ` [Buildroot] [PATCH 2/2] docs/manual: " Luca Ceresoli via buildroot
2023-03-28 19:38 ` Yann E. MORIN
@ 2023-04-10 19:24 ` Peter Korsgaard
1 sibling, 0 replies; 7+ messages in thread
From: Peter Korsgaard @ 2023-04-10 19:24 UTC (permalink / raw)
To: Luca Ceresoli via buildroot
Cc: Luca Ceresoli, Yann E . MORIN, Thomas De Schampheleire
>>>>> "Luca" == Luca Ceresoli via buildroot <buildroot@buildroot.org> writes:
> The value of the RM variable in make is 'rm -f', thus the additional -f is
> redundant. Avoid it on the docs to avoid developers taking it as a good
> example to follow.
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Committed to 2023.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH 1/2] package/linux-tools: perf: ditch redundant -f 'rm' flag
2023-03-27 14:11 [Buildroot] [PATCH 1/2] package/linux-tools: perf: ditch redundant -f 'rm' flag Luca Ceresoli via buildroot
2023-03-27 14:11 ` [Buildroot] [PATCH 2/2] docs/manual: " Luca Ceresoli via buildroot
@ 2023-03-28 19:37 ` Yann E. MORIN
2023-04-10 19:24 ` Peter Korsgaard
2 siblings, 0 replies; 7+ messages in thread
From: Yann E. MORIN @ 2023-03-28 19:37 UTC (permalink / raw)
To: Luca Ceresoli; +Cc: Thomas De Schampheleire, buildroot
Luca, All,
On 2023-03-27 16:11 +0200, Luca Ceresoli spake thusly:
> The value of the RM variable in make is 'rm -f', thus the additional -f is
> redundant.
I've added a pointer to the documentation:
https://www.gnu.org/software/make/manual/make.html#index-RM
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Both applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/linux-tools/linux-tool-perf.mk.in | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/package/linux-tools/linux-tool-perf.mk.in b/package/linux-tools/linux-tool-perf.mk.in
> index dda63cccecb4..5431c78152c5 100644
> --- a/package/linux-tools/linux-tool-perf.mk.in
> +++ b/package/linux-tools/linux-tool-perf.mk.in
> @@ -166,8 +166,8 @@ endef
> # target unless BR2_PACKAGE_LINUX_TOOLS_PERF_SCRIPTS is enabled
> ifeq ($(BR2_PACKAGE_LINUX_TOOLS_PERF_SCRIPTS),)
> define PERF_INSTALL_REMOVE_SCRIPTS
> - $(RM) -rf $(TARGET_DIR)/usr/libexec/perf-core/scripts/
> - $(RM) -rf $(TARGET_DIR)/usr/libexec/perf-core/tests/
> + $(RM) -r $(TARGET_DIR)/usr/libexec/perf-core/scripts/
> + $(RM) -r $(TARGET_DIR)/usr/libexec/perf-core/tests/
> endef
> endif
>
> --
> 2.34.1
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [Buildroot] [PATCH 1/2] package/linux-tools: perf: ditch redundant -f 'rm' flag
2023-03-27 14:11 [Buildroot] [PATCH 1/2] package/linux-tools: perf: ditch redundant -f 'rm' flag Luca Ceresoli via buildroot
2023-03-27 14:11 ` [Buildroot] [PATCH 2/2] docs/manual: " Luca Ceresoli via buildroot
2023-03-28 19:37 ` [Buildroot] [PATCH 1/2] package/linux-tools: perf: " Yann E. MORIN
@ 2023-04-10 19:24 ` Peter Korsgaard
2 siblings, 0 replies; 7+ messages in thread
From: Peter Korsgaard @ 2023-04-10 19:24 UTC (permalink / raw)
To: Luca Ceresoli via buildroot
Cc: Luca Ceresoli, Yann E . MORIN, Thomas De Schampheleire
>>>>> "Luca" == Luca Ceresoli via buildroot <buildroot@buildroot.org> writes:
> The value of the RM variable in make is 'rm -f', thus the additional -f is
> redundant.
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Committed to 2023.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-04-10 19:25 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-27 14:11 [Buildroot] [PATCH 1/2] package/linux-tools: perf: ditch redundant -f 'rm' flag Luca Ceresoli via buildroot
2023-03-27 14:11 ` [Buildroot] [PATCH 2/2] docs/manual: " Luca Ceresoli via buildroot
2023-03-28 19:38 ` Yann E. MORIN
2023-03-29 6:43 ` Luca Ceresoli via buildroot
2023-04-10 19:24 ` Peter Korsgaard
2023-03-28 19:37 ` [Buildroot] [PATCH 1/2] package/linux-tools: perf: " Yann E. MORIN
2023-04-10 19:24 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.