[Qemu-devel] [PATCH 2/2] niagara: check if a serial port is available

[Qemu-devel] [PATCH 2/2] niagara: check if a serial port is available

[Artyom Tarasenko]

Reported-by:Markus Armbruster <armbru@redhat.com>
Signed-off-by: Artyom Tarasenko <atar4qemu@gmail.com>
---
 hw/sparc64/niagara.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/hw/sparc64/niagara.c b/hw/sparc64/niagara.c
index e945b5a..a14724f 100644
--- a/hw/sparc64/niagara.c
+++ b/hw/sparc64/niagara.c
@@ -154,9 +154,10 @@ static void niagara_init(MachineState *machine)
             exit(1);
         }
     }
-    serial_mm_init(sysmem, NIAGARA_UART_BASE, 0, NULL, 115200,
-                   serial_hds[0], DEVICE_BIG_ENDIAN);
-
+    if (serial_hds[0]) {
+        serial_mm_init(sysmem, NIAGARA_UART_BASE, 0, NULL, 115200,
+                       serial_hds[0], DEVICE_BIG_ENDIAN);
+    }
     empty_slot_init(NIAGARA_IOBBASE, NIAGARA_IOBSIZE);
     sun4v_rtc_init(NIAGARA_RTC_BASE);
 }
-- 
2.7.2

Re: [Qemu-devel] [PATCH 2/2] niagara: check if a serial port is available

[Markus Armbruster]

Your series lacks threading: the patches don't carry In-Reply-To and
References headers.  The easiest way to fix that is sending them with
git-send-email --thread.  You should be able to omit --thread; it's the
default unless configured otherwise.

Artyom Tarasenko <atar4qemu@gmail.com> writes:

> Reported-by:Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Artyom Tarasenko <atar4qemu@gmail.com>
> ---
>  hw/sparc64/niagara.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/hw/sparc64/niagara.c b/hw/sparc64/niagara.c
> index e945b5a..a14724f 100644
> --- a/hw/sparc64/niagara.c
> +++ b/hw/sparc64/niagara.c
> @@ -154,9 +154,10 @@ static void niagara_init(MachineState *machine)
>              exit(1);
>          }
>      }
> -    serial_mm_init(sysmem, NIAGARA_UART_BASE, 0, NULL, 115200,
> -                   serial_hds[0], DEVICE_BIG_ENDIAN);
> -
> +    if (serial_hds[0]) {
> +        serial_mm_init(sysmem, NIAGARA_UART_BASE, 0, NULL, 115200,
> +                       serial_hds[0], DEVICE_BIG_ENDIAN);
> +    }
>      empty_slot_init(NIAGARA_IOBBASE, NIAGARA_IOBSIZE);
>      sun4v_rtc_init(NIAGARA_RTC_BASE);
>  }

Reviewed-by: Markus Armbruster <armbru@redhat.com>