All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] tests: set QEMU_AUDIO_DRV=none for pci sound cards
@ 2014-07-22  7:28 Gerd Hoffmann
  2014-07-22 11:36 ` Markus Armbruster
  2014-08-05 14:23 ` Michael S. Tsirkin
  0 siblings, 2 replies; 7+ messages in thread
From: Gerd Hoffmann @ 2014-07-22  7:28 UTC (permalink / raw)
  To: qemu-devel; +Cc: Vassili Karpov (malc), Gerd Hoffmann

This way the tests run without sound hardware being present
on the build machine.  Even with sound hardware it IMO isn't
very useful to use it in regression testing.  Once the sound
card tests are advanced enougth that they try to actually
play sound we probably want the guests sound output written
to a file (via QEMU_AUDIO_DRV=wav) rather than played on the
build machines sound hardware.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 tests/ac97-test.c      | 3 +++
 tests/es1370-test.c    | 3 +++
 tests/intel-hda-test.c | 3 +++
 3 files changed, 9 insertions(+)

diff --git a/tests/ac97-test.c b/tests/ac97-test.c
index af30ea1..ba3be1a 100644
--- a/tests/ac97-test.c
+++ b/tests/ac97-test.c
@@ -8,6 +8,7 @@
  */
 
 #include <glib.h>
+#include <stdlib.h>
 #include <string.h>
 #include "libqtest.h"
 #include "qemu/osdep.h"
@@ -21,6 +22,8 @@ int main(int argc, char **argv)
 {
     int ret;
 
+    setenv("QEMU_AUDIO_DRV", "none", true);
+
     g_test_init(&argc, &argv, NULL);
     qtest_add_func("/ac97/nop", nop);
 
diff --git a/tests/es1370-test.c b/tests/es1370-test.c
index cc23fb5..d539ba3 100644
--- a/tests/es1370-test.c
+++ b/tests/es1370-test.c
@@ -8,6 +8,7 @@
  */
 
 #include <glib.h>
+#include <stdlib.h>
 #include <string.h>
 #include "libqtest.h"
 #include "qemu/osdep.h"
@@ -21,6 +22,8 @@ int main(int argc, char **argv)
 {
     int ret;
 
+    setenv("QEMU_AUDIO_DRV", "none", true);
+
     g_test_init(&argc, &argv, NULL);
     qtest_add_func("/es1370/nop", nop);
 
diff --git a/tests/intel-hda-test.c b/tests/intel-hda-test.c
index d89b407..32dc58f 100644
--- a/tests/intel-hda-test.c
+++ b/tests/intel-hda-test.c
@@ -8,6 +8,7 @@
  */
 
 #include <glib.h>
+#include <stdlib.h>
 #include <string.h>
 #include "libqtest.h"
 #include "qemu/osdep.h"
@@ -35,6 +36,8 @@ int main(int argc, char **argv)
 {
     int ret;
 
+    setenv("QEMU_AUDIO_DRV", "none", true);
+
     g_test_init(&argc, &argv, NULL);
     qtest_add_func("/intel-hda/ich6", ich6_test);
     qtest_add_func("/intel-hda/ich9", ich9_test);
-- 
1.8.3.1

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [Qemu-devel] [PATCH] tests: set QEMU_AUDIO_DRV=none for pci sound cards
  2014-07-22  7:28 [Qemu-devel] [PATCH] tests: set QEMU_AUDIO_DRV=none for pci sound cards Gerd Hoffmann
@ 2014-07-22 11:36 ` Markus Armbruster
  2014-08-05 14:05   ` Markus Armbruster
  2014-08-05 14:23 ` Michael S. Tsirkin
  1 sibling, 1 reply; 7+ messages in thread
From: Markus Armbruster @ 2014-07-22 11:36 UTC (permalink / raw)
  To: Gerd Hoffmann; +Cc: Vassili Karpov (malc), qemu-devel

Gerd Hoffmann <kraxel@redhat.com> writes:

> This way the tests run without sound hardware being present
> on the build machine.  Even with sound hardware it IMO isn't
> very useful to use it in regression testing.  Once the sound
> card tests are advanced enougth that they try to actually
> play sound we probably want the guests sound output written
> to a file (via QEMU_AUDIO_DRV=wav) rather than played on the
> build machines sound hardware.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

Bonus: I no longer get "audio: Could not init `oss' audio driver" noise.

Reviewed-by: Markus Armbruster <armbru@redhat.com>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Qemu-devel] [PATCH] tests: set QEMU_AUDIO_DRV=none for pci sound cards
  2014-07-22 11:36 ` Markus Armbruster
@ 2014-08-05 14:05   ` Markus Armbruster
  2014-08-26  6:39     ` Gerd Hoffmann
  0 siblings, 1 reply; 7+ messages in thread
From: Markus Armbruster @ 2014-08-05 14:05 UTC (permalink / raw)
  To: Gerd Hoffmann; +Cc: Vassili Karpov (malc), qemu-devel

Ping?

Markus Armbruster <armbru@redhat.com> writes:

> Gerd Hoffmann <kraxel@redhat.com> writes:
>
>> This way the tests run without sound hardware being present
>> on the build machine.  Even with sound hardware it IMO isn't
>> very useful to use it in regression testing.  Once the sound
>> card tests are advanced enougth that they try to actually
>> play sound we probably want the guests sound output written
>> to a file (via QEMU_AUDIO_DRV=wav) rather than played on the
>> build machines sound hardware.
>>
>> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>
> Bonus: I no longer get "audio: Could not init `oss' audio driver" noise.
>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Qemu-devel] [PATCH] tests: set QEMU_AUDIO_DRV=none for pci sound cards
  2014-07-22  7:28 [Qemu-devel] [PATCH] tests: set QEMU_AUDIO_DRV=none for pci sound cards Gerd Hoffmann
  2014-07-22 11:36 ` Markus Armbruster
@ 2014-08-05 14:23 ` Michael S. Tsirkin
  1 sibling, 0 replies; 7+ messages in thread
From: Michael S. Tsirkin @ 2014-08-05 14:23 UTC (permalink / raw)
  To: Gerd Hoffmann; +Cc: Vassili Karpov (malc), qemu-devel

On Tue, Jul 22, 2014 at 09:28:55AM +0200, Gerd Hoffmann wrote:
> This way the tests run without sound hardware being present
> on the build machine.  Even with sound hardware it IMO isn't
> very useful to use it in regression testing.  Once the sound
> card tests are advanced enougth that they try to actually
> play sound we probably want the guests sound output written
> to a file (via QEMU_AUDIO_DRV=wav) rather than played on the
> build machines sound hardware.
> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

Useful already:
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>

Long term, won't it be cleaner to supply driver using
a command line flag? Can be a patch on top ...

> ---
>  tests/ac97-test.c      | 3 +++
>  tests/es1370-test.c    | 3 +++
>  tests/intel-hda-test.c | 3 +++
>  3 files changed, 9 insertions(+)
> 
> diff --git a/tests/ac97-test.c b/tests/ac97-test.c
> index af30ea1..ba3be1a 100644
> --- a/tests/ac97-test.c
> +++ b/tests/ac97-test.c
> @@ -8,6 +8,7 @@
>   */
>  
>  #include <glib.h>
> +#include <stdlib.h>
>  #include <string.h>
>  #include "libqtest.h"
>  #include "qemu/osdep.h"
> @@ -21,6 +22,8 @@ int main(int argc, char **argv)
>  {
>      int ret;
>  
> +    setenv("QEMU_AUDIO_DRV", "none", true);
> +
>      g_test_init(&argc, &argv, NULL);
>      qtest_add_func("/ac97/nop", nop);
>  
> diff --git a/tests/es1370-test.c b/tests/es1370-test.c
> index cc23fb5..d539ba3 100644
> --- a/tests/es1370-test.c
> +++ b/tests/es1370-test.c
> @@ -8,6 +8,7 @@
>   */
>  
>  #include <glib.h>
> +#include <stdlib.h>
>  #include <string.h>
>  #include "libqtest.h"
>  #include "qemu/osdep.h"
> @@ -21,6 +22,8 @@ int main(int argc, char **argv)
>  {
>      int ret;
>  
> +    setenv("QEMU_AUDIO_DRV", "none", true);
> +
>      g_test_init(&argc, &argv, NULL);
>      qtest_add_func("/es1370/nop", nop);
>  
> diff --git a/tests/intel-hda-test.c b/tests/intel-hda-test.c
> index d89b407..32dc58f 100644
> --- a/tests/intel-hda-test.c
> +++ b/tests/intel-hda-test.c
> @@ -8,6 +8,7 @@
>   */
>  
>  #include <glib.h>
> +#include <stdlib.h>
>  #include <string.h>
>  #include "libqtest.h"
>  #include "qemu/osdep.h"
> @@ -35,6 +36,8 @@ int main(int argc, char **argv)
>  {
>      int ret;
>  
> +    setenv("QEMU_AUDIO_DRV", "none", true);
> +
>      g_test_init(&argc, &argv, NULL);
>      qtest_add_func("/intel-hda/ich6", ich6_test);
>      qtest_add_func("/intel-hda/ich9", ich9_test);
> -- 
> 1.8.3.1
> 

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Qemu-devel] [PATCH] tests: set QEMU_AUDIO_DRV=none for pci sound cards
  2014-08-05 14:05   ` Markus Armbruster
@ 2014-08-26  6:39     ` Gerd Hoffmann
  2014-08-26 11:28       ` Markus Armbruster
  2014-08-27 11:05       ` Stefan Hajnoczi
  0 siblings, 2 replies; 7+ messages in thread
From: Gerd Hoffmann @ 2014-08-26  6:39 UTC (permalink / raw)
  To: Markus Armbruster; +Cc: Stefan Hajnoczi, Vassili Karpov (malc), qemu-devel

On Di, 2014-08-05 at 16:05 +0200, Markus Armbruster wrote:
> Ping?

Back online.  What is the state here?  I've seen Stefan (Cc'ed) posted a
different patch for the same issue?  Anything merged meanwhile?

cheers,
  Gerd

> 
> Markus Armbruster <armbru@redhat.com> writes:
> 
> > Gerd Hoffmann <kraxel@redhat.com> writes:
> >
> >> This way the tests run without sound hardware being present
> >> on the build machine.  Even with sound hardware it IMO isn't
> >> very useful to use it in regression testing.  Once the sound
> >> card tests are advanced enougth that they try to actually
> >> play sound we probably want the guests sound output written
> >> to a file (via QEMU_AUDIO_DRV=wav) rather than played on the
> >> build machines sound hardware.
> >>
> >> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> >
> > Bonus: I no longer get "audio: Could not init `oss' audio driver" noise.
> >
> > Reviewed-by: Markus Armbruster <armbru@redhat.com>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Qemu-devel] [PATCH] tests: set QEMU_AUDIO_DRV=none for pci sound cards
  2014-08-26  6:39     ` Gerd Hoffmann
@ 2014-08-26 11:28       ` Markus Armbruster
  2014-08-27 11:05       ` Stefan Hajnoczi
  1 sibling, 0 replies; 7+ messages in thread
From: Markus Armbruster @ 2014-08-26 11:28 UTC (permalink / raw)
  To: Gerd Hoffmann; +Cc: Vassili Karpov (malc), Stefan Hajnoczi, qemu-devel

Gerd Hoffmann <kraxel@redhat.com> writes:

> On Di, 2014-08-05 at 16:05 +0200, Markus Armbruster wrote:
>> Ping?
>
> Back online.  What is the state here?  I've seen Stefan (Cc'ed) posted a
> different patch for the same issue?  Anything merged meanwhile?

Neither patch has been merged.  Either would do for me :)

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Qemu-devel] [PATCH] tests: set QEMU_AUDIO_DRV=none for pci sound cards
  2014-08-26  6:39     ` Gerd Hoffmann
  2014-08-26 11:28       ` Markus Armbruster
@ 2014-08-27 11:05       ` Stefan Hajnoczi
  1 sibling, 0 replies; 7+ messages in thread
From: Stefan Hajnoczi @ 2014-08-27 11:05 UTC (permalink / raw)
  To: Gerd Hoffmann
  Cc: Vassili Karpov (malc), Stefan Hajnoczi, Markus Armbruster, qemu-devel

[-- Attachment #1: Type: text/plain, Size: 421 bytes --]

On Tue, Aug 26, 2014 at 08:39:14AM +0200, Gerd Hoffmann wrote:
> On Di, 2014-08-05 at 16:05 +0200, Markus Armbruster wrote:
> > Ping?
> 
> Back online.  What is the state here?  I've seen Stefan (Cc'ed) posted a
> different patch for the same issue?  Anything merged meanwhile?

I am sending a v2 of my series that will use setenv(3) like you did
except for all tests (Markus preferred that approach).

Stefan

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2014-08-27 11:05 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-22  7:28 [Qemu-devel] [PATCH] tests: set QEMU_AUDIO_DRV=none for pci sound cards Gerd Hoffmann
2014-07-22 11:36 ` Markus Armbruster
2014-08-05 14:05   ` Markus Armbruster
2014-08-26  6:39     ` Gerd Hoffmann
2014-08-26 11:28       ` Markus Armbruster
2014-08-27 11:05       ` Stefan Hajnoczi
2014-08-05 14:23 ` Michael S. Tsirkin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.