* [Buildroot] [PATCH 1/1] package/avrdude: spi needs headers >= 4.8
@ 2022-04-11 22:12 Fabrice Fontaine
2022-04-12 6:06 ` Yegor Yefremov via buildroot
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Fabrice Fontaine @ 2022-04-11 22:12 UTC (permalink / raw)
To: buildroot; +Cc: Wojciech M . Zabolotny, Fabrice Fontaine
SPI unconditionally uses GPIOHANDLE_SET_LINE_VALUES_IOCTL which is only
available since kernel 4.8 and
https://github.com/torvalds/linux/commit/d7c51b47ac11e66f547b55640405c1c474642d72
resulting in the following build failure since switch to upstream in
commit 03fa36df7e6aca0f4a1c8ae2fe691c0cda6ddc7a:
linuxspi.c: In function 'linuxspi_reset_mcu':
linuxspi.c:102:28: error: storage size of 'data' isn't known
struct gpiohandle_data data;
^~~~
linuxspi.c:110:32: error: 'GPIOHANDLE_SET_LINE_VALUES_IOCTL' undeclared (first use in this function)
ret = ioctl(fd_linehandle, GPIOHANDLE_SET_LINE_VALUES_IOCTL, &data);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Fixes:
- http://autobuild.buildroot.org/results/769021040e5e9293584734e4f461baeaa6dd91cd
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/avrdude/Config.in | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/package/avrdude/Config.in b/package/avrdude/Config.in
index 89558a5ff5..cbbd076667 100644
--- a/package/avrdude/Config.in
+++ b/package/avrdude/Config.in
@@ -20,10 +20,10 @@ if BR2_PACKAGE_AVRDUDE
config BR2_PACKAGE_AVRDUDE_SPI
bool "SPI support"
default y # Backward compatibility
- depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_6
+ depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_8
-comment "SPI support needs a toolchain w/ linux headers >= 4.6"
- depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_6
+comment "SPI support needs a toolchain w/ linux headers >= 4.8"
+ depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_8
endif
--
2.35.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/avrdude: spi needs headers >= 4.8
2022-04-11 22:12 [Buildroot] [PATCH 1/1] package/avrdude: spi needs headers >= 4.8 Fabrice Fontaine
@ 2022-04-12 6:06 ` Yegor Yefremov via buildroot
2022-04-14 20:25 ` Arnout Vandecappelle
2022-05-22 10:07 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Yegor Yefremov via buildroot @ 2022-04-12 6:06 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Wojciech M . Zabolotny, buildroot
On Tue, Apr 12, 2022 at 12:14 AM Fabrice Fontaine
<fontaine.fabrice@gmail.com> wrote:
>
> SPI unconditionally uses GPIOHANDLE_SET_LINE_VALUES_IOCTL which is only
> available since kernel 4.8 and
> https://github.com/torvalds/linux/commit/d7c51b47ac11e66f547b55640405c1c474642d72
> resulting in the following build failure since switch to upstream in
> commit 03fa36df7e6aca0f4a1c8ae2fe691c0cda6ddc7a:
>
> linuxspi.c: In function 'linuxspi_reset_mcu':
> linuxspi.c:102:28: error: storage size of 'data' isn't known
> struct gpiohandle_data data;
> ^~~~
> linuxspi.c:110:32: error: 'GPIOHANDLE_SET_LINE_VALUES_IOCTL' undeclared (first use in this function)
> ret = ioctl(fd_linehandle, GPIOHANDLE_SET_LINE_VALUES_IOCTL, &data);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Fixes:
> - http://autobuild.buildroot.org/results/769021040e5e9293584734e4f461baeaa6dd91cd
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>
> package/avrdude/Config.in | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/package/avrdude/Config.in b/package/avrdude/Config.in
> index 89558a5ff5..cbbd076667 100644
> --- a/package/avrdude/Config.in
> +++ b/package/avrdude/Config.in
> @@ -20,10 +20,10 @@ if BR2_PACKAGE_AVRDUDE
> config BR2_PACKAGE_AVRDUDE_SPI
> bool "SPI support"
> default y # Backward compatibility
> - depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_6
> + depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_8
>
> -comment "SPI support needs a toolchain w/ linux headers >= 4.6"
> - depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_6
> +comment "SPI support needs a toolchain w/ linux headers >= 4.8"
> + depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_8
>
> endif
>
> --
> 2.35.1
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/avrdude: spi needs headers >= 4.8
2022-04-11 22:12 [Buildroot] [PATCH 1/1] package/avrdude: spi needs headers >= 4.8 Fabrice Fontaine
2022-04-12 6:06 ` Yegor Yefremov via buildroot
@ 2022-04-14 20:25 ` Arnout Vandecappelle
2022-05-22 10:07 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Arnout Vandecappelle @ 2022-04-14 20:25 UTC (permalink / raw)
To: Fabrice Fontaine, buildroot; +Cc: Wojciech M . Zabolotny
On 12/04/2022 00:12, Fabrice Fontaine wrote:
> SPI unconditionally uses GPIOHANDLE_SET_LINE_VALUES_IOCTL which is only
> available since kernel 4.8 and
> https://github.com/torvalds/linux/commit/d7c51b47ac11e66f547b55640405c1c474642d72
> resulting in the following build failure since switch to upstream in
> commit 03fa36df7e6aca0f4a1c8ae2fe691c0cda6ddc7a:
>
> linuxspi.c: In function 'linuxspi_reset_mcu':
> linuxspi.c:102:28: error: storage size of 'data' isn't known
> struct gpiohandle_data data;
> ^~~~
> linuxspi.c:110:32: error: 'GPIOHANDLE_SET_LINE_VALUES_IOCTL' undeclared (first use in this function)
> ret = ioctl(fd_linehandle, GPIOHANDLE_SET_LINE_VALUES_IOCTL, &data);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Fixes:
> - http://autobuild.buildroot.org/results/769021040e5e9293584734e4f461baeaa6dd91cd
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Applied to master, thanks.
Regards,
Arnout
> ---
> package/avrdude/Config.in | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/package/avrdude/Config.in b/package/avrdude/Config.in
> index 89558a5ff5..cbbd076667 100644
> --- a/package/avrdude/Config.in
> +++ b/package/avrdude/Config.in
> @@ -20,10 +20,10 @@ if BR2_PACKAGE_AVRDUDE
> config BR2_PACKAGE_AVRDUDE_SPI
> bool "SPI support"
> default y # Backward compatibility
> - depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_6
> + depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_8
>
> -comment "SPI support needs a toolchain w/ linux headers >= 4.6"
> - depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_6
> +comment "SPI support needs a toolchain w/ linux headers >= 4.8"
> + depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_8
>
> endif
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/avrdude: spi needs headers >= 4.8
2022-04-11 22:12 [Buildroot] [PATCH 1/1] package/avrdude: spi needs headers >= 4.8 Fabrice Fontaine
2022-04-12 6:06 ` Yegor Yefremov via buildroot
2022-04-14 20:25 ` Arnout Vandecappelle
@ 2022-05-22 10:07 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2022-05-22 10:07 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Wojciech M . Zabolotny, buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> SPI unconditionally uses GPIOHANDLE_SET_LINE_VALUES_IOCTL which is only
> available since kernel 4.8 and
> https://github.com/torvalds/linux/commit/d7c51b47ac11e66f547b55640405c1c474642d72
> resulting in the following build failure since switch to upstream in
> commit 03fa36df7e6aca0f4a1c8ae2fe691c0cda6ddc7a:
> linuxspi.c: In function 'linuxspi_reset_mcu':
> linuxspi.c:102:28: error: storage size of 'data' isn't known
> struct gpiohandle_data data;
> ^~~~
> linuxspi.c:110:32: error: 'GPIOHANDLE_SET_LINE_VALUES_IOCTL' undeclared (first use in this function)
> ret = ioctl(fd_linehandle, GPIOHANDLE_SET_LINE_VALUES_IOCTL, &data);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> Fixes:
> - http://autobuild.buildroot.org/results/769021040e5e9293584734e4f461baeaa6dd91cd
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2022.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-05-22 10:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-11 22:12 [Buildroot] [PATCH 1/1] package/avrdude: spi needs headers >= 4.8 Fabrice Fontaine
2022-04-12 6:06 ` Yegor Yefremov via buildroot
2022-04-14 20:25 ` Arnout Vandecappelle
2022-05-22 10:07 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.