From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: qemu-devel@nongnu.org, "Huacai Chen" <chenhuacai@kernel.org>,
"Greg Kurz" <groug@kaod.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
qemu-trivial@nongnu.org, "Amit Shah" <amit@kernel.org>,
"Dmitry Fleytman" <dmitry.fleytman@gmail.com>,
qemu-arm@nongnu.org, "John Snow" <jsnow@redhat.com>,
qemu-s390x@nongnu.org, "Paul Durrant" <paul@xen.org>,
"Anthony Perard" <anthony.perard@citrix.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Kevin Wolf" <kwolf@redhat.com>,
"Marcelo Tosatti" <mtosatti@redhat.com>,
"Max Reitz" <mreitz@redhat.com>,
"Alex Williamson" <alex.williamson@redhat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Jason Wang" <jasowang@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Cédric Le Goater" <clg@kaod.org>,
"Halil Pasic" <pasic@linux.ibm.com>, "Fam Zheng" <fam@euphon.net>,
qemu-ppc@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
kvm@vger.kernel.org,
"Stefano Stabellini" <sstabellini@kernel.org>,
xen-devel@lists.xenproject.org,
"Cornelia Huck" <cohuck@redhat.com>,
"David Hildenbrand" <david@redhat.com>,
qemu-block@nongnu.org,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
"Sunil Muthuswamy" <sunilmut@microsoft.com>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Laurent Vivier" <laurent@vivier.eu>,
"Thomas Huth" <thuth@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>
Subject: Re: [PATCH 2/2] sysemu: Let VMChangeStateHandler take boolean 'running' argument
Date: Mon, 11 Jan 2021 17:48:41 +0000 [thread overview]
Message-ID: <87lfcznz3x.fsf@linaro.org> (raw)
In-Reply-To: <20210111152020.1422021-3-philmd@redhat.com>
Philippe Mathieu-Daudé <philmd@redhat.com> writes:
> The 'running' argument from VMChangeStateHandler does not require
> other value than 0 / 1. Make it a plain boolean.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Seems reasonable
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
WARNING: multiple messages have this Message-ID (diff)
From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: "Fam Zheng" <fam@euphon.net>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Dmitry Fleytman" <dmitry.fleytman@gmail.com>,
kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"David Hildenbrand" <david@redhat.com>,
qemu-devel@nongnu.org, "Laurent Vivier" <laurent@vivier.eu>,
"Thomas Huth" <thuth@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
qemu-block@nongnu.org, qemu-trivial@nongnu.org,
"Huacai Chen" <chenhuacai@kernel.org>,
"Halil Pasic" <pasic@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
"Anthony Perard" <anthony.perard@citrix.com>,
xen-devel@lists.xenproject.org,
"Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Amit Shah" <amit@kernel.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Greg Kurz" <groug@kaod.org>, "Paul Durrant" <paul@xen.org>,
"Alex Williamson" <alex.williamson@redhat.com>,
qemu-arm@nongnu.org, "Cédric Le Goater" <clg@kaod.org>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Sunil Muthuswamy" <sunilmut@microsoft.com>,
"John Snow" <jsnow@redhat.com>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Kevin Wolf" <kwolf@redhat.com>,
"Marcelo Tosatti" <mtosatti@redhat.com>,
qemu-s390x@nongnu.org, "Max Reitz" <mreitz@redhat.com>,
qemu-ppc@nongnu.org, "Cornelia Huck" <cohuck@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>
Subject: Re: [PATCH 2/2] sysemu: Let VMChangeStateHandler take boolean 'running' argument
Date: Mon, 11 Jan 2021 17:48:41 +0000 [thread overview]
Message-ID: <87lfcznz3x.fsf@linaro.org> (raw)
In-Reply-To: <20210111152020.1422021-3-philmd@redhat.com>
Philippe Mathieu-Daudé <philmd@redhat.com> writes:
> The 'running' argument from VMChangeStateHandler does not require
> other value than 0 / 1. Make it a plain boolean.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Seems reasonable
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
next prev parent reply other threads:[~2021-01-11 17:49 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 15:20 [PATCH 0/2] sysemu: Let VMChangeStateHandler take boolean 'running' argument Philippe Mathieu-Daudé
2021-01-11 15:20 ` Philippe Mathieu-Daudé
2021-01-11 15:20 ` [PATCH 1/2] sysemu/runstate: Let runstate_is_running() return bool Philippe Mathieu-Daudé
2021-01-11 15:20 ` Philippe Mathieu-Daudé
2021-01-11 16:08 ` David Hildenbrand
2021-01-11 16:08 ` David Hildenbrand
2021-01-11 17:46 ` Alex Bennée
2021-01-11 17:46 ` Alex Bennée
2021-03-09 22:13 ` Laurent Vivier
2021-03-09 22:13 ` Laurent Vivier
2021-01-11 15:20 ` [PATCH 2/2] sysemu: Let VMChangeStateHandler take boolean 'running' argument Philippe Mathieu-Daudé
2021-01-11 15:20 ` Philippe Mathieu-Daudé
2021-01-11 17:48 ` Alex Bennée [this message]
2021-01-11 17:48 ` Alex Bennée
2021-01-12 0:17 ` David Gibson
2021-01-12 0:17 ` David Gibson
2021-03-09 22:14 ` Laurent Vivier
2021-03-09 22:14 ` Laurent Vivier
2021-01-12 10:30 ` [PATCH 0/2] " Stefan Hajnoczi
2021-01-12 10:30 ` Stefan Hajnoczi
2021-02-22 14:34 ` Philippe Mathieu-Daudé
2021-02-22 14:34 ` Philippe Mathieu-Daudé
2021-03-09 22:08 ` Philippe Mathieu-Daudé
2021-03-09 22:08 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfcznz3x.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=aleksandar.rikalo@syrmia.com \
--cc=alex.williamson@redhat.com \
--cc=amit@kernel.org \
--cc=anthony.perard@citrix.com \
--cc=aurelien@aurel32.net \
--cc=borntraeger@de.ibm.com \
--cc=chenhuacai@kernel.org \
--cc=clg@kaod.org \
--cc=cohuck@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=david@redhat.com \
--cc=dmitry.fleytman@gmail.com \
--cc=ehabkost@redhat.com \
--cc=fam@euphon.net \
--cc=groug@kaod.org \
--cc=jasowang@redhat.com \
--cc=jiaxun.yang@flygoat.com \
--cc=jsnow@redhat.com \
--cc=kraxel@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=laurent@vivier.eu \
--cc=marcel.apfelbaum@gmail.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sstabellini@kernel.org \
--cc=stefanha@redhat.com \
--cc=sunilmut@microsoft.com \
--cc=thuth@redhat.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.