From: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
To: Richard Henderson <rth@twiddle.net>,
qemu-ppc@nongnu.org, david@gibson.dropbear.id.au
Cc: qemu-devel@nongnu.org, aneesh.kumar@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [RFC 3/6] target-ppc: adding addpcis instruction
Date: Thu, 21 Jul 2016 13:36:34 +0530 [thread overview]
Message-ID: <87lh0v9zzp.fsf@abhimanyu.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <6b568a67-b83b-a956-a4e8-ec0a087acea8@twiddle.net>
Richard Henderson <rth@twiddle.net> writes:
> On 07/12/2016 11:33 PM, Nikunj A Dadhania wrote:
>> +static void gen_addpcis(DisasContext *ctx)
>> +{
>> + target_long d = DX(ctx->opcode);
>> +
>> + tcg_gen_movi_tl(cpu_gpr[rD(ctx->opcode)], ctx->nip);
>> + tcg_gen_addi_tl(cpu_gpr[rD(ctx->opcode)], cpu_gpr[rD(ctx->opcode)], d);
>> +}
>
> (1) You appear to have forgotten the "shift" part of "addpcis".
Yes, i had not seen this reply.
> (2) Both of these are translate-time constants, so...
>
> tcg_gen_movi_tl(cpu_gpr[rD(ctx->opcode)], ctx->nip + (d << 16));
Sure
Regards
Nikunj
next prev parent reply other threads:[~2016-07-21 8:06 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-12 18:03 [Qemu-devel] [RFC 0/6] POWER9 TCG enablements - part1 Nikunj A Dadhania
2016-07-12 18:03 ` [Qemu-devel] [RFC 1/6] target-ppc: Introduce Power9 family Nikunj A Dadhania
2016-07-14 5:26 ` Bharata B Rao
2016-07-14 6:02 ` Nikunj A Dadhania
2016-07-18 1:48 ` David Gibson
2016-07-18 5:13 ` Nikunj A Dadhania
2016-07-12 18:03 ` [Qemu-devel] [RFC 2/6] target-ppc: Introduce POWER ISA 3.0 flag Nikunj A Dadhania
2016-07-18 1:49 ` David Gibson
2016-07-12 18:03 ` [Qemu-devel] [RFC 3/6] target-ppc: adding addpcis instruction Nikunj A Dadhania
2016-07-18 1:55 ` David Gibson
2016-07-21 5:59 ` Richard Henderson
2016-07-21 8:06 ` Nikunj A Dadhania [this message]
2016-07-12 18:03 ` [Qemu-devel] [RFC 4/6] target-ppc: add cmprb instruction Nikunj A Dadhania
2016-07-18 2:00 ` David Gibson
2016-07-21 6:17 ` Richard Henderson
2016-07-21 8:08 ` Nikunj A Dadhania
2016-08-02 7:02 ` Nikunj A Dadhania
2016-07-12 18:03 ` [Qemu-devel] [RFC 5/6] target-ppc: add modulo word operations Nikunj A Dadhania
2016-07-18 2:04 ` David Gibson
2016-07-18 5:08 ` Nikunj A Dadhania
2016-07-21 6:24 ` Richard Henderson
2016-07-21 8:11 ` Nikunj A Dadhania
2016-07-21 10:24 ` Richard Henderson
2016-07-12 18:03 ` [Qemu-devel] [RFC 6/6] target-ppc: add modulo dword operations Nikunj A Dadhania
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lh0v9zzp.fsf@abhimanyu.i-did-not-set--mail-host-address--so-tickle-me \
--to=nikunj@linux.vnet.ibm.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.