From: Michael Ellerman <mpe@ellerman.id.au>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
KVM list <kvm@vger.kernel.org>,
virtualization@lists.linux-foundation.org,
Netdev <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
mie@igel.co.jp
Subject: Re: [GIT PULL] virtio: last minute fixup
Date: Thu, 12 May 2022 23:30:15 +1000 [thread overview]
Message-ID: <87mtfm7uag.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <CAHk-=wj9zKJGA_6SJOMPiQEoYke6cKX-FV3X_5zNXOcFJX1kOQ@mail.gmail.com>
Linus Torvalds <torvalds@linux-foundation.org> writes:
> On Wed, May 11, 2022 at 3:12 AM Michael Ellerman <mpe@ellerman.id.au> wrote:
>>
>> Which I read as you endorsing Link: tags :)
>
> I absolutely adore "Link:" tags. They've been great.
>
> But they've been great for links that are *usedful*.
>
> They are wonderful when they link to the original problem.
>
> They are *really* wonderful when they link to some long discussion
> about how to solve the problem.
>
> They are completely useless when they link to "this is the patch
> submission of the SAME DAMN PATCH THAT THE COMMIT IS".
Folks wanted to add Change-Id: tags to every commit.
You said we didn't need to, because we have the Link: to the original
patch submission, which includes the Message-Id and therefore is a
de facto change id.
Links to other random places don't serve that function.
cheers
WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <mpe@ellerman.id.au>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: KVM list <kvm@vger.kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Netdev <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
virtualization@lists.linux-foundation.org, mie@igel.co.jp,
Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Subject: Re: [GIT PULL] virtio: last minute fixup
Date: Thu, 12 May 2022 23:30:15 +1000 [thread overview]
Message-ID: <87mtfm7uag.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <CAHk-=wj9zKJGA_6SJOMPiQEoYke6cKX-FV3X_5zNXOcFJX1kOQ@mail.gmail.com>
Linus Torvalds <torvalds@linux-foundation.org> writes:
> On Wed, May 11, 2022 at 3:12 AM Michael Ellerman <mpe@ellerman.id.au> wrote:
>>
>> Which I read as you endorsing Link: tags :)
>
> I absolutely adore "Link:" tags. They've been great.
>
> But they've been great for links that are *usedful*.
>
> They are wonderful when they link to the original problem.
>
> They are *really* wonderful when they link to some long discussion
> about how to solve the problem.
>
> They are completely useless when they link to "this is the patch
> submission of the SAME DAMN PATCH THAT THE COMMIT IS".
Folks wanted to add Change-Id: tags to every commit.
You said we didn't need to, because we have the Link: to the original
patch submission, which includes the Message-Id and therefore is a
de facto change id.
Links to other random places don't serve that function.
cheers
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2022-05-12 13:30 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 12:23 [GIT PULL] virtio: last minute fixup Michael S. Tsirkin
2022-05-10 12:23 ` Michael S. Tsirkin
2022-05-10 18:23 ` Linus Torvalds
2022-05-10 18:23 ` Linus Torvalds
2022-05-10 23:12 ` Nathan Chancellor
2022-05-10 23:50 ` Linus Torvalds
2022-05-10 23:50 ` Linus Torvalds
2022-05-11 7:13 ` Michael S. Tsirkin
2022-05-11 7:13 ` Michael S. Tsirkin
2022-05-11 12:51 ` Konstantin Ryabitsev
2022-05-11 13:40 ` Michael Ellerman
2022-05-11 13:40 ` Michael Ellerman
2022-05-11 16:31 ` Konstantin Ryabitsev
2022-05-12 2:07 ` Theodore Ts'o
2022-05-12 2:07 ` Theodore Ts'o
2022-05-11 17:35 ` Dave Taht
2022-05-11 6:22 ` Michael S. Tsirkin
2022-05-11 6:22 ` Michael S. Tsirkin
2022-05-11 10:12 ` Michael Ellerman
2022-05-11 10:12 ` Michael Ellerman
2022-05-11 16:20 ` Linus Torvalds
2022-05-11 16:20 ` Linus Torvalds
2022-05-12 13:30 ` Michael Ellerman [this message]
2022-05-12 13:30 ` Michael Ellerman
2022-05-12 17:10 ` Linus Torvalds
2022-05-12 17:10 ` Linus Torvalds
2022-05-12 17:19 ` Linus Torvalds
2022-05-12 17:19 ` Linus Torvalds
2022-05-13 14:14 ` Eric W. Biederman
2022-05-13 14:14 ` Eric W. Biederman
2022-05-13 17:00 ` Jakub Kicinski
2022-05-16 9:03 ` Michael S. Tsirkin
2022-05-16 9:03 ` Michael S. Tsirkin
2022-05-11 12:24 ` Jörg Rödel
2022-05-11 12:24 ` Jörg Rödel
2022-05-13 12:16 ` Michael S. Tsirkin
2022-05-13 12:16 ` Michael S. Tsirkin
2022-05-10 18:31 ` pr-tracker-bot
2022-05-10 18:31 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtfm7uag.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=konstantin@linuxfoundation.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mie@igel.co.jp \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.