Re: [PATCH v9 4/4] mac80211: Use Airtime-based Queue Limits (AQL) on packet dequeue

["Toke Høiland-Jørgensen" <toke@redhat.com>]

Kan Yan <kyan@google.com> writes:

>> > Given the fact that AQL is only tested in very limited platforms,
>> > should we set the default to disabled by removing this change in the
>> > next update?
>> >
>> > -       local->airtime_flags = AIRTIME_USE_TX | AIRTIME_USE_RX;
>> > +
>> > +       local->airtime_flags = AIRTIME_USE_TX |
>> > +                              AIRTIME_USE_RX |
>> > +                              AIRTIME_USE_AQL;
>> > +       local->aql_threshold = IEEE80211_AQL_THRESHOLD;
>> > +       atomic_set(&local->aql_total_pending_airtime, 0);
>> Well, we have the whole -rc series to get more testing in if we merge it
>> as-is. It's up to the maintainers, of course, but I would be in favour
>> of merging as-is, then optionally backing out the default before the
>> final release if problems do turn up. But I would hope that the limits
>> are sufficiently conservative that it would not result in any problems :)
>
> Sounds good. The current default limits are reasonably conservative
> and are tunable via debugfs.
>
> I will give the v10 version of this patch serial a quick test and
> hopefully we can wrap it up soon.

Sounds good, thanks! Also, seems we got a 5.4-rc8 yesterday, so we have
another week before the merge window.

Johannes, any chance you'll get a chance to take a look at this sometime
this week? :)

-Toke