All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Anholt <eric@anholt.net>
To: Stefan Wahren <stefan.wahren@i2se.com>, Rob Herring <robh@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org,
	Florian Fainelli <f.fainelli@gmail.com>,
	Scott Branden <sbranden@broadcom.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>, Alexander Graf <agraf@suse.de>,
	Phil Elwell <phil@raspberrypi.org>,
	bcm-kernel-feedback-list@broadcom.com,
	linux-rpi-kernel@lists.infradead.org, Ray Jui <rjui@broadcom.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/9] ARM: dts: bcm2837: Add Raspberry Pi 3 B+
Date: Tue, 17 Apr 2018 09:02:57 -0700	[thread overview]
Message-ID: <87muy1253i.fsf@anholt.net> (raw)
In-Reply-To: <60625d11-c521-b004-d64c-f72c9c6aac83@i2se.com>


[-- Attachment #1.1: Type: text/plain, Size: 1711 bytes --]

Stefan Wahren <stefan.wahren@i2se.com> writes:

> Hi Rob,
>
> Am 16.04.2018 um 22:43 schrieb Rob Herring:
>> On Fri, Apr 13, 2018 at 07:27:53PM +0200, Stefan Wahren wrote:
>>> The Raspberry Pi 3 B+ has the following major differences compared
>>> to the model 3 B:
>>> * Microchip LAN7515 (Gigabit Ethernet)
>>> * Cypress CYW43455 (802.11n/ac and BT 4.2)
>>>
>>> We need to add the USB LAN chip so the bootloader can add the MAC address.
>>> This is necessary because there ain't a EEPROM or a valid OTP.
>>>
>>> Signed-off-by: Phil Elwell <phil@raspberrypi.org>
>>> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
>>> ---
>>>   arch/arm/boot/dts/Makefile                 |   1 +
>>>   arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts | 108 +++++++++++++++++++++++++++++
>>>   arch/arm/boot/dts/bcm283x-rpi-lan7515.dtsi |  27 ++++++++
>>>   3 files changed, 136 insertions(+)
>>>   create mode 100644 arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts
>>>   create mode 100644 arch/arm/boot/dts/bcm283x-rpi-lan7515.dtsi
>>>
>>> ...
>>> diff --git a/arch/arm/boot/dts/bcm283x-rpi-lan7515.dtsi b/arch/arm/boot/dts/bcm283x-rpi-lan7515.dtsi
>>> new file mode 100644
>>> index 0000000..169203c
>>> --- /dev/null
>>> +++ b/arch/arm/boot/dts/bcm283x-rpi-lan7515.dtsi
>> Why the separate file? This can be shared?
>
> this comes from the assumption the RPi 3 B+ won't be the only RPi board 
> with a LAN7515. Should i fold it in the dts file as long as we don't 
> have a second board?

I think it's great as is -- our other network chips are hooked up this
way and it makes 3b+ match all the others.  Also, while I have no
specific knowledge, it seems likely that this would get reused.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: eric@anholt.net (Eric Anholt)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/9] ARM: dts: bcm2837: Add Raspberry Pi 3 B+
Date: Tue, 17 Apr 2018 09:02:57 -0700	[thread overview]
Message-ID: <87muy1253i.fsf@anholt.net> (raw)
In-Reply-To: <60625d11-c521-b004-d64c-f72c9c6aac83@i2se.com>

Stefan Wahren <stefan.wahren@i2se.com> writes:

> Hi Rob,
>
> Am 16.04.2018 um 22:43 schrieb Rob Herring:
>> On Fri, Apr 13, 2018 at 07:27:53PM +0200, Stefan Wahren wrote:
>>> The Raspberry Pi 3 B+ has the following major differences compared
>>> to the model 3 B:
>>> * Microchip LAN7515 (Gigabit Ethernet)
>>> * Cypress CYW43455 (802.11n/ac and BT 4.2)
>>>
>>> We need to add the USB LAN chip so the bootloader can add the MAC address.
>>> This is necessary because there ain't a EEPROM or a valid OTP.
>>>
>>> Signed-off-by: Phil Elwell <phil@raspberrypi.org>
>>> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
>>> ---
>>>   arch/arm/boot/dts/Makefile                 |   1 +
>>>   arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts | 108 +++++++++++++++++++++++++++++
>>>   arch/arm/boot/dts/bcm283x-rpi-lan7515.dtsi |  27 ++++++++
>>>   3 files changed, 136 insertions(+)
>>>   create mode 100644 arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts
>>>   create mode 100644 arch/arm/boot/dts/bcm283x-rpi-lan7515.dtsi
>>>
>>> ...
>>> diff --git a/arch/arm/boot/dts/bcm283x-rpi-lan7515.dtsi b/arch/arm/boot/dts/bcm283x-rpi-lan7515.dtsi
>>> new file mode 100644
>>> index 0000000..169203c
>>> --- /dev/null
>>> +++ b/arch/arm/boot/dts/bcm283x-rpi-lan7515.dtsi
>> Why the separate file? This can be shared?
>
> this comes from the assumption the RPi 3 B+ won't be the only RPi board 
> with a LAN7515. Should i fold it in the dts file as long as we don't 
> have a second board?

I think it's great as is -- our other network chips are hooked up this
way and it makes 3b+ match all the others.  Also, while I have no
specific knowledge, it seems likely that this would get reused.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180417/7215cc5e/attachment.sig>

  reply	other threads:[~2018-04-17 16:02 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-13 17:27 [PATCH 0/9] ARM: bcm283x: RPi 3 B+ support and other improvements Stefan Wahren
2018-04-13 17:27 ` Stefan Wahren
2018-04-13 17:27 ` [PATCH 1/9] ARM: dts: bcm283x: Fix PWM pin assignment Stefan Wahren
2018-04-13 17:27   ` Stefan Wahren
2018-04-13 17:27 ` [PATCH 2/9] ARM: dts: bcm2837: Add missing GPIOs of Expander Stefan Wahren
2018-04-13 17:27   ` Stefan Wahren
2018-04-13 17:27 ` [PATCH 3/9] dt-bindings: bcm: Add Raspberry Pi 3 B+ Stefan Wahren
2018-04-13 17:27   ` Stefan Wahren
2018-04-16 20:38   ` Rob Herring
2018-04-16 20:38     ` Rob Herring
2018-04-13 17:27 ` [PATCH 4/9] ARM: dts: bcm2837: " Stefan Wahren
2018-04-13 17:27   ` Stefan Wahren
2018-04-16 20:43   ` Rob Herring
2018-04-16 20:43     ` Rob Herring
2018-04-17  8:13     ` Stefan Wahren
2018-04-17  8:13       ` Stefan Wahren
2018-04-17 16:02       ` Eric Anholt [this message]
2018-04-17 16:02         ` Eric Anholt
2018-04-20 11:24         ` Stefan Wahren
2018-04-20 11:24           ` Stefan Wahren
2018-04-20 18:50           ` Rob Herring
2018-04-20 18:50             ` Rob Herring
2018-04-13 17:27 ` [PATCH 5/9] ARM: bcm2835_defconfig: Enable LAN78XX driver Stefan Wahren
2018-04-13 17:27   ` Stefan Wahren
2018-04-13 17:27 ` [PATCH 6/9] ARM: bcm2835_defconfig: Enable VCHIQ driver Stefan Wahren
2018-04-13 17:27   ` Stefan Wahren
2018-04-13 17:27 ` [PATCH 7/9] ARM: multi_v7_defconfig: Enable LAN and BT support for RPi 3 B+ Stefan Wahren
2018-04-13 17:27   ` Stefan Wahren
2018-04-13 17:27 ` [PATCH 8/9] arm64: defconfig: " Stefan Wahren
2018-04-13 17:27   ` Stefan Wahren
2018-04-13 17:27 ` [PATCH 9/9] arm64: dts: broadcom: Add reference to Raspberry Pi " Stefan Wahren
2018-04-13 17:27   ` Stefan Wahren
2018-04-20 11:26   ` Stefan Wahren
2018-04-20 11:26     ` Stefan Wahren
2018-04-13 20:01 ` [PATCH 0/9] ARM: bcm283x: RPi 3 B+ support and other improvements Eric Anholt
2018-04-13 20:01   ` Eric Anholt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87muy1253i.fsf@anholt.net \
    --to=eric@anholt.net \
    --cc=agraf@suse.de \
    --cc=arnd@arndb.de \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=phil@raspberrypi.org \
    --cc=rjui@broadcom.com \
    --cc=robh@kernel.org \
    --cc=sbranden@broadcom.com \
    --cc=stefan.wahren@i2se.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.