All of lore.kernel.org
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Christoph Hellwig <hch@lst.de>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Jeremy Kerr <jk@ozlabs.org>,
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
	Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	x86@kernel.org
Subject: Re: [PATCH 4/8] binfmt_elf: open code copy_siginfo_to_user to kernelspace buffer
Date: Fri, 17 Apr 2020 13:10:12 -0500	[thread overview]
Message-ID: <87o8rqc7az.fsf@x220.int.ebiederm.org> (raw)
In-Reply-To: <20200417132714.GA6401@lst.de> (Christoph Hellwig's message of "Fri, 17 Apr 2020 15:27:14 +0200")

Christoph Hellwig <hch@lst.de> writes:

> On Wed, Apr 15, 2020 at 10:20:11AM +0200, Arnd Bergmann wrote:
>> > I'd rather keep it out of this series and to
>> > an interested party.  Then again x32 doesn't seem to have a whole lot
>> > of interested parties..
>> 
>> Fine with me. It's on my mental list of things that we want to kill off
>> eventually as soon as the remaining users stop replying to questions
>> about it.
>> 
>> In fact I should really turn that into a properly maintained list in
>> Documentation/... that contains any options that someone has
>> asked about removing in the past, along with the reasons for keeping
>> it around and a time at which we should ask about it again.
>
> To the newly added x86 maintainers:  Arnd brought up the point that
> elf_core_dump writes the ABI siginfo format into the core dump. That
> format differs for i386 vs x32.  Is there any good way to find out
> which is the right format when are not in a syscall?
>
> As far a I can tell x32 vs i386 just seems to be based around what
> syscall table was used for the current syscall, but core dumps aren't
> always in syscall context.

I don't think this matters.  The i386 and x32 signal structures
only differ for SIGCHLD.  The SIGCHLD signal does cause coredumps.
So as long as we get the 32bit vs 64bit distinct correct all should be
well.

Eric




WARNING: multiple messages have this Message-ID (diff)
From: ebiederm@xmission.com (Eric W. Biederman)
To: Christoph Hellwig <hch@lst.de>
Cc: Arnd Bergmann <arnd@arndb.de>,
	x86@kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
	Jeremy Kerr <jk@ozlabs.org>
Subject: Re: [PATCH 4/8] binfmt_elf: open code copy_siginfo_to_user to kernelspace buffer
Date: Fri, 17 Apr 2020 13:10:12 -0500	[thread overview]
Message-ID: <87o8rqc7az.fsf@x220.int.ebiederm.org> (raw)
In-Reply-To: <20200417132714.GA6401@lst.de> (Christoph Hellwig's message of "Fri, 17 Apr 2020 15:27:14 +0200")

Christoph Hellwig <hch@lst.de> writes:

> On Wed, Apr 15, 2020 at 10:20:11AM +0200, Arnd Bergmann wrote:
>> > I'd rather keep it out of this series and to
>> > an interested party.  Then again x32 doesn't seem to have a whole lot
>> > of interested parties..
>> 
>> Fine with me. It's on my mental list of things that we want to kill off
>> eventually as soon as the remaining users stop replying to questions
>> about it.
>> 
>> In fact I should really turn that into a properly maintained list in
>> Documentation/... that contains any options that someone has
>> asked about removing in the past, along with the reasons for keeping
>> it around and a time at which we should ask about it again.
>
> To the newly added x86 maintainers:  Arnd brought up the point that
> elf_core_dump writes the ABI siginfo format into the core dump. That
> format differs for i386 vs x32.  Is there any good way to find out
> which is the right format when are not in a syscall?
>
> As far a I can tell x32 vs i386 just seems to be based around what
> syscall table was used for the current syscall, but core dumps aren't
> always in syscall context.

I don't think this matters.  The i386 and x32 signal structures
only differ for SIGCHLD.  The SIGCHLD signal does cause coredumps.
So as long as we get the 32bit vs 64bit distinct correct all should be
well.

Eric




  reply	other threads:[~2020-04-17 18:13 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-14  7:01 remove set_fs calls from the exec and coredump code v2 Christoph Hellwig
2020-04-14  7:01 ` Christoph Hellwig
2020-04-14  7:01 ` [PATCH 1/8] powerpc/spufs: simplify spufs core dumping Christoph Hellwig
2020-04-14  7:01   ` Christoph Hellwig
2020-04-14  7:01 ` [PATCH 2/8] signal: clean up __copy_siginfo_to_user32 Christoph Hellwig
2020-04-14  7:01   ` Christoph Hellwig
2020-04-17 21:08   ` Eric W. Biederman
2020-04-17 21:08     ` Eric W. Biederman
2020-04-17 21:09     ` [PATCH 1/2] signal: Factor copy_siginfo_to_external32 from copy_siginfo_to_user32 Eric W. Biederman
2020-04-17 21:09       ` Eric W. Biederman
2020-04-18  8:05       ` Christophe Leroy
2020-04-18 11:55         ` Eric W. Biederman
2020-04-18 11:55           ` Eric W. Biederman
2020-04-19  8:13           ` Christoph Hellwig
2020-04-19  8:13             ` Christoph Hellwig
2020-04-19  9:46             ` Christophe Leroy
2020-04-19  9:54           ` Christophe Leroy
2020-04-19  8:05         ` Christoph Hellwig
2020-04-19  8:05           ` Christoph Hellwig
2020-04-17 21:09     ` [PATCH 2/2] signal: Remove the set_fs in binfmt_elf.c:fill_siginfo_note Eric W. Biederman
2020-04-17 21:09       ` Eric W. Biederman
2020-04-19  8:03     ` [PATCH 2/8] signal: clean up __copy_siginfo_to_user32 Christoph Hellwig
2020-04-19  8:03       ` Christoph Hellwig
2020-04-14  7:01 ` [PATCH 3/8] signal: replace __copy_siginfo_to_user32 with to_compat_siginfo Christoph Hellwig
2020-04-14  7:01   ` Christoph Hellwig
2020-04-14 14:00   ` Arnd Bergmann
2020-04-14 14:00     ` Arnd Bergmann
2020-04-14  7:01 ` [PATCH 4/8] binfmt_elf: open code copy_siginfo_to_user to kernelspace buffer Christoph Hellwig
2020-04-14  7:01   ` Christoph Hellwig
2020-04-14 13:15   ` Arnd Bergmann
2020-04-14 13:15     ` Arnd Bergmann
2020-04-15  7:45     ` Christoph Hellwig
2020-04-15  7:45       ` Christoph Hellwig
2020-04-15  8:20       ` Arnd Bergmann
2020-04-15  8:20         ` Arnd Bergmann
2020-04-17 13:27         ` Christoph Hellwig
2020-04-17 13:27           ` Christoph Hellwig
2020-04-17 18:10           ` Eric W. Biederman [this message]
2020-04-17 18:10             ` Eric W. Biederman
2020-04-17 20:06             ` Arnd Bergmann
2020-04-17 20:06               ` Arnd Bergmann
2020-04-15  3:01   ` Michael Ellerman
2020-04-15  3:01     ` Michael Ellerman
2020-04-15  6:19     ` Christoph Hellwig
2020-04-15  6:19       ` Christoph Hellwig
2020-04-14  7:01 ` [PATCH 5/8] binfmt_elf: remove the set_fs(KERNEL_DS) in elf_core_dump Christoph Hellwig
2020-04-14  7:01   ` Christoph Hellwig
2020-04-14  7:01 ` [PATCH 6/8] binfmt_elf_fdpic: remove the set_fs(KERNEL_DS) in elf_fdpic_core_dump Christoph Hellwig
2020-04-14  7:01   ` Christoph Hellwig
2020-04-14  7:01 ` [PATCH 7/8] exec: simplify the copy_strings_kernel calling convention Christoph Hellwig
2020-04-14  7:01   ` Christoph Hellwig
2020-04-14  7:01 ` [PATCH 8/8] exec: open code copy_string_kernel Christoph Hellwig
2020-04-14  7:01   ` Christoph Hellwig
2020-04-18  8:15   ` Christophe Leroy
2020-04-18  8:15     ` Christophe Leroy
2020-04-19  8:06     ` Christoph Hellwig
2020-04-19  8:06       ` Christoph Hellwig
2020-04-19  9:44       ` Christophe Leroy
2020-04-19  9:44         ` Christophe Leroy
2020-04-17 22:41 ` remove set_fs calls from the exec and coredump code v2 Eric W. Biederman
2020-04-17 22:41   ` Eric W. Biederman
2020-04-19  8:19   ` Christoph Hellwig
2020-04-19  8:19     ` Christoph Hellwig
2020-04-19 11:50     ` Eric W. Biederman
2020-04-19 11:50       ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o8rqc7az.fsf@x220.int.ebiederm.org \
    --to=ebiederm@xmission.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=hch@lst.de \
    --cc=jk@ozlabs.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.