From: Arnd Bergmann <arnd@arndb.de>
To: Christoph Hellwig <hch@lst.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Jeremy Kerr <jk@ozlabs.org>,
"Eric W . Biederman" <ebiederm@xmission.com>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/8] binfmt_elf: open code copy_siginfo_to_user to kernelspace buffer
Date: Wed, 15 Apr 2020 10:20:11 +0200 [thread overview]
Message-ID: <CAK8P3a0QGQX85LaqKC1UuTERk6Bpr5TW6aWF+jxi2cOpa4L_AA@mail.gmail.com> (raw)
In-Reply-To: <20200415074514.GA1393@lst.de>
On Wed, Apr 15, 2020 at 9:45 AM Christoph Hellwig <hch@lst.de> wrote:
>
> On Tue, Apr 14, 2020 at 03:15:09PM +0200, Arnd Bergmann wrote:
> > I don't think you are changing the behavior here, but I still wonder if it
> > is in fact correct for x32: is in_x32_syscall() true here when dumping an
> > x32 compat elf process, or should this rather be set according to which
> > binfmt_elf copy is being used?
>
> The infrastructure could enable that, although it would require more
> arch hooks I think.
I was more interested in whether you can tell if it's currently broken
or not. If my feeling is right that the current code does the wrong thing
here, it would be good to at least put a FIXME comment in there.
> I'd rather keep it out of this series and to
> an interested party. Then again x32 doesn't seem to have a whole lot
> of interested parties..
Fine with me. It's on my mental list of things that we want to kill off
eventually as soon as the remaining users stop replying to questions
about it.
In fact I should really turn that into a properly maintained list in
Documentation/... that contains any options that someone has
asked about removing in the past, along with the reasons for keeping
it around and a time at which we should ask about it again.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Christoph Hellwig <hch@lst.de>
Cc: Jeremy Kerr <jk@ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Eric W . Biederman" <ebiederm@xmission.com>,
Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH 4/8] binfmt_elf: open code copy_siginfo_to_user to kernelspace buffer
Date: Wed, 15 Apr 2020 10:20:11 +0200 [thread overview]
Message-ID: <CAK8P3a0QGQX85LaqKC1UuTERk6Bpr5TW6aWF+jxi2cOpa4L_AA@mail.gmail.com> (raw)
In-Reply-To: <20200415074514.GA1393@lst.de>
On Wed, Apr 15, 2020 at 9:45 AM Christoph Hellwig <hch@lst.de> wrote:
>
> On Tue, Apr 14, 2020 at 03:15:09PM +0200, Arnd Bergmann wrote:
> > I don't think you are changing the behavior here, but I still wonder if it
> > is in fact correct for x32: is in_x32_syscall() true here when dumping an
> > x32 compat elf process, or should this rather be set according to which
> > binfmt_elf copy is being used?
>
> The infrastructure could enable that, although it would require more
> arch hooks I think.
I was more interested in whether you can tell if it's currently broken
or not. If my feeling is right that the current code does the wrong thing
here, it would be good to at least put a FIXME comment in there.
> I'd rather keep it out of this series and to
> an interested party. Then again x32 doesn't seem to have a whole lot
> of interested parties..
Fine with me. It's on my mental list of things that we want to kill off
eventually as soon as the remaining users stop replying to questions
about it.
In fact I should really turn that into a properly maintained list in
Documentation/... that contains any options that someone has
asked about removing in the past, along with the reasons for keeping
it around and a time at which we should ask about it again.
Arnd
next prev parent reply other threads:[~2020-04-15 8:20 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 7:01 remove set_fs calls from the exec and coredump code v2 Christoph Hellwig
2020-04-14 7:01 ` Christoph Hellwig
2020-04-14 7:01 ` [PATCH 1/8] powerpc/spufs: simplify spufs core dumping Christoph Hellwig
2020-04-14 7:01 ` Christoph Hellwig
2020-04-14 7:01 ` [PATCH 2/8] signal: clean up __copy_siginfo_to_user32 Christoph Hellwig
2020-04-14 7:01 ` Christoph Hellwig
2020-04-17 21:08 ` Eric W. Biederman
2020-04-17 21:08 ` Eric W. Biederman
2020-04-17 21:09 ` [PATCH 1/2] signal: Factor copy_siginfo_to_external32 from copy_siginfo_to_user32 Eric W. Biederman
2020-04-17 21:09 ` Eric W. Biederman
2020-04-18 8:05 ` Christophe Leroy
2020-04-18 11:55 ` Eric W. Biederman
2020-04-18 11:55 ` Eric W. Biederman
2020-04-19 8:13 ` Christoph Hellwig
2020-04-19 8:13 ` Christoph Hellwig
2020-04-19 9:46 ` Christophe Leroy
2020-04-19 9:54 ` Christophe Leroy
2020-04-19 8:05 ` Christoph Hellwig
2020-04-19 8:05 ` Christoph Hellwig
2020-04-17 21:09 ` [PATCH 2/2] signal: Remove the set_fs in binfmt_elf.c:fill_siginfo_note Eric W. Biederman
2020-04-17 21:09 ` Eric W. Biederman
2020-04-19 8:03 ` [PATCH 2/8] signal: clean up __copy_siginfo_to_user32 Christoph Hellwig
2020-04-19 8:03 ` Christoph Hellwig
2020-04-14 7:01 ` [PATCH 3/8] signal: replace __copy_siginfo_to_user32 with to_compat_siginfo Christoph Hellwig
2020-04-14 7:01 ` Christoph Hellwig
2020-04-14 14:00 ` Arnd Bergmann
2020-04-14 14:00 ` Arnd Bergmann
2020-04-14 7:01 ` [PATCH 4/8] binfmt_elf: open code copy_siginfo_to_user to kernelspace buffer Christoph Hellwig
2020-04-14 7:01 ` Christoph Hellwig
2020-04-14 13:15 ` Arnd Bergmann
2020-04-14 13:15 ` Arnd Bergmann
2020-04-15 7:45 ` Christoph Hellwig
2020-04-15 7:45 ` Christoph Hellwig
2020-04-15 8:20 ` Arnd Bergmann [this message]
2020-04-15 8:20 ` Arnd Bergmann
2020-04-17 13:27 ` Christoph Hellwig
2020-04-17 13:27 ` Christoph Hellwig
2020-04-17 18:10 ` Eric W. Biederman
2020-04-17 18:10 ` Eric W. Biederman
2020-04-17 20:06 ` Arnd Bergmann
2020-04-17 20:06 ` Arnd Bergmann
2020-04-15 3:01 ` Michael Ellerman
2020-04-15 3:01 ` Michael Ellerman
2020-04-15 6:19 ` Christoph Hellwig
2020-04-15 6:19 ` Christoph Hellwig
2020-04-14 7:01 ` [PATCH 5/8] binfmt_elf: remove the set_fs(KERNEL_DS) in elf_core_dump Christoph Hellwig
2020-04-14 7:01 ` Christoph Hellwig
2020-04-14 7:01 ` [PATCH 6/8] binfmt_elf_fdpic: remove the set_fs(KERNEL_DS) in elf_fdpic_core_dump Christoph Hellwig
2020-04-14 7:01 ` Christoph Hellwig
2020-04-14 7:01 ` [PATCH 7/8] exec: simplify the copy_strings_kernel calling convention Christoph Hellwig
2020-04-14 7:01 ` Christoph Hellwig
2020-04-14 7:01 ` [PATCH 8/8] exec: open code copy_string_kernel Christoph Hellwig
2020-04-14 7:01 ` Christoph Hellwig
2020-04-18 8:15 ` Christophe Leroy
2020-04-18 8:15 ` Christophe Leroy
2020-04-19 8:06 ` Christoph Hellwig
2020-04-19 8:06 ` Christoph Hellwig
2020-04-19 9:44 ` Christophe Leroy
2020-04-19 9:44 ` Christophe Leroy
2020-04-17 22:41 ` remove set_fs calls from the exec and coredump code v2 Eric W. Biederman
2020-04-17 22:41 ` Eric W. Biederman
2020-04-19 8:19 ` Christoph Hellwig
2020-04-19 8:19 ` Christoph Hellwig
2020-04-19 11:50 ` Eric W. Biederman
2020-04-19 11:50 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a0QGQX85LaqKC1UuTERk6Bpr5TW6aWF+jxi2cOpa4L_AA@mail.gmail.com \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=hch@lst.de \
--cc=jk@ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.