Re: [PATCH v4 2/3] dt-bindings: net: ath10k: add new dt entry to identify external FEM

From: Kalle Valo <kvalo@codeaurora.org>
To: Sebastian Gottschall <s.gottschall@newmedia-net.de>
Cc: ath10k@lists.infradead.org
Subject: Re: [PATCH v4 2/3] dt-bindings: net: ath10k: add new dt entry to identify external FEM
Date: Thu, 13 Dec 2018 11:08:42 +0200	[thread overview]
Message-ID: <87o99pztd1.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <a944ea19-fcfe-2ae4-d508-2cde9c34fd29@newmedia-net.de> (Sebastian Gottschall's message of "Tue, 11 Dec 2018 21:07:55 +0100")

Sebastian Gottschall <s.gottschall@newmedia-net.de> writes:

> documentation still wrong. only  microsemi-lx5586 is valid .all other
> values are invalid
> see patch 4
>
> +	if (!strcmp("microsemi-lx5586", fem_name)) {
> +		bb_timing->bb_tx_timing = 0x00;
> +		bb_timing->bb_xpa_timing = 0x0101;
> +	} else {
> +		return -ENOENT;
> +	}

Please don't top post, makes the discussion difficult.

But anyway, to my knowledge the device tree is supposed to describe
hardware and not software implementation. So I don't see a problem that
device tree documents FEMs for which ath10k does not do anything right
now.

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k