All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Rob Herring <robh@kernel.org>
Cc: Bhagavathi Perumal S <bperumal@codeaurora.org>,
	devicetree@vger.kernel.org, linux-wireless@vger.kernel.org,
	ath10k@lists.infradead.org
Subject: Re: [PATCH v4 2/3] dt-bindings: net: ath10k: add new dt entry to identify external FEM
Date: Thu, 20 Dec 2018 15:23:31 +0200	[thread overview]
Message-ID: <87lg4ktjqk.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20181217203718.GA29320@bogus> (Rob Herring's message of "Mon, 17 Dec 2018 14:37:18 -0600")

Rob Herring <robh@kernel.org> writes:

> On Tue, Dec 11, 2018 at 09:43:23PM +0530, Bhagavathi Perumal S wrote:
>> This adds new dt entry ext-fem-name, it is used by ath10k driver
>> to select correct timing parameters and configure it in target wifi hardware.
>> The Front End Module(FEM) normally includes tx power amplifier(PA) and
>> rx low noise amplifier(LNA). The default timing parameters like tx end to
>> PA off timing values were fine tuned for internal FEM used in reference
>> design. And these timing values can not be same if ODM modifies hardware
>> design with different external FEM. This DT entry helps to choose correct
>> timing values in driver if different external FEM hardware used.
>> 
>> Signed-off-by: Bhagavathi Perumal S <bperumal@codeaurora.org>
>> ---
>>  Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt | 9 ++++++++-
>>  1 file changed, 8 insertions(+), 1 deletion(-)
>
> Please add acks/reviewed-bys when posting new versions.

I added your reviewed-by from v3 in the pending branch:

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=2f4f5a81c87b9be68aa087c238e2f2b9debbfa1b

-- 
Kalle Valo

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
To: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Bhagavathi Perumal S
	<bperumal-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	ath10k-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v4 2/3] dt-bindings: net: ath10k: add new dt entry to identify external FEM
Date: Thu, 20 Dec 2018 15:23:31 +0200	[thread overview]
Message-ID: <87lg4ktjqk.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20181217203718.GA29320@bogus> (Rob Herring's message of "Mon, 17 Dec 2018 14:37:18 -0600")

Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> writes:

> On Tue, Dec 11, 2018 at 09:43:23PM +0530, Bhagavathi Perumal S wrote:
>> This adds new dt entry ext-fem-name, it is used by ath10k driver
>> to select correct timing parameters and configure it in target wifi hardware.
>> The Front End Module(FEM) normally includes tx power amplifier(PA) and
>> rx low noise amplifier(LNA). The default timing parameters like tx end to
>> PA off timing values were fine tuned for internal FEM used in reference
>> design. And these timing values can not be same if ODM modifies hardware
>> design with different external FEM. This DT entry helps to choose correct
>> timing values in driver if different external FEM hardware used.
>> 
>> Signed-off-by: Bhagavathi Perumal S <bperumal-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
>> ---
>>  Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt | 9 ++++++++-
>>  1 file changed, 8 insertions(+), 1 deletion(-)
>
> Please add acks/reviewed-bys when posting new versions.

I added your reviewed-by from v3 in the pending branch:

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=2f4f5a81c87b9be68aa087c238e2f2b9debbfa1b

-- 
Kalle Valo

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, linux-wireless@vger.kernel.org,
	ath10k@lists.infradead.org,
	Bhagavathi Perumal S <bperumal@codeaurora.org>
Subject: Re: [PATCH v4 2/3] dt-bindings: net: ath10k: add new dt entry to identify external FEM
Date: Thu, 20 Dec 2018 15:23:31 +0200	[thread overview]
Message-ID: <87lg4ktjqk.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20181217203718.GA29320@bogus> (Rob Herring's message of "Mon, 17 Dec 2018 14:37:18 -0600")

Rob Herring <robh@kernel.org> writes:

> On Tue, Dec 11, 2018 at 09:43:23PM +0530, Bhagavathi Perumal S wrote:
>> This adds new dt entry ext-fem-name, it is used by ath10k driver
>> to select correct timing parameters and configure it in target wifi hardware.
>> The Front End Module(FEM) normally includes tx power amplifier(PA) and
>> rx low noise amplifier(LNA). The default timing parameters like tx end to
>> PA off timing values were fine tuned for internal FEM used in reference
>> design. And these timing values can not be same if ODM modifies hardware
>> design with different external FEM. This DT entry helps to choose correct
>> timing values in driver if different external FEM hardware used.
>> 
>> Signed-off-by: Bhagavathi Perumal S <bperumal@codeaurora.org>
>> ---
>>  Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt | 9 ++++++++-
>>  1 file changed, 8 insertions(+), 1 deletion(-)
>
> Please add acks/reviewed-bys when posting new versions.

I added your reviewed-by from v3 in the pending branch:

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=2f4f5a81c87b9be68aa087c238e2f2b9debbfa1b

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

  reply	other threads:[~2018-12-20 13:23 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-11 16:13 [PATCH v4 0/3] ath10k: Add support to configure BB timing for external FEM Bhagavathi Perumal S
2018-12-11 16:13 ` Bhagavathi Perumal S
2018-12-11 16:13 ` Bhagavathi Perumal S
2018-12-11 16:13 ` [PATCH v4 1/3] dt-bindings: net: ath10k: fix node name and device type in qcom ath10k example Bhagavathi Perumal S
2018-12-11 16:13   ` Bhagavathi Perumal S
2018-12-11 16:13   ` Bhagavathi Perumal S
2018-12-17 21:44   ` Rob Herring
2018-12-17 21:44     ` Rob Herring
2018-12-17 21:44     ` Rob Herring
2018-12-20 17:10   ` Kalle Valo
2018-12-20 17:10     ` Kalle Valo
2018-12-20 17:10   ` Kalle Valo
2018-12-20 17:10     ` Kalle Valo
2018-12-11 16:13 ` [PATCH v4 2/3] dt-bindings: net: ath10k: add new dt entry to identify external FEM Bhagavathi Perumal S
2018-12-11 16:13   ` Bhagavathi Perumal S
2018-12-11 16:13   ` Bhagavathi Perumal S
2018-12-11 20:07   ` Sebastian Gottschall
     [not found]     ` <5dd13e00175645e495df16858399d678@euamsexm01f.eu.qualcomm.com>
2018-12-12  4:40       ` Bhagavathi Perumal S
2018-12-12  5:52         ` Bhagavathi Perumal S
2018-12-13  9:08     ` Kalle Valo
2018-12-17 20:37   ` Rob Herring
2018-12-17 20:37     ` Rob Herring
2018-12-17 20:37     ` Rob Herring
2018-12-20 13:23     ` Kalle Valo [this message]
2018-12-20 13:23       ` Kalle Valo
2018-12-20 13:23       ` Kalle Valo
2018-12-11 16:13 ` [PATCH v4 3/3] ath10k: Add support to configure BB timing over wmi Bhagavathi Perumal S
2018-12-11 16:13   ` Bhagavathi Perumal S
2018-12-11 16:13   ` Bhagavathi Perumal S

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lg4ktjqk.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@codeaurora.org \
    --cc=ath10k@lists.infradead.org \
    --cc=bperumal@codeaurora.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.