All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux-sh list <linux-sh@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sh: add missing EXPORT_SYMBOL() for __delay
Date: Thu, 12 Dec 2019 23:57:03 +0000	[thread overview]
Message-ID: <87pngt5c8g.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <CAMuHMdWb_ipn7FVHbz8=PTdGod=MW+2xHY7yuq3yJcWwNnDvcg@mail.gmail.com>


Hi Geert

Thank you for your feedback

> > --- a/arch/sh/lib/delay.c
> > +++ b/arch/sh/lib/delay.c
> > @@ -29,6 +29,7 @@ void __delay(unsigned long loops)
> >                 : "0" (loops)
> >                 : "t");
> >  }
> > +EXPORT_SYMBOL(__delay);
> >
> >  inline void __const_udelay(unsigned long xloops)
> >  {
> 
> I believe the correct fix is make drivers/net/phy/mdio-cavium.c use one
> of [nmu]delay() instead.
> 
> Cfr.
> https://lore.kernel.org/lkml/CAMuHMdUERaoHLNKi03zCuYi7NevgBFjXrV=pt0Yy=HOeRiL25Q@mail.gmail.com/

OK, make sense.
I did it because some architecture is using EXPORT_SYMBOL() to __delay.

Thank you for your help !!
Best regards
---
Kuninori Morimoto

WARNING: multiple messages have this Message-ID (diff)
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux-sh list <linux-sh@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sh: add missing EXPORT_SYMBOL() for __delay
Date: 13 Dec 2019 08:57:03 +0900	[thread overview]
Message-ID: <87pngt5c8g.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <CAMuHMdWb_ipn7FVHbz8=PTdGod=MW+2xHY7yuq3yJcWwNnDvcg@mail.gmail.com>


Hi Geert

Thank you for your feedback

> > --- a/arch/sh/lib/delay.c
> > +++ b/arch/sh/lib/delay.c
> > @@ -29,6 +29,7 @@ void __delay(unsigned long loops)
> >                 : "0" (loops)
> >                 : "t");
> >  }
> > +EXPORT_SYMBOL(__delay);
> >
> >  inline void __const_udelay(unsigned long xloops)
> >  {
> 
> I believe the correct fix is make drivers/net/phy/mdio-cavium.c use one
> of [nmu]delay() instead.
> 
> Cfr.
> https://lore.kernel.org/lkml/CAMuHMdUERaoHLNKi03zCuYi7NevgBFjXrV=pt0Yy=HOeRiL25Q@mail.gmail.com/

OK, make sense.
I did it because some architecture is using EXPORT_SYMBOL() to __delay.

Thank you for your help !!
Best regards
---
Kuninori Morimoto

  reply	other threads:[~2019-12-12 23:57 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-12  2:34 [PATCH] sh: add missing EXPORT_SYMBOL() for __delay morimoto
2019-12-12  2:34 ` morimoto
2019-12-12  2:36 ` Kuninori Morimoto
2019-12-12  2:36   ` Kuninori Morimoto
2019-12-12  2:38 ` Kuninori Morimoto
2019-12-12  2:38   ` Kuninori Morimoto
2019-12-12  7:43   ` Geert Uytterhoeven
2019-12-12  7:43     ` Geert Uytterhoeven
2019-12-12 23:57     ` Kuninori Morimoto [this message]
2019-12-12 23:57       ` Kuninori Morimoto
2019-12-16 11:28   ` Yoshinori Sato
2019-12-16 11:28     ` Yoshinori Sato
2020-07-22  2:38   ` Guenter Roeck
2020-07-22  2:38     ` Guenter Roeck
2020-07-22 22:52     ` Rich Felker
2020-07-22 22:52       ` Rich Felker
2020-07-22 23:52       ` Guenter Roeck
2020-07-22 23:52         ` Guenter Roeck
2020-07-24 19:44         ` Rich Felker
2020-07-24 19:44           ` Rich Felker
2020-07-24 23:25           ` Andrew Morton
2020-07-24 23:25             ` Andrew Morton
2020-08-03 10:01         ` Geert Uytterhoeven
2020-08-03 10:01           ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pngt5c8g.wl-kuninori.morimoto.gx@renesas.com \
    --to=kuninori.morimoto.gx@renesas.com \
    --cc=akpm@linux-foundation.org \
    --cc=dalias@libc.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.