From: Rusty Russell <rusty@rustcorp.com.au> To: Anthony Liguori <aliguori@us.ibm.com>, "Michael S. Tsirkin" <mst@redhat.com>, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org Cc: Peter Maydell <peter.maydell@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, KONRAD Frederic <fred.konrad@greensocs.com> Subject: Re: [PATCH RFC] virtio-pci: new config layout: using memory BAR Date: Wed, 29 May 2013 14:01:18 +0930 [thread overview] Message-ID: <87ppwammp5.fsf@rustcorp.com.au> (raw) In-Reply-To: <87bo7vvxej.fsf@codemonkey.ws> Anthony Liguori <aliguori@us.ibm.com> writes: > "Michael S. Tsirkin" <mst@redhat.com> writes: >> + case offsetof(struct virtio_pci_common_cfg, device_feature_select): >> + return proxy->device_feature_select; > > Oh dear no... Please use defines like the rest of QEMU. It is pretty ugly. Yet the structure definitions are descriptive, capturing layout, size and endianness in natural a format readable by any C programmer. So AFAICT the question is, do we put the required #define VIRTIO_PCI_CFG_FEATURE_SEL \ (offsetof(struct virtio_pci_common_cfg, device_feature_select)) etc. in the kernel headers or qemu? > Haven't looked at the proposed new ring layout yet. No change, but there's an open question on whether we should nail it to little endian (or define the endian by the transport). Of course, I can't rule out that the 1.0 standard *may* decide to frob the ring layout somehow, but I'd think it would require a compelling reason. I suggest that's 2.0 material... Cheers, Rusty.
WARNING: multiple messages have this Message-ID (diff)
From: Rusty Russell <rusty@rustcorp.com.au> To: Anthony Liguori <aliguori@us.ibm.com>, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org Cc: Peter Maydell <peter.maydell@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, KONRAD Frederic <fred.konrad@greensocs.com> Subject: Re: [PATCH RFC] virtio-pci: new config layout: using memory BAR Date: Wed, 29 May 2013 14:01:18 +0930 [thread overview] Message-ID: <87ppwammp5.fsf@rustcorp.com.au> (raw) In-Reply-To: <87bo7vvxej.fsf@codemonkey.ws> Anthony Liguori <aliguori@us.ibm.com> writes: > "Michael S. Tsirkin" <mst@redhat.com> writes: >> + case offsetof(struct virtio_pci_common_cfg, device_feature_select): >> + return proxy->device_feature_select; > > Oh dear no... Please use defines like the rest of QEMU. It is pretty ugly. Yet the structure definitions are descriptive, capturing layout, size and endianness in natural a format readable by any C programmer. So AFAICT the question is, do we put the required #define VIRTIO_PCI_CFG_FEATURE_SEL \ (offsetof(struct virtio_pci_common_cfg, device_feature_select)) etc. in the kernel headers or qemu? > Haven't looked at the proposed new ring layout yet. No change, but there's an open question on whether we should nail it to little endian (or define the endian by the transport). Of course, I can't rule out that the 1.0 standard *may* decide to frob the ring layout somehow, but I'd think it would require a compelling reason. I suggest that's 2.0 material... Cheers, Rusty.
next prev parent reply other threads:[~2013-05-29 4:31 UTC|newest] Thread overview: 109+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-05-28 16:03 [PATCH RFC] virtio-pci: new config layout: using memory BAR Michael S. Tsirkin 2013-05-28 17:15 ` Anthony Liguori 2013-05-28 17:15 ` Anthony Liguori 2013-05-28 17:32 ` Michael S. Tsirkin 2013-05-28 17:43 ` Paolo Bonzini 2013-05-29 2:02 ` Laszlo Ersek 2013-05-29 2:02 ` Laszlo Ersek 2013-05-29 4:33 ` Rusty Russell 2013-05-29 4:33 ` Rusty Russell 2013-05-29 7:27 ` Paolo Bonzini 2013-05-29 8:05 ` Michael S. Tsirkin 2013-05-29 10:07 ` Laszlo Ersek 2013-05-28 18:53 ` Anthony Liguori 2013-05-28 19:27 ` Michael S. Tsirkin 2013-05-29 4:31 ` Rusty Russell [this message] 2013-05-29 4:31 ` Rusty Russell 2013-05-29 8:24 ` Michael S. Tsirkin 2013-05-29 8:52 ` Paolo Bonzini 2013-05-29 9:00 ` Peter Maydell 2013-05-29 10:08 ` Michael S. Tsirkin 2013-05-29 10:53 ` Peter Maydell 2013-05-29 12:16 ` Michael S. Tsirkin 2013-05-29 12:28 ` Paolo Bonzini 2013-05-29 12:37 ` Michael S. Tsirkin 2013-05-29 12:52 ` Anthony Liguori 2013-05-29 12:52 ` Anthony Liguori 2013-05-29 13:24 ` Michael S. Tsirkin 2013-05-29 13:35 ` Peter Maydell 2013-05-29 13:35 ` Peter Maydell 2013-05-29 13:41 ` Paolo Bonzini 2013-05-29 14:02 ` Michael S. Tsirkin 2013-05-29 14:18 ` Anthony Liguori 2013-05-29 14:18 ` Anthony Liguori 2013-05-30 7:43 ` Michael S. Tsirkin 2013-05-29 14:16 ` Anthony Liguori 2013-05-29 14:16 ` Anthony Liguori 2013-05-29 14:30 ` Michael S. Tsirkin 2013-05-29 14:32 ` Paolo Bonzini 2013-05-29 14:52 ` Michael S. Tsirkin 2013-05-29 14:55 ` Anthony Liguori 2013-05-29 16:12 ` Michael S. Tsirkin 2013-05-29 18:16 ` Michael S. Tsirkin 2013-05-29 14:55 ` Anthony Liguori 2013-05-30 3:58 ` Rusty Russell 2013-05-30 3:58 ` Rusty Russell 2013-05-30 5:55 ` Michael S. Tsirkin 2013-05-30 7:55 ` Michael S. Tsirkin 2013-06-03 0:17 ` Rusty Russell 2013-05-30 13:53 ` Anthony Liguori 2013-05-30 13:53 ` Anthony Liguori 2013-05-30 14:01 ` Michael S. Tsirkin 2013-06-03 0:26 ` Rusty Russell 2013-06-03 10:11 ` Michael S. Tsirkin 2013-06-04 5:31 ` Rusty Russell 2013-06-04 6:42 ` Michael S. Tsirkin 2013-06-05 7:19 ` Rusty Russell 2013-06-05 10:22 ` Michael S. Tsirkin 2013-06-05 12:59 ` Anthony Liguori 2013-06-05 14:09 ` Michael S. Tsirkin 2013-06-05 15:08 ` Anthony Liguori 2013-06-05 15:19 ` Michael S. Tsirkin 2013-06-05 15:46 ` Anthony Liguori 2013-06-05 15:46 ` Anthony Liguori 2013-06-05 16:20 ` Michael S. Tsirkin 2013-06-05 18:57 ` Anthony Liguori 2013-06-05 19:43 ` Michael S. Tsirkin 2013-06-05 19:52 ` Michael S. Tsirkin 2013-06-05 20:45 ` Anthony Liguori 2013-06-05 21:15 ` H. Peter Anvin 2013-06-05 21:15 ` Michael S. Tsirkin 2013-06-05 20:42 ` Anthony Liguori 2013-06-05 21:14 ` Michael S. Tsirkin 2013-06-05 21:53 ` Anthony Liguori 2013-06-05 21:53 ` Anthony Liguori 2013-06-05 22:19 ` Benjamin Herrenschmidt 2013-06-05 22:53 ` Anthony Liguori 2013-06-05 23:27 ` Benjamin Herrenschmidt 2013-06-05 19:54 ` Michael S. Tsirkin 2013-06-06 3:42 ` Rusty Russell 2013-06-06 14:59 ` Anthony Liguori 2013-06-07 1:58 ` Rusty Russell 2013-06-07 8:25 ` Peter Maydell 2013-06-05 21:10 ` H. Peter Anvin 2013-06-05 21:17 ` Michael S. Tsirkin 2013-06-05 21:50 ` Anthony Liguori 2013-06-05 21:55 ` H. Peter Anvin 2013-06-05 22:08 ` Anthony Liguori 2013-06-05 23:07 ` H. Peter Anvin 2013-06-06 0:41 ` Anthony Liguori 2013-06-06 6:34 ` Gleb Natapov 2013-06-06 13:53 ` H. Peter Anvin 2013-06-06 15:02 ` Anthony Liguori 2013-06-07 11:30 ` Gleb Natapov 2013-06-11 7:10 ` Michael S. Tsirkin 2013-06-11 7:53 ` Gleb Natapov 2013-06-11 8:02 ` Michael S. Tsirkin 2013-06-11 8:03 ` Gleb Natapov 2013-06-11 8:19 ` Michael S. Tsirkin 2013-06-11 8:22 ` Gleb Natapov 2013-06-11 8:30 ` Michael S. Tsirkin 2013-06-11 8:32 ` Gleb Natapov 2013-06-11 8:04 ` Michael S. Tsirkin 2013-06-06 15:02 ` Anthony Liguori 2013-06-06 15:06 ` Gerd Hoffmann 2013-06-06 15:10 ` Gleb Natapov 2013-06-06 15:19 ` H. Peter Anvin 2013-06-06 15:22 ` Gerd Hoffmann 2013-07-08 4:25 ` Kevin O'Connor 2013-06-06 8:02 ` Michael S. Tsirkin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87ppwammp5.fsf@rustcorp.com.au \ --to=rusty@rustcorp.com.au \ --cc=aliguori@us.ibm.com \ --cc=fred.konrad@greensocs.com \ --cc=kvm@vger.kernel.org \ --cc=mst@redhat.com \ --cc=pbonzini@redhat.com \ --cc=peter.maydell@linaro.org \ --cc=stefanha@redhat.com \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.