From: Jani Nikula <jani.nikula@intel.com>
To: Matt Roper <matthew.d.roper@intel.com>,
Dan Carpenter <dan.carpenter@oracle.com>
Cc: "David Airlie" <airlied@linux.ie>,
kernel-janitors@vger.kernel.org,
"Lucas De Marchi" <lucas.demarchi@intel.com>,
"José Roberto de Souza" <jose.souza@intel.com>,
dri-devel@lists.freedesktop.org,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/bios: fix off by one in parse_generic_dtd()
Date: Fri, 13 Dec 2019 07:10:58 +0000 [thread overview]
Message-ID: <87r2181z0d.fsf@intel.com> (raw)
In-Reply-To: <20191212172707.GF85422@mdroper-desk1.amr.corp.intel.com>
On Thu, 12 Dec 2019, Matt Roper <matthew.d.roper@intel.com> wrote:
> On Thu, Dec 12, 2019 at 12:11:30PM +0300, Dan Carpenter wrote:
>> The "num_dtd" variable is the number of elements in the
>> generic_dtd->dtd[] array so the > needs to be >= to prevent reading one
>> element beyond the end of the array.
>>
>> Fixes: 33ef6d4fd8df ("drm/i915/vbt: Handle generic DTD block")
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Pushed to drm-intel-next-queued, thanks for the patch and review.
BR,
Jani.
>
>> ---
>> drivers/gpu/drm/i915/display/intel_bios.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
>> index 1aeecdd02293..d1e27ee86e53 100644
>> --- a/drivers/gpu/drm/i915/display/intel_bios.c
>> +++ b/drivers/gpu/drm/i915/display/intel_bios.c
>> @@ -338,7 +338,7 @@ parse_generic_dtd(struct drm_i915_private *dev_priv,
>>
>> num_dtd = (get_blocksize(generic_dtd) -
>> sizeof(struct bdb_generic_dtd)) / generic_dtd->gdtd_size;
>> - if (dev_priv->vbt.panel_type > num_dtd) {
>> + if (dev_priv->vbt.panel_type >= num_dtd) {
>> DRM_ERROR("Panel type %d not found in table of %d DTD's\n",
>> dev_priv->vbt.panel_type, num_dtd);
>> return;
>> --
>> 2.11.0
>>
--
Jani Nikula, Intel Open Source Graphics Center
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@intel.com>
To: Matt Roper <matthew.d.roper@intel.com>,
Dan Carpenter <dan.carpenter@oracle.com>
Cc: "David Airlie" <airlied@linux.ie>,
kernel-janitors@vger.kernel.org,
"Lucas De Marchi" <lucas.demarchi@intel.com>,
"José Roberto de Souza" <jose.souza@intel.com>,
dri-devel@lists.freedesktop.org,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/bios: fix off by one in parse_generic_dtd()
Date: Fri, 13 Dec 2019 09:10:58 +0200 [thread overview]
Message-ID: <87r2181z0d.fsf@intel.com> (raw)
In-Reply-To: <20191212172707.GF85422@mdroper-desk1.amr.corp.intel.com>
On Thu, 12 Dec 2019, Matt Roper <matthew.d.roper@intel.com> wrote:
> On Thu, Dec 12, 2019 at 12:11:30PM +0300, Dan Carpenter wrote:
>> The "num_dtd" variable is the number of elements in the
>> generic_dtd->dtd[] array so the > needs to be >= to prevent reading one
>> element beyond the end of the array.
>>
>> Fixes: 33ef6d4fd8df ("drm/i915/vbt: Handle generic DTD block")
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Pushed to drm-intel-next-queued, thanks for the patch and review.
BR,
Jani.
>
>> ---
>> drivers/gpu/drm/i915/display/intel_bios.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
>> index 1aeecdd02293..d1e27ee86e53 100644
>> --- a/drivers/gpu/drm/i915/display/intel_bios.c
>> +++ b/drivers/gpu/drm/i915/display/intel_bios.c
>> @@ -338,7 +338,7 @@ parse_generic_dtd(struct drm_i915_private *dev_priv,
>>
>> num_dtd = (get_blocksize(generic_dtd) -
>> sizeof(struct bdb_generic_dtd)) / generic_dtd->gdtd_size;
>> - if (dev_priv->vbt.panel_type > num_dtd) {
>> + if (dev_priv->vbt.panel_type >= num_dtd) {
>> DRM_ERROR("Panel type %d not found in table of %d DTD's\n",
>> dev_priv->vbt.panel_type, num_dtd);
>> return;
>> --
>> 2.11.0
>>
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@intel.com>
To: Matt Roper <matthew.d.roper@intel.com>,
Dan Carpenter <dan.carpenter@oracle.com>
Cc: David Airlie <airlied@linux.ie>,
kernel-janitors@vger.kernel.org,
Lucas De Marchi <lucas.demarchi@intel.com>,
dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/bios: fix off by one in parse_generic_dtd()
Date: Fri, 13 Dec 2019 09:10:58 +0200 [thread overview]
Message-ID: <87r2181z0d.fsf@intel.com> (raw)
In-Reply-To: <20191212172707.GF85422@mdroper-desk1.amr.corp.intel.com>
On Thu, 12 Dec 2019, Matt Roper <matthew.d.roper@intel.com> wrote:
> On Thu, Dec 12, 2019 at 12:11:30PM +0300, Dan Carpenter wrote:
>> The "num_dtd" variable is the number of elements in the
>> generic_dtd->dtd[] array so the > needs to be >= to prevent reading one
>> element beyond the end of the array.
>>
>> Fixes: 33ef6d4fd8df ("drm/i915/vbt: Handle generic DTD block")
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Pushed to drm-intel-next-queued, thanks for the patch and review.
BR,
Jani.
>
>> ---
>> drivers/gpu/drm/i915/display/intel_bios.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
>> index 1aeecdd02293..d1e27ee86e53 100644
>> --- a/drivers/gpu/drm/i915/display/intel_bios.c
>> +++ b/drivers/gpu/drm/i915/display/intel_bios.c
>> @@ -338,7 +338,7 @@ parse_generic_dtd(struct drm_i915_private *dev_priv,
>>
>> num_dtd = (get_blocksize(generic_dtd) -
>> sizeof(struct bdb_generic_dtd)) / generic_dtd->gdtd_size;
>> - if (dev_priv->vbt.panel_type > num_dtd) {
>> + if (dev_priv->vbt.panel_type >= num_dtd) {
>> DRM_ERROR("Panel type %d not found in table of %d DTD's\n",
>> dev_priv->vbt.panel_type, num_dtd);
>> return;
>> --
>> 2.11.0
>>
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-12-13 7:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 9:11 [PATCH] drm/i915/bios: fix off by one in parse_generic_dtd() Dan Carpenter
2019-12-12 9:11 ` [Intel-gfx] " Dan Carpenter
2019-12-12 9:11 ` Dan Carpenter
2019-12-12 12:53 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2019-12-12 17:27 ` [PATCH] " Matt Roper
2019-12-12 17:27 ` [Intel-gfx] " Matt Roper
2019-12-12 17:27 ` Matt Roper
2019-12-13 7:10 ` Jani Nikula [this message]
2019-12-13 7:10 ` [Intel-gfx] " Jani Nikula
2019-12-13 7:10 ` Jani Nikula
2019-12-13 1:40 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2181z0d.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=airlied@linux.ie \
--cc=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jose.souza@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=matthew.d.roper@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.