All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/bios: fix off by one in parse_generic_dtd()
@ 2019-12-12  9:11 ` Dan Carpenter
  0 siblings, 0 replies; 11+ messages in thread
From: Dan Carpenter @ 2019-12-12  9:11 UTC (permalink / raw)
  To: Jani Nikula, Matt Roper
  Cc: David Airlie, kernel-janitors, Lucas De Marchi,
	José Roberto de Souza, dri-devel, Rodrigo Vivi, intel-gfx

The "num_dtd" variable is the number of elements in the
generic_dtd->dtd[] array so the > needs to be >= to prevent reading one
element beyond the end of the array.

Fixes: 33ef6d4fd8df ("drm/i915/vbt: Handle generic DTD block")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/gpu/drm/i915/display/intel_bios.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
index 1aeecdd02293..d1e27ee86e53 100644
--- a/drivers/gpu/drm/i915/display/intel_bios.c
+++ b/drivers/gpu/drm/i915/display/intel_bios.c
@@ -338,7 +338,7 @@ parse_generic_dtd(struct drm_i915_private *dev_priv,
 
 	num_dtd = (get_blocksize(generic_dtd) -
 		   sizeof(struct bdb_generic_dtd)) / generic_dtd->gdtd_size;
-	if (dev_priv->vbt.panel_type > num_dtd) {
+	if (dev_priv->vbt.panel_type >= num_dtd) {
 		DRM_ERROR("Panel type %d not found in table of %d DTD's\n",
 			  dev_priv->vbt.panel_type, num_dtd);
 		return;
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2019-12-13  7:11 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-12  9:11 [PATCH] drm/i915/bios: fix off by one in parse_generic_dtd() Dan Carpenter
2019-12-12  9:11 ` [Intel-gfx] " Dan Carpenter
2019-12-12  9:11 ` Dan Carpenter
2019-12-12 12:53 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2019-12-12 17:27 ` [PATCH] " Matt Roper
2019-12-12 17:27   ` [Intel-gfx] " Matt Roper
2019-12-12 17:27   ` Matt Roper
2019-12-13  7:10   ` Jani Nikula
2019-12-13  7:10     ` [Intel-gfx] " Jani Nikula
2019-12-13  7:10     ` Jani Nikula
2019-12-13  1:40 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.