All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@kernel.org>
To: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	"linux-usb\@vger.kernel.org" <linux-usb@vger.kernel.org>
Cc: John Youn <John.Youn@synopsys.com>,
	"stable\@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH 2/3] usb: dwc3: gadget: Fix early exit in set/clear ep halt
Date: Fri, 02 Jun 2017 11:24:53 +0300	[thread overview]
Message-ID: <87r2z2vlt6.fsf@linux.intel.com> (raw)
In-Reply-To: <30102591E157244384E984126FC3CB4F30071006@us01wembx1.internal.synopsys.com>

[-- Attachment #1: Type: text/plain, Size: 1062 bytes --]


Hi,

Thinh Nguyen <Thinh.Nguyen@synopsys.com> writes:
>>>>> this could be, I don't remember if I checked this or not :-)
>>>>>
>>>>> Really, the best way here, IMHO, would be to re-verify what's going on
>>>>> with macOS and revert my orignal patch since it's, rather clearly,
>>>>> wrong.
>>>>>
>>>>
>>>> Sure. Are you going to make a revert patch or I am?
>>>
>>> Well, after we really know what's going on with macOS and have a better
>>> fix, then who makes the revert is less important as long as problems get
>>> sorted out :-) Either way is fine for me.
>>>
>> 
>> Do you have any update on this issue?
>> 
>
> The patch ffb80fc672c3 ("usb: dwc3: gadget: skip Set/Clear Halt when 
> invalid") still causes a regression for us. As there hasn't any update 
> for the macOS issue, can I submit a revert patch for this?

I just came back from vacations ;-) I'll get back to this. Reverting
that commit won't do any good as we'd be exchanging one regression for
another. We really need to understand what's going on.

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

      reply	other threads:[~2017-06-02  8:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <a994bd6ad75720559bd43b7c777b3135dfef9d50.1491609187.git.thinhn@synopsys.com>
2017-04-07 23:57 ` [PATCH 2/3] usb: dwc3: gadget: Fix early exit in set/clear ep halt Thinh Nguyen
2017-04-10  7:01   ` Felipe Balbi
2017-04-10  7:03     ` Felipe Balbi
2017-04-11  3:21       ` Thinh Nguyen
2017-04-11  7:35         ` Felipe Balbi
2017-04-11 23:06           ` Thinh Nguyen
2017-04-12  6:02             ` Felipe Balbi
2017-05-12  1:12               ` Thinh Nguyen
2017-05-23 20:35                 ` Thinh Nguyen
2017-06-02  8:24                   ` Felipe Balbi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r2z2vlt6.fsf@linux.intel.com \
    --to=balbi@kernel.org \
    --cc=John.Youn@synopsys.com \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.