From: Gregory CLEMENT <gregory.clement@free-electrons.com> To: Mark Rutland <mark.rutland@arm.com> Cc: Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>, Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>, arm@kernel.org, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, Jonathan Corbet <corbet@lwn.net>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jiri Slaby <jslaby@suse.com>, linux-serial@vger.kernel.org, Tejun Heo <tj@kernel.org>, Hans de Goede <hdegoede@redhat.com>, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Thomas Petazzoni <thomas.petazzoni@free-electrons.com>, linux-arm-kernel@lists.infradead.org, Wilson Ding <dingwei@marvell.com>, Nadav Haklai <nadavh@marvell.com> Subject: Re: [PATCH 01/10] serial: mvebu-uart: initial support for Armada-3700 serial port Date: Wed, 03 Feb 2016 17:32:41 +0100 [thread overview] Message-ID: <87r3gt4uvq.fsf@free-electrons.com> (raw) In-Reply-To: <20160202182842.GD29778@leverpostej> (Mark Rutland's message of "Tue, 2 Feb 2016 18:28:42 +0000") Hi Mark, On mar., févr. 02 2016, Mark Rutland <mark.rutland@arm.com> wrote: > On Tue, Feb 02, 2016 at 07:07:39PM +0100, Gregory CLEMENT wrote: >> From: Wilson Ding <dingwei@marvell.com> >> >> Armada-3700's uart is a simple serial port, which doesn't >> support. Configuring the modem control lines. The uart port has a 32 >> bytes Tx FIFO and a 64 bytes Rx FIFO >> >> The uart driver implements the uart core operations. It also support the >> system (early) console based on Armada-3700's serial port. >> >> Known Issue: >> >> The uart driver currently doesn't support clock programming, which means >> the baud-rate stays with the default value configured by the bootloader >> at boot time > > To ensure that the bootloader and kernel match, it's best to place the > rate in the stdout-path property (as in > Documentation/devicetree/bindings/chosen.txt). > > Presumably that is what you want? It is done in patch 7. > > Is it difficutl to add clock programming? Currently there is no clock tree support before adding it I would like to be able to test it. Thanks, Gregory > >> >> [gregory.clement@free-electrons.com: Rewrite many part which are too long >> to enumerate] >> >> Signed-off-by: Wilson Ding <dingwei@marvell.com> >> Signed-off-by: Nadav Haklai <nadavh@marvell.com> >> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com> >> --- >> .../devicetree/bindings/tty/serial/mvebu-uart.txt | 13 + >> Documentation/kernel-parameters.txt | 6 + >> drivers/tty/serial/Kconfig | 22 + >> drivers/tty/serial/Makefile | 1 + >> drivers/tty/serial/mvebu-uart.c | 649 +++++++++++++++++++++ >> include/uapi/linux/serial_core.h | 3 + >> 6 files changed, 694 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/tty/serial/mvebu-uart.txt >> create mode 100644 drivers/tty/serial/mvebu-uart.c >> >> diff --git a/Documentation/devicetree/bindings/tty/serial/mvebu-uart.txt b/Documentation/devicetree/bindings/tty/serial/mvebu-uart.txt >> new file mode 100644 >> index 000000000000..6087defd9f93 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/tty/serial/mvebu-uart.txt >> @@ -0,0 +1,13 @@ >> +* Marvell UART : Non standard UART used in some of Marvell EBU SoCs (e.g., Armada-3700) >> + >> +Required properties: >> +- compatible: "marvell,armada-3700-uart" >> +- reg: offset and length of the register set for the device. >> +- interrupts: device interrupt >> + >> +Example: >> + serial@12000 { >> + compatible = "marvell,armada-3700-uart"; >> + reg = <0x12000 0x400>; >> + interrupts = <43>; >> + }; > > There are no external clock inputs? > >> diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt >> index 87d40a72f6a1..198f6bd56e84 100644 >> --- a/Documentation/kernel-parameters.txt >> +++ b/Documentation/kernel-parameters.txt >> @@ -1058,6 +1058,12 @@ bytes respectively. Such letter suffixes can also be entirely omitted. >> A valid base address must be provided, and the serial >> port must already be setup and configured. >> >> + mvebu_uart,<addr> >> + Start an early, polled-mode console on an some mvebu >> + SoC (as the Armada-3700) serial port at the specified >> + address. The serial port must already be setup and >> + configured. Options are not yet supported. >> + > > Does the the mvebu UART vary between platforms at all? > > Thanks, > Mark. -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: gregory.clement@free-electrons.com (Gregory CLEMENT) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 01/10] serial: mvebu-uart: initial support for Armada-3700 serial port Date: Wed, 03 Feb 2016 17:32:41 +0100 [thread overview] Message-ID: <87r3gt4uvq.fsf@free-electrons.com> (raw) In-Reply-To: <20160202182842.GD29778@leverpostej> (Mark Rutland's message of "Tue, 2 Feb 2016 18:28:42 +0000") Hi Mark, On mar., f?vr. 02 2016, Mark Rutland <mark.rutland@arm.com> wrote: > On Tue, Feb 02, 2016 at 07:07:39PM +0100, Gregory CLEMENT wrote: >> From: Wilson Ding <dingwei@marvell.com> >> >> Armada-3700's uart is a simple serial port, which doesn't >> support. Configuring the modem control lines. The uart port has a 32 >> bytes Tx FIFO and a 64 bytes Rx FIFO >> >> The uart driver implements the uart core operations. It also support the >> system (early) console based on Armada-3700's serial port. >> >> Known Issue: >> >> The uart driver currently doesn't support clock programming, which means >> the baud-rate stays with the default value configured by the bootloader >> at boot time > > To ensure that the bootloader and kernel match, it's best to place the > rate in the stdout-path property (as in > Documentation/devicetree/bindings/chosen.txt). > > Presumably that is what you want? It is done in patch 7. > > Is it difficutl to add clock programming? Currently there is no clock tree support before adding it I would like to be able to test it. Thanks, Gregory > >> >> [gregory.clement at free-electrons.com: Rewrite many part which are too long >> to enumerate] >> >> Signed-off-by: Wilson Ding <dingwei@marvell.com> >> Signed-off-by: Nadav Haklai <nadavh@marvell.com> >> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com> >> --- >> .../devicetree/bindings/tty/serial/mvebu-uart.txt | 13 + >> Documentation/kernel-parameters.txt | 6 + >> drivers/tty/serial/Kconfig | 22 + >> drivers/tty/serial/Makefile | 1 + >> drivers/tty/serial/mvebu-uart.c | 649 +++++++++++++++++++++ >> include/uapi/linux/serial_core.h | 3 + >> 6 files changed, 694 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/tty/serial/mvebu-uart.txt >> create mode 100644 drivers/tty/serial/mvebu-uart.c >> >> diff --git a/Documentation/devicetree/bindings/tty/serial/mvebu-uart.txt b/Documentation/devicetree/bindings/tty/serial/mvebu-uart.txt >> new file mode 100644 >> index 000000000000..6087defd9f93 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/tty/serial/mvebu-uart.txt >> @@ -0,0 +1,13 @@ >> +* Marvell UART : Non standard UART used in some of Marvell EBU SoCs (e.g., Armada-3700) >> + >> +Required properties: >> +- compatible: "marvell,armada-3700-uart" >> +- reg: offset and length of the register set for the device. >> +- interrupts: device interrupt >> + >> +Example: >> + serial at 12000 { >> + compatible = "marvell,armada-3700-uart"; >> + reg = <0x12000 0x400>; >> + interrupts = <43>; >> + }; > > There are no external clock inputs? > >> diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt >> index 87d40a72f6a1..198f6bd56e84 100644 >> --- a/Documentation/kernel-parameters.txt >> +++ b/Documentation/kernel-parameters.txt >> @@ -1058,6 +1058,12 @@ bytes respectively. Such letter suffixes can also be entirely omitted. >> A valid base address must be provided, and the serial >> port must already be setup and configured. >> >> + mvebu_uart,<addr> >> + Start an early, polled-mode console on an some mvebu >> + SoC (as the Armada-3700) serial port at the specified >> + address. The serial port must already be setup and >> + configured. Options are not yet supported. >> + > > Does the the mvebu UART vary between platforms at all? > > Thanks, > Mark. -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
next prev parent reply other threads:[~2016-02-03 16:32 UTC|newest] Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-02-02 18:07 [PATCH 00/10] Add support for the Armada 3700 SoC an mvebu ARM64 based Gregory CLEMENT 2016-02-02 18:07 ` Gregory CLEMENT 2016-02-02 18:07 ` [PATCH 01/10] serial: mvebu-uart: initial support for Armada-3700 serial port Gregory CLEMENT 2016-02-02 18:07 ` Gregory CLEMENT 2016-02-02 18:19 ` Mark Rutland 2016-02-02 18:19 ` Mark Rutland 2016-02-02 18:21 ` Mark Rutland 2016-02-02 18:21 ` Mark Rutland 2016-02-02 18:19 ` One Thousand Gnomes 2016-02-02 18:19 ` One Thousand Gnomes 2016-02-03 15:58 ` Gregory CLEMENT 2016-02-03 15:58 ` Gregory CLEMENT 2016-02-02 18:28 ` Mark Rutland 2016-02-02 18:28 ` Mark Rutland 2016-02-02 18:28 ` Mark Rutland 2016-02-03 16:32 ` Gregory CLEMENT [this message] 2016-02-03 16:32 ` Gregory CLEMENT 2016-02-03 16:56 ` Gregory CLEMENT 2016-02-03 16:56 ` Gregory CLEMENT [not found] ` <87egct4trb.fsf-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> 2016-02-03 17:05 ` Mark Rutland 2016-02-03 17:05 ` Mark Rutland 2016-02-03 17:05 ` Mark Rutland 2016-02-02 21:07 ` Arnd Bergmann 2016-02-02 21:07 ` Arnd Bergmann 2016-02-03 16:36 ` Gregory CLEMENT 2016-02-03 16:36 ` Gregory CLEMENT 2016-02-03 16:36 ` Gregory CLEMENT 2016-02-02 21:19 ` Rob Herring 2016-02-02 21:19 ` Rob Herring 2016-02-03 8:05 ` Marcin Wojtas 2016-02-03 8:05 ` Marcin Wojtas 2016-02-03 8:05 ` Marcin Wojtas 2016-02-03 16:43 ` Gregory CLEMENT 2016-02-03 16:43 ` Gregory CLEMENT 2016-02-03 16:43 ` Gregory CLEMENT 2016-02-02 18:07 ` [PATCH 02/10] ata: ahci_mvebu: add support for Armada 3700 variant Gregory CLEMENT 2016-02-02 18:07 ` Gregory CLEMENT 2016-02-02 18:07 ` Gregory CLEMENT 2016-02-02 18:07 ` [PATCH 03/10] arm64: add Armada 3700 architecture entry Gregory CLEMENT 2016-02-02 18:07 ` Gregory CLEMENT 2016-02-02 18:07 ` Gregory CLEMENT 2016-02-03 6:24 ` Jisheng Zhang 2016-02-03 6:24 ` Jisheng Zhang 2016-02-03 6:24 ` Jisheng Zhang 2016-02-03 7:55 ` Gregory CLEMENT 2016-02-03 7:55 ` Gregory CLEMENT 2016-02-03 7:55 ` Gregory CLEMENT [not found] ` <87k2mm5itx.fsf-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> 2016-02-03 9:11 ` Arnd Bergmann 2016-02-03 9:11 ` Arnd Bergmann 2016-02-03 9:11 ` Arnd Bergmann 2016-02-03 11:13 ` Gregory CLEMENT 2016-02-03 11:13 ` Gregory CLEMENT 2016-02-02 18:07 ` [PATCH 04/10] Documentation: dt-bindings: Add a new compatible for the Armada 3700 Gregory CLEMENT 2016-02-02 18:07 ` Gregory CLEMENT 2016-02-02 18:07 ` Gregory CLEMENT 2016-02-02 21:20 ` Rob Herring 2016-02-02 21:20 ` Rob Herring 2016-02-02 18:07 ` [PATCH 05/10] Documentation: dt: Tidy up the Marvell related files Gregory CLEMENT 2016-02-02 18:07 ` Gregory CLEMENT [not found] ` <1454436468-4241-6-git-send-email-gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> 2016-02-02 21:26 ` Rob Herring 2016-02-02 21:26 ` Rob Herring 2016-02-02 21:26 ` Rob Herring 2016-02-02 18:07 ` [PATCH 06/10] devicetree: bindings: add DT binding for the Marvell Armada 3700 SoC family Gregory CLEMENT 2016-02-02 18:07 ` Gregory CLEMENT [not found] ` <1454436468-4241-7-git-send-email-gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> 2016-02-02 21:24 ` Rob Herring 2016-02-02 21:24 ` Rob Herring 2016-02-02 21:24 ` Rob Herring 2016-02-03 8:02 ` Gregory CLEMENT 2016-02-03 8:02 ` Gregory CLEMENT 2016-02-03 8:02 ` Gregory CLEMENT 2016-02-02 18:07 ` [PATCH 07/10] arm64: dts: add the Marvell Armada 3700 family and a development board Gregory CLEMENT 2016-02-02 18:07 ` Gregory CLEMENT 2016-02-02 18:34 ` Mark Rutland 2016-02-02 18:34 ` Mark Rutland 2016-02-03 10:44 ` Gregory CLEMENT 2016-02-03 10:44 ` Gregory CLEMENT 2016-02-03 6:37 ` Jisheng Zhang 2016-02-03 6:37 ` Jisheng Zhang 2016-02-03 6:37 ` Jisheng Zhang 2016-02-02 18:07 ` [PATCH 08/10] MAINTAINERS: Extend dts entry for ARM64 mvebu files Gregory CLEMENT 2016-02-02 18:07 ` Gregory CLEMENT 2016-02-02 18:07 ` [PATCH 09/10] Documentation: arm: update supported Marvell EBU processors Gregory CLEMENT 2016-02-02 18:07 ` Gregory CLEMENT 2016-02-02 18:07 ` [PATCH 10/10] arm64: defconfig: enable Armada 3700 related config Gregory CLEMENT 2016-02-02 18:07 ` Gregory CLEMENT
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87r3gt4uvq.fsf@free-electrons.com \ --to=gregory.clement@free-electrons.com \ --cc=andrew@lunn.ch \ --cc=arm@kernel.org \ --cc=catalin.marinas@arm.com \ --cc=corbet@lwn.net \ --cc=devicetree@vger.kernel.org \ --cc=dingwei@marvell.com \ --cc=gregkh@linuxfoundation.org \ --cc=hdegoede@redhat.com \ --cc=jason@lakedaemon.net \ --cc=jslaby@suse.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-ide@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-serial@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=nadavh@marvell.com \ --cc=sebastian.hesselbarth@gmail.com \ --cc=thomas.petazzoni@free-electrons.com \ --cc=tj@kernel.org \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.