All of lore.kernel.org
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Josef Bacik <jbacik@fb.com>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
	<linux-fsdevel@vger.kernel.org>
Subject: Re: find_fh_dentry returned a DISCONNECTED directory
Date: Fri, 14 Feb 2014 09:11:35 -0800	[thread overview]
Message-ID: <87r475sjp4.fsf@xmission.com> (raw)
In-Reply-To: <52FE4681.40901@fb.com> (Josef Bacik's message of "Fri, 14 Feb 2014 11:38:25 -0500")

Josef Bacik <jbacik@fb.com> writes:

> Ok using d_make_root makes us leak inodes on umount (I don't know why,
> I'm not drunk enough yet.)  I haven't tried it yet but I'm almost 100%
> positive if I just clear out DISCONNECTED we will BUG_ON() in
> d_splice_alias() when we go to walk into the subvol we've mounted with
> the default subvol option.  So what I think I need to do is use use
> d_materialise_unique in our lookup function instead of
> d_splice_alias() and keep using d_obtain_alias() in get_default_root()
> and just clear DISOCONNECTED on success.  Does this sound crazy to
> anybody else?  Thanks,

That sounds exactly right.

Eric

  parent reply	other threads:[~2014-02-14 17:11 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-13 21:27 find_fh_dentry returned a DISCONNECTED directory J. Bruce Fields
2014-02-13 23:45 ` Eric W. Biederman
2014-02-14  3:30   ` J. Bruce Fields
2014-02-14  4:25     ` Eric W. Biederman
2014-02-14 14:46       ` J. Bruce Fields
2014-02-14 15:49         ` Eric W. Biederman
2014-02-14 16:14           ` J. Bruce Fields
2014-02-14 16:38             ` Josef Bacik
2014-02-14 16:45               ` J. Bruce Fields
2014-02-14 17:02                 ` Josef Bacik
2014-02-14 17:14                   ` Eric W. Biederman
2014-02-14 17:11               ` Eric W. Biederman [this message]
2014-02-14 17:02             ` Eric W. Biederman
2014-02-14 22:19               ` J. Bruce Fields
2014-02-14 22:41                 ` J. Bruce Fields
2014-02-14 14:17     ` Josef Bacik
2014-02-14 15:13     ` Josef Bacik
2014-02-14 15:38       ` J. Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r475sjp4.fsf@xmission.com \
    --to=ebiederm@xmission.com \
    --cc=bfields@fieldses.org \
    --cc=jbacik@fb.com \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.