From: Thomas Gleixner <tglx@linutronix.de>
To: Rob Herring <robh@kernel.org>
Cc: Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Jonathan Corbet <corbet@lwn.net>,
Catalin Marinas <catalin.marinas@arm.com>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v12 2/5] perf: Add a counter for number of user access events in context
Date: Sat, 04 Dec 2021 15:23:39 +0100 [thread overview]
Message-ID: <87sfv84ff8.ffs@tglx> (raw)
In-Reply-To: <CAL_JsqJ9kkch_SB6LT_fwxk9QS36zbwsj5wu+dtY7yWe6SEMug@mail.gmail.com>
On Fri, Dec 03 2021 at 09:58, Rob Herring wrote:
> On Tue, Nov 30, 2021 at 4:57 PM Thomas Gleixner <tglx@linutronix.de> wrote:
> I've rewritten it like this:
>
> On arm64, user space counter access will be controlled differently
> compared to x86. On x86, access in the strictest mode is enabled for all
> tasks in an MM when any event is mmap'ed. For arm64, access is
> explicitly requested for an event and only enabled when the event's
> context is active. This avoids hooks into the arch context switch code
> and gives better control of when access is enabled.
>
> In order to configure user space access when the PMU is enabled, it is
> necessary to know if any event (currently active or not) in the current
> context has user space accessed enabled. Add a counter similar to other
> counters in the context to avoid walking the event list every time.
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Gleixner <tglx@linutronix.de>
To: Rob Herring <robh@kernel.org>
Cc: Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Jonathan Corbet <corbet@lwn.net>,
Catalin Marinas <catalin.marinas@arm.com>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v12 2/5] perf: Add a counter for number of user access events in context
Date: Sat, 04 Dec 2021 15:23:39 +0100 [thread overview]
Message-ID: <87sfv84ff8.ffs@tglx> (raw)
In-Reply-To: <CAL_JsqJ9kkch_SB6LT_fwxk9QS36zbwsj5wu+dtY7yWe6SEMug@mail.gmail.com>
On Fri, Dec 03 2021 at 09:58, Rob Herring wrote:
> On Tue, Nov 30, 2021 at 4:57 PM Thomas Gleixner <tglx@linutronix.de> wrote:
> I've rewritten it like this:
>
> On arm64, user space counter access will be controlled differently
> compared to x86. On x86, access in the strictest mode is enabled for all
> tasks in an MM when any event is mmap'ed. For arm64, access is
> explicitly requested for an event and only enabled when the event's
> context is active. This avoids hooks into the arch context switch code
> and gives better control of when access is enabled.
>
> In order to configure user space access when the PMU is enabled, it is
> necessary to know if any event (currently active or not) in the current
> context has user space accessed enabled. Add a counter similar to other
> counters in the context to avoid walking the event list every time.
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-12-04 14:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 20:16 [PATCH v12 0/5] Another version of arm64 userspace counter access support Rob Herring
2021-10-27 20:16 ` Rob Herring
2021-10-27 20:16 ` [PATCH v12 1/5] x86: perf: Move RDPMC event flag to a common definition Rob Herring
2021-10-27 20:16 ` Rob Herring
2021-11-30 22:51 ` Thomas Gleixner
2021-11-30 22:51 ` Thomas Gleixner
2021-10-27 20:16 ` [PATCH v12 2/5] perf: Add a counter for number of user access events in context Rob Herring
2021-10-27 20:16 ` Rob Herring
2021-11-30 22:57 ` Thomas Gleixner
2021-11-30 22:57 ` Thomas Gleixner
2021-12-03 15:58 ` Rob Herring
2021-12-03 15:58 ` Rob Herring
2021-12-04 14:23 ` Thomas Gleixner [this message]
2021-12-04 14:23 ` Thomas Gleixner
2021-10-27 20:16 ` [PATCH v12 3/5] arm64: perf: Add userspace counter access disable switch Rob Herring
2021-10-27 20:16 ` Rob Herring
2021-10-27 20:16 ` [PATCH v12 4/5] arm64: perf: Enable PMU counter userspace access for perf event Rob Herring
2021-10-27 20:16 ` Rob Herring
2021-10-27 20:16 ` [PATCH v12 5/5] Documentation: arm64: Document PMU counters access from userspace Rob Herring
2021-10-27 20:16 ` Rob Herring
2021-11-15 16:57 ` [PATCH v12 0/5] Another version of arm64 userspace counter access support Rob Herring
2021-11-15 16:57 ` Rob Herring
2021-11-30 21:56 ` Rob Herring
2021-11-30 21:56 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfv84ff8.ffs@tglx \
--to=tglx@linutronix.de \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=robh@kernel.org \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.