From: "Toke Høiland-Jørgensen" <toke@toke.dk> To: Louie Lu <git@louie.lu> Cc: kvalo@codeaurora.org, ath9k-devel@qca.qualcomm.com, davem@davemloft.net, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] ath9k: add reset for airtime station debugfs Date: Thu, 06 Sep 2018 12:40:10 +0200 [thread overview] Message-ID: <87sh2mykmt.fsf@toke.dk> (raw) In-Reply-To: <CADMDV=ws-iM6+L+CLyrGK=srV56jbYgBbOVWg2AxEX0gR6t8WQ@mail.gmail.com> Louie Lu <git@louie.lu> writes: > Toke H=C3=B8iland-J=C3=B8rgensen <toke@toke.dk> =E6=96=BC 2018=E5=B9=B49= =E6=9C=886=E6=97=A5 =E9=80=B1=E5=9B=9B =E4=B8=8B=E5=8D=885:27=E5=AF=AB=E9= =81=93=EF=BC=9A > >> Louie Lu <git@louie.lu> writes: >> >> > Let user can reset station airtime status by debugfs, it will >> > reset all airtime deficit to ATH_AIRTIME_QUANTUM and reset rx/tx >> > airtime accumulate to 0. >> >> No objections to the patch, but I'm curious which issues you were >> debugging that led you to needing it? :) >> > I'm testing to get the packet queue time + airtime in > ath_tx_process_buffer, Right; I've been thinking that it would be useful to make the CoDel enqueue time available to drivers. And minstrel, for that matter (lowering the number of retries for packets that has queued for a long time, for instance). Good to hear that others are looking into something similar :) > it would be useful if I can reset the station airtime accumulated > value, so I can observe in each test round (e.g. 5 ping) airtime > accumulated > > Also to reset the deficit to make sure it run like fresh one. Yup, makes sense. -Toke
WARNING: multiple messages have this Message-ID (diff)
From: "Toke Høiland-Jørgensen" <toke-LJ9M9ZcSy1A@public.gmane.org> To: Louie Lu <git-sgRGTR89XAc@public.gmane.org> Cc: kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, ath9k-devel-A+ZNKFmMK5xy9aJCnZT0Uw@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org, linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: [PATCH] ath9k: add reset for airtime station debugfs Date: Thu, 06 Sep 2018 12:40:10 +0200 [thread overview] Message-ID: <87sh2mykmt.fsf@toke.dk> (raw) In-Reply-To: <CADMDV=ws-iM6+L+CLyrGK=srV56jbYgBbOVWg2AxEX0gR6t8WQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> Louie Lu <git-sgRGTR89XAc@public.gmane.org> writes: > Toke Høiland-Jørgensen <toke-LJ9M9ZcSy1A@public.gmane.org> 於 2018年9月6日 週四 下午5:27寫道: > >> Louie Lu <git-sgRGTR89XAc@public.gmane.org> writes: >> >> > Let user can reset station airtime status by debugfs, it will >> > reset all airtime deficit to ATH_AIRTIME_QUANTUM and reset rx/tx >> > airtime accumulate to 0. >> >> No objections to the patch, but I'm curious which issues you were >> debugging that led you to needing it? :) >> > I'm testing to get the packet queue time + airtime in > ath_tx_process_buffer, Right; I've been thinking that it would be useful to make the CoDel enqueue time available to drivers. And minstrel, for that matter (lowering the number of retries for packets that has queued for a long time, for instance). Good to hear that others are looking into something similar :) > it would be useful if I can reset the station airtime accumulated > value, so I can observe in each test round (e.g. 5 ping) airtime > accumulated > > Also to reset the deficit to make sure it run like fresh one. Yup, makes sense. -Toke
next prev parent reply other threads:[~2018-09-06 15:15 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-09-06 3:53 [PATCH] ath9k: add reset for airtime station debugfs Louie Lu 2018-09-06 9:27 ` Toke Høiland-Jørgensen 2018-09-06 9:27 ` Toke Høiland-Jørgensen [not found] ` <CADMDV=ws-iM6+L+CLyrGK=srV56jbYgBbOVWg2AxEX0gR6t8WQ@mail.gmail.com> 2018-09-06 10:40 ` Toke Høiland-Jørgensen [this message] 2018-09-06 10:40 ` Toke Høiland-Jørgensen 2018-09-09 23:44 ` Dave Taht 2018-09-09 23:44 ` Dave Taht 2018-09-06 10:41 ` Louie Lu 2018-10-01 14:06 ` Kalle Valo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87sh2mykmt.fsf@toke.dk \ --to=toke@toke.dk \ --cc=ath9k-devel@qca.qualcomm.com \ --cc=davem@davemloft.net \ --cc=git@louie.lu \ --cc=kvalo@codeaurora.org \ --cc=linux-wireless@vger.kernel.org \ --cc=netdev@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.