From: Dave Taht <dave.taht@gmail.com>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>
Cc: git@louie.lu, Kalle Valo <kvalo@codeaurora.org>,
QCA ath9k Development <ath9k-devel@qca.qualcomm.com>,
"David S. Miller" <davem@davemloft.net>,
linux-wireless <linux-wireless@vger.kernel.org>,
Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: [PATCH] ath9k: add reset for airtime station debugfs
Date: Sun, 9 Sep 2018 16:44:53 -0700 [thread overview]
Message-ID: <CAA93jw4ud9f2hwhz5nqJa3B0p8N7hP=Hd9ZyGok-k16_-sonoQ@mail.gmail.com> (raw)
In-Reply-To: <87sh2mykmt.fsf@toke.dk>
On Thu, Sep 6, 2018 at 4:13 AM Toke H=C3=B8iland-J=C3=B8rgensen <toke@toke.=
dk> wrote:
>
> Louie Lu <git@louie.lu> writes:
>
> > Toke H=C3=B8iland-J=C3=B8rgensen <toke@toke.dk> =E6=96=BC 2018=E5=B9=B4=
9=E6=9C=886=E6=97=A5 =E9=80=B1=E5=9B=9B =E4=B8=8B=E5=8D=885:27=E5=AF=AB=E9=
=81=93=EF=BC=9A
> >
> >> Louie Lu <git@louie.lu> writes:
> >>
> >> > Let user can reset station airtime status by debugfs, it will
> >> > reset all airtime deficit to ATH_AIRTIME_QUANTUM and reset rx/tx
> >> > airtime accumulate to 0.
> >>
> >> No objections to the patch, but I'm curious which issues you were
> >> debugging that led you to needing it? :)
> >>
> > I'm testing to get the packet queue time + airtime in
> > ath_tx_process_buffer,
>
> Right; I've been thinking that it would be useful to make the CoDel
> enqueue time available to drivers. And minstrel, for that matter
> (lowering the number of retries for packets that has queued for a long
> time, for instance). Good to hear that others are looking into something
> similar :)
Yea! Seeing retransmits scale down would be a goodness. Last I looked
ath9k was at, like 10?, when it should be, like, 2, at mcs0 and 10 at
mcs15.
I can't seem to publish a link to this directly, but it's open access
if you search via https://scholar.google.com/:
"Resolving Bufferbloat in TCP Communication over IEEE 802.11 n WLAN by
Reducing MAC Retransmission Limit at Low Data Rate"
even their simple bifurcated model worked well.
>
> > it would be useful if I can reset the station airtime accumulated
> > value, so I can observe in each test round (e.g. 5 ping) airtime
> > accumulated
> >
> > Also to reset the deficit to make sure it run like fresh one.
>
> Yup, makes sense.
>
> -Toke
--=20
Dave T=C3=A4ht
CEO, TekLibre, LLC
http://www.teklibre.com
Tel: 1-669-226-2619
WARNING: multiple messages have this Message-ID (diff)
From: Dave Taht <dave.taht@gmail.com>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>
Cc: git@louie.lu, Kalle Valo <kvalo@codeaurora.org>,
QCA ath9k Development <ath9k-devel@qca.qualcomm.com>,
"David S. Miller" <davem@davemloft.net>,
linux-wireless <linux-wireless@vger.kernel.org>,
Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: [PATCH] ath9k: add reset for airtime station debugfs
Date: Sun, 9 Sep 2018 16:44:53 -0700 [thread overview]
Message-ID: <CAA93jw4ud9f2hwhz5nqJa3B0p8N7hP=Hd9ZyGok-k16_-sonoQ@mail.gmail.com> (raw)
In-Reply-To: <87sh2mykmt.fsf@toke.dk>
On Thu, Sep 6, 2018 at 4:13 AM Toke Høiland-Jørgensen <toke@toke.dk> wrote:
>
> Louie Lu <git@louie.lu> writes:
>
> > Toke Høiland-Jørgensen <toke@toke.dk> 於 2018年9月6日 週四 下午5:27寫道：
> >
> >> Louie Lu <git@louie.lu> writes:
> >>
> >> > Let user can reset station airtime status by debugfs, it will
> >> > reset all airtime deficit to ATH_AIRTIME_QUANTUM and reset rx/tx
> >> > airtime accumulate to 0.
> >>
> >> No objections to the patch, but I'm curious which issues you were
> >> debugging that led you to needing it? :)
> >>
> > I'm testing to get the packet queue time + airtime in
> > ath_tx_process_buffer,
>
> Right; I've been thinking that it would be useful to make the CoDel
> enqueue time available to drivers. And minstrel, for that matter
> (lowering the number of retries for packets that has queued for a long
> time, for instance). Good to hear that others are looking into something
> similar :)
Yea! Seeing retransmits scale down would be a goodness. Last I looked
ath9k was at, like 10?, when it should be, like, 2, at mcs0 and 10 at
mcs15.
I can't seem to publish a link to this directly, but it's open access
if you search via https://scholar.google.com/:
"Resolving Bufferbloat in TCP Communication over IEEE 802.11 n WLAN by
Reducing MAC Retransmission Limit at Low Data Rate"
even their simple bifurcated model worked well.
>
> > it would be useful if I can reset the station airtime accumulated
> > value, so I can observe in each test round (e.g. 5 ping) airtime
> > accumulated
> >
> > Also to reset the deficit to make sure it run like fresh one.
>
> Yup, makes sense.
>
> -Toke
--
Dave Täht
CEO, TekLibre, LLC
http://www.teklibre.com
Tel: 1-669-226-2619
next prev parent reply other threads:[~2018-09-10 7:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-06 3:53 [PATCH] ath9k: add reset for airtime station debugfs Louie Lu
2018-09-06 9:27 ` Toke Høiland-Jørgensen
2018-09-06 9:27 ` Toke Høiland-Jørgensen
[not found] ` <CADMDV=ws-iM6+L+CLyrGK=srV56jbYgBbOVWg2AxEX0gR6t8WQ@mail.gmail.com>
2018-09-06 10:40 ` Toke Høiland-Jørgensen
2018-09-06 10:40 ` Toke Høiland-Jørgensen
2018-09-09 23:44 ` Dave Taht [this message]
2018-09-09 23:44 ` Dave Taht
2018-09-06 10:41 ` Louie Lu
2018-10-01 14:06 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA93jw4ud9f2hwhz5nqJa3B0p8N7hP=Hd9ZyGok-k16_-sonoQ@mail.gmail.com' \
--to=dave.taht@gmail.com \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=davem@davemloft.net \
--cc=git@louie.lu \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.