* [PATCH] powerpc/32: add missing \n at end of printk warning message
@ 2016-09-12 10:12 Colin King
2016-09-12 15:21 ` Christophe Leroy
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Colin King @ 2016-09-12 10:12 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman,
Christophe Leroy, Scott Wood, Kevin Hao, Joonsoo Kim,
linuxppc-dev
Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The message is missing a \n, add it.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
arch/powerpc/mm/init_32.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/mm/init_32.c b/arch/powerpc/mm/init_32.c
index 448685f..b532dd9 100644
--- a/arch/powerpc/mm/init_32.c
+++ b/arch/powerpc/mm/init_32.c
@@ -137,7 +137,7 @@ void __init MMU_init(void)
if (memblock.memory.cnt > 1) {
#ifndef CONFIG_WII
memblock_enforce_memory_limit(memblock.memory.regions[0].size);
- printk(KERN_WARNING "Only using first contiguous memory region");
+ printk(KERN_WARNING "Only using first contiguous memory region\n");
#else
wii_memory_fixups();
#endif
--
2.9.3
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] powerpc/32: add missing \n at end of printk warning message
2016-09-12 10:12 [PATCH] powerpc/32: add missing \n at end of printk warning message Colin King
@ 2016-09-12 15:21 ` Christophe Leroy
2016-09-13 1:25 ` Michael Ellerman
2016-09-12 16:34 ` Joe Perches
2016-09-13 12:16 ` Michael Ellerman
2 siblings, 1 reply; 7+ messages in thread
From: Christophe Leroy @ 2016-09-12 15:21 UTC (permalink / raw)
To: Colin King, Benjamin Herrenschmidt, Paul Mackerras,
Michael Ellerman, Scott Wood, Kevin Hao, Joonsoo Kim,
linuxppc-dev
Cc: linux-kernel
Le 12/09/2016 à 12:12, Colin King a écrit :
> From: Colin Ian King <colin.king@canonical.com>
>
> The message is missing a \n, add it.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> arch/powerpc/mm/init_32.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/mm/init_32.c b/arch/powerpc/mm/init_32.c
> index 448685f..b532dd9 100644
> --- a/arch/powerpc/mm/init_32.c
> +++ b/arch/powerpc/mm/init_32.c
> @@ -137,7 +137,7 @@ void __init MMU_init(void)
> if (memblock.memory.cnt > 1) {
> #ifndef CONFIG_WII
> memblock_enforce_memory_limit(memblock.memory.regions[0].size);
> - printk(KERN_WARNING "Only using first contiguous memory region");
> + printk(KERN_WARNING "Only using first contiguous memory region\n");
This line was already 81 characters long. It is now 83.
I would suggest to use pr_warn() instead in order to shorten the line.
Christophe
> #else
> wii_memory_fixups();
> #endif
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] powerpc/32: add missing \n at end of printk warning message
2016-09-12 15:21 ` Christophe Leroy
@ 2016-09-13 1:25 ` Michael Ellerman
0 siblings, 0 replies; 7+ messages in thread
From: Michael Ellerman @ 2016-09-13 1:25 UTC (permalink / raw)
To: Christophe Leroy, Colin King, Benjamin Herrenschmidt,
Paul Mackerras, Scott Wood, Kevin Hao, Joonsoo Kim, linuxppc-dev
Cc: linux-kernel
Christophe Leroy <christophe.leroy@c-s.fr> writes:
> Le 12/09/2016 à 12:12, Colin King a écrit :
>> diff --git a/arch/powerpc/mm/init_32.c b/arch/powerpc/mm/init_32.c
>> index 448685f..b532dd9 100644
>> --- a/arch/powerpc/mm/init_32.c
>> +++ b/arch/powerpc/mm/init_32.c
>> @@ -137,7 +137,7 @@ void __init MMU_init(void)
>> if (memblock.memory.cnt > 1) {
>> #ifndef CONFIG_WII
>> memblock_enforce_memory_limit(memblock.memory.regions[0].size);
>> - printk(KERN_WARNING "Only using first contiguous memory region");
>> + printk(KERN_WARNING "Only using first contiguous memory region\n");
>
> This line was already 81 characters long. It is now 83.
That doesn't really bother me.
> I would suggest to use pr_warn() instead in order to shorten the line.
But I do like pr_warn(), it's less shouty.
I'll fix it up when I apply it.
cheers
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] powerpc/32: add missing \n at end of printk warning message
@ 2016-09-13 1:25 ` Michael Ellerman
0 siblings, 0 replies; 7+ messages in thread
From: Michael Ellerman @ 2016-09-13 1:25 UTC (permalink / raw)
To: Christophe Leroy, Colin King, Benjamin Herrenschmidt,
Paul Mackerras, Scott Wood, Kevin Hao, Joonsoo Kim, linuxppc-dev
Cc: linux-kernel
Christophe Leroy <christophe.leroy@c-s.fr> writes:
> Le 12/09/2016 =C3=A0 12:12, Colin King a =C3=A9crit :
>> diff --git a/arch/powerpc/mm/init_32.c b/arch/powerpc/mm/init_32.c
>> index 448685f..b532dd9 100644
>> --- a/arch/powerpc/mm/init_32.c
>> +++ b/arch/powerpc/mm/init_32.c
>> @@ -137,7 +137,7 @@ void __init MMU_init(void)
>> if (memblock.memory.cnt > 1) {
>> #ifndef CONFIG_WII
>> memblock_enforce_memory_limit(memblock.memory.regions[0].size);
>> - printk(KERN_WARNING "Only using first contiguous memory region");
>> + printk(KERN_WARNING "Only using first contiguous memory region\n");
>
> This line was already 81 characters long. It is now 83.
That doesn't really bother me.
> I would suggest to use pr_warn() instead in order to shorten the line.
But I do like pr_warn(), it's less shouty.
I'll fix it up when I apply it.
cheers
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] powerpc/32: add missing \n at end of printk warning message
2016-09-12 10:12 [PATCH] powerpc/32: add missing \n at end of printk warning message Colin King
2016-09-12 15:21 ` Christophe Leroy
@ 2016-09-12 16:34 ` Joe Perches
2016-09-12 16:49 ` Colin Ian King
2016-09-13 12:16 ` Michael Ellerman
2 siblings, 1 reply; 7+ messages in thread
From: Joe Perches @ 2016-09-12 16:34 UTC (permalink / raw)
To: Colin King, linuxppc-dev; +Cc: linux-kernel
On Mon, 2016-09-12 at 11:12 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> The message is missing a \n, add it.
Was this found via inspection or a tool?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] powerpc/32: add missing \n at end of printk warning message
2016-09-12 16:34 ` Joe Perches
@ 2016-09-12 16:49 ` Colin Ian King
0 siblings, 0 replies; 7+ messages in thread
From: Colin Ian King @ 2016-09-12 16:49 UTC (permalink / raw)
To: Joe Perches, linuxppc-dev; +Cc: linux-kernel
On 12/09/16 17:34, Joe Perches wrote:
> On Mon, 2016-09-12 at 11:12 +0100, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>> The message is missing a \n, add it.
>
> Was this found via inspection or a tool?
>
grep
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: powerpc/32: add missing \n at end of printk warning message
2016-09-12 10:12 [PATCH] powerpc/32: add missing \n at end of printk warning message Colin King
2016-09-12 15:21 ` Christophe Leroy
2016-09-12 16:34 ` Joe Perches
@ 2016-09-13 12:16 ` Michael Ellerman
2 siblings, 0 replies; 7+ messages in thread
From: Michael Ellerman @ 2016-09-13 12:16 UTC (permalink / raw)
To: Colin King, Benjamin Herrenschmidt, Paul Mackerras,
Christophe Leroy, Scott Wood, Kevin Hao, Joonsoo Kim,
linuxppc-dev
Cc: linux-kernel
On Mon, 2016-12-09 at 10:12:24 UTC, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The message is missing a \n, add it.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/3daf3c206992891ac0cec6a54a
cheers
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-09-13 12:16 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-12 10:12 [PATCH] powerpc/32: add missing \n at end of printk warning message Colin King
2016-09-12 15:21 ` Christophe Leroy
2016-09-13 1:25 ` Michael Ellerman
2016-09-13 1:25 ` Michael Ellerman
2016-09-12 16:34 ` Joe Perches
2016-09-12 16:49 ` Colin Ian King
2016-09-13 12:16 ` Michael Ellerman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.