[Buildroot] [PATCH 0/3] Add lightweight Zile editor

[Buildroot] [PATCH 0/3] Add lightweight Zile editor

[Alex Bennée]

Hi,

I've updated the patches based on review comments. There is a new
patch just to enable the existing libatmomic to be built for aarch64
(the platform I'm testing on). As a result the ugly hackage in the gc
library build has gone away.

Cheers,

--
Alex Benn?e
QEMU/KVM Hacker for Linaro


Alex Benn?e (3):
  package/libatomic: mark as supporting aarch64
  package/libgc: add Boehm-Demers-Weiser gc library
  package/zile: add Zile is Lossy Emacs editor

 package/Config.in                  |  2 ++
 package/libatomic_ops/Config.in    |  2 +-
 package/libgc/Config.in            | 10 ++++++++++
 package/libgc/libgc.mk             | 15 +++++++++++++++
 package/zile/Config.in             | 13 +++++++++++++
 package/zile/remove-help2man.patch | 30 ++++++++++++++++++++++++++++++
 package/zile/zile.mk               | 14 ++++++++++++++
 7 files changed, 85 insertions(+), 1 deletion(-)
 create mode 100644 package/libgc/Config.in
 create mode 100644 package/libgc/libgc.mk
 create mode 100644 package/zile/Config.in
 create mode 100644 package/zile/remove-help2man.patch
 create mode 100644 package/zile/zile.mk

-- 
1.9.2

[Buildroot] [PATCH 1/3] package/libatomic: mark as supporting aarch64

[Alex Bennée]

Signed-off-by: Alex Benn?e <alex.bennee@linaro.org>

diff --git a/package/libatomic_ops/Config.in b/package/libatomic_ops/Config.in
index 3d5d0a8..290d0b0 100644
--- a/package/libatomic_ops/Config.in
+++ b/package/libatomic_ops/Config.in
@@ -1,5 +1,5 @@
 config BR2_PACKAGE_LIBATOMIC_OPS
 	bool "libatomic_ops"
-	depends on BR2_arm || BR2_armeb || BR2_i386 || BR2_sparc || BR2_powerpc || BR2_x86_64
+	depends on BR2_arm || BR2_armeb || BR_aarch64 || BR2_i386 || BR2_sparc || BR2_powerpc || BR2_x86_64
 	help
 	  Atomic operations library
-- 
1.9.2

[Buildroot] [PATCH 2/3] package/libgc: add Boehm-Demers-Weiser gc library

[Alex Bennée]

This is needed for applications like Zile

Signed-off-by: Alex Benn?e <alex.bennee@linaro.org>

---
v2
- fix whitespace
- proper dependancies
- use system libatomic

 create mode 100644 package/libgc/Config.in
 create mode 100644 package/libgc/libgc.mk

diff --git a/package/Config.in b/package/Config.in
index 6abc7b3..0e7e246 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -788,6 +788,7 @@ source "package/libev/Config.in"
 source "package/libevdev/Config.in"
 source "package/libevent/Config.in"
 source "package/libffi/Config.in"
+source "package/libgc/Config.in"
 source "package/libglib2/Config.in"
 source "package/libical/Config.in"
 source "package/libnspr/Config.in"
diff --git a/package/libgc/Config.in b/package/libgc/Config.in
new file mode 100644
index 0000000..5bceb3d
--- /dev/null
+++ b/package/libgc/Config.in
@@ -0,0 +1,10 @@
+config BR2_PACKAGE_LIBGC
+	bool "libgc"
+	select BR2_PACKAGE_LIBATOMIC_OPS
+	help
+	  The Boehm-Demers-Weiser conservative garbage collector can be used
+	  as a garbage collecting replacement for C malloc or C++ new. It allows
+	  you to allocate memory basically as you normally would, without
+	  explicitly deallocating memory that is no longer useful.
+
+	  http://www.hboehm.info/gc/
diff --git a/package/libgc/libgc.mk b/package/libgc/libgc.mk
new file mode 100644
index 0000000..e3c5bf1
--- /dev/null
+++ b/package/libgc/libgc.mk
@@ -0,0 +1,15 @@
+################################################################################
+#
+# libgc
+#
+################################################################################
+
+LIBGC_VERSION = 7.4.0
+LIBGC_SOURCE = gc-${LIBGC_VERSION}.tar.gz
+LIBGC_SITE = http://www.hboehm.info/gc/gc_source/
+LIBGC_DEPENDANCIES += libatomic_ops
+LIBGC_LICENSE = GPLv1+
+LIBGC_LICENSE_FILES = COPYING
+LIBGC_INSTALL_STAGING = YES
+
+$(eval $(autotools-package))
-- 
1.9.2

[Buildroot] [PATCH 3/3] package/zile: add Zile is Lossy Emacs editor

[Alex Bennée]

This is a lightweight Emacs clone useful for embedded systems. I nabbed
the help2man disable patch from OpenEmbedded.

Signed-off-by: Alex Benn?e <alex.bennee@linaro.org>

---
v2 - review comments
* fixup dependancies
* add s-o-b tag to patch
* fix whitespace

 create mode 100644 package/zile/Config.in
 create mode 100644 package/zile/remove-help2man.patch
 create mode 100644 package/zile/zile.mk

diff --git a/package/Config.in b/package/Config.in
index 0e7e246..ad1f4c1 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1119,6 +1119,7 @@ source "package/uemacs/Config.in"
 if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 source "package/vim/Config.in"
 endif
+source "package/zile/Config.in"
 endmenu
 
 endmenu
diff --git a/package/zile/Config.in b/package/zile/Config.in
new file mode 100644
index 0000000..163b44d
--- /dev/null
+++ b/package/zile/Config.in
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_ZILE
+	bool "zile"
+	select BR2_PACKAGE_LIBGC
+	depends on BR2_USE_MMU # fork()
+	help
+	  Zile is Lossy Emacs
+
+	  GNU Zile (Zile Is Lossy Emacs) is a lightweight Emacs clone. Every
+	  Emacs user should feel at home with Zile. Zile is aimed at small
+	  footprint systems (a typical binary is about 100Kb) and quick editing
+	  sessions (it starts up and shuts down instantly).
+
+	  http://www.gnu.org/software/zile/
diff --git a/package/zile/remove-help2man.patch b/package/zile/remove-help2man.patch
new file mode 100644
index 0000000..d397543
--- /dev/null
+++ b/package/zile/remove-help2man.patch
@@ -0,0 +1,30 @@
+Upstream-Status: Inappropriate [configuration]
+
+Signed-off-by: Alex Benn?e <alex.bennee@linaro.org>
+
+diff --git a/Makefile.am b/Makefile.am
+index 54bc59f..46c2650 100644
+--- a/Makefile.am
++++ b/Makefile.am
+@@ -36,7 +36,6 @@ PERL_BUILDTIME =					\
+ 
+ EXTRA_DIST =						\
+ 	FAQ						\
+-	build-aux/zile-help2man-wrapper			\
+ 	$(PERL_BUILDTIME)
+ 
+ doc_DATA = AUTHORS FAQ NEWS
+diff --git a/doc/Makefile.am b/doc/Makefile.am
+index 639f59c..8c5123e 100644
+--- a/doc/Makefile.am
++++ b/doc/Makefile.am
+@@ -33,9 +33,3 @@ doc/zile.1: $(srcdir)/doc/zile.1.in doc/Makefile.am config.status
+ 	$(edit) $(abs_srcdir)/doc/zile.1.in >$@.tmp
+ 	mv $@.tmp $@
+ 
+-$(srcdir)/doc/zile.1.in: doc/man-extras build-aux/zile-help2man-wrapper configure.ac $(builddir)/src/zile$(EXEEXT)
+-	@test -d doc || mkdir doc
+-## Exit gracefully if zile.1.in is not writeable, such as during distcheck!
+-	$(AM_V_GEN)if ( touch $@.w && rm -f $@.w; ) >/dev/null 2>&1; then \
+-	  $(srcdir)/build-aux/missing --run $(HELP2MAN) --output=$@ --no-info --name="Zile Is Lossy Emacs" --include $(srcdir)/doc/man-extras $(srcdir)/build-aux/zile-help2man-wrapper; \
+-	fi
diff --git a/package/zile/zile.mk b/package/zile/zile.mk
new file mode 100644
index 0000000..b641fe6
--- /dev/null
+++ b/package/zile/zile.mk
@@ -0,0 +1,14 @@
+################################################################################
+#
+# Zile
+#
+################################################################################
+
+ZILE_VERSION = 2.4.11
+ZILE_SITE = http://ftp.gnu.org/gnu/zile/
+ZILE_LICENSE = GPLv1+
+ZILE_LICENSE_FILES = COPYING
+ZILE_CONF_OPT += --without-help2man
+ZILE_DEPENDANCIES += libgc
+
+$(eval $(autotools-package))
-- 
1.9.2

[Buildroot] [PATCH 3/3] package/zile: add Zile is Lossy Emacs editor

[Alex Bennée]

Alex Benn?e <alex.bennee@linaro.org> writes:

> This is a lightweight Emacs clone useful for embedded systems. I nabbed
> the help2man disable patch from OpenEmbedded.

I forgot to mention the disable patch was never sent upstream as their
policy is not to submit tweaks to the configure scripts. The alternative
is to submit a patch upstream that enables the disabling of document
generation.

-- 
Alex Benn?e

[Buildroot] [PATCH 2/3] package/libgc: add Boehm-Demers-Weiser gc library

[Thomas De Schampheleire]

"Alex Benn?e" <alex.bennee@linaro.org> schreef:
>This is needed for applications like Zile
>
>Signed-off-by: Alex Benn?e <alex.bennee@linaro.org>
>
>---
>v2
>- fix whitespace
>- proper dependancies
>- use system libatomic
>
> create mode 100644 package/libgc/Config.in
> create mode 100644 package/libgc/libgc.mk
>
>diff --git a/package/Config.in b/package/Config.in
>index 6abc7b3..0e7e246 100644
>--- a/package/Config.in
>+++ b/package/Config.in
>@@ -788,6 +788,7 @@ source "package/libev/Config.in"
> source "package/libevdev/Config.in"
> source "package/libevent/Config.in"
> source "package/libffi/Config.in"
>+source "package/libgc/Config.in"
> source "package/libglib2/Config.in"
> source "package/libical/Config.in"
> source "package/libnspr/Config.in"
>diff --git a/package/libgc/Config.in b/package/libgc/Config.in
>new file mode 100644
>index 0000000..5bceb3d
>--- /dev/null
>+++ b/package/libgc/Config.in
>@@ -0,0 +1,10 @@
>+config BR2_PACKAGE_LIBGC
>+	bool "libgc"
>+	select BR2_PACKAGE_LIBATOMIC_OPS
>+	help
>+	  The Boehm-Demers-Weiser conservative garbage collector can be used
>+	  as a garbage collecting replacement for C malloc or C++ new. It allows
>+	  you to allocate memory basically as you normally would, without
>+	  explicitly deallocating memory that is no longer useful.
>+
>+	  http://www.hboehm.info/gc/
>diff --git a/package/libgc/libgc.mk b/package/libgc/libgc.mk
>new file mode 100644
>index 0000000..e3c5bf1
>--- /dev/null
>+++ b/package/libgc/libgc.mk
>@@ -0,0 +1,15 @@
>+################################################################################
>+#
>+# libgc
>+#
>+################################################################################
>+
>+LIBGC_VERSION = 7.4.0
>+LIBGC_SOURCE = gc-${LIBGC_VERSION}.tar.gz
>+LIBGC_SITE = http://www.hboehm.info/gc/gc_source/
>+LIBGC_DEPENDANCIES += libatomic_ops

This should be: ..._DEPENDENCIES with E.

>+LIBGC_LICENSE = GPLv1+
>+LIBGC_LICENSE_FILES = COPYING
>+LIBGC_INSTALL_STAGING = YES
>+
>+$(eval $(autotools-package))

Best regards,
Thomas

[Buildroot] [PATCH 3/3] package/zile: add Zile is Lossy Emacs editor

[Thomas De Schampheleire]

"Alex Benn?e" <alex.bennee@linaro.org> schreef:
>This is a lightweight Emacs clone useful for embedded systems. I nabbed
>the help2man disable patch from OpenEmbedded.
>
>Signed-off-by: Alex Benn?e <alex.bennee@linaro.org>
>
>---
>v2 - review comments
>* fixup dependancies
>* add s-o-b tag to patch
>* fix whitespace
>
> create mode 100644 package/zile/Config.in
> create mode 100644 package/zile/remove-help2man.patch
> create mode 100644 package/zile/zile.mk
>
>diff --git a/package/Config.in b/package/Config.in
>index 0e7e246..ad1f4c1 100644
>--- a/package/Config.in
>+++ b/package/Config.in
>@@ -1119,6 +1119,7 @@ source "package/uemacs/Config.in"
> if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
> source "package/vim/Config.in"
> endif
>+source "package/zile/Config.in"
> endmenu
> 
> endmenu
>diff --git a/package/zile/Config.in b/package/zile/Config.in
>new file mode 100644
>index 0000000..163b44d
>--- /dev/null
>+++ b/package/zile/Config.in
>@@ -0,0 +1,13 @@
>+config BR2_PACKAGE_ZILE
>+	bool "zile"
>+	select BR2_PACKAGE_LIBGC
>+	depends on BR2_USE_MMU # fork()
>+	help
>+	  Zile is Lossy Emacs
>+
>+	  GNU Zile (Zile Is Lossy Emacs) is a lightweight Emacs clone. Every
>+	  Emacs user should feel at home with Zile. Zile is aimed at small
>+	  footprint systems (a typical binary is about 100Kb) and quick editing
>+	  sessions (it starts up and shuts down instantly).
>+
>+	  http://www.gnu.org/software/zile/
>diff --git a/package/zile/remove-help2man.patch b/package/zile/remove-help2man.patch
>new file mode 100644
>index 0000000..d397543
>--- /dev/null
>+++ b/package/zile/remove-help2man.patch

Patches are supposed to be called: pkgname-0001-description.patch


>@@ -0,0 +1,30 @@
>+Upstream-Status: Inappropriate [configuration]
>+
>+Signed-off-by: Alex Benn?e <alex.bennee@linaro.org>
>+
>+diff --git a/Makefile.am b/Makefile.am
>+index 54bc59f..46c2650 100644
>+--- a/Makefile.am
>++++ b/Makefile.am
>+@@ -36,7 +36,6 @@ PERL_BUILDTIME =					\
>+ 
>+ EXTRA_DIST =						\
>+ 	FAQ						\
>+-	build-aux/zile-help2man-wrapper			\
>+ 	$(PERL_BUILDTIME)
>+ 
>+ doc_DATA = AUTHORS FAQ NEWS
>+diff --git a/doc/Makefile.am b/doc/Makefile.am
>+index 639f59c..8c5123e 100644
>+--- a/doc/Makefile.am
>++++ b/doc/Makefile.am
>+@@ -33,9 +33,3 @@ doc/zile.1: $(srcdir)/doc/zile.1.in doc/Makefile.am config.status
>+ 	$(edit) $(abs_srcdir)/doc/zile.1.in >$@.tmp
>+ 	mv $@.tmp $@
>+ 
>+-$(srcdir)/doc/zile.1.in: doc/man-extras build-aux/zile-help2man-wrapper configure.ac $(builddir)/src/zile$(EXEEXT)
>+-	@test -d doc || mkdir doc
>+-## Exit gracefully if zile.1.in is not writeable, such as during distcheck!
>+-	$(AM_V_GEN)if ( touch $@.w && rm -f $@.w; ) >/dev/null 2>&1; then \
>+-	  $(srcdir)/build-aux/missing --run $(HELP2MAN) --output=$@ --no-info --name="Zile Is Lossy Emacs" --include $(srcdir)/doc/man-extras $(srcdir)/build-aux/zile-help2man-wrapper; \
>+-	fi
>diff --git a/package/zile/zile.mk b/package/zile/zile.mk
>new file mode 100644
>index 0000000..b641fe6
>--- /dev/null
>+++ b/package/zile/zile.mk
>@@ -0,0 +1,14 @@
>+################################################################################
>+#
>+# Zile
>+#
>+################################################################################
>+
>+ZILE_VERSION = 2.4.11
>+ZILE_SITE = http://ftp.gnu.org/gnu/zile/
>+ZILE_LICENSE = GPLv1+
>+ZILE_LICENSE_FILES = COPYING
>+ZILE_CONF_OPT += --without-help2man
>+ZILE_DEPENDANCIES += libgc

DEPENDENCIES

Best regards,
Thomas

[Buildroot] [PATCH 2/3] package/libgc: add Boehm-Demers-Weiser gc library

[Thomas Petazzoni]

Dear Thomas De Schampheleire,

On Fri, 11 Apr 2014 22:03:23 +0200, Thomas De Schampheleire wrote:

> >+LIBGC_VERSION = 7.4.0
> >+LIBGC_SOURCE = gc-${LIBGC_VERSION}.tar.gz
> >+LIBGC_SITE = http://www.hboehm.info/gc/gc_source/
> >+LIBGC_DEPENDANCIES += libatomic_ops
> 
> This should be: ..._DEPENDENCIES with E.

And the += is not needed, a simple = is sufficient here.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 3/3] package/zile: add Zile is Lossy Emacs editor

[Thomas Petazzoni]

Dear Alex Benn?e,

On Fri, 11 Apr 2014 15:05:56 +0100, Alex Benn?e wrote:

> diff --git a/package/zile/remove-help2man.patch b/package/zile/remove-help2man.patch
> new file mode 100644
> index 0000000..d397543
> --- /dev/null
> +++ b/package/zile/remove-help2man.patch
> @@ -0,0 +1,30 @@
> +Upstream-Status: Inappropriate [configuration]
> +
> +Signed-off-by: Alex Benn?e <alex.bennee@linaro.org>
> +
> +diff --git a/Makefile.am b/Makefile.am

You're patching Makefile.am here...


> +ZILE_VERSION = 2.4.11
> +ZILE_SITE = http://ftp.gnu.org/gnu/zile/
> +ZILE_LICENSE = GPLv1+
> +ZILE_LICENSE_FILES = COPYING
> +ZILE_CONF_OPT += --without-help2man
> +ZILE_DEPENDANCIES += libgc

but you never mark zile as requiring autoreconf using ZILE_AUTORECONF =
YES. How can this work?

Also, use '=' instead of '+=' above.

And use $(BR2_GNU_MIRROR) for the download URL.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 1/3] package/libatomic: mark as supporting aarch64

[Thomas Petazzoni]

Dear Alex Benn?e,

On Fri, 11 Apr 2014 15:05:54 +0100, Alex Benn?e wrote:
> Signed-off-by: Alex Benn?e <alex.bennee@linaro.org>
> 
> diff --git a/package/libatomic_ops/Config.in b/package/libatomic_ops/Config.in
> index 3d5d0a8..290d0b0 100644
> --- a/package/libatomic_ops/Config.in
> +++ b/package/libatomic_ops/Config.in
> @@ -1,5 +1,5 @@
>  config BR2_PACKAGE_LIBATOMIC_OPS
>  	bool "libatomic_ops"
> -	depends on BR2_arm || BR2_armeb || BR2_i386 || BR2_sparc || BR2_powerpc || BR2_x86_64
> +	depends on BR2_arm || BR2_armeb || BR_aarch64 || BR2_i386 || BR2_sparc || BR2_powerpc || BR2_x86_64

                                           ^^^^ how could this even
                                                work ?

Anyway, I've committed your patch with this fixed to BR2_aarch64.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 2/3] package/libgc: add Boehm-Demers-Weiser gc library

[Thomas Petazzoni]

Dear Alex Benn?e,

I applied your patch, but there were several problems to fix. See
below for details.

On Fri, 11 Apr 2014 15:05:55 +0100, Alex Benn?e wrote:

> diff --git a/package/libgc/Config.in b/package/libgc/Config.in
> new file mode 100644
> index 0000000..5bceb3d
> --- /dev/null
> +++ b/package/libgc/Config.in
> @@ -0,0 +1,10 @@
> +config BR2_PACKAGE_LIBGC
> +	bool "libgc"
> +	select BR2_PACKAGE_LIBATOMIC_OPS

When you select a package, you need to duplicate the dependencies of
that package. So here, you should have duplicate the dependencies of
the libatomic_ops package. To make this easier, I've made a small
change to the libatomic_ops package so that it provides a
BR2_PACKAGE_LIBATOMIC_OPS_ARCH_SUPPORTS Config.in option that other
packages can depend on.

> +	help
> +	  The Boehm-Demers-Weiser conservative garbage collector can be used
> +	  as a garbage collecting replacement for C malloc or C++ new. It allows
> +	  you to allocate memory basically as you normally would, without
> +	  explicitly deallocating memory that is no longer useful.
> +
> +	  http://www.hboehm.info/gc/
> diff --git a/package/libgc/libgc.mk b/package/libgc/libgc.mk
> new file mode 100644
> index 0000000..e3c5bf1
> --- /dev/null
> +++ b/package/libgc/libgc.mk
> @@ -0,0 +1,15 @@
> +################################################################################
> +#
> +# libgc
> +#
> +################################################################################
> +
> +LIBGC_VERSION = 7.4.0
> +LIBGC_SOURCE = gc-${LIBGC_VERSION}.tar.gz

We normally use $(...) to reference make variables, not ${...}.

> +LIBGC_SITE = http://www.hboehm.info/gc/gc_source/
> +LIBGC_DEPENDANCIES += libatomic_ops

It should have been DEPENDENCIES, and the += is unnecessary, = is
enough.

> +LIBGC_LICENSE = GPLv1+

libgc is apparently not under GPLv1+, but under some X11-like
permissive license.

> +LIBGC_LICENSE_FILES = COPYING

There was no file named COPYING, the copyright details are found in the
README.md file.

> +LIBGC_INSTALL_STAGING = YES
> +
> +$(eval $(autotools-package))

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 3/3] package/zile: add Zile is Lossy Emacs editor

[Alex Bennée]

Thomas De Schampheleire <patrickdepinguin@gmail.com> writes:

> "Alex Benn?e" <alex.bennee@linaro.org> schreef:
>>This is a lightweight Emacs clone useful for embedded systems. I nabbed
>>the help2man disable patch from OpenEmbedded.
>>
<snip>
>
> Patches are supposed to be called: pkgname-0001-description.patch

ok, I'll fix that up.
>
> DEPENDENCIES

oops, sorry.

>
> Best regards,
> Thomas

-- 
Alex Benn?e

[Buildroot] [PATCH 3/3] package/zile: add Zile is Lossy Emacs editor

[Alex Bennée]

Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

<snip>
>> +diff --git a/Makefile.am b/Makefile.am
>
> You're patching Makefile.am here...
>
>
>> +ZILE_VERSION = 2.4.11
>> +ZILE_SITE = http://ftp.gnu.org/gnu/zile/
>> +ZILE_LICENSE = GPLv1+
>> +ZILE_LICENSE_FILES = COPYING
>> +ZILE_CONF_OPT += --without-help2man
>> +ZILE_DEPENDANCIES += libgc
>
> but you never mark zile as requiring autoreconf using ZILE_AUTORECONF =
> YES. How can this work?

I assume the make machinery picked it up, will fix.

>
> Also, use '=' instead of '+=' above.
>
> And use $(BR2_GNU_MIRROR) for the download URL.
>
> Thanks!

Will send v3 once I've re-built and tested.

>
> Thomas

-- 
Alex Benn?e