From: Juan Quintela <quintela@redhat.com> To: "Michael S. Tsirkin" <mst@redhat.com> Cc: "Laurent Vivier" <lvivier@redhat.com>, "Eduardo Habkost" <ehabkost@redhat.com>, "Richard Henderson" <richard.henderson@linaro.org>, qemu-devel@nongnu.org, "Markus Armbruster" <armbru@redhat.com>, "Eugenio Pérez" <eperezma@redhat.com>, "Stefan Hajnoczi" <stefanha@redhat.com>, "Xiao W Wang" <xiao.w.wang@intel.com>, "Harpreet Singh Anand" <hanand@xilinx.com>, "Eli Cohen" <eli@mellanox.com>, "Paolo Bonzini" <pbonzini@redhat.com>, "Eric Blake" <eblake@redhat.com>, virtualization@lists.linux-foundation.org, "Parav Pandit" <parav@mellanox.com> Subject: Re: [RFC PATCH v5 02/26] vhost: Fix last queue index of devices with no cvq Date: Tue, 02 Nov 2021 08:39:37 +0100 [thread overview] Message-ID: <87v91bngzq.fsf@secure.mitica> (raw) In-Reply-To: <20211102033023-mutt-send-email-mst@kernel.org> (Michael S. Tsirkin's message of "Tue, 2 Nov 2021 03:32:32 -0400") "Michael S. Tsirkin" <mst@redhat.com> wrote: > On Tue, Nov 02, 2021 at 08:25:27AM +0100, Juan Quintela wrote: >> Eugenio Pérez <eperezma@redhat.com> wrote: >> > The -1 assumes that all devices with no cvq have an spare vq allocated >> > for them, but with no offer of VIRTIO_NET_F_CTRL_VQ. This may not be the >> > case, and the device may have a pair number of queues. >> ^^^^ >> even >> >> I know, I know, I am Spanish myself O:-) > > Nobody expects the Spanish ;) O:-) >> int main(void) >> { >> int i = 7; >> i &= -1ULL; > > Stefano's patch has ~1ULL , not -1ULL here. > Stupid eyes. Thanks, Juan. _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
WARNING: multiple messages have this Message-ID (diff)
From: Juan Quintela <quintela@redhat.com> To: "Michael S. Tsirkin" <mst@redhat.com> Cc: "Laurent Vivier" <lvivier@redhat.com>, "Eduardo Habkost" <ehabkost@redhat.com>, "Jason Wang" <jasowang@redhat.com>, "Richard Henderson" <richard.henderson@linaro.org>, qemu-devel@nongnu.org, "Peter Xu" <peterx@redhat.com>, "Markus Armbruster" <armbru@redhat.com>, "Eugenio Pérez" <eperezma@redhat.com>, "Stefan Hajnoczi" <stefanha@redhat.com>, "Xiao W Wang" <xiao.w.wang@intel.com>, "Harpreet Singh Anand" <hanand@xilinx.com>, "Eli Cohen" <eli@mellanox.com>, "Paolo Bonzini" <pbonzini@redhat.com>, "Stefano Garzarella" <sgarzare@redhat.com>, "Eric Blake" <eblake@redhat.com>, virtualization@lists.linux-foundation.org, "Parav Pandit" <parav@mellanox.com> Subject: Re: [RFC PATCH v5 02/26] vhost: Fix last queue index of devices with no cvq Date: Tue, 02 Nov 2021 08:39:37 +0100 [thread overview] Message-ID: <87v91bngzq.fsf@secure.mitica> (raw) In-Reply-To: <20211102033023-mutt-send-email-mst@kernel.org> (Michael S. Tsirkin's message of "Tue, 2 Nov 2021 03:32:32 -0400") "Michael S. Tsirkin" <mst@redhat.com> wrote: > On Tue, Nov 02, 2021 at 08:25:27AM +0100, Juan Quintela wrote: >> Eugenio Pérez <eperezma@redhat.com> wrote: >> > The -1 assumes that all devices with no cvq have an spare vq allocated >> > for them, but with no offer of VIRTIO_NET_F_CTRL_VQ. This may not be the >> > case, and the device may have a pair number of queues. >> ^^^^ >> even >> >> I know, I know, I am Spanish myself O:-) > > Nobody expects the Spanish ;) O:-) >> int main(void) >> { >> int i = 7; >> i &= -1ULL; > > Stefano's patch has ~1ULL , not -1ULL here. > Stupid eyes. Thanks, Juan.
next prev parent reply other threads:[~2021-11-02 7:39 UTC|newest] Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-29 18:34 [RFC PATCH v5 00/26] vDPA shadow virtqueue Eugenio Pérez 2021-10-29 18:35 ` [RFC PATCH v5 01/26] util: Make some iova_tree parameters const Eugenio Pérez 2021-10-31 18:59 ` Juan Quintela 2021-10-31 18:59 ` Juan Quintela 2021-11-01 8:20 ` Eugenio Perez Martin 2021-10-29 18:35 ` [RFC PATCH v5 02/26] vhost: Fix last queue index of devices with no cvq Eugenio Pérez 2021-11-02 7:25 ` Juan Quintela 2021-11-02 7:25 ` Juan Quintela 2021-11-02 7:32 ` Michael S. Tsirkin 2021-11-02 7:32 ` Michael S. Tsirkin 2021-11-02 7:39 ` Juan Quintela [this message] 2021-11-02 7:39 ` Juan Quintela 2021-11-02 8:34 ` Eugenio Perez Martin 2021-11-02 7:40 ` Juan Quintela 2021-11-02 7:40 ` Juan Quintela 2021-10-29 18:35 ` [RFC PATCH v5 03/26] virtio: Add VIRTIO_F_QUEUE_STATE Eugenio Pérez 2021-11-02 4:57 ` Jason Wang 2021-11-02 4:57 ` Jason Wang 2021-10-29 18:35 ` [RFC PATCH v5 04/26] virtio-net: Honor VIRTIO_CONFIG_S_DEVICE_STOPPED Eugenio Pérez 2021-10-29 18:35 ` [RFC PATCH v5 05/26] vhost: Add x-vhost-set-shadow-vq qmp Eugenio Pérez 2021-11-02 7:36 ` Juan Quintela 2021-11-02 7:36 ` Juan Quintela 2021-11-02 8:29 ` Eugenio Perez Martin 2021-10-29 18:35 ` [RFC PATCH v5 06/26] vhost: Add VhostShadowVirtqueue Eugenio Pérez 2021-10-29 18:35 ` [RFC PATCH v5 07/26] vdpa: Save kick_fd in vhost-vdpa Eugenio Pérez 2021-10-29 18:35 ` [RFC PATCH v5 08/26] vdpa: Add vhost_svq_get_dev_kick_notifier Eugenio Pérez 2021-10-29 18:35 ` [RFC PATCH v5 09/26] vdpa: Add vhost_svq_set_svq_kick_fd Eugenio Pérez 2021-10-29 18:35 ` [RFC PATCH v5 10/26] vhost: Add Shadow VirtQueue kick forwarding capabilities Eugenio Pérez 2021-10-29 18:35 ` [RFC PATCH v5 11/26] vhost: Handle host notifiers in SVQ Eugenio Pérez 2021-11-02 7:54 ` Jason Wang 2021-11-02 7:54 ` Jason Wang 2021-11-02 8:46 ` Eugenio Perez Martin [not found] ` <CACGkMEvOxUMo1WA4tUfDhw+FOJVW87JJGPw=U3JvUSQTU_ogWQ@mail.gmail.com> [not found] ` <CAJaqyWd4DQwRSL5StCft+3-uq12TW5x1o4DN_YW97D0JzOr2XQ@mail.gmail.com> 2021-11-04 2:31 ` Jason Wang 2021-11-04 2:31 ` Jason Wang 2021-10-29 18:35 ` [RFC PATCH v5 12/26] vhost: Route guest->host notification through shadow virtqueue Eugenio Pérez 2021-11-02 5:36 ` Jason Wang 2021-11-02 5:36 ` Jason Wang 2021-11-02 7:35 ` Eugenio Perez Martin 2021-10-29 18:35 ` [RFC PATCH v5 13/26] Add vhost_svq_get_svq_call_notifier Eugenio Pérez 2021-10-29 18:35 ` [RFC PATCH v5 14/26] Add vhost_svq_set_guest_call_notifier Eugenio Pérez 2021-10-29 18:35 ` [RFC PATCH v5 15/26] vdpa: Save call_fd in vhost-vdpa Eugenio Pérez 2021-10-29 18:35 ` [RFC PATCH v5 16/26] vhost-vdpa: Take into account SVQ in vhost_vdpa_set_vring_call Eugenio Pérez 2021-10-29 18:35 ` [RFC PATCH v5 17/26] vhost: Route host->guest notification through shadow virtqueue Eugenio Pérez 2021-10-29 18:35 ` [RFC PATCH v5 18/26] virtio: Add vhost_shadow_vq_get_vring_addr Eugenio Pérez 2021-10-29 18:35 ` [RFC PATCH v5 19/26] vdpa: ack VIRTIO_F_QUEUE_STATE if device supports it Eugenio Pérez 2021-10-29 18:35 ` [RFC PATCH v5 20/26] vhost: Add vhost_svq_valid_device_features to shadow vq Eugenio Pérez 2021-10-29 18:35 ` [RFC PATCH v5 21/26] vhost: Add vhost_svq_valid_guest_features " Eugenio Pérez 2021-11-02 5:25 ` Jason Wang 2021-11-02 5:25 ` Jason Wang 2021-11-02 8:09 ` Eugenio Perez Martin 2021-11-03 3:18 ` Jason Wang 2021-11-03 3:18 ` Jason Wang 2021-11-03 7:43 ` Eugenio Perez Martin 2021-11-04 2:34 ` Jason Wang 2021-11-04 2:34 ` Jason Wang 2021-10-29 18:35 ` [RFC PATCH v5 22/26] vhost: Shadow virtqueue buffers forwarding Eugenio Pérez 2021-11-02 7:59 ` Jason Wang 2021-11-02 7:59 ` Jason Wang 2021-11-02 10:22 ` Eugenio Perez Martin 2021-10-29 18:35 ` [RFC PATCH v5 23/26] util: Add iova_tree_alloc Eugenio Pérez 2021-11-02 6:35 ` Jason Wang 2021-11-02 6:35 ` Jason Wang 2021-11-02 8:28 ` Eugenio Perez Martin 2021-11-03 3:10 ` Jason Wang 2021-11-03 3:10 ` Jason Wang 2021-11-03 7:41 ` Eugenio Perez Martin 2021-11-23 6:56 ` Peter Xu 2021-11-23 6:56 ` Peter Xu 2021-11-23 7:08 ` Eugenio Perez Martin 2022-01-27 8:57 ` Peter Xu 2022-01-27 8:57 ` Peter Xu 2022-01-27 10:09 ` Eugenio Perez Martin 2022-01-27 11:25 ` Peter Xu 2022-01-27 11:25 ` Peter Xu 2022-01-27 11:45 ` Eugenio Perez Martin 2021-10-29 18:35 ` [RFC PATCH v5 24/26] vhost: Add VhostIOVATree Eugenio Pérez 2021-10-29 18:35 ` [RFC PATCH v5 25/26] vhost: Use a tree to store memory mappings Eugenio Pérez 2021-10-29 18:35 ` [RFC PATCH v5 26/26] vdpa: Add custom IOTLB translations to SVQ Eugenio Pérez 2021-11-01 9:06 ` [RFC PATCH v5 00/26] vDPA shadow virtqueue Eugenio Perez Martin 2021-11-02 4:25 ` Jason Wang 2021-11-02 4:25 ` Jason Wang 2021-11-02 11:21 ` Eugenio Perez Martin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87v91bngzq.fsf@secure.mitica \ --to=quintela@redhat.com \ --cc=armbru@redhat.com \ --cc=eblake@redhat.com \ --cc=ehabkost@redhat.com \ --cc=eli@mellanox.com \ --cc=eperezma@redhat.com \ --cc=hanand@xilinx.com \ --cc=lvivier@redhat.com \ --cc=mst@redhat.com \ --cc=parav@mellanox.com \ --cc=pbonzini@redhat.com \ --cc=qemu-devel@nongnu.org \ --cc=richard.henderson@linaro.org \ --cc=stefanha@redhat.com \ --cc=virtualization@lists.linux-foundation.org \ --cc=xiao.w.wang@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.