All of lore.kernel.org
 help / color / mirror / Atom feed
From: Reinhard Tartler <Reinhard.Tartler@informatik.uni-erlangen.de>
To: Russell King <linux@arm.linux.org.uk>,
	Rob Herring <rob.herring@calxeda.com>,
	Nicolas Pitre <nicolas.pitre@linaro.org>,
	Arnd Bergmann <arnd@arndb.de>, Guan Xuetao <gxt@mprc.pku.edu.cn>,
	Ralf Baechle <ralf@linux-mips.org>
Cc: vamos-dev@lists.informatik.uni-erlangen.de,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] ARM: arch/arm/mach-shark/pci.c: signal errors correctly
Date: Tue, 24 Apr 2012 11:45:37 +0200	[thread overview]
Message-ID: <87vckpsbsu.fsf@faui43f.informatik.uni-erlangen.de> (raw)


Hi,

with configration-aware static analysis, we have found a gcc warning
that can be fixed easily. Please consider applying the following
patch (based on v3.4-rc4).


>From 4fd3be96ed8d35d9825d833623ddd69485ddc5ba Mon Sep 17 00:00:00 2001
From: Reinhard Tartler <siretart@tauware.de>
Date: Tue, 24 Apr 2012 11:35:16 +0200
Subject: [PATCH] ARM: arch/arm/mach-shark/pci.c: signal errors correctly
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This commit fixes the following gcc warning:
arch/arm/mach-shark/pci.c:42: warning: ‘return’ with no value, in function returning non-void

Signed-off-by: Reinhard Tartler <tartler@cs.fau.de>
---
 arch/arm/mach-shark/pci.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-shark/pci.c b/arch/arm/mach-shark/pci.c
index 7cb79a0..12fcc47 100644
--- a/arch/arm/mach-shark/pci.c
+++ b/arch/arm/mach-shark/pci.c
@@ -39,7 +39,7 @@ static struct hw_pci shark_pci __initdata = {
 static int __init shark_pci_init(void)
 {
        if (!machine_is_shark())
-               return;
+               return 1;
 
        pcibios_min_io = 0x6000;
        pcibios_min_mem = 0x50000000;
-- 
1.7.9.5


-- 
Reinhard Tartler                     Department of Computer Science IV
Martensstr 1, 91058 Erlangen Germany, University of Erlangen-Nuremberg
            http://www4.informatik.uni-erlangen.de/~tartler

WARNING: multiple messages have this Message-ID (diff)
From: Reinhard.Tartler@informatik.uni-erlangen.de (Reinhard Tartler)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: arch/arm/mach-shark/pci.c: signal errors correctly
Date: Tue, 24 Apr 2012 11:45:37 +0200	[thread overview]
Message-ID: <87vckpsbsu.fsf@faui43f.informatik.uni-erlangen.de> (raw)


Hi,

with configration-aware static analysis, we have found a gcc warning
that can be fixed easily. Please consider applying the following
patch (based on v3.4-rc4).


>From 4fd3be96ed8d35d9825d833623ddd69485ddc5ba Mon Sep 17 00:00:00 2001
From: Reinhard Tartler <siretart@tauware.de>
Date: Tue, 24 Apr 2012 11:35:16 +0200
Subject: [PATCH] ARM: arch/arm/mach-shark/pci.c: signal errors correctly
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This commit fixes the following gcc warning:
arch/arm/mach-shark/pci.c:42: warning: ?return? with no value, in function returning non-void

Signed-off-by: Reinhard Tartler <tartler@cs.fau.de>
---
 arch/arm/mach-shark/pci.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-shark/pci.c b/arch/arm/mach-shark/pci.c
index 7cb79a0..12fcc47 100644
--- a/arch/arm/mach-shark/pci.c
+++ b/arch/arm/mach-shark/pci.c
@@ -39,7 +39,7 @@ static struct hw_pci shark_pci __initdata = {
 static int __init shark_pci_init(void)
 {
        if (!machine_is_shark())
-               return;
+               return 1;
 
        pcibios_min_io = 0x6000;
        pcibios_min_mem = 0x50000000;
-- 
1.7.9.5


-- 
Reinhard Tartler                     Department of Computer Science IV
Martensstr 1, 91058 Erlangen Germany, University of Erlangen-Nuremberg
            http://www4.informatik.uni-erlangen.de/~tartler

             reply	other threads:[~2012-04-24  9:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-24  9:45 Reinhard Tartler [this message]
2012-04-24  9:45 ` [PATCH] ARM: arch/arm/mach-shark/pci.c: signal errors correctly Reinhard Tartler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vckpsbsu.fsf@faui43f.informatik.uni-erlangen.de \
    --to=reinhard.tartler@informatik.uni-erlangen.de \
    --cc=arnd@arndb.de \
    --cc=gxt@mprc.pku.edu.cn \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=nicolas.pitre@linaro.org \
    --cc=ralf@linux-mips.org \
    --cc=rob.herring@calxeda.com \
    --cc=vamos-dev@lists.informatik.uni-erlangen.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.