All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3 0/2] Sanitycheck PCI BARs
@ 2022-08-05 15:59 ` Piorkowski, Piotr
  0 siblings, 0 replies; 15+ messages in thread
From: Piorkowski, Piotr @ 2022-08-05 15:59 UTC (permalink / raw)
  To: intel-gfx, dri-devel; +Cc: Lucas De Marchi, Piotr Piórkowski

From: Piotr Piórkowski <piotr.piorkowski@intel.com>

When initializing the i915, we want to be sure that the PCI
BARs have been properly initialized.
As part of this series, I have prepared two patches,
one that introduces BARs names to use in code instead of numbers,
and another that adds function to validate BARs before use.
This is an evolution of the concept I presented in the patch:
https://patchwork.freedesktop.org/patch/470184/?series=99094
The main difference between the original patch and what I have
prepared here is that previously I checked all BARs at the beginning
of i915 initialization, and now I only check BAR 0 at beginning.
This is due to the fact that I have noticed that it can happen that only
BAR 0 is available (I have observed this in the case of virtualization,
on some platforms).
Therefore, at the beginning, let's verify only BAR 0, and the others only
before the first use.

v2: Fix build
v3: replace header linux/pci.h to forward declaration for struct pci_dev

Signed-off-by: Piotr Piórkowski <piotr.piorkowski@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Matt Roper <matthew.d.roper@intel.com>


Piotr Piórkowski (2):
  drm/i915: Use of BARs names instead of numbers
  drm/i915: Sanitycheck PCI BARs

 .../gpu/drm/i915/display/intel_lpe_audio.c    |  5 ++--
 drivers/gpu/drm/i915/gem/i915_gem_stolen.c    | 11 +++++---
 drivers/gpu/drm/i915/gt/intel_ggtt.c          | 16 +++++++++---
 drivers/gpu/drm/i915/gt/intel_gt.c            |  3 ++-
 drivers/gpu/drm/i915/gt/intel_region_lmem.c   | 17 +++++++------
 drivers/gpu/drm/i915/gvt/cfg_space.c          |  5 ++--
 drivers/gpu/drm/i915/i915_pci.c               | 25 +++++++++++++++++++
 drivers/gpu/drm/i915/i915_pci.h               |  6 +++++
 drivers/gpu/drm/i915/intel_pci_config.h       |  7 ++++++
 9 files changed, 76 insertions(+), 19 deletions(-)

-- 
2.25.1


^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2022-08-10 11:33 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-05 15:59 [PATCH v3 0/2] Sanitycheck PCI BARs Piorkowski, Piotr
2022-08-05 15:59 ` [Intel-gfx] " Piorkowski, Piotr
2022-08-05 15:59 ` [PATCH v3 1/2] drm/i915: Use of BARs names instead of numbers Piorkowski, Piotr
2022-08-05 15:59   ` [Intel-gfx] " Piorkowski, Piotr
2022-08-10 10:53   ` Andrzej Hajda
2022-08-10 11:31     ` Jani Nikula
2022-08-05 15:59 ` [PATCH v3 2/2] drm/i915: Sanitycheck PCI BARs Piorkowski, Piotr
2022-08-05 15:59   ` [Intel-gfx] " Piorkowski, Piotr
2022-08-10 10:39   ` Jani Nikula
2022-08-10 10:39     ` [Intel-gfx] " Jani Nikula
2022-08-05 17:18 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Sanitycheck PCI BARs (rev2) Patchwork
2022-08-05 17:41 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2022-08-08 20:26   ` Matt Roper
2022-08-08 20:34 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-08-08 23:46 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.