All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Daniel Palmer <daniel@0x0f.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	DTML <devicetree@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Romain Perier <romain.perier@gmail.com>
Subject: Re: [PATCH 2/3] irqchip: SigmaStar SSD20xD gpi
Date: Thu, 30 Sep 2021 15:11:32 +0100	[thread overview]
Message-ID: <87y27erw4r.wl-maz@kernel.org> (raw)
In-Reply-To: <CAFr9PXn5BiN1mqeZYcVMfDKWx3Re9BkY_miE34669XivCpmrCg@mail.gmail.com>

On Thu, 30 Sep 2021 14:59:24 +0100,
Daniel Palmer <daniel@0x0f.com> wrote:
> 
> Hi Marc,
> 
> On Thu, 30 Sept 2021 at 22:53, Marc Zyngier <maz@kernel.org> wrote:
> > Somehow, the handler for this interrupt is set to handle_bad_irq(),
> > which probably isn't what you want. You'll have to find out who sets
> > this (there is a comment about that in gpiolib.c, but I haven't had a
> > chance to find where this is coming from).
> >
> > Do you happen to set it in your driver?
> 
> The gpio driver (gpio-msc313.c) sets it during probe:
> 
> gpioirqchip = &gpiochip->irq;
> gpioirqchip->chip = &msc313_gpio_irqchip;
> gpioirqchip->fwnode = of_node_to_fwnode(dev->of_node);
> gpioirqchip->parent_domain = parent_domain;
> gpioirqchip->child_to_parent_hwirq = match_data->child_to_parent_hwirq;
> gpioirqchip->populate_parent_alloc_arg = match_data->populate_parent_fwspec;
> gpioirqchip->handler = handle_bad_irq;
> gpioirqchip->default_type = IRQ_TYPE_NONE;

Right. I have no idea why this is a requirement, and I would normally
set it to whatever is the normal flow handler on this HW, but this
looks like the GPIO subsystem has some expectations here.

I'll let Linus comment on it.

	M.

-- 
Without deviation from the norm, progress is not possible.

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Daniel Palmer <daniel@0x0f.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	DTML <devicetree@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Romain Perier <romain.perier@gmail.com>
Subject: Re: [PATCH 2/3] irqchip: SigmaStar SSD20xD gpi
Date: Thu, 30 Sep 2021 15:11:32 +0100	[thread overview]
Message-ID: <87y27erw4r.wl-maz@kernel.org> (raw)
In-Reply-To: <CAFr9PXn5BiN1mqeZYcVMfDKWx3Re9BkY_miE34669XivCpmrCg@mail.gmail.com>

On Thu, 30 Sep 2021 14:59:24 +0100,
Daniel Palmer <daniel@0x0f.com> wrote:
> 
> Hi Marc,
> 
> On Thu, 30 Sept 2021 at 22:53, Marc Zyngier <maz@kernel.org> wrote:
> > Somehow, the handler for this interrupt is set to handle_bad_irq(),
> > which probably isn't what you want. You'll have to find out who sets
> > this (there is a comment about that in gpiolib.c, but I haven't had a
> > chance to find where this is coming from).
> >
> > Do you happen to set it in your driver?
> 
> The gpio driver (gpio-msc313.c) sets it during probe:
> 
> gpioirqchip = &gpiochip->irq;
> gpioirqchip->chip = &msc313_gpio_irqchip;
> gpioirqchip->fwnode = of_node_to_fwnode(dev->of_node);
> gpioirqchip->parent_domain = parent_domain;
> gpioirqchip->child_to_parent_hwirq = match_data->child_to_parent_hwirq;
> gpioirqchip->populate_parent_alloc_arg = match_data->populate_parent_fwspec;
> gpioirqchip->handler = handle_bad_irq;
> gpioirqchip->default_type = IRQ_TYPE_NONE;

Right. I have no idea why this is a requirement, and I would normally
set it to whatever is the normal flow handler on this HW, but this
looks like the GPIO subsystem has some expectations here.

I'll let Linus comment on it.

	M.

-- 
Without deviation from the norm, progress is not possible.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-09-30 14:11 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-14 10:04 [PATCH 0/3] SigmaStar SSD20XD GPIO interrupt controller Daniel Palmer
2021-09-14 10:04 ` Daniel Palmer
2021-09-14 10:04 ` [PATCH 1/3] dt-bindings: interrupt-controller: Add SigmaStar SSD20xD gpi Daniel Palmer
2021-09-14 10:04   ` Daniel Palmer
2021-09-21 20:36   ` Rob Herring
2021-09-21 20:36     ` Rob Herring
2021-09-14 10:04 ` [PATCH 2/3] irqchip: " Daniel Palmer
2021-09-14 10:04   ` Daniel Palmer
2021-09-20  9:45   ` Marc Zyngier
2021-09-20  9:45     ` Marc Zyngier
2021-09-20 10:05     ` Daniel Palmer
2021-09-20 10:05       ` Daniel Palmer
2021-09-20 11:24       ` Marc Zyngier
2021-09-20 11:24         ` Marc Zyngier
2021-09-21  4:16         ` Daniel Palmer
2021-09-21  4:16           ` Daniel Palmer
2021-09-21  8:27           ` Marc Zyngier
2021-09-21  8:27             ` Marc Zyngier
2021-09-21 18:23             ` Linus Walleij
2021-09-21 18:23               ` Linus Walleij
2021-09-30 12:39               ` Daniel Palmer
2021-09-30 12:39                 ` Daniel Palmer
2021-09-30 13:07                 ` Marc Zyngier
2021-09-30 13:07                   ` Marc Zyngier
2021-09-30 13:10                   ` Daniel Palmer
2021-09-30 13:10                     ` Daniel Palmer
2021-09-30 13:06               ` Marc Zyngier
2021-09-30 13:06                 ` Marc Zyngier
2021-09-30 13:36                 ` Daniel Palmer
2021-09-30 13:36                   ` Daniel Palmer
2021-09-30 13:53                   ` Marc Zyngier
2021-09-30 13:53                     ` Marc Zyngier
2021-09-30 13:59                     ` Daniel Palmer
2021-09-30 13:59                       ` Daniel Palmer
2021-09-30 14:11                       ` Marc Zyngier [this message]
2021-09-30 14:11                         ` Marc Zyngier
2021-09-30 16:10                         ` Linus Walleij
2021-09-30 16:10                           ` Linus Walleij
2021-09-30 16:13                   ` Linus Walleij
2021-09-30 16:13                     ` Linus Walleij
2021-10-01 12:33                     ` Daniel Palmer
2021-10-01 12:33                       ` Daniel Palmer
2021-10-02  3:08                     ` Daniel Palmer
2021-10-02  3:08                       ` Daniel Palmer
2021-09-21  6:11         ` Daniel Palmer
2021-09-21  6:11           ` Daniel Palmer
2021-09-14 10:04 ` [PATCH 3/3] ARM: dts: mstar: Add gpi interrupt controller to i2m Daniel Palmer
2021-09-14 10:04   ` Daniel Palmer
2021-09-14 15:59 ` [PATCH 0/3] SigmaStar SSD20XD GPIO interrupt controller Andrew Lunn
2021-09-14 15:59   ` Andrew Lunn
2021-09-15  9:06   ` Daniel Palmer
2021-09-15  9:06     ` Daniel Palmer
2021-09-15 20:34     ` Andrew Lunn
2021-09-15 20:34       ` Andrew Lunn
2021-09-20  8:36       ` Daniel Palmer
2021-09-20  8:36         ` Daniel Palmer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y27erw4r.wl-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=daniel@0x0f.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=romain.perier@gmail.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.