All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Gabriela Bittencourt <gabrielabittencourt00@gmail.com>,
	 outreachy-kernel@googlegroups.com, sudipm.mukherjee@gmail.com,
	 teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org,
	 linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
	 linux-kernel@vger.kernel.org, lkcamp@lists.libreplanetbr.org,
	trivial@kernel.org
Subject: Re: [PATCH] staging: sm750fb: align arguments with open parenthesis
Date: Fri, 11 Oct 2019 19:07:06 -0700	[thread overview]
Message-ID: <8886b98ca936e7150abf36aa3c9d167073eaba86.camel@perches.com> (raw)
In-Reply-To: <20191012011956.9452-1-gabrielabittencourt00@gmail.com>

On Fri, 2019-10-11 at 22:19 -0300, Gabriela Bittencourt wrote:
> Cleans up checks of "Alignment should match open parenthesis" in tree sm750fb
[]
> diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c
[]
> @@ -289,7 +289,7 @@ static unsigned int deGetTransparency(struct lynx_accel *accel)
>  }
>  
>  int sm750_hw_imageblit(struct lynx_accel *accel,
> -		 const char *pSrcbuf, /* pointer to start of source buffer in system memory */
> +		       const char *pSrcbuf, /* pointer to start of source buffer in system memory */
>  		 u32 srcDelta,          /* Pitch value (in bytes) of the source buffer, +ive means top down and -ive mean button up */

checkpatch only warns on the first unaligned argument, but
all statement lines are meant to align to the open parenthesis.

>  		 u32 startBit, /* Mono data can start at any bit in a byte, this value should be 0 to 7 */
>  		 u32 dBase,    /* Address of destination: offset in frame buffer */




WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Gabriela Bittencourt <gabrielabittencourt00@gmail.com>,
	outreachy-kernel@googlegroups.com, sudipm.mukherjee@gmail.com,
	teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org,
	linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org, lkcamp@lists.libreplanetbr.org,
	trivial@kernel.org
Subject: Re: [PATCH] staging: sm750fb: align arguments with open parenthesis
Date: Sat, 12 Oct 2019 02:07:06 +0000	[thread overview]
Message-ID: <8886b98ca936e7150abf36aa3c9d167073eaba86.camel@perches.com> (raw)
In-Reply-To: <20191012011956.9452-1-gabrielabittencourt00@gmail.com>

On Fri, 2019-10-11 at 22:19 -0300, Gabriela Bittencourt wrote:
> Cleans up checks of "Alignment should match open parenthesis" in tree sm750fb
[]
> diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c
[]
> @@ -289,7 +289,7 @@ static unsigned int deGetTransparency(struct lynx_accel *accel)
>  }
>  
>  int sm750_hw_imageblit(struct lynx_accel *accel,
> -		 const char *pSrcbuf, /* pointer to start of source buffer in system memory */
> +		       const char *pSrcbuf, /* pointer to start of source buffer in system memory */
>  		 u32 srcDelta,          /* Pitch value (in bytes) of the source buffer, +ive means top down and -ive mean button up */

checkpatch only warns on the first unaligned argument, but
all statement lines are meant to align to the open parenthesis.

>  		 u32 startBit, /* Mono data can start at any bit in a byte, this value should be 0 to 7 */
>  		 u32 dBase,    /* Address of destination: offset in frame buffer */

WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Gabriela Bittencourt <gabrielabittencourt00@gmail.com>,
	 outreachy-kernel@googlegroups.com, sudipm.mukherjee@gmail.com,
	 teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org,
	 linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
	 linux-kernel@vger.kernel.org, lkcamp@lists.libreplanetbr.org,
	trivial@kernel.org
Subject: Re: [PATCH] staging: sm750fb: align arguments with open parenthesis
Date: Fri, 11 Oct 2019 19:07:06 -0700	[thread overview]
Message-ID: <8886b98ca936e7150abf36aa3c9d167073eaba86.camel@perches.com> (raw)
In-Reply-To: <20191012011956.9452-1-gabrielabittencourt00@gmail.com>

On Fri, 2019-10-11 at 22:19 -0300, Gabriela Bittencourt wrote:
> Cleans up checks of "Alignment should match open parenthesis" in tree sm750fb
[]
> diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c
[]
> @@ -289,7 +289,7 @@ static unsigned int deGetTransparency(struct lynx_accel *accel)
>  }
>  
>  int sm750_hw_imageblit(struct lynx_accel *accel,
> -		 const char *pSrcbuf, /* pointer to start of source buffer in system memory */
> +		       const char *pSrcbuf, /* pointer to start of source buffer in system memory */
>  		 u32 srcDelta,          /* Pitch value (in bytes) of the source buffer, +ive means top down and -ive mean button up */

checkpatch only warns on the first unaligned argument, but
all statement lines are meant to align to the open parenthesis.

>  		 u32 startBit, /* Mono data can start at any bit in a byte, this value should be 0 to 7 */
>  		 u32 dBase,    /* Address of destination: offset in frame buffer */


_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  reply	other threads:[~2019-10-12  2:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-12  1:19 [PATCH] staging: sm750fb: align arguments with open parenthesis Gabriela Bittencourt
2019-10-12  1:19 ` Gabriela Bittencourt
2019-10-12  1:19 ` Gabriela Bittencourt
2019-10-12  2:07 ` Joe Perches [this message]
2019-10-12  2:07   ` Joe Perches
2019-10-12  2:07   ` Joe Perches
2019-10-12  5:41 ` [Outreachy kernel] " Julia Lawall
2019-10-12  5:41   ` Julia Lawall
2019-10-12  5:41   ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8886b98ca936e7150abf36aa3c9d167073eaba86.camel@perches.com \
    --to=joe@perches.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gabrielabittencourt00@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkcamp@lists.libreplanetbr.org \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=teddy.wang@siliconmotion.com \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.