All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Shenhar, Talel" <talel@amazon.com>
To: Marc Zyngier <marc.zyngier@arm.com>,
	<nicolas.ferre@microchip.com>, <jason@lakedaemon.net>,
	<mark.rutland@arm.com>, <mchehab+samsung@kernel.org>,
	<robh+dt@kernel.org>, <davem@davemloft.net>,
	<shawn.lin@rock-chips.com>, <tglx@linutronix.de>,
	<devicetree@vger.kernel.org>, <gregkh@linuxfoundation.org>,
	<linux-kernel@vger.kernel.org>
Cc: <dwmw@amazon.co.uk>, <benh@kernel.crashing.org>,
	<jonnyc@amazon.com>, <hhhawa@amazon.com>, <ronenk@amazon.com>,
	<hanochu@amazon.com>, <barakw@amazon.com>, <talel@amazon.com>
Subject: Re: [PATCH v2 2/2] irqchip: al-fic: Introduce Amazon's Annapurna Labs Fabric Interrupt Controller Driver
Date: Thu, 6 Jun 2019 10:25:55 +0300	[thread overview]
Message-ID: <88907fea-aee1-62c8-604a-726b603ec48a@amazon.com> (raw)
In-Reply-To: <0915892c-0e53-8f53-e858-b1c3298a4d35@arm.com>


On 6/5/2019 6:12 PM, Marc Zyngier wrote:
> On 05/06/2019 15:38, Shenhar, Talel wrote:
>>
>> FIC only support two sensing modes, rising-edge and level.
> Yes, I can tell. Yet, this code will let EDGE_BOTH pass through, even if
> it cannot handle it.
Will handle on v4
> Indeed we use interrupt specifier that has the level type in it
>> (dt-binding: "#interrupt-cells: must be 2.") which in turns causes to
>> this irq_set_type callback.
> Well, this isn't what the example in your DT binding shows.
Will update the example in v4


Thanks,

Talel.


WARNING: multiple messages have this Message-ID (diff)
From: "Shenhar, Talel" <talel@amazon.com>
To: Marc Zyngier <marc.zyngier@arm.com>,
	nicolas.ferre@microchip.com, jason@lakedaemon.net,
	mark.rutland@arm.com, mchehab+samsung@kernel.org,
	robh+dt@kernel.org, davem@davemloft.net,
	shawn.lin@rock-chips.com, tglx@linutronix.de,
	devicetree@vger.kernel.org, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org
Cc: dwmw@amazon.co.uk, benh@kernel.crashing.org, jonnyc@amazon.com,
	hhhawa@amazon.com, ronenk@amazon.com, hanochu@amazon.com,
	barakw@amazon.com, talel@amazon.com
Subject: Re: [PATCH v2 2/2] irqchip: al-fic: Introduce Amazon's Annapurna Labs Fabric Interrupt Controller Driver
Date: Thu, 6 Jun 2019 10:25:55 +0300	[thread overview]
Message-ID: <88907fea-aee1-62c8-604a-726b603ec48a@amazon.com> (raw)
In-Reply-To: <0915892c-0e53-8f53-e858-b1c3298a4d35@arm.com>


On 6/5/2019 6:12 PM, Marc Zyngier wrote:
> On 05/06/2019 15:38, Shenhar, Talel wrote:
>>
>> FIC only support two sensing modes, rising-edge and level.
> Yes, I can tell. Yet, this code will let EDGE_BOTH pass through, even if
> it cannot handle it.
Will handle on v4
> Indeed we use interrupt specifier that has the level type in it
>> (dt-binding: "#interrupt-cells: must be 2.") which in turns causes to
>> this irq_set_type callback.
> Well, this isn't what the example in your DT binding shows.
Will update the example in v4


Thanks,

Talel.

  parent reply	other threads:[~2019-06-06  7:26 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-05 10:51 [PATCH v2 0/2] Amazon's Annapurna Labs Fabric Interrupt Controller Talel Shenhar
2019-06-05 10:51 ` Talel Shenhar
2019-06-05 10:52 ` [PATCH v2 1/2] dt-bindings: interrupt-controller: Amazon's Annapurna Labs FIC Talel Shenhar
2019-06-05 10:52   ` Talel Shenhar
2019-06-05 11:08   ` Sudeep Holla
2019-06-05 15:49   ` Eduardo Valentin
2019-06-05 15:49     ` Eduardo Valentin
2019-06-06  7:23     ` Shenhar, Talel
2019-06-06  7:23       ` Shenhar, Talel
2019-06-05 10:52 ` [PATCH v2 2/2] irqchip: al-fic: Introduce Amazon's Annapurna Labs Fabric Interrupt Controller Driver Talel Shenhar
2019-06-05 10:52   ` Talel Shenhar
2019-06-05 12:22   ` Marc Zyngier
2019-06-05 14:38     ` Shenhar, Talel
2019-06-05 14:38       ` Shenhar, Talel
2019-06-05 15:12       ` Marc Zyngier
2019-06-05 22:06         ` Benjamin Herrenschmidt
2019-06-06  7:05           ` Marc Zyngier
2019-06-06  7:05             ` Marc Zyngier
2019-06-06  7:49             ` Benjamin Herrenschmidt
2019-06-06  7:25         ` Shenhar, Talel [this message]
2019-06-06  7:25           ` Shenhar, Talel
2019-06-05 22:02     ` Benjamin Herrenschmidt
2019-06-06  7:10       ` Marc Zyngier
2019-06-06  7:10         ` Marc Zyngier
2019-06-05 12:50   ` Greg KH
2019-06-05 14:51     ` Shenhar, Talel
2019-06-05 14:51       ` Shenhar, Talel
2019-06-05 15:40       ` Greg KH
2019-06-05 14:56     ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=88907fea-aee1-62c8-604a-726b603ec48a@amazon.com \
    --to=talel@amazon.com \
    --cc=barakw@amazon.com \
    --cc=benh@kernel.crashing.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dwmw@amazon.co.uk \
    --cc=gregkh@linuxfoundation.org \
    --cc=hanochu@amazon.com \
    --cc=hhhawa@amazon.com \
    --cc=jason@lakedaemon.net \
    --cc=jonnyc@amazon.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=mchehab+samsung@kernel.org \
    --cc=nicolas.ferre@microchip.com \
    --cc=robh+dt@kernel.org \
    --cc=ronenk@amazon.com \
    --cc=shawn.lin@rock-chips.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.