All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Shenhar, Talel" <talel@amazon.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: <nicolas.ferre@microchip.com>, <jason@lakedaemon.net>,
	<marc.zyngier@arm.com>, <mark.rutland@arm.com>,
	<mchehab+samsung@kernel.org>, <robh+dt@kernel.org>,
	<davem@davemloft.net>, <shawn.lin@rock-chips.com>,
	<tglx@linutronix.de>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <dwmw@amazon.co.uk>,
	<benh@kernel.crashing.org>, <jonnyc@amazon.com>,
	<hhhawa@amazon.com>, <ronenk@amazon.com>, <hanochu@amazon.com>,
	<barakw@amazon.com>, <talel@amazon.com>
Subject: Re: [PATCH v2 2/2] irqchip: al-fic: Introduce Amazon's Annapurna Labs Fabric Interrupt Controller Driver
Date: Wed, 5 Jun 2019 17:51:08 +0300	[thread overview]
Message-ID: <fb3f5f4d-26f4-8729-7370-f206369ab2b7@amazon.com> (raw)
In-Reply-To: <20190605125055.GA3184@kroah.com>


On 6/5/2019 3:50 PM, Greg KH wrote:
> On Wed, Jun 05, 2019 at 01:52:01PM +0300, Talel Shenhar wrote:
>> --- /dev/null
>> +++ b/drivers/irqchip/irq-al-fic.c
>> @@ -0,0 +1,289 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/**
> No need for kernel-doc format style here.
done
>
>> + * Copyright 2019 Amazon.com, Inc. or its affiliates. All Rights Reserved.
> "or its affiliates"?  You know the answer to this, don't keep us in
> suspense.  Put the proper copyright holder here please, otherwise this
> is totally useless.
>
> Well, copyright notices are technically useless anyway, but lawyers like
> to cargo-cult with the best of them, so it should be correct at the
> least.

This is the format we were asked to use and have been using.

I am pinging them with your comment but I am likely not to get immediate 
response so I'm publishing v3 without changing the "affiliates" for now.

>
> thanks,
>
> greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: "Shenhar, Talel" <talel@amazon.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: nicolas.ferre@microchip.com, jason@lakedaemon.net,
	marc.zyngier@arm.com, mark.rutland@arm.com,
	mchehab+samsung@kernel.org, robh+dt@kernel.org,
	davem@davemloft.net, shawn.lin@rock-chips.com,
	tglx@linutronix.de, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, dwmw@amazon.co.uk,
	benh@kernel.crashing.org, jonnyc@amazon.com, hhhawa@amazon.com,
	ronenk@amazon.com, hanochu@amazon.com, barakw@amazon.com,
	talel@amazon.com
Subject: Re: [PATCH v2 2/2] irqchip: al-fic: Introduce Amazon's Annapurna Labs Fabric Interrupt Controller Driver
Date: Wed, 5 Jun 2019 17:51:08 +0300	[thread overview]
Message-ID: <fb3f5f4d-26f4-8729-7370-f206369ab2b7@amazon.com> (raw)
In-Reply-To: <20190605125055.GA3184@kroah.com>


On 6/5/2019 3:50 PM, Greg KH wrote:
> On Wed, Jun 05, 2019 at 01:52:01PM +0300, Talel Shenhar wrote:
>> --- /dev/null
>> +++ b/drivers/irqchip/irq-al-fic.c
>> @@ -0,0 +1,289 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/**
> No need for kernel-doc format style here.
done
>
>> + * Copyright 2019 Amazon.com, Inc. or its affiliates. All Rights Reserved.
> "or its affiliates"?  You know the answer to this, don't keep us in
> suspense.  Put the proper copyright holder here please, otherwise this
> is totally useless.
>
> Well, copyright notices are technically useless anyway, but lawyers like
> to cargo-cult with the best of them, so it should be correct at the
> least.

This is the format we were asked to use and have been using.

I am pinging them with your comment but I am likely not to get immediate 
response so I'm publishing v3 without changing the "affiliates" for now.

>
> thanks,
>
> greg k-h

  reply	other threads:[~2019-06-05 14:51 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-05 10:51 [PATCH v2 0/2] Amazon's Annapurna Labs Fabric Interrupt Controller Talel Shenhar
2019-06-05 10:51 ` Talel Shenhar
2019-06-05 10:52 ` [PATCH v2 1/2] dt-bindings: interrupt-controller: Amazon's Annapurna Labs FIC Talel Shenhar
2019-06-05 10:52   ` Talel Shenhar
2019-06-05 11:08   ` Sudeep Holla
2019-06-05 15:49   ` Eduardo Valentin
2019-06-05 15:49     ` Eduardo Valentin
2019-06-06  7:23     ` Shenhar, Talel
2019-06-06  7:23       ` Shenhar, Talel
2019-06-05 10:52 ` [PATCH v2 2/2] irqchip: al-fic: Introduce Amazon's Annapurna Labs Fabric Interrupt Controller Driver Talel Shenhar
2019-06-05 10:52   ` Talel Shenhar
2019-06-05 12:22   ` Marc Zyngier
2019-06-05 14:38     ` Shenhar, Talel
2019-06-05 14:38       ` Shenhar, Talel
2019-06-05 15:12       ` Marc Zyngier
2019-06-05 22:06         ` Benjamin Herrenschmidt
2019-06-06  7:05           ` Marc Zyngier
2019-06-06  7:05             ` Marc Zyngier
2019-06-06  7:49             ` Benjamin Herrenschmidt
2019-06-06  7:25         ` Shenhar, Talel
2019-06-06  7:25           ` Shenhar, Talel
2019-06-05 22:02     ` Benjamin Herrenschmidt
2019-06-06  7:10       ` Marc Zyngier
2019-06-06  7:10         ` Marc Zyngier
2019-06-05 12:50   ` Greg KH
2019-06-05 14:51     ` Shenhar, Talel [this message]
2019-06-05 14:51       ` Shenhar, Talel
2019-06-05 15:40       ` Greg KH
2019-06-05 14:56     ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fb3f5f4d-26f4-8729-7370-f206369ab2b7@amazon.com \
    --to=talel@amazon.com \
    --cc=barakw@amazon.com \
    --cc=benh@kernel.crashing.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dwmw@amazon.co.uk \
    --cc=gregkh@linuxfoundation.org \
    --cc=hanochu@amazon.com \
    --cc=hhhawa@amazon.com \
    --cc=jason@lakedaemon.net \
    --cc=jonnyc@amazon.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=mchehab+samsung@kernel.org \
    --cc=nicolas.ferre@microchip.com \
    --cc=robh+dt@kernel.org \
    --cc=ronenk@amazon.com \
    --cc=shawn.lin@rock-chips.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.