* [PATCH] ASoC: Intel: Skylake: make function skl_clk_round_rate static
@ 2018-02-08 14:35 ` Colin King
0 siblings, 0 replies; 9+ messages in thread
From: Colin King @ 2018-02-08 14:35 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Sriram Periyasamy, Stephen Boyd, Subhransu S . Prusty,
alsa-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The function skl_clk_round_rate is local to the source and does not
need to be in global scope, so make it static.
Cleans up sparse warning:
sound/soc/intel/skylake/skl-ssp-clk.c:250:6: warning: symbol
'skl_clk_round_rate' was not declared. Should it be static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
sound/soc/intel/skylake/skl-ssp-clk.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/intel/skylake/skl-ssp-clk.c b/sound/soc/intel/skylake/skl-ssp-clk.c
index 7fbddf5e3b00..cda1b5fa7436 100644
--- a/sound/soc/intel/skylake/skl-ssp-clk.c
+++ b/sound/soc/intel/skylake/skl-ssp-clk.c
@@ -247,8 +247,8 @@ static unsigned long skl_clk_recalc_rate(struct clk_hw *hw,
}
/* Not supported by clk driver. Implemented to satisfy clk fw */
-long skl_clk_round_rate(struct clk_hw *hw, unsigned long rate,
- unsigned long *parent_rate)
+static long skl_clk_round_rate(struct clk_hw *hw, unsigned long rate,
+ unsigned long *parent_rate)
{
return rate;
}
--
2.15.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] ASoC: Intel: Skylake: make function skl_clk_round_rate static
2018-02-08 14:35 ` Colin King
@ 2018-02-09 2:07 ` Takashi Sakamoto
-1 siblings, 0 replies; 9+ messages in thread
From: Takashi Sakamoto @ 2018-02-09 2:07 UTC (permalink / raw)
To: Colin King, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Sriram Periyasamy, Stephen Boyd,
Subhransu S . Prusty, alsa-devel
Cc: kernel-janitors, linux-kernel
Hi,
On Feb 8 2018 23:35, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function skl_clk_round_rate is local to the source and does not
> need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> sound/soc/intel/skylake/skl-ssp-clk.c:250:6: warning: symbol
> 'skl_clk_round_rate' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> sound/soc/intel/skylake/skl-ssp-clk.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
> diff --git a/sound/soc/intel/skylake/skl-ssp-clk.c b/sound/soc/intel/skylake/skl-ssp-clk.c
> index 7fbddf5e3b00..cda1b5fa7436 100644
> --- a/sound/soc/intel/skylake/skl-ssp-clk.c
> +++ b/sound/soc/intel/skylake/skl-ssp-clk.c
> @@ -247,8 +247,8 @@ static unsigned long skl_clk_recalc_rate(struct clk_hw *hw,
> }
>
> /* Not supported by clk driver. Implemented to satisfy clk fw */
> -long skl_clk_round_rate(struct clk_hw *hw, unsigned long rate,
> - unsigned long *parent_rate)
> +static long skl_clk_round_rate(struct clk_hw *hw, unsigned long rate,
> + unsigned long *parent_rate)
> {
> return rate;
> }
Thanks
Takashi Sakamoto
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] ASoC: Intel: Skylake: make function skl_clk_round_rate static
@ 2018-02-09 2:07 ` Takashi Sakamoto
0 siblings, 0 replies; 9+ messages in thread
From: Takashi Sakamoto @ 2018-02-09 2:07 UTC (permalink / raw)
To: Colin King, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Sriram Periyasamy, Stephen Boyd,
Subhransu S . Prusty, alsa-devel
Cc: kernel-janitors, linux-kernel
Hi,
On Feb 8 2018 23:35, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function skl_clk_round_rate is local to the source and does not
> need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> sound/soc/intel/skylake/skl-ssp-clk.c:250:6: warning: symbol
> 'skl_clk_round_rate' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> sound/soc/intel/skylake/skl-ssp-clk.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
> diff --git a/sound/soc/intel/skylake/skl-ssp-clk.c b/sound/soc/intel/skylake/skl-ssp-clk.c
> index 7fbddf5e3b00..cda1b5fa7436 100644
> --- a/sound/soc/intel/skylake/skl-ssp-clk.c
> +++ b/sound/soc/intel/skylake/skl-ssp-clk.c
> @@ -247,8 +247,8 @@ static unsigned long skl_clk_recalc_rate(struct clk_hw *hw,
> }
>
> /* Not supported by clk driver. Implemented to satisfy clk fw */
> -long skl_clk_round_rate(struct clk_hw *hw, unsigned long rate,
> - unsigned long *parent_rate)
> +static long skl_clk_round_rate(struct clk_hw *hw, unsigned long rate,
> + unsigned long *parent_rate)
> {
> return rate;
> }
Thanks
Takashi Sakamoto
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [alsa-devel] [PATCH] ASoC: Intel: Skylake: make function skl_clk_round_rate static
2018-02-08 14:35 ` Colin King
@ 2018-02-09 5:28 ` Vinod Koul
-1 siblings, 0 replies; 9+ messages in thread
From: Vinod Koul @ 2018-02-09 5:16 UTC (permalink / raw)
To: Colin King
Cc: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Sriram Periyasamy, Stephen Boyd, Subhransu S . Prusty,
alsa-devel, kernel-janitors, linux-kernel
On Thu, Feb 08, 2018 at 02:35:30PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function skl_clk_round_rate is local to the source and does not
> need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> sound/soc/intel/skylake/skl-ssp-clk.c:250:6: warning: symbol
> 'skl_clk_round_rate' was not declared. Should it be static?
Acked-By: Vinod Koul <vinod.koul@intel.com>
--
~Vinod
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [alsa-devel] [PATCH] ASoC: Intel: Skylake: make function skl_clk_round_rate static
@ 2018-02-09 5:28 ` Vinod Koul
0 siblings, 0 replies; 9+ messages in thread
From: Vinod Koul @ 2018-02-09 5:28 UTC (permalink / raw)
To: Colin King
Cc: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Sriram Periyasamy, Stephen Boyd, Subhransu S . Prusty,
alsa-devel, kernel-janitors, linux-kernel
On Thu, Feb 08, 2018 at 02:35:30PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function skl_clk_round_rate is local to the source and does not
> need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> sound/soc/intel/skylake/skl-ssp-clk.c:250:6: warning: symbol
> 'skl_clk_round_rate' was not declared. Should it be static?
Acked-By: Vinod Koul <vinod.koul@intel.com>
--
~Vinod
^ permalink raw reply [flat|nested] 9+ messages in thread
* Applied "ASoC: Intel: Skylake: make function skl_clk_round_rate static" to the asoc tree
2018-02-08 14:35 ` Colin King
(?)
@ 2018-02-12 12:52 ` Mark Brown
-1 siblings, 0 replies; 9+ messages in thread
From: Mark Brown @ 2018-02-12 12:52 UTC (permalink / raw)
To: Colin Ian King
Cc: Mark Brown, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Sriram Periyasamy, Stephen Boyd,
Subhransu S . Prusty, alsa-devel, kernel-janitors, linux-kernel,
alsa-devel
The patch
ASoC: Intel: Skylake: make function skl_clk_round_rate static
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 29c5b8fd8c07a42b07383c5fac47173d882f74b2 Mon Sep 17 00:00:00 2001
From: Colin Ian King <colin.king@canonical.com>
Date: Thu, 8 Feb 2018 14:35:30 +0000
Subject: [PATCH] ASoC: Intel: Skylake: make function skl_clk_round_rate static
The function skl_clk_round_rate is local to the source and does not
need to be in global scope, so make it static.
Cleans up sparse warning:
sound/soc/intel/skylake/skl-ssp-clk.c:250:6: warning: symbol
'skl_clk_round_rate' was not declared. Should it be static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Acked-By: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/intel/skylake/skl-ssp-clk.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/intel/skylake/skl-ssp-clk.c b/sound/soc/intel/skylake/skl-ssp-clk.c
index 7fbddf5e3b00..cda1b5fa7436 100644
--- a/sound/soc/intel/skylake/skl-ssp-clk.c
+++ b/sound/soc/intel/skylake/skl-ssp-clk.c
@@ -247,8 +247,8 @@ static unsigned long skl_clk_recalc_rate(struct clk_hw *hw,
}
/* Not supported by clk driver. Implemented to satisfy clk fw */
-long skl_clk_round_rate(struct clk_hw *hw, unsigned long rate,
- unsigned long *parent_rate)
+static long skl_clk_round_rate(struct clk_hw *hw, unsigned long rate,
+ unsigned long *parent_rate)
{
return rate;
}
--
2.16.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Applied "ASoC: Intel: Skylake: make function skl_clk_round_rate static" to the asoc tree
@ 2018-02-12 12:52 ` Mark Brown
0 siblings, 0 replies; 9+ messages in thread
From: Mark Brown @ 2018-02-12 12:52 UTC (permalink / raw)
To: Colin Ian King; +Cc: Mark Brown, Liam Girdwood
The patch
ASoC: Intel: Skylake: make function skl_clk_round_rate static
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 29c5b8fd8c07a42b07383c5fac47173d882f74b2 Mon Sep 17 00:00:00 2001
From: Colin Ian King <colin.king@canonical.com>
Date: Thu, 8 Feb 2018 14:35:30 +0000
Subject: [PATCH] ASoC: Intel: Skylake: make function skl_clk_round_rate static
The function skl_clk_round_rate is local to the source and does not
need to be in global scope, so make it static.
Cleans up sparse warning:
sound/soc/intel/skylake/skl-ssp-clk.c:250:6: warning: symbol
'skl_clk_round_rate' was not declared. Should it be static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Acked-By: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/intel/skylake/skl-ssp-clk.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/intel/skylake/skl-ssp-clk.c b/sound/soc/intel/skylake/skl-ssp-clk.c
index 7fbddf5e3b00..cda1b5fa7436 100644
--- a/sound/soc/intel/skylake/skl-ssp-clk.c
+++ b/sound/soc/intel/skylake/skl-ssp-clk.c
@@ -247,8 +247,8 @@ static unsigned long skl_clk_recalc_rate(struct clk_hw *hw,
}
/* Not supported by clk driver. Implemented to satisfy clk fw */
-long skl_clk_round_rate(struct clk_hw *hw, unsigned long rate,
- unsigned long *parent_rate)
+static long skl_clk_round_rate(struct clk_hw *hw, unsigned long rate,
+ unsigned long *parent_rate)
{
return rate;
}
--
2.16.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Applied "ASoC: Intel: Skylake: make function skl_clk_round_rate static" to the asoc tree
@ 2018-02-12 12:52 ` Mark Brown
0 siblings, 0 replies; 9+ messages in thread
From: Mark Brown @ 2018-02-12 12:52 UTC (permalink / raw)
To: Colin Ian King; +Cc: Mark Brown, Liam Girdwood
The patch
ASoC: Intel: Skylake: make function skl_clk_round_rate static
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
From 29c5b8fd8c07a42b07383c5fac47173d882f74b2 Mon Sep 17 00:00:00 2001
From: Colin Ian King <colin.king@canonical.com>
Date: Thu, 8 Feb 2018 14:35:30 +0000
Subject: [PATCH] ASoC: Intel: Skylake: make function skl_clk_round_rate static
The function skl_clk_round_rate is local to the source and does not
need to be in global scope, so make it static.
Cleans up sparse warning:
sound/soc/intel/skylake/skl-ssp-clk.c:250:6: warning: symbol
'skl_clk_round_rate' was not declared. Should it be static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Acked-By: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/intel/skylake/skl-ssp-clk.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/intel/skylake/skl-ssp-clk.c b/sound/soc/intel/skylake/skl-ssp-clk.c
index 7fbddf5e3b00..cda1b5fa7436 100644
--- a/sound/soc/intel/skylake/skl-ssp-clk.c
+++ b/sound/soc/intel/skylake/skl-ssp-clk.c
@@ -247,8 +247,8 @@ static unsigned long skl_clk_recalc_rate(struct clk_hw *hw,
}
/* Not supported by clk driver. Implemented to satisfy clk fw */
-long skl_clk_round_rate(struct clk_hw *hw, unsigned long rate,
- unsigned long *parent_rate)
+static long skl_clk_round_rate(struct clk_hw *hw, unsigned long rate,
+ unsigned long *parent_rate)
{
return rate;
}
--
2.16.1
^ permalink raw reply related [flat|nested] 9+ messages in thread