From: Rafael Aquini <aquini@redhat.com> To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, x86@kernel.org, luto@kernel.org, aarcange@redhat.com, lwoodman@redhat.com, riel@redhat.com, mgorman@suse.de, akpm@linux-foundation.org Subject: [PATCH] x86/mm: Add barriers and document switch_mm()-vs-flush synchronization follow-up Date: Tue, 2 Aug 2016 11:34:49 -0400 [thread overview] Message-ID: <88fb045963d1e51cd14c05c9c4d283a1ccd29c80.1470151425.git.aquini@redhat.com> (raw) While backporting 71b3c126e611 ("x86/mm: Add barriers and document switch_mm()-vs-flush synchronization") we stumbled across a possibly missing barrier at flush_tlb_page(). Following the reasoning presented while introducing the synchronization barrier at flush_tlb_mm_range(), for the current->active_mm != mm checkpoint: if (current->active_mm != mm) { /* Synchronize with switch_mm. */ smp_mb(); goto out; } it suggests the same barrier should be introduced for the similar outcome at flush_tlb_page(). This patch add that mentioned missing barrier and documents its case. Suggested-by: Andrea Arcangeli <aarcange@redhat.com> Signed-off-by: Rafael Aquini <aquini@redhat.com> --- arch/x86/mm/tlb.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c index 4dbe656..3b4addc 100644 --- a/arch/x86/mm/tlb.c +++ b/arch/x86/mm/tlb.c @@ -375,6 +375,12 @@ void flush_tlb_page(struct vm_area_struct *vma, unsigned long start) /* Synchronize with switch_mm. */ smp_mb(); } + } else { + /* + * current->active_mm != mm + * Synchronize with switch_mm. + */ + smp_mb(); } if (cpumask_any_but(mm_cpumask(mm), smp_processor_id()) < nr_cpu_ids) -- 2.5.5
WARNING: multiple messages have this Message-ID (diff)
From: Rafael Aquini <aquini@redhat.com> To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, x86@kernel.org, luto@kernel.org, aarcange@redhat.com, lwoodman@redhat.com, riel@redhat.com, mgorman@suse.de, akpm@linux-foundation.org Subject: [PATCH] x86/mm: Add barriers and document switch_mm()-vs-flush synchronization follow-up Date: Tue, 2 Aug 2016 11:34:49 -0400 [thread overview] Message-ID: <88fb045963d1e51cd14c05c9c4d283a1ccd29c80.1470151425.git.aquini@redhat.com> (raw) While backporting 71b3c126e611 ("x86/mm: Add barriers and document switch_mm()-vs-flush synchronization") we stumbled across a possibly missing barrier at flush_tlb_page(). Following the reasoning presented while introducing the synchronization barrier at flush_tlb_mm_range(), for the current->active_mm != mm checkpoint: if (current->active_mm != mm) { /* Synchronize with switch_mm. */ smp_mb(); goto out; } it suggests the same barrier should be introduced for the similar outcome at flush_tlb_page(). This patch add that mentioned missing barrier and documents its case. Suggested-by: Andrea Arcangeli <aarcange@redhat.com> Signed-off-by: Rafael Aquini <aquini@redhat.com> --- arch/x86/mm/tlb.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c index 4dbe656..3b4addc 100644 --- a/arch/x86/mm/tlb.c +++ b/arch/x86/mm/tlb.c @@ -375,6 +375,12 @@ void flush_tlb_page(struct vm_area_struct *vma, unsigned long start) /* Synchronize with switch_mm. */ smp_mb(); } + } else { + /* + * current->active_mm != mm + * Synchronize with switch_mm. + */ + smp_mb(); } if (cpumask_any_but(mm_cpumask(mm), smp_processor_id()) < nr_cpu_ids) -- 2.5.5 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2016-08-02 15:42 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-08-02 15:34 Rafael Aquini [this message] 2016-08-02 15:34 ` [PATCH] x86/mm: Add barriers and document switch_mm()-vs-flush synchronization follow-up Rafael Aquini 2016-08-02 22:27 ` Nadav Amit 2016-08-02 22:27 ` Nadav Amit 2016-08-02 22:34 ` Andy Lutomirski 2016-08-02 22:34 ` Andy Lutomirski 2016-08-02 23:12 ` Rafael Aquini 2016-08-02 23:12 ` Rafael Aquini 2016-08-03 0:46 ` Nadav Amit 2016-08-03 0:46 ` Nadav Amit
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=88fb045963d1e51cd14c05c9c4d283a1ccd29c80.1470151425.git.aquini@redhat.com \ --to=aquini@redhat.com \ --cc=aarcange@redhat.com \ --cc=akpm@linux-foundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=luto@kernel.org \ --cc=lwoodman@redhat.com \ --cc=mgorman@suse.de \ --cc=riel@redhat.com \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.