From: Max Gurtovoy <maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>,
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Subject: Re: [PATCH v2 0/3] Allow ib_clients to nullify .add but still get .remove events reliably
Date: Sun, 2 Jul 2017 12:14:31 +0300 [thread overview]
Message-ID: <8927ea7d-c6ba-4f32-4ede-0897e83bcda2@mellanox.com> (raw)
In-Reply-To: <1498983652-18250-1-git-send-email-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
On 7/2/2017 11:20 AM, Sagi Grimberg wrote:
> Some ULPs are just interested in device removal notification with no specific
> association because they work over RDMA_CM so no need for detecting appearance
> of the devices. That wasn't the because the corresponding ib_client_data
> was never added to the device clients list when the ib_client registers,
> Patch 1 fixes it. Patches 2-3 just removes the empty .add callout nvme(t)-rdma set.
>
> Changes from v1:
> - reword patch 1 change log title
> - collected review tags
>
> Note that this will create a conflict with jens's for-4.13 which we added
> ib_client registration to nvmet-rdma.
>
> Sagi Grimberg (3):
> RDMA/core: make ib_device.add method optional
> nvme-rdma: remove redundant empty device add callout
> nvmet-rdma: remove redundant empty device add callout
All these patches looks fine to me,
Reviewed-by: Max Gurtovoy <maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: maxg@mellanox.com (Max Gurtovoy)
Subject: [PATCH v2 0/3] Allow ib_clients to nullify .add but still get .remove events reliably
Date: Sun, 2 Jul 2017 12:14:31 +0300 [thread overview]
Message-ID: <8927ea7d-c6ba-4f32-4ede-0897e83bcda2@mellanox.com> (raw)
In-Reply-To: <1498983652-18250-1-git-send-email-sagi@grimberg.me>
On 7/2/2017 11:20 AM, Sagi Grimberg wrote:
> Some ULPs are just interested in device removal notification with no specific
> association because they work over RDMA_CM so no need for detecting appearance
> of the devices. That wasn't the because the corresponding ib_client_data
> was never added to the device clients list when the ib_client registers,
> Patch 1 fixes it. Patches 2-3 just removes the empty .add callout nvme(t)-rdma set.
>
> Changes from v1:
> - reword patch 1 change log title
> - collected review tags
>
> Note that this will create a conflict with jens's for-4.13 which we added
> ib_client registration to nvmet-rdma.
>
> Sagi Grimberg (3):
> RDMA/core: make ib_device.add method optional
> nvme-rdma: remove redundant empty device add callout
> nvmet-rdma: remove redundant empty device add callout
All these patches looks fine to me,
Reviewed-by: Max Gurtovoy <maxg at mellanox.com>
next prev parent reply other threads:[~2017-07-02 9:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-02 8:20 [PATCH v2 0/3] Allow ib_clients to nullify .add but still get .remove events reliably Sagi Grimberg
2017-07-02 8:20 ` Sagi Grimberg
[not found] ` <1498983652-18250-1-git-send-email-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-07-02 8:20 ` [PATCH v2 1/3] RDMA/core: make ib_device.add method optional Sagi Grimberg
2017-07-02 8:20 ` Sagi Grimberg
[not found] ` <1498983652-18250-2-git-send-email-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-07-06 7:51 ` Sagi Grimberg
2017-07-06 7:51 ` Sagi Grimberg
[not found] ` <14303999-2479-653c-719f-ac5a5b03fb33-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-07-06 8:33 ` Leon Romanovsky
2017-07-06 8:33 ` Leon Romanovsky
[not found] ` <20170706083301.GS1528-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-07-06 8:38 ` Sagi Grimberg
2017-07-06 8:38 ` Sagi Grimberg
2017-07-02 8:20 ` [PATCH v2 2/3] nvme-rdma: remove redundant empty device add callout Sagi Grimberg
2017-07-02 8:20 ` Sagi Grimberg
2017-07-02 8:20 ` [PATCH v2 3/3] nvmet-rdma: " Sagi Grimberg
2017-07-02 8:20 ` Sagi Grimberg
2017-07-02 9:14 ` Max Gurtovoy [this message]
2017-07-02 9:14 ` [PATCH v2 0/3] Allow ib_clients to nullify .add but still get .remove events reliably Max Gurtovoy
[not found] ` <8927ea7d-c6ba-4f32-4ede-0897e83bcda2-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-08-18 14:46 ` Doug Ledford
2017-08-18 14:46 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8927ea7d-c6ba-4f32-4ede-0897e83bcda2@mellanox.com \
--to=maxg-vpraknaxozvwk0htik3j/w@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=hch-jcswGhMUV9g@public.gmane.org \
--cc=linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.