All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Aradhya Bhatia <a-bhatia1@ti.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Rob Herring <robh+dt@kernel.org>
Cc: Tomi Valkeinen <tomba@kernel.org>,
	Samuel Holland <samuel@sholland.org>,
	Maxime Ripard <mripard@kernel.org>,
	Linux Clock List <linux-clk@vger.kernel.org>,
	Devicetree List <devicetree@vger.kernel.org>,
	Linux Kernel List <linux-kernel@vger.kernel.org>,
	Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
	Devarsh Thakkar <devarsht@ti.com>, Jai Luthra <j-luthra@ti.com>,
	Aradhya Bhatia <a-bhatia1@ti.com>
Subject: Re: [PATCH 1/2] dt-bindings: clock: fixed-factor: Add TI AM62 SoC OLDI clock
Date: Wed, 11 Jan 2023 11:44:59 -0800	[thread overview]
Message-ID: <8980856c1138571976f00413b94cfeb8.sboyd@kernel.org> (raw)
In-Reply-To: <20221226095745.19757-2-a-bhatia1@ti.com>

Quoting Aradhya Bhatia (2022-12-26 01:57:44)
> Add "ti,k3-am62-oldi-clk-div" to the fixed factor clock compatible enum
> list.
> 
> "ti,k3-am62-oldi-clk-div" is a fixed-factor clock that helps the TI
> display subsystem request a pixel clock for itself and a corresponding
> serial clock for its OLDI Transmitters. The serial clock is 7 times the
> pixel clock. This clock needs the clock set rate request to be
> propagated to the parent clock provider.
> 
> Signed-off-by: Aradhya Bhatia <a-bhatia1@ti.com>
> ---
>  Documentation/devicetree/bindings/clock/fixed-factor-clock.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/clock/fixed-factor-clock.yaml b/Documentation/devicetree/bindings/clock/fixed-factor-clock.yaml
> index 8f71ab300470..0696237530f7 100644
> --- a/Documentation/devicetree/bindings/clock/fixed-factor-clock.yaml
> +++ b/Documentation/devicetree/bindings/clock/fixed-factor-clock.yaml
> @@ -14,6 +14,7 @@ properties:
>    compatible:
>      enum:
>        - fixed-factor-clock
> +      - ti,k3-am62-oldi-clk-div

I don't see this compatible anywhere in the kernel tree. Is there a
patch that adds a node using this? I wonder why the display subsystem
can't add this fixed factor clk directly in the driver. Does the OLDI
Transmitter send a clk to the display subsystem?

I'm asking all these questions because we got rid of vendor compatibles
here in hopes of simplifying the logic. Maybe the problem can be
approached differently, but I don't know all the details.

  parent reply	other threads:[~2023-01-11 19:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-26  9:57 [PATCH 0/2] Re-introduce parent clock-rate set for fixed-factor clock Aradhya Bhatia
2022-12-26  9:57 ` [PATCH 1/2] dt-bindings: clock: fixed-factor: Add TI AM62 SoC OLDI clock Aradhya Bhatia
2022-12-26 22:03   ` Rob Herring
2023-01-11 19:44   ` Stephen Boyd [this message]
2023-01-16  9:51     ` Aradhya Bhatia
2023-01-17  9:40       ` Tomi Valkeinen
2023-01-26  0:06         ` Stephen Boyd
2023-02-06  5:34           ` Aradhya Bhatia
2023-02-17 22:32             ` Stephen Boyd
2022-12-26  9:57 ` [PATCH 2/2] clk: fixed-factor: Re-introduce support for clocks to set parent clock-rate Aradhya Bhatia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8980856c1138571976f00413b94cfeb8.sboyd@kernel.org \
    --to=sboyd@kernel.org \
    --cc=a-bhatia1@ti.com \
    --cc=devarsht@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=j-luthra@ti.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mripard@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=samuel@sholland.org \
    --cc=tomba@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.