[MPTCP] Re: [PATCH 0/6] IPv6 support

[MPTCP] Re: [PATCH 0/6] IPv6 support

[Paolo Abeni]

[-- Attachment #1: Type: text/plain, Size: 1052 bytes --]

On Wed, 2019-10-30 at 16:38 -0700, Peter Krystad wrote:
> Implemented support for IPv6. selftests pass with ipv6=true, 

Nice! 

> but they take twice as long to run...

Yep, that is expected, right? ;)

> With re-factoring the addition of IPv6 is very clean but I did not
> split files yet as it will be hard to squash any changes after the
> such a split.

We still need the Kconfig boilerplate, right? something alike:

---
diff --git a/net/mptcp/Kconfig b/net/mptcp/Kconfig
index f21190a4f7e9..3fa6d91f57ee 100644
--- a/net/mptcp/Kconfig
+++ b/net/mptcp/Kconfig
@@ -9,3 +9,8 @@ config MPTCP
          uses the TCP protocol, and TCP options carry header
information for
          MPTCP.
 
+config MPTCP_IPV6
+       bool "IPv6 support form Multipath TCP"
+       depends on MPTCP
+       select IPV6
+       default y
---

and than replace IS_ENABLED(IPV6) with CONFIG_MPTCP_IPV6.

Additinal question: what happens if ipv6 is disabled at boot time
(ipv6.disable=1 on the kernel command line)?

Thanks,

Paolo

[MPTCP] Re: [PATCH 0/6] IPv6 support

[Peter Krystad]

[-- Attachment #1: Type: text/plain, Size: 1488 bytes --]


Hi Paolo -

On Thu, 2019-10-31 at 10:02 +0100, Paolo Abeni wrote:
> On Wed, 2019-10-30 at 16:38 -0700, Peter Krystad wrote:
> > Implemented support for IPv6. selftests pass with ipv6=true, 
> 
> Nice! 
> 
> > but they take twice as long to run...
> 
> Yep, that is expected, right? ;)

Right.

> 
> > With re-factoring the addition of IPv6 is very clean but I did not
> > split files yet as it will be hard to squash any changes after the
> > such a split.
> 
> We still need the Kconfig boilerplate, right? something alike:
>
> ---
> diff --git a/net/mptcp/Kconfig b/net/mptcp/Kconfig
> index f21190a4f7e9..3fa6d91f57ee 100644
> --- a/net/mptcp/Kconfig
> +++ b/net/mptcp/Kconfig
> @@ -9,3 +9,8 @@ config MPTCP
>           uses the TCP protocol, and TCP options carry header
> information for
>           MPTCP.
>  
> +config MPTCP_IPV6
> +       bool "IPv6 support form Multipath TCP"
> +       depends on MPTCP
> +       select IPV6
> +       default y
> ---
> 
> and than replace IS_ENABLED(IPV6) with CONFIG_MPTCP_IPV6.

Indeed we do, I will submit a patchset that does that will need to
be merged before the v2 IPv6 patchset (coming tomorrow).

> Additinal question: what happens if ipv6 is disabled at boot time
> (ipv6.disable=1 on the kernel command line)?

I believe the initialization in inet6_init() will not run and it will
not be possible to create a socket in the AF_INET6 domain.

Peter.

 
> Thanks,
> 
> Paolo
>