[PATCH 1/6 v2] gst-plugins-bad: Use new PACKAGECONFIG feature

[PATCH 1/6 v2] gst-plugins-bad: Use new PACKAGECONFIG feature

[Franklin S. Cooper Jr]

* Recent patch in oe-core allows certain features to be enabled or disabled
  based on the PACKAGECONFIG variable.
* Use this variable which will obsolete alot of the code in this bbappend while
  achieving the same result.

Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
---
Version 2 changes:
Update patch tailored to recent change to base recipe in oe-core.


 .../gstreamer/gst-plugins-bad_0.10.23.bbappend     |   14 ++------------
 1 files changed, 2 insertions(+), 12 deletions(-)

diff --git a/meta-arago-distro/recipes-multimedia/gstreamer/gst-plugins-bad_0.10.23.bbappend b/meta-arago-distro/recipes-multimedia/gstreamer/gst-plugins-bad_0.10.23.bbappend
index 8ae8050..8cee785 100644
--- a/meta-arago-distro/recipes-multimedia/gstreamer/gst-plugins-bad_0.10.23.bbappend
+++ b/meta-arago-distro/recipes-multimedia/gstreamer/gst-plugins-bad_0.10.23.bbappend
@@ -1,21 +1,11 @@
-PR_append = "-arago3"
+PR_append = "-arago4"
 
 # look for files in this layer first
 FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
 
-# Disable rsvg which caused gtk+ to be pulled in
-DEPENDS := "${@oe_filter_out('librsvg','${DEPENDS}', d)}"
-EXTRA_OECONF += "--disable-rsvg"
-
-# Remove the restriction of which plugins are built. Previously fbdevsink
-# was not built which is needed by the gstreamer demos included in the SDK.
-EXTRA_OECONF := "${@oe_filter_out('--with-plugins=musicbrainz,wavpack,ivorbis,mpegvideoparse','${EXTRA_OECONF}', d)}"
-
 SRC_URI += "file://0001-gstfbdevsink-Fix-depth-value-for-GST_VIDEO_CAPS_RGB_.patch"
 
-# Add faad has a dependency to insure gst-plugins-bad-faad is built.
-DEPENDS += "faad2"
-RDEPENDS_${PN}-faad += "libfaad"
+PACKAGECONFIG = "bzip curl faad"
 
 # Disable features that have potential commercial licensing restrictions
 EXTRA_OECONF += "\
-- 
1.7.0.4

[PATCH 2/6 v2] sourceipk: Add ability to preserve Git repository

[Franklin S. Cooper Jr]

* When a git repository is unpacked the repository located in the WORKDIR is
  cloned from the git repository located in the downloads directory.
* Various references and settings are set within the repo which makes it
  impossible for the git repository packaged by sourceipk to be useable on any
  computer other than the original computer that the sourceipk was created in.
* This patch allows the git repository to be preserved and fixed up to become
  a fully functional portable git repository.

Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
---
Version 2 changes:
Fix commit message typo and add comment removal to this patch.

 meta-arago-distro/classes/sourceipk.bbclass |   35 +++++++++++++++++++++++----
 1 files changed, 30 insertions(+), 5 deletions(-)

diff --git a/meta-arago-distro/classes/sourceipk.bbclass b/meta-arago-distro/classes/sourceipk.bbclass
index 1844ff3..1ea0577 100644
--- a/meta-arago-distro/classes/sourceipk.bbclass
+++ b/meta-arago-distro/classes/sourceipk.bbclass
@@ -59,17 +59,42 @@ SRCIPK_SECTION ?= "${SECTION}"
 # Default SRCIPK_INCLUDE_EXTRAFILES is to include the extra files
 SRCIPK_INCLUDE_EXTRAFILES ?= "1"
 
-# Remove git repositories before packaging up the sources
-clear_git() {
+SRCIPK_PRESERVE_GIT ?= "false"
+
+adjust_git() {
+
+    orig_dir="$PWD"
 
     cd ${S}
 
     if [ -d ".git" ]
     then
-        rm -rf .git
+
+        # Grab path to cloned local repository
+        old=`git remote -v | grep "(fetch)" | cut -d ' ' -f 1   | cut -c 7- | tr -d ' '`
+
+        if [ -d $old -a "${SRCIPK_PRESERVE_GIT}" = "true" ]
+        then
+            cd $old
+
+            # Grab actual url used to create the repository
+            orig=`git remote -v | grep "(fetch)" | cut -d ' ' -f 1   | cut -c 7- | tr -d ' '`
+
+            cd -
+
+            git remote set-url origin $orig $old
+
+            # Repackage the repository so its a proper clone of the original (remote) git repository
+            git repack -a -d
+            rm .git/objects/info/alternates
+
+        else
+            rm -rf .git
+        fi
+
     fi
 
-    cd -
+    cd $orig_dir
 
 }
 
@@ -97,7 +122,7 @@ sourceipk_do_create_srcipk() {
     if [ ${CREATE_SRCIPK} != "0" ]
     then
 
-        clear_git
+        adjust_git
 
         tmp_dir="${WORKDIR}/sourceipk-tmp"
         srcipk_dir="${WORKDIR}/sourceipk-data"
-- 
1.7.0.4

Re: [PATCH 2/6 v2] sourceipk: Add ability to preserve Git repository

[Maupin, Chase]

Acked-by: Chase Maupin <chase.maupin@ti.com>


>-----Original Message-----
>From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
>bounces@arago-project.org] On Behalf Of Cooper Jr., Franklin
>Sent: Tuesday, August 27, 2013 2:51 PM
>To: meta-arago@arago-project.org
>Cc: Cooper Jr., Franklin
>Subject: [meta-arago] [PATCH 2/6 v2] sourceipk: Add ability to
>preserve Git repository
>
>* When a git repository is unpacked the repository located in the
>WORKDIR is
>  cloned from the git repository located in the downloads
>directory.
>* Various references and settings are set within the repo which
>makes it
>  impossible for the git repository packaged by sourceipk to be
>useable on any
>  computer other than the original computer that the sourceipk was
>created in.
>* This patch allows the git repository to be preserved and fixed
>up to become
>  a fully functional portable git repository.
>
>Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
>---
>Version 2 changes:
>Fix commit message typo and add comment removal to this patch.
>
> meta-arago-distro/classes/sourceipk.bbclass |   35
>+++++++++++++++++++++++----
> 1 files changed, 30 insertions(+), 5 deletions(-)
>
>diff --git a/meta-arago-distro/classes/sourceipk.bbclass b/meta-
>arago-distro/classes/sourceipk.bbclass
>index 1844ff3..1ea0577 100644
>--- a/meta-arago-distro/classes/sourceipk.bbclass
>+++ b/meta-arago-distro/classes/sourceipk.bbclass
>@@ -59,17 +59,42 @@ SRCIPK_SECTION ?= "${SECTION}"
> # Default SRCIPK_INCLUDE_EXTRAFILES is to include the extra files
> SRCIPK_INCLUDE_EXTRAFILES ?= "1"
>
>-# Remove git repositories before packaging up the sources
>-clear_git() {
>+SRCIPK_PRESERVE_GIT ?= "false"
>+
>+adjust_git() {
>+
>+    orig_dir="$PWD"
>
>     cd ${S}
>
>     if [ -d ".git" ]
>     then
>-        rm -rf .git
>+
>+        # Grab path to cloned local repository
>+        old=`git remote -v | grep "(fetch)" | cut -d ' ' -f 1   |
>cut -c 7- | tr -d ' '`
>+
>+        if [ -d $old -a "${SRCIPK_PRESERVE_GIT}" = "true" ]
>+        then
>+            cd $old
>+
>+            # Grab actual url used to create the repository
>+            orig=`git remote -v | grep "(fetch)" | cut -d ' ' -f
>1   | cut -c 7- | tr -d ' '`
>+
>+            cd -
>+
>+            git remote set-url origin $orig $old
>+
>+            # Repackage the repository so its a proper clone of
>the original (remote) git repository
>+            git repack -a -d
>+            rm .git/objects/info/alternates
>+
>+        else
>+            rm -rf .git
>+        fi
>+
>     fi
>
>-    cd -
>+    cd $orig_dir
>
> }
>
>@@ -97,7 +122,7 @@ sourceipk_do_create_srcipk() {
>     if [ ${CREATE_SRCIPK} != "0" ]
>     then
>
>-        clear_git
>+        adjust_git
>
>         tmp_dir="${WORKDIR}/sourceipk-tmp"
>         srcipk_dir="${WORKDIR}/sourceipk-data"
>--
>1.7.0.4
>
>_______________________________________________
>meta-arago mailing list
>meta-arago@arago-project.org
>http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago

[PATCH 3/6 v2] board-port-labs-linux: Create new recipe using new sourceipk.bbclass feature

[Franklin S. Cooper Jr]

* Do to the inability to keep the git repository intact the board port labs
  recipe manually ran git clone which took a long time every time the recipe was
  built.
* Using the new SRCIPK_PRESERVED_GIT feature in sourceipk.bbclass the recipes can
  now be treated like any other recipe and allow OE to handle the cloning and
  unpacking.
* This will significantly shorten the amount of time required to rebuild this
  recipe.

Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
---
Changes Version 2:
Split recipe into its own patch.
Also use the kernel's license.

 .../board-port-labs/board-port-labs-linux_git.bb   |   35 ++++++++++++++++++++
 1 files changed, 35 insertions(+), 0 deletions(-)
 create mode 100644 meta-arago-distro/recipes-tisdk/board-port-labs/board-port-labs-linux_git.bb

diff --git a/meta-arago-distro/recipes-tisdk/board-port-labs/board-port-labs-linux_git.bb b/meta-arago-distro/recipes-tisdk/board-port-labs/board-port-labs-linux_git.bb
new file mode 100644
index 0000000..711e3a8
--- /dev/null
+++ b/meta-arago-distro/recipes-tisdk/board-port-labs/board-port-labs-linux_git.bb
@@ -0,0 +1,35 @@
+DESCRIPTION = "Git repositories containing sample board port code"
+HOMEPAGE = "https://gitorious.org/sitara-board-port"
+
+LICENSE = "GPLv2"
+LIC_FILES_CHKSUM = "file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7"
+
+inherit allarch
+
+CREATE_SRCIPK = "1"
+SRCIPK_INSTALL_DIR = "board-support/board-port-labs/sitara-board-port-linux"
+SRCIPK_PRESERVE_GIT = "true"
+
+PR = "r0"
+
+BRANCH = "master"
+SRC_URI = "git://gitorious.org/sitara-board-port/sitara-board-port-linux.git;protocol=git;branch=${BRANCH}"
+
+SRCREV = "${AUTOREV}"
+
+S = "${WORKDIR}/git"
+
+adjust_git_prepend() {
+
+    # Checkout a specific branch instead of a commit that is used by default
+    git checkout ${BRANCH}
+}
+
+do_configure() {
+    :
+}
+
+do_compile() {
+    :
+}
+
-- 
1.7.0.4

Re: [PATCH 3/6 v2] board-port-labs-linux: Create new recipe using new sourceipk.bbclass feature

[Maupin, Chase]

Acked-by: Chase Maupin <chase.maupin@ti.com>

>-----Original Message-----
>From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
>bounces@arago-project.org] On Behalf Of Cooper Jr., Franklin
>Sent: Tuesday, August 27, 2013 2:51 PM
>To: meta-arago@arago-project.org
>Cc: Cooper Jr., Franklin
>Subject: [meta-arago] [PATCH 3/6 v2] board-port-labs-linux: Create
>new recipe using new sourceipk.bbclass feature
>
>* Do to the inability to keep the git repository intact the board
>port labs
>  recipe manually ran git clone which took a long time every time
>the recipe was
>  built.
>* Using the new SRCIPK_PRESERVED_GIT feature in sourceipk.bbclass
>the recipes can
>  now be treated like any other recipe and allow OE to handle the
>cloning and
>  unpacking.
>* This will significantly shorten the amount of time required to
>rebuild this
>  recipe.
>
>Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
>---
>Changes Version 2:
>Split recipe into its own patch.
>Also use the kernel's license.
>
> .../board-port-labs/board-port-labs-linux_git.bb   |   35
>++++++++++++++++++++
> 1 files changed, 35 insertions(+), 0 deletions(-)
> create mode 100644 meta-arago-distro/recipes-tisdk/board-port-
>labs/board-port-labs-linux_git.bb
>
>diff --git a/meta-arago-distro/recipes-tisdk/board-port-
>labs/board-port-labs-linux_git.bb b/meta-arago-distro/recipes-
>tisdk/board-port-labs/board-port-labs-linux_git.bb
>new file mode 100644
>index 0000000..711e3a8
>--- /dev/null
>+++ b/meta-arago-distro/recipes-tisdk/board-port-labs/board-port-
>labs-linux_git.bb
>@@ -0,0 +1,35 @@
>+DESCRIPTION = "Git repositories containing sample board port
>code"
>+HOMEPAGE = "https://gitorious.org/sitara-board-port"
>+
>+LICENSE = "GPLv2"
>+LIC_FILES_CHKSUM =
>"file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7"
>+
>+inherit allarch
>+
>+CREATE_SRCIPK = "1"
>+SRCIPK_INSTALL_DIR = "board-support/board-port-labs/sitara-board-
>port-linux"
>+SRCIPK_PRESERVE_GIT = "true"
>+
>+PR = "r0"
>+
>+BRANCH = "master"
>+SRC_URI = "git://gitorious.org/sitara-board-port/sitara-board-
>port-linux.git;protocol=git;branch=${BRANCH}"
>+
>+SRCREV = "${AUTOREV}"
>+
>+S = "${WORKDIR}/git"
>+
>+adjust_git_prepend() {
>+
>+    # Checkout a specific branch instead of a commit that is used
>by default
>+    git checkout ${BRANCH}
>+}
>+
>+do_configure() {
>+    :
>+}
>+
>+do_compile() {
>+    :
>+}
>+
>--
>1.7.0.4
>
>_______________________________________________
>meta-arago mailing list
>meta-arago@arago-project.org
>http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago

Re: [PATCH 3/6 v2] board-port-labs-linux: Create new recipe using new sourceipk.bbclass feature

[Denys Dmytriyenko]

Can we do away w/o using AUTOREV here? How often do you change the content in 
those repos? Would it be too much hassle to keep updating the recipe with the 
new SRCREV for every new (AM-)SDK release?

-- 
Denys

On Tue, Aug 27, 2013 at 02:51:29PM -0500, Franklin S. Cooper Jr wrote:
> * Do to the inability to keep the git repository intact the board port labs
>   recipe manually ran git clone which took a long time every time the recipe was
>   built.
> * Using the new SRCIPK_PRESERVED_GIT feature in sourceipk.bbclass the recipes can
>   now be treated like any other recipe and allow OE to handle the cloning and
>   unpacking.
> * This will significantly shorten the amount of time required to rebuild this
>   recipe.
> 
> Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
> ---
> Changes Version 2:
> Split recipe into its own patch.
> Also use the kernel's license.
> 
>  .../board-port-labs/board-port-labs-linux_git.bb   |   35 ++++++++++++++++++++
>  1 files changed, 35 insertions(+), 0 deletions(-)
>  create mode 100644 meta-arago-distro/recipes-tisdk/board-port-labs/board-port-labs-linux_git.bb
> 
> diff --git a/meta-arago-distro/recipes-tisdk/board-port-labs/board-port-labs-linux_git.bb b/meta-arago-distro/recipes-tisdk/board-port-labs/board-port-labs-linux_git.bb
> new file mode 100644
> index 0000000..711e3a8
> --- /dev/null
> +++ b/meta-arago-distro/recipes-tisdk/board-port-labs/board-port-labs-linux_git.bb
> @@ -0,0 +1,35 @@
> +DESCRIPTION = "Git repositories containing sample board port code"
> +HOMEPAGE = "https://gitorious.org/sitara-board-port"
> +
> +LICENSE = "GPLv2"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7"
> +
> +inherit allarch
> +
> +CREATE_SRCIPK = "1"
> +SRCIPK_INSTALL_DIR = "board-support/board-port-labs/sitara-board-port-linux"
> +SRCIPK_PRESERVE_GIT = "true"
> +
> +PR = "r0"
> +
> +BRANCH = "master"
> +SRC_URI = "git://gitorious.org/sitara-board-port/sitara-board-port-linux.git;protocol=git;branch=${BRANCH}"
> +
> +SRCREV = "${AUTOREV}"
> +
> +S = "${WORKDIR}/git"
> +
> +adjust_git_prepend() {
> +
> +    # Checkout a specific branch instead of a commit that is used by default
> +    git checkout ${BRANCH}
> +}
> +
> +do_configure() {
> +    :
> +}
> +
> +do_compile() {
> +    :
> +}
> +
> -- 
> 1.7.0.4
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago

Re: [PATCH 3/6 v2] board-port-labs-linux: Create new recipe using new sourceipk.bbclass feature

[Cooper Jr., Franklin]

On Sep 4, 2013, at 5:47 PM, "Dmytriyenko, Denys" <denys@ti.com> wrote:

> Can we do away w/o using AUTOREV here? How often do you change the content in 
> those repos? Would it be too much hassle to keep updating the recipe with the 
> new SRCREV for every new (AM-)SDK release?
> 
Repo won't change often so that is fine with me.
> -- 
> Denys
> 
> On Tue, Aug 27, 2013 at 02:51:29PM -0500, Franklin S. Cooper Jr wrote:
>> * Do to the inability to keep the git repository intact the board port labs
>>  recipe manually ran git clone which took a long time every time the recipe was
>>  built.
>> * Using the new SRCIPK_PRESERVED_GIT feature in sourceipk.bbclass the recipes can
>>  now be treated like any other recipe and allow OE to handle the cloning and
>>  unpacking.
>> * This will significantly shorten the amount of time required to rebuild this
>>  recipe.
>> 
>> Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
>> ---
>> Changes Version 2:
>> Split recipe into its own patch.
>> Also use the kernel's license.
>> 
>> .../board-port-labs/board-port-labs-linux_git.bb   |   35 ++++++++++++++++++++
>> 1 files changed, 35 insertions(+), 0 deletions(-)
>> create mode 100644 meta-arago-distro/recipes-tisdk/board-port-labs/board-port-labs-linux_git.bb
>> 
>> diff --git a/meta-arago-distro/recipes-tisdk/board-port-labs/board-port-labs-linux_git.bb b/meta-arago-distro/recipes-tisdk/board-port-labs/board-port-labs-linux_git.bb
>> new file mode 100644
>> index 0000000..711e3a8
>> --- /dev/null
>> +++ b/meta-arago-distro/recipes-tisdk/board-port-labs/board-port-labs-linux_git.bb
>> @@ -0,0 +1,35 @@
>> +DESCRIPTION = "Git repositories containing sample board port code"
>> +HOMEPAGE = "https://gitorious.org/sitara-board-port"
>> +
>> +LICENSE = "GPLv2"
>> +LIC_FILES_CHKSUM = "file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7"
>> +
>> +inherit allarch
>> +
>> +CREATE_SRCIPK = "1"
>> +SRCIPK_INSTALL_DIR = "board-support/board-port-labs/sitara-board-port-linux"
>> +SRCIPK_PRESERVE_GIT = "true"
>> +
>> +PR = "r0"
>> +
>> +BRANCH = "master"
>> +SRC_URI = "git://gitorious.org/sitara-board-port/sitara-board-port-linux.git;protocol=git;branch=${BRANCH}"
>> +
>> +SRCREV = "${AUTOREV}"
>> +
>> +S = "${WORKDIR}/git"
>> +
>> +adjust_git_prepend() {
>> +
>> +    # Checkout a specific branch instead of a commit that is used by default
>> +    git checkout ${BRANCH}
>> +}
>> +
>> +do_configure() {
>> +    :
>> +}
>> +
>> +do_compile() {
>> +    :
>> +}
>> +
>> -- 
>> 1.7.0.4
>> 
>> _______________________________________________
>> meta-arago mailing list
>> meta-arago@arago-project.org
>> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago

[PATCH 4/6 v2] board-port-labs-u-boot: Create new recipe using new sourceipk.bbclass feature

[Franklin S. Cooper Jr]

* Do to the inability to keep the git repository intact the board port labs
  recipe manually ran git clone which took a long time every time the recipe was
  built.
* Using the new SRCIPK_PRESERVED_GIT feature in sourceipk.bbclass the recipes
* can
  now be treated like any other recipe and allow OE to handle the cloning and
  unpacking.
* This will significantly shorten the amount of time required to rebuild this
  recipe.

Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
---
Version 2 changes:
Place recipe in its own patch.
Use U-boot's license.

 .../board-port-labs/board-port-labs-u-boot_git.bb  |   35 ++++++++++++++++++++
 1 files changed, 35 insertions(+), 0 deletions(-)
 create mode 100644 meta-arago-distro/recipes-tisdk/board-port-labs/board-port-labs-u-boot_git.bb

diff --git a/meta-arago-distro/recipes-tisdk/board-port-labs/board-port-labs-u-boot_git.bb b/meta-arago-distro/recipes-tisdk/board-port-labs/board-port-labs-u-boot_git.bb
new file mode 100644
index 0000000..46e75bd
--- /dev/null
+++ b/meta-arago-distro/recipes-tisdk/board-port-labs/board-port-labs-u-boot_git.bb
@@ -0,0 +1,35 @@
+DESCRIPTION = "Git repositories containing sample board port code"
+HOMEPAGE = "https://gitorious.org/sitara-board-port"
+
+LICENSE = "GPLv2+"
+LIC_FILES_CHKSUM = "file://COPYING;md5=1707d6db1d42237583f50183a5651ecb"
+
+inherit allarch
+
+CREATE_SRCIPK = "1"
+SRCIPK_INSTALL_DIR = "board-support/board-port-labs/sitara-board-port-u-boot"
+SRCIPK_PRESERVE_GIT = "true"
+
+PR = "r0"
+
+BRANCH = "master"
+SRC_URI = "git://gitorious.org/sitara-board-port/sitara-board-port-uboot.git;protocol=git;branch=${BRANCH}"
+
+SRCREV = "${AUTOREV}"
+
+S = "${WORKDIR}/git"
+
+adjust_git_prepend() {
+
+    # Checkout a specific branch instead of a commit that is used by default
+    git checkout ${BRANCH}
+}
+
+do_configure() {
+    :
+}
+
+do_compile() {
+    :
+}
+
-- 
1.7.0.4

Re: [PATCH 4/6 v2] board-port-labs-u-boot: Create new recipe using new sourceipk.bbclass feature

[Maupin, Chase]

Acked-by: Chase Maupin <chase.maupin@ti.com>

>-----Original Message-----
>From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
>bounces@arago-project.org] On Behalf Of Cooper Jr., Franklin
>Sent: Tuesday, August 27, 2013 2:52 PM
>To: meta-arago@arago-project.org
>Cc: Cooper Jr., Franklin
>Subject: [meta-arago] [PATCH 4/6 v2] board-port-labs-u-boot:
>Create new recipe using new sourceipk.bbclass feature
>
>* Do to the inability to keep the git repository intact the board
>port labs
>  recipe manually ran git clone which took a long time every time
>the recipe was
>  built.
>* Using the new SRCIPK_PRESERVED_GIT feature in sourceipk.bbclass
>the recipes
>* can
>  now be treated like any other recipe and allow OE to handle the
>cloning and
>  unpacking.
>* This will significantly shorten the amount of time required to
>rebuild this
>  recipe.
>
>Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
>---
>Version 2 changes:
>Place recipe in its own patch.
>Use U-boot's license.
>
> .../board-port-labs/board-port-labs-u-boot_git.bb  |   35
>++++++++++++++++++++
> 1 files changed, 35 insertions(+), 0 deletions(-)
> create mode 100644 meta-arago-distro/recipes-tisdk/board-port-
>labs/board-port-labs-u-boot_git.bb
>
>diff --git a/meta-arago-distro/recipes-tisdk/board-port-
>labs/board-port-labs-u-boot_git.bb b/meta-arago-distro/recipes-
>tisdk/board-port-labs/board-port-labs-u-boot_git.bb
>new file mode 100644
>index 0000000..46e75bd
>--- /dev/null
>+++ b/meta-arago-distro/recipes-tisdk/board-port-labs/board-port-
>labs-u-boot_git.bb
>@@ -0,0 +1,35 @@
>+DESCRIPTION = "Git repositories containing sample board port
>code"
>+HOMEPAGE = "https://gitorious.org/sitara-board-port"
>+
>+LICENSE = "GPLv2+"
>+LIC_FILES_CHKSUM =
>"file://COPYING;md5=1707d6db1d42237583f50183a5651ecb"
>+
>+inherit allarch
>+
>+CREATE_SRCIPK = "1"
>+SRCIPK_INSTALL_DIR = "board-support/board-port-labs/sitara-board-
>port-u-boot"
>+SRCIPK_PRESERVE_GIT = "true"
>+
>+PR = "r0"
>+
>+BRANCH = "master"
>+SRC_URI = "git://gitorious.org/sitara-board-port/sitara-board-
>port-uboot.git;protocol=git;branch=${BRANCH}"
>+
>+SRCREV = "${AUTOREV}"
>+
>+S = "${WORKDIR}/git"
>+
>+adjust_git_prepend() {
>+
>+    # Checkout a specific branch instead of a commit that is used
>by default
>+    git checkout ${BRANCH}
>+}
>+
>+do_configure() {
>+    :
>+}
>+
>+do_compile() {
>+    :
>+}
>+
>--
>1.7.0.4
>
>_______________________________________________
>meta-arago mailing list
>meta-arago@arago-project.org
>http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago

[PATCH 5/6 v2] packagegroup-arago-tisdk-amsdk-sdk-host: Use new board-port-labs recipe

[Franklin S. Cooper Jr]

* Use new board-port-labs recipe

Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
---
Version 2 changes:
Remove board-port-labs recipe removal from this patch.

 .../packagegroup-arago-tisdk-amsdk-sdk-host.bb     |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-amsdk-sdk-host.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-amsdk-sdk-host.bb
index 70f767d..94d8288 100644
--- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-amsdk-sdk-host.bb
+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-amsdk-sdk-host.bb
@@ -1,6 +1,6 @@
 DESCRIPTION = "Task to install additional scripts and applications into the SDK"
 LICENSE = "MIT"
-PR = "r11"
+PR = "r12"
 
 inherit packagegroup
 
@@ -24,7 +24,8 @@ RDEPENDS_${PN} = "\
     ${TOOLS} \
     ti-tisdk-setup \
     ${EXTRA_FILES} \
-    board-port-labs-src \
+    board-port-labs-u-boot-src \
+    board-port-labs-linux-src \
     ti-tisdk-makefile \
     ${U-BOOT_SRC} \
     ${KERNEL_SRC} \
-- 
1.7.0.4

Re: [PATCH 5/6 v2] packagegroup-arago-tisdk-amsdk-sdk-host: Use new board-port-labs recipe

[Maupin, Chase]

Acked-by: Chase Maupin <chase.maupin@ti.com>

>-----Original Message-----
>From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
>bounces@arago-project.org] On Behalf Of Cooper Jr., Franklin
>Sent: Tuesday, August 27, 2013 2:52 PM
>To: meta-arago@arago-project.org
>Cc: Cooper Jr., Franklin
>Subject: [meta-arago] [PATCH 5/6 v2] packagegroup-arago-tisdk-
>amsdk-sdk-host: Use new board-port-labs recipe
>
>* Use new board-port-labs recipe
>
>Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
>---
>Version 2 changes:
>Remove board-port-labs recipe removal from this patch.
>
> .../packagegroup-arago-tisdk-amsdk-sdk-host.bb     |    5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/meta-arago-distro/recipes-
>core/packagegroups/packagegroup-arago-tisdk-amsdk-sdk-host.bb
>b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-
>tisdk-amsdk-sdk-host.bb
>index 70f767d..94d8288 100644
>--- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-
>arago-tisdk-amsdk-sdk-host.bb
>+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-
>arago-tisdk-amsdk-sdk-host.bb
>@@ -1,6 +1,6 @@
> DESCRIPTION = "Task to install additional scripts and
>applications into the SDK"
> LICENSE = "MIT"
>-PR = "r11"
>+PR = "r12"
>
> inherit packagegroup
>
>@@ -24,7 +24,8 @@ RDEPENDS_${PN} = "\
>     ${TOOLS} \
>     ti-tisdk-setup \
>     ${EXTRA_FILES} \
>-    board-port-labs-src \
>+    board-port-labs-u-boot-src \
>+    board-port-labs-linux-src \
>     ti-tisdk-makefile \
>     ${U-BOOT_SRC} \
>     ${KERNEL_SRC} \
>--
>1.7.0.4
>
>_______________________________________________
>meta-arago mailing list
>meta-arago@arago-project.org
>http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago

[PATCH 6/6] board-port-labs: Remove old board-port-labs recipe

[Franklin S. Cooper Jr]

* This recipe has been replaced by the new board-port-labs recipe

Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
---
 .../board-port-labs/board-port-labs/LICENSE        |   16 ----------
 .../board-port-labs/board-port-labs_git.bb         |   32 --------------------
 2 files changed, 0 insertions(+), 48 deletions(-)
 delete mode 100644 meta-arago-distro/recipes-tisdk/board-port-labs/board-port-labs/LICENSE
 delete mode 100644 meta-arago-distro/recipes-tisdk/board-port-labs/board-port-labs_git.bb

diff --git a/meta-arago-distro/recipes-tisdk/board-port-labs/board-port-labs/LICENSE b/meta-arago-distro/recipes-tisdk/board-port-labs/board-port-labs/LICENSE
deleted file mode 100644
index 738cb23..0000000
--- a/meta-arago-distro/recipes-tisdk/board-port-labs/board-port-labs/LICENSE
+++ /dev/null
@@ -1,16 +0,0 @@
-The trees found within this directory are git trees for the Linux
-kernel and u-boot.  These trees are based on the AM335x part and
-are meant to serve as a reference for general tasks involved in a board
-port.  These trees go along with the training available at:
-
-http://processors.wiki.ti.com/index.php/Sitara_Linux_Training
-
-Inside of each directory is a full git repository.  These repositories
-have tags that make isolating the changes for each functionality easier.
-You can view the tag using the "git tag" command and use "gitk --all"
-to better view the git tree contents.
-
-The individual trees are licensed under the same license as the Linux
-kernel and u-boot sources which is the GPLv2 license. A copy of license
-for the kernel and u-boot can be found in a file called COPYING within
-each of the respective git repositories.
diff --git a/meta-arago-distro/recipes-tisdk/board-port-labs/board-port-labs_git.bb b/meta-arago-distro/recipes-tisdk/board-port-labs/board-port-labs_git.bb
deleted file mode 100644
index b7f7d29..0000000
--- a/meta-arago-distro/recipes-tisdk/board-port-labs/board-port-labs_git.bb
+++ /dev/null
@@ -1,32 +0,0 @@
-DESCRIPTION = "Git repositories containing sample board port code"
-HOMEPAGE = "https://gitorious.org/sitara-board-port"
-LICENSE = "GPLv2"
-DEPENDS += "git-native"
-
-SRC_URI = "file://LICENSE"
-LIC_FILES_CHKSUM = "file://LICENSE;md5=d9fb2a547cd8e6bb75c0ecf427a139a9"
-
-inherit allarch
-
-CREATE_SRCIPK = "1"
-SRCIPK_INSTALL_DIR = "board-support/board-port-labs"
-
-PR = "r5"
-
-REPOS ?= "git://gitorious.org/sitara-board-port/sitara-board-port-linux.git \
-          git://gitorious.org/sitara-board-port/sitara-board-port-uboot.git \
-         "
-
-S = "${WORKDIR}"
-
-# Checkout the REPOS before the do_patch task so that it will be done prior
-# to the srcipk being made.
-do_repos_checkout() {
-    cd ${S}
-    for r in ${REPOS}
-    do
-        git clone $r
-    done
-}
-
-addtask repos_checkout after do_fetch before do_patch
-- 
1.7.0.4

Re: [PATCH 6/6] board-port-labs: Remove old board-port-labs recipe

[Maupin, Chase]

Acked-by: Chase Maupin <chase.maupin@ti.com>

>-----Original Message-----
>From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
>bounces@arago-project.org] On Behalf Of Cooper Jr., Franklin
>Sent: Tuesday, August 27, 2013 2:52 PM
>To: meta-arago@arago-project.org
>Cc: Cooper Jr., Franklin
>Subject: [meta-arago] [PATCH 6/6] board-port-labs: Remove old
>board-port-labs recipe
>
>* This recipe has been replaced by the new board-port-labs recipe
>
>Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
>---
> .../board-port-labs/board-port-labs/LICENSE        |   16 -------
>---
> .../board-port-labs/board-port-labs_git.bb         |   32 -------
>-------------
> 2 files changed, 0 insertions(+), 48 deletions(-)
> delete mode 100644 meta-arago-distro/recipes-tisdk/board-port-
>labs/board-port-labs/LICENSE
> delete mode 100644 meta-arago-distro/recipes-tisdk/board-port-
>labs/board-port-labs_git.bb
>
>diff --git a/meta-arago-distro/recipes-tisdk/board-port-
>labs/board-port-labs/LICENSE b/meta-arago-distro/recipes-
>tisdk/board-port-labs/board-port-labs/LICENSE
>deleted file mode 100644
>index 738cb23..0000000
>--- a/meta-arago-distro/recipes-tisdk/board-port-labs/board-port-
>labs/LICENSE
>+++ /dev/null
>@@ -1,16 +0,0 @@
>-The trees found within this directory are git trees for the Linux
>-kernel and u-boot.  These trees are based on the AM335x part and
>-are meant to serve as a reference for general tasks involved in a
>board
>-port.  These trees go along with the training available at:
>-
>-http://processors.wiki.ti.com/index.php/Sitara_Linux_Training
>-
>-Inside of each directory is a full git repository.  These
>repositories
>-have tags that make isolating the changes for each functionality
>easier.
>-You can view the tag using the "git tag" command and use "gitk --
>all"
>-to better view the git tree contents.
>-
>-The individual trees are licensed under the same license as the
>Linux
>-kernel and u-boot sources which is the GPLv2 license. A copy of
>license
>-for the kernel and u-boot can be found in a file called COPYING
>within
>-each of the respective git repositories.
>diff --git a/meta-arago-distro/recipes-tisdk/board-port-
>labs/board-port-labs_git.bb b/meta-arago-distro/recipes-
>tisdk/board-port-labs/board-port-labs_git.bb
>deleted file mode 100644
>index b7f7d29..0000000
>--- a/meta-arago-distro/recipes-tisdk/board-port-labs/board-port-
>labs_git.bb
>+++ /dev/null
>@@ -1,32 +0,0 @@
>-DESCRIPTION = "Git repositories containing sample board port
>code"
>-HOMEPAGE = "https://gitorious.org/sitara-board-port"
>-LICENSE = "GPLv2"
>-DEPENDS += "git-native"
>-
>-SRC_URI = "file://LICENSE"
>-LIC_FILES_CHKSUM =
>"file://LICENSE;md5=d9fb2a547cd8e6bb75c0ecf427a139a9"
>-
>-inherit allarch
>-
>-CREATE_SRCIPK = "1"
>-SRCIPK_INSTALL_DIR = "board-support/board-port-labs"
>-
>-PR = "r5"
>-
>-REPOS ?= "git://gitorious.org/sitara-board-port/sitara-board-
>port-linux.git \
>-          git://gitorious.org/sitara-board-port/sitara-board-
>port-uboot.git \
>-         "
>-
>-S = "${WORKDIR}"
>-
>-# Checkout the REPOS before the do_patch task so that it will be
>done prior
>-# to the srcipk being made.
>-do_repos_checkout() {
>-    cd ${S}
>-    for r in ${REPOS}
>-    do
>-        git clone $r
>-    done
>-}
>-
>-addtask repos_checkout after do_fetch before do_patch
>--
>1.7.0.4
>
>_______________________________________________
>meta-arago mailing list
>meta-arago@arago-project.org
>http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago

Re: [PATCH 1/6 v2] gst-plugins-bad: Use new PACKAGECONFIG feature

[Maupin, Chase]

>-----Original Message-----
>From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
>bounces@arago-project.org] On Behalf Of Cooper Jr., Franklin
>Sent: Tuesday, August 27, 2013 2:51 PM
>To: meta-arago@arago-project.org
>Cc: Cooper Jr., Franklin
>Subject: [meta-arago] [PATCH 1/6 v2] gst-plugins-bad: Use new
>PACKAGECONFIG feature
>
>* Recent patch in oe-core allows certain features to be enabled or
>disabled
>  based on the PACKAGECONFIG variable.
>* Use this variable which will obsolete alot of the code in this
>bbappend while
>  achieving the same result.
>
>Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
>---
>Version 2 changes:
>Update patch tailored to recent change to base recipe in oe-core.
>
>
> .../gstreamer/gst-plugins-bad_0.10.23.bbappend     |   14 ++-----
>-------
> 1 files changed, 2 insertions(+), 12 deletions(-)
>
>diff --git a/meta-arago-distro/recipes-multimedia/gstreamer/gst-
>plugins-bad_0.10.23.bbappend b/meta-arago-distro/recipes-
>multimedia/gstreamer/gst-plugins-bad_0.10.23.bbappend
>index 8ae8050..8cee785 100644
>--- a/meta-arago-distro/recipes-multimedia/gstreamer/gst-plugins-
>bad_0.10.23.bbappend
>+++ b/meta-arago-distro/recipes-multimedia/gstreamer/gst-plugins-
>bad_0.10.23.bbappend
>@@ -1,21 +1,11 @@
>-PR_append = "-arago3"
>+PR_append = "-arago4"
>
> # look for files in this layer first
> FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
>
>-# Disable rsvg which caused gtk+ to be pulled in
>-DEPENDS := "${@oe_filter_out('librsvg','${DEPENDS}', d)}"
>-EXTRA_OECONF += "--disable-rsvg"
>-
>-# Remove the restriction of which plugins are built. Previously
>fbdevsink
>-# was not built which is needed by the gstreamer demos included
>in the SDK.
>-EXTRA_OECONF := "${@oe_filter_out('--with-
>plugins=musicbrainz,wavpack,ivorbis,mpegvideoparse','${EXTRA_OECON
>F}', d)}"

I'm assuming that these are removed because of the COMMERCIAL filter setting (I don't remember the full variable off the top of my head)

Should this be called out in the commit message?

>-
> SRC_URI += "file://0001-gstfbdevsink-Fix-depth-value-for-
>GST_VIDEO_CAPS_RGB_.patch"
>
>-# Add faad has a dependency to insure gst-plugins-bad-faad is
>built.
>-DEPENDS += "faad2"
>-RDEPENDS_${PN}-faad += "libfaad"
>+PACKAGECONFIG = "bzip curl faad"

I have some question here.  You changed the DEPENDS to faad instead of faad2.  I see in base.bbclass the DEPENDS magic based on PACKAGECONFIG, but the RDEPENDS setting there didn't look like it would add libfaad.  Maybe I am just not reading it right but did you check that?

Also, why add curl and bzip too?  If needed should that be a separate patch or at least updated in the commit message?
>
> # Disable features that have potential commercial licensing
>restrictions
> EXTRA_OECONF += "\
>--
>1.7.0.4
>
>_______________________________________________
>meta-arago mailing list
>meta-arago@arago-project.org
>http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago

Re: [PATCH 1/6 v2] gst-plugins-bad: Use new PACKAGECONFIG feature

[Cooper Jr., Franklin]

> -----Original Message-----
> From: Maupin, Chase
> Sent: Friday, August 30, 2013 10:04 AM
> To: Cooper Jr., Franklin; meta-arago@arago-project.org
> Subject: RE: [meta-arago] [PATCH 1/6 v2] gst-plugins-bad: Use new
> PACKAGECONFIG feature
> 
> >-----Original Message-----
> >From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> >bounces@arago-project.org] On Behalf Of Cooper Jr., Franklin
> >Sent: Tuesday, August 27, 2013 2:51 PM
> >To: meta-arago@arago-project.org
> >Cc: Cooper Jr., Franklin
> >Subject: [meta-arago] [PATCH 1/6 v2] gst-plugins-bad: Use new
> >PACKAGECONFIG feature
> >
> >* Recent patch in oe-core allows certain features to be enabled or
> >disabled
> >  based on the PACKAGECONFIG variable.
> >* Use this variable which will obsolete alot of the code in this
> >bbappend while
> >  achieving the same result.
> >
> >Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
> >---
> >Version 2 changes:
> >Update patch tailored to recent change to base recipe in oe-core.
> >
> >
> > .../gstreamer/gst-plugins-bad_0.10.23.bbappend     |   14 ++-----
> >-------
> > 1 files changed, 2 insertions(+), 12 deletions(-)
> >
> >diff --git a/meta-arago-distro/recipes-multimedia/gstreamer/gst-
> >plugins-bad_0.10.23.bbappend b/meta-arago-distro/recipes-
> >multimedia/gstreamer/gst-plugins-bad_0.10.23.bbappend
> >index 8ae8050..8cee785 100644
> >--- a/meta-arago-distro/recipes-multimedia/gstreamer/gst-plugins-
> >bad_0.10.23.bbappend
> >+++ b/meta-arago-distro/recipes-multimedia/gstreamer/gst-plugins-
> >bad_0.10.23.bbappend
> >@@ -1,21 +1,11 @@
> >-PR_append = "-arago3"
> >+PR_append = "-arago4"
> >
> > # look for files in this layer first
> > FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
> >
> >-# Disable rsvg which caused gtk+ to be pulled in -DEPENDS :=
> >"${@oe_filter_out('librsvg','${DEPENDS}', d)}"
> >-EXTRA_OECONF += "--disable-rsvg"
> >-
> >-# Remove the restriction of which plugins are built. Previously
> >fbdevsink -# was not built which is needed by the gstreamer demos
> >included in the SDK.
> >-EXTRA_OECONF := "${@oe_filter_out('--with-
> >plugins=musicbrainz,wavpack,ivorbis,mpegvideoparse','${EXTRA_OECON
> >F}', d)}"
> 
> I'm assuming that these are removed because of the COMMERCIAL filter setting
> (I don't remember the full variable off the top of my head)
> 
> Should this be called out in the commit message?
[Franklin] So this oe_filter_out wasn't due to COMMERCIAL filter it was due to with-plugins will only build plugins in the list. So by filtering out that string gst-plugins-bad will attempt to build all plugins.
Further down in the recipe you can see where certain plugins are explicitly removed because of license reasoning. There is even a comment about it addressing that.
> 
> >-
> > SRC_URI += "file://0001-gstfbdevsink-Fix-depth-value-for-
> >GST_VIDEO_CAPS_RGB_.patch"
> >
> >-# Add faad has a dependency to insure gst-plugins-bad-faad is built.
> >-DEPENDS += "faad2"
> >-RDEPENDS_${PN}-faad += "libfaad"
> >+PACKAGECONFIG = "bzip curl faad"
> 
> I have some question here.  You changed the DEPENDS to faad instead of faad2.
> I see in base.bbclass the DEPENDS magic based on PACKAGECONFIG, but the
> RDEPENDS setting there didn't look like it would add libfaad.  Maybe I am just
> not reading it right but did you check that?
[Franklin] Ah your right.

Comment from base.bbclass
PACKAGECONFIG[foo] = "--enable-foo,--disable-foo,foo_depends,foo_runtime_depends"

Snippet from gst-plugins-bad
PACKAGECONFIG[faad] = "--enable-faad,--disable-faad,faad2"

So I probably need to change the override the above line with
PACKAGECONFIG[faad] = "--enable-faad,--disable-faad,faad2,libfaad"

Let me double check this.



> 
> Also, why add curl and bzip too?  If needed should that be a separate patch or at
> least updated in the commit message?
[Franklin] In the base recipe PACKAGECONFIG is set to "bzip curl". Since I am adding faad I needed to override that variable but I didn't want to lose the default. Probably a better approach is
PACKAGECONFIG = "${PACKAGECONFIG} faad"
Although I don't know what ??= means so I will have to see if that works.
> >
> > # Disable features that have potential commercial licensing
> >restrictions
> > EXTRA_OECONF += "\
> >--
> >1.7.0.4
> >
> >_______________________________________________
> >meta-arago mailing list
> >meta-arago@arago-project.org
> >http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago

Re: [PATCH 1/6 v2] gst-plugins-bad: Use new PACKAGECONFIG feature

[Denys Dmytriyenko]

On Fri, Aug 30, 2013 at 03:44:26PM +0000, Cooper Jr., Franklin wrote:
> 
> 
> > -----Original Message-----
> > From: Maupin, Chase
> > Sent: Friday, August 30, 2013 10:04 AM
> > To: Cooper Jr., Franklin; meta-arago@arago-project.org
> > Subject: RE: [meta-arago] [PATCH 1/6 v2] gst-plugins-bad: Use new
> > PACKAGECONFIG feature
> > 
> > >-----Original Message-----
> > >From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> > >bounces@arago-project.org] On Behalf Of Cooper Jr., Franklin
> > >Sent: Tuesday, August 27, 2013 2:51 PM
> > >To: meta-arago@arago-project.org
> > >Cc: Cooper Jr., Franklin
> > >Subject: [meta-arago] [PATCH 1/6 v2] gst-plugins-bad: Use new
> > >PACKAGECONFIG feature
> > >
> > >* Recent patch in oe-core allows certain features to be enabled or
> > >disabled
> > >  based on the PACKAGECONFIG variable.
> > >* Use this variable which will obsolete alot of the code in this
> > >bbappend while
> > >  achieving the same result.
> > >
> > >Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
> > >---
> > >Version 2 changes:
> > >Update patch tailored to recent change to base recipe in oe-core.
> > >
> > >
> > > .../gstreamer/gst-plugins-bad_0.10.23.bbappend     |   14 ++-----
> > >-------
> > > 1 files changed, 2 insertions(+), 12 deletions(-)
> > >
> > >diff --git a/meta-arago-distro/recipes-multimedia/gstreamer/gst-
> > >plugins-bad_0.10.23.bbappend b/meta-arago-distro/recipes-
> > >multimedia/gstreamer/gst-plugins-bad_0.10.23.bbappend
> > >index 8ae8050..8cee785 100644
> > >--- a/meta-arago-distro/recipes-multimedia/gstreamer/gst-plugins-
> > >bad_0.10.23.bbappend
> > >+++ b/meta-arago-distro/recipes-multimedia/gstreamer/gst-plugins-
> > >bad_0.10.23.bbappend
> > >@@ -1,21 +1,11 @@
> > >-PR_append = "-arago3"
> > >+PR_append = "-arago4"
> > >
> > > # look for files in this layer first
> > > FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
> > >
> > >-# Disable rsvg which caused gtk+ to be pulled in -DEPENDS :=
> > >"${@oe_filter_out('librsvg','${DEPENDS}', d)}"
> > >-EXTRA_OECONF += "--disable-rsvg"
> > >-
> > >-# Remove the restriction of which plugins are built. Previously
> > >fbdevsink -# was not built which is needed by the gstreamer demos
> > >included in the SDK.
> > >-EXTRA_OECONF := "${@oe_filter_out('--with-
> > >plugins=musicbrainz,wavpack,ivorbis,mpegvideoparse','${EXTRA_OECON
> > >F}', d)}"
> > 
> > I'm assuming that these are removed because of the COMMERCIAL filter setting
> > (I don't remember the full variable off the top of my head)
> > 
> > Should this be called out in the commit message?

> [Franklin] So this oe_filter_out wasn't due to COMMERCIAL filter it was due 
> to with-plugins will only build plugins in the list. So by filtering out 
> that string gst-plugins-bad will attempt to build all plugins. Further down 
> in the recipe you can see where certain plugins are explicitly removed 
> because of license reasoning. There is even a comment about it addressing 
> that.

> > 
> > >-
> > > SRC_URI += "file://0001-gstfbdevsink-Fix-depth-value-for-
> > >GST_VIDEO_CAPS_RGB_.patch"
> > >
> > >-# Add faad has a dependency to insure gst-plugins-bad-faad is built.
> > >-DEPENDS += "faad2"
> > >-RDEPENDS_${PN}-faad += "libfaad"
> > >+PACKAGECONFIG = "bzip curl faad"
> > 
> > I have some question here.  You changed the DEPENDS to faad instead of faad2.
> > I see in base.bbclass the DEPENDS magic based on PACKAGECONFIG, but the
> > RDEPENDS setting there didn't look like it would add libfaad.  Maybe I am just
> > not reading it right but did you check that?
> [Franklin] Ah your right.
> 
> Comment from base.bbclass
> PACKAGECONFIG[foo] = "--enable-foo,--disable-foo,foo_depends,foo_runtime_depends"
> 
> Snippet from gst-plugins-bad
> PACKAGECONFIG[faad] = "--enable-faad,--disable-faad,faad2"
> 
> So I probably need to change the override the above line with
> PACKAGECONFIG[faad] = "--enable-faad,--disable-faad,faad2,libfaad"
> 
> Let me double check this.

That is the correct use of PACKAGECONFIG, although handling shlib dependencies 
is usually done automatically. In other words, if you have DEPENDS on faad 
already and it installs libfaad that this package uses, it will figure out 
RDEPENDS automatically...


> > Also, why add curl and bzip too?  If needed should that be a separate patch or at
> > least updated in the commit message?

> [Franklin] In the base recipe PACKAGECONFIG is set to "bzip curl". Since I 
> am adding faad I needed to override that variable but I didn't want to lose 
> the default. Probably a better approach is

> PACKAGECONFIG = "${PACKAGECONFIG} faad"
> Although I don't know what ??= means so I will have to see if that works.

It is just a "lazy" variant of a regular ?= conditional assignment, i.e. it 
just wait until the end of the parsing to decide upon it:

http://docs.openembedded.org/bitbake/html/ch02.html#id398548


> > >
> > > # Disable features that have potential commercial licensing
> > >restrictions
> > > EXTRA_OECONF += "\
> > >--
> > >1.7.0.4
> > >
> > >_______________________________________________
> > >meta-arago mailing list
> > >meta-arago@arago-project.org
> > >http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago