From: Michael Walle <michael@walle.cc>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
Vladimir Zapolskiy <vz@mleia.com>,
Tudor Ambarus <tudor.ambarus@microchip.com>,
Pratyush Yadav <p.yadav@ti.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH v1 1/1] mtd: spi-nor: Use SPI_MODE_X_MASK
Date: Mon, 10 May 2021 22:23:18 +0200 [thread overview]
Message-ID: <8b280c0fc105ededc399ee22b940e671@walle.cc> (raw)
In-Reply-To: <20210510141343.56805-1-andriy.shevchenko@linux.intel.com>
Am 2021-05-10 16:13, schrieb Andy Shevchenko:
> Use SPI_MODE_X_MASK instead of open coded variant.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/mtd/spi-nor/controllers/nxp-spifi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/controllers/nxp-spifi.c
> b/drivers/mtd/spi-nor/controllers/nxp-spifi.c
> index 5703e8313980..2635c80231bb 100644
> --- a/drivers/mtd/spi-nor/controllers/nxp-spifi.c
> +++ b/drivers/mtd/spi-nor/controllers/nxp-spifi.c
> @@ -326,7 +326,7 @@ static int nxp_spifi_setup_flash(struct nxp_spifi
> *spifi,
> ctrl |= SPIFI_CTRL_DUAL;
> }
>
> - switch (mode & (SPI_CPHA | SPI_CPOL)) {
> + switch (mode & SPI_MODE_X_MASK) {
> case SPI_MODE_0:
> ctrl &= ~SPIFI_CTRL_MODE3;
> break;
Reviewed-by: Michael Walle <michael@walle.cc>
-michael
WARNING: multiple messages have this Message-ID (diff)
From: Michael Walle <michael@walle.cc>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
Vladimir Zapolskiy <vz@mleia.com>,
Tudor Ambarus <tudor.ambarus@microchip.com>,
Pratyush Yadav <p.yadav@ti.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH v1 1/1] mtd: spi-nor: Use SPI_MODE_X_MASK
Date: Mon, 10 May 2021 22:23:18 +0200 [thread overview]
Message-ID: <8b280c0fc105ededc399ee22b940e671@walle.cc> (raw)
In-Reply-To: <20210510141343.56805-1-andriy.shevchenko@linux.intel.com>
Am 2021-05-10 16:13, schrieb Andy Shevchenko:
> Use SPI_MODE_X_MASK instead of open coded variant.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/mtd/spi-nor/controllers/nxp-spifi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/controllers/nxp-spifi.c
> b/drivers/mtd/spi-nor/controllers/nxp-spifi.c
> index 5703e8313980..2635c80231bb 100644
> --- a/drivers/mtd/spi-nor/controllers/nxp-spifi.c
> +++ b/drivers/mtd/spi-nor/controllers/nxp-spifi.c
> @@ -326,7 +326,7 @@ static int nxp_spifi_setup_flash(struct nxp_spifi
> *spifi,
> ctrl |= SPIFI_CTRL_DUAL;
> }
>
> - switch (mode & (SPI_CPHA | SPI_CPOL)) {
> + switch (mode & SPI_MODE_X_MASK) {
> case SPI_MODE_0:
> ctrl &= ~SPIFI_CTRL_MODE3;
> break;
Reviewed-by: Michael Walle <michael@walle.cc>
-michael
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Michael Walle <michael@walle.cc>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
Vladimir Zapolskiy <vz@mleia.com>,
Tudor Ambarus <tudor.ambarus@microchip.com>,
Pratyush Yadav <p.yadav@ti.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH v1 1/1] mtd: spi-nor: Use SPI_MODE_X_MASK
Date: Mon, 10 May 2021 22:23:18 +0200 [thread overview]
Message-ID: <8b280c0fc105ededc399ee22b940e671@walle.cc> (raw)
In-Reply-To: <20210510141343.56805-1-andriy.shevchenko@linux.intel.com>
Am 2021-05-10 16:13, schrieb Andy Shevchenko:
> Use SPI_MODE_X_MASK instead of open coded variant.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/mtd/spi-nor/controllers/nxp-spifi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/controllers/nxp-spifi.c
> b/drivers/mtd/spi-nor/controllers/nxp-spifi.c
> index 5703e8313980..2635c80231bb 100644
> --- a/drivers/mtd/spi-nor/controllers/nxp-spifi.c
> +++ b/drivers/mtd/spi-nor/controllers/nxp-spifi.c
> @@ -326,7 +326,7 @@ static int nxp_spifi_setup_flash(struct nxp_spifi
> *spifi,
> ctrl |= SPIFI_CTRL_DUAL;
> }
>
> - switch (mode & (SPI_CPHA | SPI_CPOL)) {
> + switch (mode & SPI_MODE_X_MASK) {
> case SPI_MODE_0:
> ctrl &= ~SPIFI_CTRL_MODE3;
> break;
Reviewed-by: Michael Walle <michael@walle.cc>
-michael
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-10 20:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 14:13 [PATCH v1 1/1] mtd: spi-nor: Use SPI_MODE_X_MASK Andy Shevchenko
2021-05-10 14:13 ` Andy Shevchenko
2021-05-10 14:13 ` Andy Shevchenko
2021-05-10 20:23 ` Michael Walle [this message]
2021-05-10 20:23 ` Michael Walle
2021-05-10 20:23 ` Michael Walle
2021-05-27 14:06 ` Vignesh Raghavendra
2021-05-27 14:06 ` Vignesh Raghavendra
2021-05-27 14:06 ` Vignesh Raghavendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b280c0fc105ededc399ee22b940e671@walle.cc \
--to=michael@walle.cc \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=p.yadav@ti.com \
--cc=richard@nod.at \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.