* [PATCH v1 1/1] mtd: spi-nor: Use SPI_MODE_X_MASK
@ 2021-05-10 14:13 ` Andy Shevchenko
0 siblings, 0 replies; 9+ messages in thread
From: Andy Shevchenko @ 2021-05-10 14:13 UTC (permalink / raw)
To: linux-arm-kernel, linux-mtd, linux-kernel
Cc: Vladimir Zapolskiy, Tudor Ambarus, Michael Walle, Pratyush Yadav,
Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Andy Shevchenko
Use SPI_MODE_X_MASK instead of open coded variant.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/mtd/spi-nor/controllers/nxp-spifi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/spi-nor/controllers/nxp-spifi.c b/drivers/mtd/spi-nor/controllers/nxp-spifi.c
index 5703e8313980..2635c80231bb 100644
--- a/drivers/mtd/spi-nor/controllers/nxp-spifi.c
+++ b/drivers/mtd/spi-nor/controllers/nxp-spifi.c
@@ -326,7 +326,7 @@ static int nxp_spifi_setup_flash(struct nxp_spifi *spifi,
ctrl |= SPIFI_CTRL_DUAL;
}
- switch (mode & (SPI_CPHA | SPI_CPOL)) {
+ switch (mode & SPI_MODE_X_MASK) {
case SPI_MODE_0:
ctrl &= ~SPIFI_CTRL_MODE3;
break;
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH v1 1/1] mtd: spi-nor: Use SPI_MODE_X_MASK
@ 2021-05-10 14:13 ` Andy Shevchenko
0 siblings, 0 replies; 9+ messages in thread
From: Andy Shevchenko @ 2021-05-10 14:13 UTC (permalink / raw)
To: linux-arm-kernel, linux-mtd, linux-kernel
Cc: Vladimir Zapolskiy, Tudor Ambarus, Michael Walle, Pratyush Yadav,
Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Andy Shevchenko
Use SPI_MODE_X_MASK instead of open coded variant.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/mtd/spi-nor/controllers/nxp-spifi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/spi-nor/controllers/nxp-spifi.c b/drivers/mtd/spi-nor/controllers/nxp-spifi.c
index 5703e8313980..2635c80231bb 100644
--- a/drivers/mtd/spi-nor/controllers/nxp-spifi.c
+++ b/drivers/mtd/spi-nor/controllers/nxp-spifi.c
@@ -326,7 +326,7 @@ static int nxp_spifi_setup_flash(struct nxp_spifi *spifi,
ctrl |= SPIFI_CTRL_DUAL;
}
- switch (mode & (SPI_CPHA | SPI_CPOL)) {
+ switch (mode & SPI_MODE_X_MASK) {
case SPI_MODE_0:
ctrl &= ~SPIFI_CTRL_MODE3;
break;
--
2.30.2
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v1 1/1] mtd: spi-nor: Use SPI_MODE_X_MASK
2021-05-10 14:13 ` Andy Shevchenko
(?)
@ 2021-05-10 20:23 ` Michael Walle
-1 siblings, 0 replies; 9+ messages in thread
From: Michael Walle @ 2021-05-10 20:23 UTC (permalink / raw)
To: Andy Shevchenko
Cc: linux-arm-kernel, linux-mtd, linux-kernel, Vladimir Zapolskiy,
Tudor Ambarus, Pratyush Yadav, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra
Am 2021-05-10 16:13, schrieb Andy Shevchenko:
> Use SPI_MODE_X_MASK instead of open coded variant.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/mtd/spi-nor/controllers/nxp-spifi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/controllers/nxp-spifi.c
> b/drivers/mtd/spi-nor/controllers/nxp-spifi.c
> index 5703e8313980..2635c80231bb 100644
> --- a/drivers/mtd/spi-nor/controllers/nxp-spifi.c
> +++ b/drivers/mtd/spi-nor/controllers/nxp-spifi.c
> @@ -326,7 +326,7 @@ static int nxp_spifi_setup_flash(struct nxp_spifi
> *spifi,
> ctrl |= SPIFI_CTRL_DUAL;
> }
>
> - switch (mode & (SPI_CPHA | SPI_CPOL)) {
> + switch (mode & SPI_MODE_X_MASK) {
> case SPI_MODE_0:
> ctrl &= ~SPIFI_CTRL_MODE3;
> break;
Reviewed-by: Michael Walle <michael@walle.cc>
-michael
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v1 1/1] mtd: spi-nor: Use SPI_MODE_X_MASK
@ 2021-05-10 20:23 ` Michael Walle
0 siblings, 0 replies; 9+ messages in thread
From: Michael Walle @ 2021-05-10 20:23 UTC (permalink / raw)
To: Andy Shevchenko
Cc: linux-arm-kernel, linux-mtd, linux-kernel, Vladimir Zapolskiy,
Tudor Ambarus, Pratyush Yadav, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra
Am 2021-05-10 16:13, schrieb Andy Shevchenko:
> Use SPI_MODE_X_MASK instead of open coded variant.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/mtd/spi-nor/controllers/nxp-spifi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/controllers/nxp-spifi.c
> b/drivers/mtd/spi-nor/controllers/nxp-spifi.c
> index 5703e8313980..2635c80231bb 100644
> --- a/drivers/mtd/spi-nor/controllers/nxp-spifi.c
> +++ b/drivers/mtd/spi-nor/controllers/nxp-spifi.c
> @@ -326,7 +326,7 @@ static int nxp_spifi_setup_flash(struct nxp_spifi
> *spifi,
> ctrl |= SPIFI_CTRL_DUAL;
> }
>
> - switch (mode & (SPI_CPHA | SPI_CPOL)) {
> + switch (mode & SPI_MODE_X_MASK) {
> case SPI_MODE_0:
> ctrl &= ~SPIFI_CTRL_MODE3;
> break;
Reviewed-by: Michael Walle <michael@walle.cc>
-michael
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v1 1/1] mtd: spi-nor: Use SPI_MODE_X_MASK
@ 2021-05-10 20:23 ` Michael Walle
0 siblings, 0 replies; 9+ messages in thread
From: Michael Walle @ 2021-05-10 20:23 UTC (permalink / raw)
To: Andy Shevchenko
Cc: linux-arm-kernel, linux-mtd, linux-kernel, Vladimir Zapolskiy,
Tudor Ambarus, Pratyush Yadav, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra
Am 2021-05-10 16:13, schrieb Andy Shevchenko:
> Use SPI_MODE_X_MASK instead of open coded variant.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/mtd/spi-nor/controllers/nxp-spifi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/controllers/nxp-spifi.c
> b/drivers/mtd/spi-nor/controllers/nxp-spifi.c
> index 5703e8313980..2635c80231bb 100644
> --- a/drivers/mtd/spi-nor/controllers/nxp-spifi.c
> +++ b/drivers/mtd/spi-nor/controllers/nxp-spifi.c
> @@ -326,7 +326,7 @@ static int nxp_spifi_setup_flash(struct nxp_spifi
> *spifi,
> ctrl |= SPIFI_CTRL_DUAL;
> }
>
> - switch (mode & (SPI_CPHA | SPI_CPOL)) {
> + switch (mode & SPI_MODE_X_MASK) {
> case SPI_MODE_0:
> ctrl &= ~SPIFI_CTRL_MODE3;
> break;
Reviewed-by: Michael Walle <michael@walle.cc>
-michael
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1 1/1] mtd: spi-nor: Use SPI_MODE_X_MASK
2021-05-10 14:13 ` Andy Shevchenko
(?)
@ 2021-05-27 14:06 ` Vignesh Raghavendra
-1 siblings, 0 replies; 9+ messages in thread
From: Vignesh Raghavendra @ 2021-05-27 14:06 UTC (permalink / raw)
To: linux-kernel, Andy Shevchenko, linux-mtd, linux-arm-kernel
Cc: Vignesh Raghavendra, Richard Weinberger, Vladimir Zapolskiy,
Tudor Ambarus, Pratyush Yadav, Michael Walle, Miquel Raynal
On Mon, 10 May 2021 17:13:43 +0300, Andy Shevchenko wrote:
> Use SPI_MODE_X_MASK instead of open coded variant.
Updated $subject to:
"mtd: spi-nor: nxp-spifi: Use SPI_MODE_X_MASK"
Applied to spi-nor/next, thanks!
[1/1] mtd: spi-nor: Use SPI_MODE_X_MASK
https://git.kernel.org/mtd/c/5c26d52c9e
--
Regards
Vignesh
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v1 1/1] mtd: spi-nor: Use SPI_MODE_X_MASK
@ 2021-05-27 14:06 ` Vignesh Raghavendra
0 siblings, 0 replies; 9+ messages in thread
From: Vignesh Raghavendra @ 2021-05-27 14:06 UTC (permalink / raw)
To: linux-kernel, Andy Shevchenko, linux-mtd, linux-arm-kernel
Cc: Vignesh Raghavendra, Richard Weinberger, Vladimir Zapolskiy,
Tudor Ambarus, Pratyush Yadav, Michael Walle, Miquel Raynal
On Mon, 10 May 2021 17:13:43 +0300, Andy Shevchenko wrote:
> Use SPI_MODE_X_MASK instead of open coded variant.
Updated $subject to:
"mtd: spi-nor: nxp-spifi: Use SPI_MODE_X_MASK"
Applied to spi-nor/next, thanks!
[1/1] mtd: spi-nor: Use SPI_MODE_X_MASK
https://git.kernel.org/mtd/c/5c26d52c9e
--
Regards
Vignesh
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v1 1/1] mtd: spi-nor: Use SPI_MODE_X_MASK
@ 2021-05-27 14:06 ` Vignesh Raghavendra
0 siblings, 0 replies; 9+ messages in thread
From: Vignesh Raghavendra @ 2021-05-27 14:06 UTC (permalink / raw)
To: linux-kernel, Andy Shevchenko, linux-mtd, linux-arm-kernel
Cc: Vignesh Raghavendra, Richard Weinberger, Vladimir Zapolskiy,
Tudor Ambarus, Pratyush Yadav, Michael Walle, Miquel Raynal
On Mon, 10 May 2021 17:13:43 +0300, Andy Shevchenko wrote:
> Use SPI_MODE_X_MASK instead of open coded variant.
Updated $subject to:
"mtd: spi-nor: nxp-spifi: Use SPI_MODE_X_MASK"
Applied to spi-nor/next, thanks!
[1/1] mtd: spi-nor: Use SPI_MODE_X_MASK
https://git.kernel.org/mtd/c/5c26d52c9e
--
Regards
Vignesh
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 9+ messages in thread