From: Oleksij Rempel <linux@rempel-privat.de>
To: Ben Greear <greearb@candelatech.com>,
Johannes Berg <johannes@sipsolutions.net>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
ath10k <ath10k@lists.infradead.org>,
kirtika@google.com
Subject: Re: Setting single rate in ath10k broken by "reject/clear user rate mask if not usable"
Date: Wed, 18 Oct 2017 19:56:16 +0200 [thread overview]
Message-ID: <8c2e0e98-f3f4-6e0c-1bf0-43dfa6e97275@rempel-privat.de> (raw)
In-Reply-To: <2ad42671-59c4-80ed-4bca-f874eb53d653@candelatech.com>
Am 18.10.2017 um 16:50 schrieb Ben Greear:
>
>
> On 10/18/2017 12:33 AM, Johannes Berg wrote:
>> Hi,
>>
>>> The call to set the rate in the driver comes before the error
>>> check.
>>>
>>> if (ieee80211_hw_check(&local->hw, HAS_RATE_CONTROL)) {
>>> ret = drv_set_bitrate_mask(local, sdata, mask);
>>> if (ret) {
>>> pr_err("%s: drv-set-bitrate-mask had error
>>> return: %d\n",
>>> sdata->dev->name, ret);
>>> return ret;
>>> }
>>> }
>>>
>>> /*
>>> * If active validate the setting and reject it if it doesn't
>>> leave
>>> * at least one basic rate usable, since we really have to be
>>> able
>>> * to send something, and if we're an AP we have to be able to
>>> do
>>> * so at a basic rate so that all clients can receive it.
>>> */
>>> if (rcu_access_pointer(sdata->vif.chanctx_conf) &&
>>> sdata->vif.bss_conf.chandef.chan) {
>>> u32 basic_rates = sdata->vif.bss_conf.basic_rates;
>>> enum nl80211_band band = sdata-
>>>> vif.bss_conf.chandef.chan->band;
>>>
>>> if (!(mask->control[band].legacy & basic_rates)) {
>>> #### I changed this code so I could set a
>>> single rate... --Ben
>>> pr_err("%s: WARNING: no legacy rates for
>>> band[%d] in set-bitrate-mask.\n",
>>> sdata->dev->name, band);
>>> }
>>> }
>>
>> Heh, that's just dumb. I guess I'll fix that by putting the test first,
>> no idea how that happened.
>>
>>>>
>>>>> So, I think we should relax this check, at least for ath10k.
>>>>
>>>> Well, yes and no. I don't think we should make ath10k special here,
>>>> and
>>>> this fixes a real problem - namely that you can set up the system
>>>> so
>>>> that you have no usable rates at all, and then you just get a
>>>> WARN_ON
>>>> and start using the lowest possible rate...
>>>
>>> Well, there are a million ways to set up a broken system,
>>
>> True, but this one actually happened in practice, for some reason, and
>> stopping the user from constantly shooting themselves in the foot seems
>> like a good idea to me. Especially if the user (or application) can't
>> really even know what they're getting into.
>>
>> Now, the case in question was _client_ mode, but still.
>>
>>> and setting a single rate has a useful purpose, especially with
>>> ath10k since it has such limited rate-setting capabilities.
>>
>> You're stretching the definition of "useful purpose" a bit here though,
>> you're about the only one who's ever going to need to set a single
>> rate.
>
> People trying to do regulatory testing want this feature, and other people
> that are not me also like to test with specific rates. Still a
> small-ish set
> of people, but bigger than just me at least.
Till now i was interviewing different people who was asking for this for
ath9k-htc. So I would say we have:
- academical researchers
- testers
- R&D
- exploit and penetration testers
- HAM
- just hackers
As for me, it sounds a s lot.
--
Regards,
Oleksij
WARNING: multiple messages have this Message-ID (diff)
From: Oleksij Rempel <linux@rempel-privat.de>
To: Ben Greear <greearb@candelatech.com>,
Johannes Berg <johannes@sipsolutions.net>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
ath10k <ath10k@lists.infradead.org>,
kirtika@google.com
Subject: Re: Setting single rate in ath10k broken by "reject/clear user rate mask if not usable"
Date: Wed, 18 Oct 2017 19:56:16 +0200 [thread overview]
Message-ID: <8c2e0e98-f3f4-6e0c-1bf0-43dfa6e97275@rempel-privat.de> (raw)
In-Reply-To: <2ad42671-59c4-80ed-4bca-f874eb53d653@candelatech.com>
Am 18.10.2017 um 16:50 schrieb Ben Greear:
>
>
> On 10/18/2017 12:33 AM, Johannes Berg wrote:
>> Hi,
>>
>>> The call to set the rate in the driver comes before the error
>>> check.
>>>
>>> if (ieee80211_hw_check(&local->hw, HAS_RATE_CONTROL)) {
>>> ret = drv_set_bitrate_mask(local, sdata, mask);
>>> if (ret) {
>>> pr_err("%s: drv-set-bitrate-mask had error
>>> return: %d\n",
>>> sdata->dev->name, ret);
>>> return ret;
>>> }
>>> }
>>>
>>> /*
>>> * If active validate the setting and reject it if it doesn't
>>> leave
>>> * at least one basic rate usable, since we really have to be
>>> able
>>> * to send something, and if we're an AP we have to be able to
>>> do
>>> * so at a basic rate so that all clients can receive it.
>>> */
>>> if (rcu_access_pointer(sdata->vif.chanctx_conf) &&
>>> sdata->vif.bss_conf.chandef.chan) {
>>> u32 basic_rates = sdata->vif.bss_conf.basic_rates;
>>> enum nl80211_band band = sdata-
>>>> vif.bss_conf.chandef.chan->band;
>>>
>>> if (!(mask->control[band].legacy & basic_rates)) {
>>> #### I changed this code so I could set a
>>> single rate... --Ben
>>> pr_err("%s: WARNING: no legacy rates for
>>> band[%d] in set-bitrate-mask.\n",
>>> sdata->dev->name, band);
>>> }
>>> }
>>
>> Heh, that's just dumb. I guess I'll fix that by putting the test first,
>> no idea how that happened.
>>
>>>>
>>>>> So, I think we should relax this check, at least for ath10k.
>>>>
>>>> Well, yes and no. I don't think we should make ath10k special here,
>>>> and
>>>> this fixes a real problem - namely that you can set up the system
>>>> so
>>>> that you have no usable rates at all, and then you just get a
>>>> WARN_ON
>>>> and start using the lowest possible rate...
>>>
>>> Well, there are a million ways to set up a broken system,
>>
>> True, but this one actually happened in practice, for some reason, and
>> stopping the user from constantly shooting themselves in the foot seems
>> like a good idea to me. Especially if the user (or application) can't
>> really even know what they're getting into.
>>
>> Now, the case in question was _client_ mode, but still.
>>
>>> and setting a single rate has a useful purpose, especially with
>>> ath10k since it has such limited rate-setting capabilities.
>>
>> You're stretching the definition of "useful purpose" a bit here though,
>> you're about the only one who's ever going to need to set a single
>> rate.
>
> People trying to do regulatory testing want this feature, and other people
> that are not me also like to test with specific rates. Still a
> small-ish set
> of people, but bigger than just me at least.
Till now i was interviewing different people who was asking for this for
ath9k-htc. So I would say we have:
- academical researchers
- testers
- R&D
- exploit and penetration testers
- HAM
- just hackers
As for me, it sounds a s lot.
--
Regards,
Oleksij
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2017-10-18 17:56 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 20:54 Setting single rate in ath10k broken by "reject/clear user rate mask if not usable" Ben Greear
2017-10-10 20:54 ` Ben Greear
2017-10-11 4:37 ` Not able to set single rate in ath10k (backports-4.14-rc2-1) KAVITA MATHUR
2017-10-11 8:02 ` Setting single rate in ath10k broken by "reject/clear user rate mask if not usable" Johannes Berg
2017-10-11 8:02 ` Johannes Berg
2017-10-11 8:07 ` Johannes Berg
2017-10-11 8:07 ` Johannes Berg
2017-10-11 14:51 ` Ben Greear
2017-10-11 14:51 ` Ben Greear
2017-10-18 7:33 ` Johannes Berg
2017-10-18 7:33 ` Johannes Berg
2017-10-18 14:50 ` Ben Greear
2017-10-18 14:50 ` Ben Greear
2017-10-18 17:56 ` Oleksij Rempel [this message]
2017-10-18 17:56 ` Oleksij Rempel
2017-10-18 20:34 ` Johannes Berg
2017-10-18 20:34 ` Johannes Berg
2017-10-18 20:51 ` Ben Greear
2017-10-18 20:51 ` Ben Greear
2017-10-18 21:02 ` Johannes Berg
2017-10-18 21:02 ` Johannes Berg
2017-10-18 21:30 ` Ben Greear
2017-10-18 21:30 ` Ben Greear
2017-10-25 15:17 ` Johannes Berg
2017-10-25 15:17 ` Johannes Berg
2017-10-25 16:13 ` Ben Greear
2017-10-25 16:13 ` Ben Greear
2017-10-27 20:15 ` Johannes Berg
2017-10-27 20:15 ` Johannes Berg
2017-10-27 20:41 ` Ben Greear
2017-10-27 20:41 ` Ben Greear
2017-11-13 10:09 ` Johannes Berg
2017-11-13 10:09 ` Johannes Berg
2017-11-13 17:05 ` Ben Greear
2017-11-13 17:05 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c2e0e98-f3f4-6e0c-1bf0-43dfa6e97275@rempel-privat.de \
--to=linux@rempel-privat.de \
--cc=ath10k@lists.infradead.org \
--cc=greearb@candelatech.com \
--cc=johannes@sipsolutions.net \
--cc=kirtika@google.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.