All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Walle <michael@walle.cc>
To: Tim Harvey <tharvey@gateworks.com>
Cc: devicetree@vger.kernel.org, NXP Linux Team <linux-imx@nxp.com>,
	Fabio Estevam <festevam@gmail.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	Tudor Ambarus <tudor.ambarus@microchip.com>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: at25: add Fujitsu MB85RS4MT
Date: Tue, 09 Mar 2021 23:59:58 +0100	[thread overview]
Message-ID: <8ca5c54140d69307f3c08ca85a09f0b5@walle.cc> (raw)
In-Reply-To: <20210309220014.22205-1-tharvey@gateworks.com>

Hi Tim,

Am 2021-03-09 23:00, schrieb Tim Harvey:
> Document the compatible value for the Fujitsu MB85RS4MT SPI
> FRAM EEPROM device so that it can be used in DTS files.
> 
> This is a 512KiB FRAM EEPROM.
> 
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> ---
>  Documentation/devicetree/bindings/eeprom/at25.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/eeprom/at25.yaml
> b/Documentation/devicetree/bindings/eeprom/at25.yaml
> index 6a2dc8b3ed14..f594db72b711 100644
> --- a/Documentation/devicetree/bindings/eeprom/at25.yaml
> +++ b/Documentation/devicetree/bindings/eeprom/at25.yaml
> @@ -26,6 +26,7 @@ properties:
>                - anvo,anv32e61w
>                - atmel,at25256B
>                - fujitsu,mb85rs1mt
> +              - fujitsu,mb85rs4mt
>                - fujitsu,mb85rs64
>                - microchip,at25160bn
>                - microchip,25lc040

Hm, the driver is spi-nor but this is for the at25 driver. Is
this correct? Doesn't it work if you just add the ID to
spi-nor/fujitsu.c and use 'compatible = "jedec,spi-nor' ?

-michael

WARNING: multiple messages have this Message-ID (diff)
From: Michael Walle <michael@walle.cc>
To: Tim Harvey <tharvey@gateworks.com>
Cc: devicetree@vger.kernel.org, NXP Linux Team <linux-imx@nxp.com>,
	Fabio Estevam <festevam@gmail.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	Tudor Ambarus <tudor.ambarus@microchip.com>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: at25: add Fujitsu MB85RS4MT
Date: Tue, 09 Mar 2021 23:59:58 +0100	[thread overview]
Message-ID: <8ca5c54140d69307f3c08ca85a09f0b5@walle.cc> (raw)
In-Reply-To: <20210309220014.22205-1-tharvey@gateworks.com>

Hi Tim,

Am 2021-03-09 23:00, schrieb Tim Harvey:
> Document the compatible value for the Fujitsu MB85RS4MT SPI
> FRAM EEPROM device so that it can be used in DTS files.
> 
> This is a 512KiB FRAM EEPROM.
> 
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> ---
>  Documentation/devicetree/bindings/eeprom/at25.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/eeprom/at25.yaml
> b/Documentation/devicetree/bindings/eeprom/at25.yaml
> index 6a2dc8b3ed14..f594db72b711 100644
> --- a/Documentation/devicetree/bindings/eeprom/at25.yaml
> +++ b/Documentation/devicetree/bindings/eeprom/at25.yaml
> @@ -26,6 +26,7 @@ properties:
>                - anvo,anv32e61w
>                - atmel,at25256B
>                - fujitsu,mb85rs1mt
> +              - fujitsu,mb85rs4mt
>                - fujitsu,mb85rs64
>                - microchip,at25160bn
>                - microchip,25lc040

Hm, the driver is spi-nor but this is for the at25 driver. Is
this correct? Doesn't it work if you just add the ID to
spi-nor/fujitsu.c and use 'compatible = "jedec,spi-nor' ?

-michael

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  parent reply	other threads:[~2021-03-09 23:00 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-09 22:00 [PATCH 1/4] dt-bindings: at25: add Fujitsu MB85RS4MT Tim Harvey
2021-03-09 22:00 ` Tim Harvey
2021-03-09 22:00 ` [PATCH 2/4] mtd: spi-nor: fujitsu: add support for MB85RS4MT Tim Harvey
2021-03-09 22:00   ` Tim Harvey
2021-03-09 22:00 ` [PATCH 3/4] dt-bindings: arm: imx: add imx8mm gw7901 support Tim Harvey
2021-03-09 22:00   ` Tim Harvey
2021-03-16 22:23   ` Rob Herring
2021-03-16 22:23     ` Rob Herring
2021-03-09 22:00 ` [PATCH 4/4] arm64: dts: imx: Add i.mx8mm Gateworks gw7901 dts support Tim Harvey
2021-03-09 22:00   ` Tim Harvey
2021-03-09 22:59 ` Michael Walle [this message]
2021-03-09 22:59   ` [PATCH 1/4] dt-bindings: at25: add Fujitsu MB85RS4MT Michael Walle
2021-03-10  5:33   ` Tudor.Ambarus
2021-03-10  5:33     ` Tudor.Ambarus
2021-03-11 22:39     ` Tim Harvey
2021-03-11 22:39       ` Tim Harvey
2021-03-11  1:52   ` Tim Harvey
2021-03-11  1:52     ` Tim Harvey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8ca5c54140d69307f3c08ca85a09f0b5@walle.cc \
    --to=michael@walle.cc \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=tharvey@gateworks.com \
    --cc=tudor.ambarus@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.